graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3494
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundso
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> scene_qpainter_test.cpp:199
> +using namespace KWayland::Client;
> +QVERIFY(Test::setupWaylandConnection(s_socketName,
> Test::AdditionalWayland
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.
You added a typo in the commit message: "relatvie" -> relative
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3501
EMAIL
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3499
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, graesslin
Cc: graesslin, pl
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3496
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, graesslin
Cc: graesslin, pl
subdiff added inline comments.
INLINE COMMENTS
> DigitalClock.qml:211
>
> -height: Math.max(sizehelper.lineCount > 1 ? 2 *
> Math.round(timeLabel.height / 6) : 2 * Math.round(timeLabel.height / 3),
> theme.smallestFont.pixelSize)
> +height: Math.min(Math.max(s
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0b0d14639a1a: Refresh the ScreenGeometry data role
whenever a screen is added or changes its… (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde
mart requested changes to this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> DigitalClock.qml:57
> // if the date/timezone cannot be fit with the smallest font to its
> designated space
> -readonly pro
davidedmundson added a comment.
No, you're right. I mistakenly thought actions were in the hints even though
the code even has "{} //no actions" documented
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3606
EMAIL PREFERENCES
https://phabricator.kde.org/
mart added a subscriber: davidedmundson.
mart added a comment.
In https://phabricator.kde.org/D3606#67751, @davidedmundson wrote:
> Note that actions won't work, we'd always be replying on the session bus.
(this is solvable)
is that even possible to add an action at all from there
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3620
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: da
davidedmundson closed this revision.
davidedmundson added a comment.
This was submitted with
https://phabricator.kde.org/R108:d0e0f6c88cdd032d3bdb9dc7b0c85902fb3d859a
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3526
EMAIL PREFERENCES
https://phabricator.kde.org/s
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cbf06cf862c5: If we get a notification with no body,
treat the subject line as the body (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator
davidedmundson updated this revision to Diff 8890.
davidedmundson added a comment.
Marco's comments
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3620?vs=8855&id=8890
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3620
AFFECTED FIL
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
I'd prefer it if you actually fixed it, instead of opting for the simplest
solution. Otherwise we may go back to only having a smaller bug, but it would
be better to have no
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D3628
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, davidedm
On Friday 09 December 2016 00:43:28 Sebastian Kügler wrote:
> On Wednesday, December 7, 2016 8:58:34 PM UTC Martin Gräßlin wrote:
> > Personally I find it important that the developers have a say in what
> > the logo is. I think we identify by it and the logo needs to work with
> > us.
>
> We did
17 matches
Mail list logo