Review Request 129652: update network, smb, thumbnail ioslave docbooks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129652/ --- Review request for Documentation and Plasma. Repository: kio-extras Des

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

> On Дек. 7, 2016, 3:59 след обяд, Anthony Fieroni wrote: > > You not against i plan to ship this patch next week. Ping, Eike, it works fine. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewbo

[Differential] [Commented On] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in playercontainer.cpp:119 > There is a way to do it which will work for all players much more reliably: > > auto message = QDBusMessage::createMethodCall("org.freedesktop.DBus", "/", > "org.freedesktop.DBus", "GetCo

[Differential] [Changed Subscribers] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

davidedmundson added inline comments. INLINE COMMENTS > playercontainer.cpp:119 > +// at the end of its dbus address. This code bit sets > "SecondaryInstancePid" to > +// in this case, otherwise it defaults to -1 (for the first one or > players > +// which don't implement the stand

[Differential] [Commented On] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

broulik added a comment. LGTM overall "Prototype of redesigned taskbar" made me curious ;) INLINE COMMENTS > playercontainer.cpp:123 > +int secondaryInstancePid = -1; > +int lastPoint = m_dbusAddress.lastIndexOf("."); > +QString end = m_dbusAddress.right(m_dbusAddress.length(

[Differential] [Request, 20 lines] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

subdiff created this revision. subdiff added a reviewer: Plasma. subdiff added a subscriber: plasma-devel. subdiff set the repository for this revision to R120 Plasma Workspace. subdiff added a project: Plasma. REVISION SUMMARY The MPRIS specification recommends to media players to distinguish i

[Differential] [Accepted] D3666: Test the variable type without warning

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Request, 2 lines] D3666: Test the variable type without warning

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY type===undefined also raises a warning which we don't desire, use typeof() instead, which doesn't. REPO

[Differential] [Closed] D3655: Kicker backend changes for Simple Menu.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3e88ac63f25d: Kicker backend changes for Simple Menu. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3655?vs=8955&id=8972 REVISION DETAI

[Differential] [Accepted] D3655: Kicker backend changes for Simple Menu.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3655 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: brouli

Re: Minutes Monday Plasma Meeting

On Mon, Dec 12, 2016 at 12:40 PM, Sebastian Kügler wrote: > Plasma Meeting minutes 12-12-2016 > > Present: Sho, kbroulik, romangg, bshah, notmart, d_ed, sebas > > Logo discussion: > - We want to finalize this topic (finally), notmart to check with mgraesslin He is ok, and yes, we should go ahead

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

hein added a comment. Marco: Yeah I agree it's fugly. The constructor was originally added for atomicity and then it grew ove time. Let's refactor separately from this maybe though? INLINE COMMENTS > broulik wrote in wheelinterceptor.cpp:52 > Is this for another patch? > > Also, you lose p

[Differential] [Commented On] D3660: Plasma 5.9 "Canopee" Wallpaper

kvermette added a comment. In https://phabricator.kde.org/D3660#68450, @broulik wrote: > Overall I quite like it, especially the stylized 9 referencing Plasma 5.9 (not sure if that was fully intentional, though? ;) > > The blurry jaggy, coronal mass ejection like edges of the yellow b

Re: Review Request 129528: Fix "Unable to assign [undefined] to int" log

> On Nov. 22, 2016, 11:05 a.m., David Edmundson wrote: > > lookandfeel/contents/components/Battery.qml, line 48 > > > > > > Given we don't actually care about the value used as long as it's an > > int as this wil

[Differential] [Closed] D3663: [Task Manager] Don't emit urls dropped on drag enter

This revision was automatically updated to reflect the committed changes. Closed by commit R119:643e424d7f1e: [Task Manager] Don't emit urls dropped on drag enter (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3663?vs=8969&id=8970

[Differential] [Accepted] D3663: [Task Manager] Don't emit urls dropped on drag enter

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3663 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, davidedmundson, #plasm

[Differential] [Updated] D3663: [Task Manager] Don't emit urls dropped on drag enter

broulik retitled this revision from "[Task Manager] Don't emit urls droppde on drag enter" to "[Task Manager] Don't emit urls dropped on drag enter". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3663 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Request, 1 line] D3663: [Task Manager] Don't emit urls droppde on drag enter

broulik created this revision. broulik added reviewers: Plasma, hein, davidedmundson. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise we'll une

[Differential] [Commented On] D3658: Set Automatic login flag to adjust SDDM config directly

davidedmundson added a comment. Already exists in the sddm kcm. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D3658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, lesliezhai,

[Differential] [Updated, 594 lines] D2687: [Icon Widget] Bring back properties dialog

broulik updated this revision to Diff 8968. broulik added a comment. - Create context menu actions on demand, saves some cycles on startup and more importantly allows us to follow SystemImmutable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2687

[Differential] [Commented On] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

broulik added a comment. > could also be a property of an object that's inside instead of the root object I also need to access it from the style and didn't want to randomly do control.someRandomObject.foo REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.or

[Differential] [Commented On] D2687: [Icon Widget] Bring back properties dialog

mart added a comment. for me +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterber

[Differential] [Commented On] D3651: Add utility to send broadcast notifications

broulik added a comment. > I wonder if it can take usernames instead of uids? Perhaps not "instead" but in addition. The tool is mostly meant to be used by background services and scripts, so remembering should not be an issue but we can offer both. Will make a patch for the notification

[Differential] [Updated, 594 lines] D2687: [Icon Widget] Bring back properties dialog

broulik retitled this revision from "WIP: [Icon Widget] Bring back properties dialog" to "[Icon Widget] Bring back properties dialog". broulik updated the test plan for this revision. broulik updated this revision to Diff 8967. broulik added a comment. - Ensure Link desktop file is actually .d

[Differential] [Changed Subscribers] D3651: Add utility to send broadcast notifications

bshah added inline comments. INLINE COMMENTS > main.cpp:79 > +if (!uids.isEmpty()) { > +properties.insert(QStringLiteral("uids"), uids); > +} I wonder if it can take usernames instead of uids? It is slightly easier to remember usernames then uids REPOSITORY R126 K

[Differential] [Accepted] D3651: Add utility to send broadcast notifications

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D3651 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasm

[Differential] [Accepted] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TextField.qml:49 > +// this takes into account kiosk restriction > +readonly property bool __effectiveRevealPasswordButtonShown: > reve

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

mart added inline comments. INLINE COMMENTS > appentry.h:79 > AppGroupEntry(AppsModel *parentModel, KServiceGroup::Ptr group, > -bool flat, bool sorted, bool separators, int appNameFormat); > +bool paginate, int pageSize, bool flat, bool sorted, bool > separators

[Differential] [Commented On] D3658: Set Automatic login flag to adjust SDDM config directly

mart added a comment. did the helper already supported the action or is a different rr? REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D3658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, p

[Differential] [Commented On] D3660: Plasma 5.9 "Canopee" Wallpaper

mart added a comment. like it a lot! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3660 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kvermette, #plasma Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreu

[Differential] [Updated] D2687: WIP: [Icon Widget] Bring back properties dialog

broulik marked 9 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreu

[Differential] [Commented On] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

franckarrecot added a comment. my current urls are : origin git://anongit.kde.org/kirigami.git (fetch) origin git://anongit.kde.org/kirigami.git (push) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3649 EMAIL PREFERENCES https://phabricator.kde.org/sett

[Differential] [Commented On] D3649: Make kirigami.qrc ressource path relative to CMAKE_CURRENT_SOURCE_DIR

franckarrecot added a comment. thanks, I can't push though, do I need special access or special urls to do so ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3649 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: franckarrecot,

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

sitter added a comment. Ok. Kindly take note of potential adjustment needs then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: graesslin, brou