GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 06:36:26 +
Build duration: 30 min
CHANGE SET
Revision e018318f670a7526c0f28d4eaa
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 06:36:46 +
Build duration: 5 min 53 sec
CHANGE SET
Revision 3b44f2e50a36ab57da
> On Ян. 21, 2017, 7:24 преди обяд, Anthony Fieroni wrote:
> > All IconDialogs from QML are with small and hard to visible icons e.g.
> > Kicker (right click -> change icon -> small icons)
Ping
- Anthony
---
This is an automatically ge
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/572/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 Jan 2017 04:58:03 +
Build duration: 9 min 6 sec
CHANGE SET
Revision 74ac222ad43505c7f924929c23f6832d
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
ContainmentConfigView has a special code path for wallpaper configs
where, if you change wall
> On Ян. 25, 2017, 11:30 преди обяд, Martin Gräßlin wrote:
> > I don't understand. We already have support for this in 5.9?!?
I made in same approach like other roles and i commit defaults (in blocks)
- Anthony
---
This is an automatica
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:42:08 +
Build duration: 16 min
CHANGE SET
Revision e47a5c96783453d974404f80
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/571/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:25:53 +
Build duration: 16 min
CHANGE SET
Revision 3e7e1c07161666912c971d9417ebd326b531
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f5bf988c5bd5: Fix group parents not appearing when
disabling inline grouping. (authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4284?vs=10
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D4284
EMAIL PREFERENCES
https://phabricator.kde.org/set
https://bugs.kde.org/show_bug.cgi?id=375552
Elvis Angelaccio changed:
What|Removed |Added
Assignee|dolphin-bugs-n...@kde.org |plasma-devel@kde.org
Product|dolp
davidedmundson added a comment.
you have
flattenGroupsProxyModel = nullptr;
after q->setSourceModel()
so does this actually work when automatic sorting is on?
(which doesn't go through forceResort())
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.k
hein updated this revision to Diff 10565.
hein added a comment.
Do it properly and fix the filter instead.
Really asleep at the wheel today ...
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4284?vs=10564&id=10565
BRANCH
Plasma/5.8
REVISIO
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:24:38 +
Build duration: 6 min 24 sec
CHANGE SET
Revision 3e7e1c07161666912c97
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/570/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 18:01:18 +
Build duration: 18 min
CHANGE SET
Revision 383cf19d0a911bdd121decbab9a647fdc7ee
hein created this revision.
hein added reviewers: Plasma, broulik.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D4284
AFFECTED FILES
libtaskmanager/ta
broulik added a comment.
I was under the impression that opening a plasma config dialog would keep the
popup opened but then I found that it doesn't (at least not the default popup
impl) after I already submitted the patch.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
http
hein added a comment.
This is what I suggested in IRC, but Kai had some concerns that it wasn't
always desired.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4282
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:383cf19d0a91: Support spring-loading on drag hover and
drops into preview popups. (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4103?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f6b30cb08d4c: Overhaul group popup dialog (authored by
hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4229?vs=10555&id=10562
REVISION DETAIL
https:
konstantinshtepa added a comment.
In https://phabricator.kde.org/D4204#80142, @mart wrote:
> what i would like to have logically splitted is the management of the
floating property (and having positionItem()/releasePosition used around)
>
> and on the other hand the signal handlers of
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4229
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreference
broulik added a comment.
Cool! +1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4282
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: drosca, #plasma
Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-moh
drosca added a comment.
Shouldn't this be fixed in plasma-framework instead?
https://phabricator.kde.org/D4282
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4280
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik,
drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
TEST PLAN
Expand applet in systray -> open config -> applet popup gets closed
REPOSITORY
R242 Plasma Fr
konstantinshtepa added inline comments.
INLINE COMMENTS
> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
>
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
>
> for all 4
>
> would st
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/569/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 16:48:15 +
Build duration: 24 min
CHANGE SET
Revision af36a54e947f32974a83c4ff166908189967
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Having opened a file with a long fi
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/25/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 16:47:00 +
Build duration: 25 min
CHANGE SET
Revision 38fca064a1d0d4ec94543805e9
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ceeb57d17fed: [PlasmaComponents Menu] Add maximumWidth
property (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4257?vs=104
hein updated this revision to Diff 10555.
hein added a comment.
Bite the bullet and do the active task collection the brute force way.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4229?vs=10552&id=10555
BRANCH
master
REVISION DETAIL
https://p
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:38fca064a1d0: [Task Manager] Hide group dialog when
opening applets settings (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4280?vs=10
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Should be in 5.8 and up.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4280
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When moving focus from one Plasma w
On srijeda, 25. siječnja 2017. 17:08:49 CET Michail Vourlakos wrote:
> On 25/01/2017 06:02 μμ, šumski wrote:
> >>> Unless you have something like this[1] in ki18n package,
> >>> translations will be found only in $prefix/share/locale...
> >>
> >> the mentioned package is just a plasma5 plasmoid th
hein added a comment.
Also added a more localized comment on Marco's request.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4229
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
Cc: mart, broulik, plasma-dev
hein updated this revision to Diff 10552.
hein added a comment.
Collect active task on hover but invalidate when child count changes.
This should be reasonably safe-ish with regard to the stored task
index still being valid at click time.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE
On 25/01/2017 06:02 μμ, šumski wrote:
Unless you have something like this[1] in ki18n package,
translations will be found only in $prefix/share/locale...
the mentioned package is just a plasma5 plasmoid that should install its
translations at /usr/share/locale/kf5 (according to openSUSE direc
On 25/01/2017 05:44 μμ, šumski wrote:
On utorak, 24. siječnja 2017. 20:45:24 CET Michail Vourlakos wrote:
I have the following situation and I would like you to clarify it in
order to open a bug in the distro that should fix this...
KDE_INSTALL_LOCALEDIR for CMAKE
in openSUSE
points to /usr/
On srijeda, 25. siječnja 2017. 16:56:04 CET Michail Vourlakos wrote:
> On 25/01/2017 05:44 μμ, šumski wrote:
> > On utorak, 24. siječnja 2017. 20:45:24 CET Michail Vourlakos wrote:
> >> I have the following situation and I would like you to clarify it in
> >> order to open a bug in the distro that
broulik accepted this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4103
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-moh
hein updated this revision to Diff 10551.
hein added a comment.
Don't forget to null hoveredItem.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4103?vs=10549&id=10551
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4103
AFFECTED FI
On utorak, 24. siječnja 2017. 20:45:24 CET Michail Vourlakos wrote:
> I have the following situation and I would like you to clarify it in
> order to open a bug in the distro that should fix this...
>
> KDE_INSTALL_LOCALEDIR for CMAKE
>
> in openSUSE
>
> points to /usr/share/locale but the tran
hein updated this revision to Diff 10549.
hein added a comment.
Rebase patch to drop unrelated change from diff shown in Phab.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4103?vs=10548&id=10549
BRANCH
master
REVISION DETAIL
https://phabricat
hein updated this revision to Diff 10548.
hein added a comment.
Fix internal DND in listview mode when changing URL mid-drag.
It crashed, and also wouldn't work even without the crash.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4103?vs=10275
This revision was automatically updated to reflect the committed changes.
Closed by commit R101:d5b63b4132e0: update khotkeys kcm docbook (authored by
lueck).
REPOSITORY
R101 KHotKeys
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4246?vs=10433&id=10547
REVISION DETAIL
https://pha
lueck created this revision.
lueck added reviewers: Plasma, Documentation.
lueck set the repository for this revision to R124 System Settings.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
bump date + releaseinfo
acces
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/703/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 13:33:22 +
Build duration: 33 min
CHANGE SET
Revision ad66dc81817ea7b7d4bf98dd772ddf9910
hein added a comment.
There's extensive comments explaining it in the patch actually ...?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4229
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
Cc: mart, broulik
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/568/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 13:38:37 +
Build duration: 29 min
CHANGE SET
Revision 85754b3ddcb1df479031d680fabc53363cb8
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 Jan 2017 13:32:57 +
Build duration: 34 min
CHANGE SET
Revision 656fa842a69198028e2e8c93
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:85754b3ddcb1: [KRDB] Fix wording in comment at the top of
"gtkrc" (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4170?vs=10279&id=1054
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:656fa842a691: [Image Wallpaper] Provide fallback for
thumbnail size of no "plasmoid" around (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kd
konstantinshtepa added inline comments.
INLINE COMMENTS
> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
>
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
>
> for all 4
>
> would st
konstantinshtepa added inline comments.
INLINE COMMENTS
> davidedmundson wrote in AppletAppearance.qml:101
> this is broken.
>
> if I'm an applet and do:
> Plasmoid.Layout.maximumWidth = 50
>
> this appletItem.maximumWidth == 58 (assuming 4px margins)
> which is correct
>
> Now if I do:
>
>
davidedmundson added inline comments.
INLINE COMMENTS
> AppletAppearance.qml:445
> +
> property int minimumWidth: minimumSize.width;
> property int minimumHeight: minimumSize.height;
Edit, maybe it won't - that's why you have the separate Binding.
However chang
On maandag 23 januari 2017 17:42:20 CET Jonathan Riddell wrote:
> okay, how's 7th at 14:00UTC, 15:00CET?
Would work for me.
--
sebas
http://www.kde.org | http://vizZzion.org
davidedmundson added inline comments.
INLINE COMMENTS
> AppletAppearance.qml:101
> +if (minimumWidth > maximumWidth)
> +maximumWidth = minimumWidth;
> +if (width < minimumWidth) {
this is broken.
if I'm an applet and do:
Plasmoid.Layout.maximumWidth = 50
this applet
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:fe561c5c7def: Add a basic SNI for keyboard layout
(authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4220?vs=10427&id=10539#toc
REPOSITORY
R108 KWin
CHANGES SINCE LAST
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:d38bce776fa2: Add support for skip close animation to
OnScreenMessage (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4091?vs=10069&id=10537
R
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7e89c518237b: Add workaround for touch input offset for
decorated windows (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4074?vs=10004&id=1053
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in AppletAppearance.qml:50
> mouseListener just has a simple anchors.fill:parent to this, so makes
> innerWidth/innerHeight redundant as they are the same as the parent?
It did. It doesn't after this patch.
It's detached so tha
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4277
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
broulik created this revision.
broulik added reviewers: Plasma, graesslin.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This fixes wallpaper thumbna
broulik updated this revision to Diff 10535.
broulik added a comment.
- Reflect in comment that we no longer hash
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4157?vs=10534&id=10535
REVISION DETAIL
https://phabricator.kde.org/D4157
AFFECTED F
broulik updated this revision to Diff 10534.
broulik added a comment.
- Use KIO::encodeFileName instead of QCryptoGraphicHash
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4157?vs=10348&id=10534
REVISION DETAIL
https://phabricator.kde.org/D4157
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5a87fa3f92cf: Support modifier-only-shortcuts when
capslock is on (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4241?vs=10426&id=10533
REVIS
mart added a comment.
In https://phabricator.kde.org/D4204#80123, @konstantinshtepa wrote:
> In https://phabricator.kde.org/D4204#80106, @mart wrote:
>
> > can this be splitted in multiple reviews/commits?
>
>
> It can be splitted into multiple commits inside one branch so you ca
broulik added inline comments.
INLINE COMMENTS
> dfaure wrote in iconapplet.cpp:108
> Not convinced that KIO::encodeFileName would be better than a MD5 filename,
> then?
Ah, that's what you meant with that. I got confused as to where and why I
should use this … so, will work for when there's n
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:bac5a39f01a8: Add workaround for QMenuBar::setVisible bug
in 5.7.0 (authored by davidedmundson).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabric
broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.
Works for me. Cool.
I asked Dmitry (who did the Qt menu stuff) and he's fine with it. Let's go
with it, thanks.
You can close Bug 375498 then
On Tue, Jan 24, 2017 at 8:45 PM, Michail Vourlakos wrote:
> I have the following situation and I would like you to clarify it in order
> to open a bug in the distro that should fix this...
>
> KDE_INSTALL_LOCALEDIR for CMAKE
>
> in openSUSE
>
> points to /usr/share/locale but the translations are
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QMenuBar::setVisible() only checks isNativeMenuBar on OS X
leading to both the normal in-appm
konstantinshtepa updated the summary for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, les
konstantinshtepa added a comment.
In https://phabricator.kde.org/D4204#80106, @mart wrote:
> can this be splitted in multiple reviews/commits?
It can be splitted into multiple commits inside one branch so you can view
what exactly fix what. But multiple reviews based on master? I
mart added inline comments.
INLINE COMMENTS
> GroupDialog.qml:91
>
> -TaskList {
> -id: taskList
> +Timer {
> +id: focusActiveTaskTimer
is this timer working around some bug? should have at least some comments
explaining why this needs to be del
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R101 KHotKeys
REVISION DETAIL
https://phabricator.kde.org/D4246
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: lueck, #plasma, #documen
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D4224
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, mart
Cc: p
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4223
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: d
mart added a comment.
can this be splitted in multiple reviews/commits?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: konstantinshtepa, #plasma
Cc: mart, davidedmundso
mart added a comment.
In https://phabricator.kde.org/D4215#78915, @apol wrote:
> In https://phabricator.kde.org/D4215#78913, @mck182 wrote:
>
> > -1, I don't want to keep thinking "am I now going to close the
notification or execute an action" everytime I'm about to click the
notific
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:1c9f50c88e96: VolumeSlider: Ignore all value changes
until Component is completed (authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
keyboard-layout-sni
REVISION DETAIL
https://phabricator.kde.org/D4220
EMAIL PREFERENCES
https://phabricator.kde.org/settin
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
Plasma-5.8-fix-capslock-mod-only-shortcuts
REVISION DETAIL
https://phabricator.kde.org/D4241
EMAIL PREFERENCES
https://pha
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in keyboard_layout.cpp:142
> You only want this in ::reconfigure() before resetLayout and not here.
>
> You're calling this method from reconfigure and in processKeymapChange, from
> keyboard_input - that won't affect wheth
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in modifier_only_shortcut_test.cpp:281
> I don't get this change:
>
> This is the " // this test verifies that Capslock does not trigger the shift
> shortcut" part of the test.
>
> Shift has been released on line 276, so t
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/#review102237
---
I don't understand. We already have support for this in 5.9?
87 matches
Mail list logo
