D4290: [Calculator Runner] Use "approximate" approximation mode

lueck added a comment. OK from german team REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: lueck, yurchor, kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5209: Load translations from KPackage files if bundled

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Installed battery monitor locally with kpackagetool5 -i moved x-test .po file from being installed systemwide to only

Re: appstreamrunner in plasma-workspace

On Mon, Mar 27, 2017 at 12:07 PM, Harald Sitter wrote: > Aloha > > A while ago Aleix created an appstreamrunner allowing you to find > applications (from appstream data) via krunner and install them (by > invoking whatever software center is associated with appstream URIs). > >

D3552: Remove quoting from kscreen-console json-output (Bug 354534)

aacid added a comment. He can't push it, he doesn't have a devel account. Sebas can you please push it? Name is Jan-Matthias Braun and e-mail according to identity is jan_br...@gmx.net Or i can commit if if you tell me the repo, which you did not fill out when creating the request.

D5112: Make archiver ioslave extensible

marten added a comment. Point taken regarding the KF5 prefix, this was based on the installed names for libkonq (= libKF5Konq.so etc) although not every application support library is named the same way (libkworkspace5.so isn't). Would the name libKioArchive.so, etc be appropriate, or

D5112: Make archiver ioslave extensible

dfaure added a comment. The idea sounds OK to me. INLINE COMMENTS > CMakeLists.txt:32 > +FILE KF5KioArchiveTargets.cmake > +NAMESPACE KF5:: > +) The KF5 prefix is wrong, this isn't part of KF5. > CMakeLists.txt:44 > + > +add_library(KF5KioArchive kio_archivebase.cpp

D5204: [Folder View] Show pin icon only if really in a popup

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When placed in a wide panel, Folder View would reveal its contents but the pin icon was still there TEST PLAN Pin icon no longer shows up

D5203: Add support for interactive selection through touch events

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This was forgotten during implementing the interactive window/point selection. With this change it is also possible to perform the

D5202: [Default Tooltip] Fix icon size

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5202 To: broulik, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5202: [Default Tooltip] Fix icon size

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We overwrite implicit size based on the icon loaded nowadays which breaks this. TEST PLAN No longer get icon sizes

D5201: [Folder View] Add "home" button

broulik updated this revision to Diff 12877. broulik added a comment. - Destroy button again so the label anchoring and all resets properly when going home REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5201?vs=12876=12877 REVISION DETAIL

D5201: [Folder View] Add "home" button

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds an easy way to get back to the preconfigured location. While Folder View reverts to the start location automatically when a popup

D5200: [Calendar] Shrink and elide week names like is done with day delegate

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This ensures week names never exceed their cell's boundaries. BUG: 378020 TEST PLAN `LC_ALL=pt_PT plasmashell`

D4290: [Calculator Runner] Use "approximate" approximation mode

yurchor added a comment. In https://phabricator.kde.org/D4290#98033, @broulik wrote: > @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix.

D2104: [Task Manager] Close gap when there is no icon

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2104 To: broulik, hein, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D3743: [Folder View] Show proper trash icon when it points to trash:/

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D5198 and https://phabricator.kde.org/D5199 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3743 To: broulik, #plasma, #plasma:_design, mart, hein Cc: mart,

D4290: [Calculator Runner] Use "approximate" approximation mode

broulik added a subscriber: kde-i18n-doc. broulik added a comment. @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix. Initially it would have

D4761: [Task Manager] Don't delay appearance of audio stream in popup

broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4761 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

broulik abandoned this revision. broulik added a comment. Somehow I must have screwed up my setup somehow, I can't reproduce the issues I had anymore and never had it on my laptop to begin with. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4923 To:

D5198: [Folder View] Use KIO::iconNameForUrl

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Fancy! I learned something new, thank you :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5198 To: broulik, #plasma, hein, markg Cc: markg,

D4290: [Calculator Runner] Use "approximate" approximation mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:df7f1ed1eb7d: [Calculator Runner] Use "approximate" approximation mode (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D4290: [Calculator Runner] Use "approximate" approximation mode

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5002: [oxygen/kstyle] Fix build

hpereiradacosta added inline comments. INLINE COMMENTS > oxygenanimations.cpp:178 > // unregister all toolbuttons that belong to a toolbar > -foreach( QWidget* widget, > _widgetStateEngine->registeredWidgets( AnimationHover|AnimationFocus ) ) > +

D5198: [Folder View] Use KIO::iconNameForUrl

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In contrast to KFileItem it also has special fallback mechanisms, such as using the protocol icon, if none cound be determined. This way my

D5157: Add support for emergency message show on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R133:565259358ec0: Add support for emergency message show on Wayland (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5157?vs=12749=12866

D5137: Add support for screenedge touchscreen events through XInput 2.2

This revision was automatically updated to reflect the committed changes. Closed by commit R108:8672b93bdd14: Add support for screenedge touchscreen events through XInput 2.2 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D5097: Add support for global touchpad swipe gestures

This revision was automatically updated to reflect the committed changes. Closed by commit R108:22c91df2ec6c: Add support for global touchpad swipe gestures (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5097?vs=12586=12863 REVISION

D5106: Add support for activating screenedges through touch swipe gestures

This revision was automatically updated to reflect the committed changes. Closed by commit R108:aa6c8f81168e: Add support for activating screenedges through touch swipe gestures (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D5177: Initial support for popup window handling

graesslin added a comment. In https://phabricator.kde.org/D5177#97958, @broulik wrote: > > Concerning whether or not it should update: I'm not sure. On X11 it's due to the pointer grab, but is that a feature or a bug? > > I think it's a side-effect of the pointer grab which quite

D5097: Add support for global touchpad swipe gestures

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in gestures.cpp:95 > I think you need to handle delta being zero in both directions and return > without cancelling I think a delta of 0/0 just cannot happen. libinput should not send us an update in such a case. We only

D5177: Initial support for popup window handling

broulik added a comment. > Concerning whether or not it should update: I'm not sure. On X11 it's due to the pointer grab, but is that a feature or a bug? I think it's a side-effect of the pointer grab which quite effectively communicates that clicking the button wouldn't trigger it

D5177: Initial support for popup window handling

graesslin updated this revision to Diff 12861. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. last -> constLast REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5177?vs=12798=12861 BRANCH popup-filter REVISION

D5177: Initial support for popup window handling

graesslin added a comment. In https://phabricator.kde.org/D5177#97950, @broulik wrote: > A thing to the future might be to consider blocking hover events for other clients, too? On X while a menu is opened, buttons in other clients won't highlight as the menu grabs. On Wayland they

D5177: Initial support for popup window handling

graesslin marked an inline comment as done. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5177 To: graesslin, #plasma, #kwin Cc: broulik, subdiff, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol

D5177: Initial support for popup window handling

graesslin added a comment. In https://phabricator.kde.org/D5177#97858, @subdiff wrote: > I tried it and compiles fine. Some popups don't yet go away though: > > - Click on window decoration of window with the popup. > - Panel and launcher popups, click on other part of plasmashell.

D5088: Generate plugins.qmltypes files for the plugins we install

apol added a comment. Can somebody please help review the ECM side of things? https://phabricator.kde.org/D5087 REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5088 To: apol, #plasma, #frameworks, davidedmundson Cc:

D5177: Initial support for popup window handling

broulik added a comment. A thing to the future might be to consider blocking hover events for other clients, too? On X while a menu is opened, buttons in other clients won't highlight as the menu grabs. On Wayland they would still highlight. REPOSITORY R108 KWin REVISION DETAIL

D3805: Per-activity favorites (Final, again?)

ivan added a comment. p.s. I haven't tested the patch since posting - it is possible that some change in plasma broke the thing (like the problematic change that got reverted) REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: plasma-devel, progwolff, lesliezhai,

D3805: Per-activity favorites (Final, again?)

ivan added a comment. > Could you document here how to reset all state so I can re-test migration on a clean base? 1. kill plasma and kamd 2. rm .config/kactivitymanagerd-statsrc 3. echo "delete from ResourceLink" | sqlite3

D4899: [Folder View] Workaround label eliding bug

broulik abandoned this revision. broulik added a comment. Superseded by https://cgit.kde.org/plasma-desktop.git/commit/?id=a03d08a99e86c13ee50407f5189d70bf0a2b37fc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4899 To: broulik, #plasma, hein Cc:

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 98 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Mar 2017 12:05:03 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 677 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/677/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 27 Mar 2017 12:06:43 + Build duration: 6 min 1 sec CHANGE SET Revision

D5192: Connect aboutToHide signal from QMenu to relevant libdbusmenu-qt slot

broulik accepted this revision. broulik added a comment. 5.9 branch pls REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5192 To: davidedmundson, #plasma, markg, broulik Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5192: Connect aboutToHide signal from QMenu to relevant libdbusmenu-qt slot

markg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5192 To: davidedmundson, #plasma, markg Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5192: Connect aboutToHide signal from QMenu to relevant libdbusmenu-qt slot

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This sends the close event to the client which then sends aboutToHide to the QMenu. Code was all there, just not hooked up

appstreamrunner in plasma-workspace

Aloha A while ago Aleix created an appstreamrunner allowing you to find applications (from appstream data) via krunner and install them (by invoking whatever software center is associated with appstream URIs). There was some consensus that it would be nice to have but we never reached a decision

D3805: Per-activity favorites (Final, again?)

hein added a comment. Could you document here how to reset all state so I can re-test migration on a clean base? Did you do any work yet on migrating as a superset instead of just the first launcher roulette? REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc:

D5085: [DrKonqi] Drop "It is safe to close this dialog if you don't want to report a bug"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:91deac7c6a19: [DrKonqi] Drop "It is safe to close this dialog if you don't want to report a… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D5177: Initial support for popup window handling

broulik added inline comments. INLINE COMMENTS > popup_input_filter.cpp:62 > +auto pointerFocus = > qobject_cast(input()->findToplevel(event->globalPos())); > +if (!pointerFocus || > !AbstractClient::belongToSameApplication(pointerFocus, >

D5097: Add support for global touchpad swipe gestures

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. All good I think, a few questions. INLINE COMMENTS > gestures.cpp:95 > +void GestureRecognizer::updateSwipeGesture(const QSizeF ) > +{ > +m_swipeUpdates << delta; I

D5177: Initial support for popup window handling

subdiff added a comment. I tried it and compiles fine. Some popups don't yet go away though: - Click on window decoration of window with the popup. - Panel and launcher popups, click on other part of plasmashell. REPOSITORY R108 KWin REVISION DETAIL