D5382: Improve password dialogs

jgrulich added a comment. In https://phabricator.kde.org/D5382#101074, @broulik wrote: > I like! > > Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN* connection" (ie. capital). Also, add a colon at the end "password below:" Any suggestion what to

D5346: DigitalClock: Use correct language for month and day names

mck182 accepted this revision. mck182 added a comment. This revision is now accepted and ready to land. Same as the other diff, if safe, good to go. EDIT: I feel like we could wrap the `Qt.locale(Qt.locale().uiLanguages[0])` into something shorter, maybe. Possibly also keep it

D5345: Calendar: Use correct language for month and day names

mck182 accepted this revision. mck182 added a comment. This revision is now accepted and ready to land. ...provided the usage of `uiLanguages[0]` is safe like this. INLINE COMMENTS > DaysCalendar.qml:315 > height: daysCalendar.cellHeight > -text:

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #15 from Roman Gilg --- I don't know for sure why your bug report / wishlist item is again closed without further comment slartibart70, but I assume it's because of your aggressive tone in the beginning and the unfriendly

D5321: [Notifications Applet] Don't crash when containment() disappears

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Heh, finally found the bug. I was a bit wrong. QObject::destroyed() is emitted before we delete the children. But that still doesn't explain everything, the

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #14 from Gregor Mi --- last link was wrong, sorry. Here is the correct one: https://openclipart.org/search/?query=penguin -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 Gregor Mi changed: What|Removed |Added CC||codestr...@posteo.org ---

D5330: [QDBusMenuBar] Don't wait for (un)register call to finish

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in qdbusmenubar.cpp:193 > I don't understand why this is also here. You'll have always do line 199 > first. Edit: My English made no sense. I meant: You also unregister the object on line 199. That line will always

D5333: [Plasma Windowed] Disable standard actions on SNI

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in plasmawindowedview.cpp:115 > or we could just not manually add our own close entry? Would be less code and > give us the minimzeRestore thing too? SNI's default action would *quit* the app but one plasma-windowed instance

D5333: [Plasma Windowed] Disable standard actions on SNI

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > plasmawindowedview.cpp:115 > m_statusNotifier = new > KStatusNotifierItem(applet->pluginMetaData().pluginId(), this); > +

D5330: [QDBusMenuBar] Don't wait for (un)register call to finish

davidedmundson added inline comments. INLINE COMMENTS > qdbusmenubar.cpp:169 > +qDebug() << "Register finished" << watcher->isError() << > watcher->error().name(); > + > +if (watcher->isError()) { you leak this watcher > qdbusmenubar.cpp:193 > +

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 David Edmundson changed: What|Removed |Added Status|RESOLVED|CLOSED -- You

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 David Edmundson changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

D5380: [platforms/drm] Explicitly request event context version 2

This revision was automatically updated to reflect the committed changes. Closed by commit R108:c8cd474acd0c: [platforms/drm] Explicitly request event context version 2 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5380?vs=13288=13307

Re: Default touch screen edge gestures

Am 2017-04-10 17:28, schrieb Marco Martin: On Saturday 08 April 2017, Martin Gräßlin wrote: Hi Plasmates, now that we have touch screen edge swipe gesture support both on X11 and Wayland we could define which actions to put on each edge. My suggestion would be to put a sensible action on

Re: Default touch screen edge gestures

Am 2017-04-10 17:14, schrieb Marco Martin: On Saturday 08 April 2017, Martin Gräßlin wrote: Hi Plasmates, now that we have touch screen edge swipe gesture support both on X11 and Wayland we could define which actions to put on each edge. My suggestion would be to put a sensible action on

Re: Default touch screen edge gestures

On Monday 10 April 2017, Aleix Pol wrote: > On Mon, Apr 10, 2017 at 4:54 PM, Martin Gräßlin wrote: > > Am 2017-04-10 16:26, schrieb Aleix Pol: > >> Shouldn't it depend on the current configuration? > >> For example, I would expect the Application launcher to be triggered > >>

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 Roman Gilg changed: What|Removed |Added CC||subd...@gmail.com --- Comment

D5388: Cancel popup if the user clicked window decoration of parent window

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far the window decoration was not considered and e.g. right clicking the window decoration resulted in two open popups - one by KWin

Re: Default touch screen edge gestures

On Mon, Apr 10, 2017 at 4:54 PM, Martin Gräßlin wrote: > Am 2017-04-10 16:26, schrieb Aleix Pol: >> >> Shouldn't it depend on the current configuration? >> For example, I would expect the Application launcher to be triggered >> wherever the panel is present... > > > We don't

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #11 from Kai Uwe Broulik --- Ah, it has usesPlasmaTheme: false and because of its large size it picks the the huge blue one? -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #10 from Kai Uwe Broulik --- Ah, it has usesPlasmaTheme: false and because of its large size it picks the the huge blue one? -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #9 from Kai Uwe Broulik --- What I don't understand is where that icon is coming from. The places/user-identity and actions/user-identity are still the same, for some reason it now picks the applets/user-identity

Re: Default touch screen edge gestures

On Saturday 08 April 2017, Martin Gräßlin wrote: > Hi Plasmates, > > now that we have touch screen edge swipe gesture support both on X11 and > Wayland we could define which actions to put on each edge. > > My suggestion would be to put a sensible action on each of the four > actions. > >

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #8 from slartibar...@gmail.com --- I added screenshots of previous avatar icons, perfectly in harmony with breeze icon set. Something like this should remain the default, not some random choice out of a list. (just my 2 cents) @Jens..

Re: Default touch screen edge gestures

On Saturday 08 April 2017, Martin Gräßlin wrote: > Hi Plasmates, > > now that we have touch screen edge swipe gesture support both on X11 and > Wayland we could define which actions to put on each edge. > > My suggestion would be to put a sensible action on each of the four > actions. > as

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #7 from slartibar...@gmail.com --- Created attachment 104948 --> https://bugs.kde.org/attachment.cgi?id=104948=edit avatar2 -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #6 from slartibar...@gmail.com --- Created attachment 104947 --> https://bugs.kde.org/attachment.cgi?id=104947=edit avatar1 -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #5 from Jens Reuterberg --- I'm not entirely certain which are the "technical" ones you refer - is it the B/W then thank you I made them. I rather disagree with you except on one point - the default avatar - I think

Re: Default touch screen edge gestures

On Sat, Apr 8, 2017 at 1:40 PM, Ivan Čukić wrote: > Hi Martin, > > I think this needs more in-depth investigation. We've had a couple of, > I'd say, knee jerk shortcuts pushed to master without much thought > about them (Alt+Space for KRunner, Meta+number for tasks). > Whoa,

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 --- Comment #4 from slartibar...@gmail.com --- Agreed, it's not your fault if distros choose silly avatar icons. I mean, the samples you showed in http://i.imgur.com/eOZn8D8.png are the problem i am speaking of. No offence, but why are the blue/green

Re: Default touch screen edge gestures

Am 2017-04-10 16:26, schrieb Aleix Pol: Shouldn't it depend on the current configuration? For example, I would expect the Application launcher to be triggered wherever the panel is present... We don't have this information available. We might know that there is a panel, but we don't know

[Powerdevil] [Bug 378445] kscreenlocker_greet occasionally freezes in malloc in signal handler

https://bugs.kde.org/show_bug.cgi?id=378445 Martin Gräßlin changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED

D5382: Improve password dialogs

broulik added a comment. I like! Not sure about the "Authenticate %1" naming. Also, "For accessing the *VPN* connection" (ie. capital). Also, add a colon at the end "password below:" (Is there a way to get rid of the "KDE Daemon" caption and replace it by something more

D5377: Using proper checkboxes with labels instead of labels plus checkboxes

ivan abandoned this revision. ivan added a comment. Pushed without going through Phab, so Phab has no clue. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5377 To: ivan, mart, hein, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5382: Improve password dialogs

jgrulich edited the summary of this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D5382 To: jgrulich Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5378: Adding an option to show popular documents/apps for Kicker and Dash

mart added a comment. two small feedback pieces: 1. not sure about the term "popular" as it would suggest most used by many people, while this is just about one user, would "most used" be better? 2. let's try to make this default? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D5378: Adding an option to show popular documents/apps for Kicker and Dash

hein added a comment. Agreeing with Marco re "Most used", also because I can see "Popular" being an i18n challenge. In other languages the word that most closely maps to Popular might have an even more different sentiment from actually-most-used. I'm kind of confused by the settings UI.

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 Jens Reuterberg changed: What|Removed |Added CC||jens...@kolabnow.com

Re: Default touch screen edge gestures

On Sat, Apr 8, 2017 at 11:24 AM, Martin Gräßlin wrote: > Hi Plasmates, > > now that we have touch screen edge swipe gesture support both on X11 and > Wayland we could define which actions to put on each edge. > > My suggestion would be to put a sensible action on each of the

[Breeze] [Bug 378606] Please replace those childish avatar images

https://bugs.kde.org/show_bug.cgi?id=378606 Christoph Feck changed: What|Removed |Added Target Milestone|1.0 |---

Re: Default touch screen edge gestures

> That's exactly why I put up this thread! I know, I just wanted to make the background of mail clear as well :) > Wishful thinking :-) I wanted to have that for years: :) > Personally I think that this will be a feature which we will advertise > in the release announcement and we must define

D5088: Generate plugins.qmltypes files for the plugins we install

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2df613f9381f: Generate plugins.qmltypes files for the plugins we install (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5382: Improve password dialogs

broulik added reviewers: Plasma, VDG. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D5382 To: jgrulich, #plasma, #vdg Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5380: [platforms/drm] Explicitly request event context version 2

subdiff accepted this revision. REPOSITORY R108 KWin BRANCH drm-event-version-plasma-5.8 REVISION DETAIL https://phabricator.kde.org/D5380 To: graesslin, #kwin, #plasma, fooishbar, subdiff Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts,

D5381: Add brightness control using ddcutil lib

broulik added a comment. Cool! INLINE COMMENTS > ddcutilbrightness.cpp:7 > +{ > +QList m_displayHandleList = > QList(); > +QList m_displayInfoList = QList(); No need to explicitly initialize these, the constructor could just remain empty > ddcutilbrightness.cpp:17 > + > +void

Minutes Monday Plasma Meeting

Hey Friends, Here are the minutes and log of today's meeting. Cheers, -- sebas http://www.kde.org | http://vizZzion.org Plasma Team meeting, 20-302017 Present: notmart, Sho, bshah notmart: * [Qt] eaten events qt patch https://codereview.qt-project.org/#/c/185946/ * [Qt] Add NOTIFY signals

D5382: Improve password dialogs

jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Improve UI of all paswords dialogs. Previously we had two methods to setup UI of the dialog, either for VPN or for regular connections like

D5381: Add brightness control using ddcutil lib

dvogel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Setting up ddcutil for non-root CLI use is required first. Please refer to

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 707 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/707/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Apr 2017 10:41:55 + Build duration: 15 min CHANGE SET Revision

D5377: Using proper checkboxes with labels instead of labels plus checkboxes

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5377 To: ivan, mart, hein, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5355: Fix query for available modules

This revision was automatically updated to reflect the committed changes. Closed by commit R126:19a6bb179d5f: Fix query for available modules (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5355?vs=13238=13290#toc REPOSITORY R126 KDE CLI Utilities CHANGES SINCE

Re: Complex text input in Plasma

On 04/07/17 22:46, Martin Gräßlin-san wrote: Am 2017-04-07 07:56, schrieb Takao Fujiwara: Due to that: no chance for IM controlling part of our stack. We control the IM. Probably I think this way would not work with IBus. Each IBus IME are called by IBus dbus method. You hardly ask each IME

Re: Complex text input in Plasma

On 04/09/17 01:46, Martin Gräßlin-san wrote: Am 2017-04-08 17:26, schrieb Weng Xuetian: You're wrong about the QT_IM_MODULE stuff. To make application to use the wayland protocol to type (text-input), the implementation must be done with QT_IM_MODULE=wayland. I don't mind if it is set to

D5380: [platforms/drm] Explicitly request event context version 2

fooishbar accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drm-event-version-plasma-5.8 REVISION DETAIL https://phabricator.kde.org/D5380 To: graesslin, #kwin, #plasma, fooishbar Cc: plasma-devel, kwin, progwolff, lesliezhai,