D5346: DigitalClock: Use correct language for month and day names

2017-04-12 Thread David Rosca
drosca updated this revision to Diff 13343. drosca added a comment. Make uiLocale as property + fix language in tooltip REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5346?vs=13221&id=13343 BRANCH master REVISION DETAIL https://phabricator.kd

D5402: always close the downloaded file after downloading

2017-04-12 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Yes, good catch. I am unsure of why that happened, but i quite agree, that certainly needs to happen whether or not a redirection has been involved. REPOSITORY R304 KNewStuff BRANCH ph

D5402: always close the downloaded file after downloading

2017-04-12 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R304:925ec8a17ffb: always close the downloaded file after downloading (authored by mart). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5402?vs=13331&id=13344 REVISI

D5346: DigitalClock: Use correct language for month and day names

2017-04-12 Thread David Rosca
drosca updated this revision to Diff 13345. drosca added a comment. Also fix language in compact representation when Long Date is configured REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5346?vs=13343&id=13345 BRANCH master REVISION DETAIL h

D5406: possible to edit the default color scheme

2017-04-12 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH phab/editDefault REVISION DETAIL https://phabricator.kde.org/D5406 To: mart, #plasma, davidedmundson Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreut

D5406: possible to edit the default color scheme

2017-04-12 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R119:cca27a026af3: possible to edit the default color scheme (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5406?vs=13346&id=13347 REVISION D

D5406: possible to edit the default color scheme

2017-04-12 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY no reason to not allow editing the default color sheme with an invalid path, everyting falls back to the default, keeping the dialog fully fun

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 09:33:29 + Build duration: 6 min 15 sec CHANGE SET Revision c8d7f0363a568b6a4c5

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 710 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/710/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 09:27:13 + Build duration: 20 min CHANGE SET Revision cca27a026af372ac339db12a66779c858b4b

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 922 - Fixed!

2017-04-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/922/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 09:50:33 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 922 - Fixed!

2017-04-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/922/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 09:50:33 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name: (root)

D5407: Sort the themes in decoration KCM

2017-04-12 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY Even though we're using a QSortFilterProxy model, by default it doesn't actually sort anything until instructed to. This

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 118 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 10:48:00 + Build duration: 6 min 16 sec CHANGE SET Revision fcecf928409c7b9b00f

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 711 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/711/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 10:48:00 + Build duration: 17 min CHANGE SET Revision 373fd101c77fd7969f8b9e9683657219d8d1

D5408: Don't forward keys until the recipient is ready

2017-04-12 Thread Dan Leinir Turthra Jensen
leinir created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This avoids numerous crashes when using the keyboard navigation in Discover during searches. It would seem that, without this, we occasionall

D5410: Fix error text

2017-04-12 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN None REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5410 AFFECTED FILES shell/scriptin

D5409: Queue some connections which cannot be autodetected

2017-04-12 Thread Dan Leinir Turthra Jensen
leinir created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some of the connections we make are doing cross-thread calls, but in functions which exist on objects which live inside the same thread. Conse

D5408: Don't forward keys until the recipient is ready

2017-04-12 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D5408 To: leinir, apol, #kirigami, mart Cc: plasma-devel, apol

D5411: restore the "current" color scheme concept

2017-04-12 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY add again a fake entry called current like there used to be, add an "Apply" button in the color scheme editor (when not in standalone app mode

D5309: Hoist the actions overlay out of the frame loader.

2017-04-12 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Indeed RTL seems broken with and without this patch.. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5309 To: hein, #plasma, broulik Cc:

D5310: Don't close popup when spring-load dragging into it.

2017-04-12 Thread Kai Uwe Broulik
broulik added a comment. Works fine but I don't have Qt 5.9 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5310 To: hein, #plasma, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5409: Queue some connections which cannot be autodetected

2017-04-12 Thread Aleix Pol Gonzalez
apol added a comment. Are you sure? Which other threads? From the rendering? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5409 To: leinir, #discover_software_store, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5407: Sort the themes in decoration KCM

2017-04-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D5407 To: davidedmundson, #plasma, mart Cc: plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterber

D5411: restore the "current" color scheme concept

2017-04-12 Thread David Edmundson
davidedmundson added a comment. You've exlained what the patch does, but you've not said why you're doing it. What does this achieve? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5411 To: mart, #plasma Cc: davidedmundson, plasma-devel, progwolff, lesliezh

D5410: Fix error text

2017-04-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5410 To: davidedmundson, #plasma, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, s

D5409: Queue some connections which cannot be autodetected

2017-04-12 Thread Dan Leinir Turthra Jensen
leinir added a comment. In https://phabricator.kde.org/D5409#101510, @apol wrote: > Are you sure? Which other threads? From the rendering? Yeah, the crashes happen when forwarding the data updates to the view, which has potentially changed in the meantime. REPOSITORY R134 Disco

D5412: Support fractional scailng in KScreen Scaling preview

2017-04-12 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qt 5.something changed to support fractional scaling. I updated the backend code to support that, I never updated the preview UI. T

D5351: kcm_baloofile: Add option to disable file content indexing

2017-04-12 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D5351 To: fvogt, #plasma, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5351: kcm_baloofile: Add option to disable file content indexing

2017-04-12 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a818d2f0ad30: kcm_baloofile: Add option to disable file content indexing (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5351?vs=13325&id

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 712 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/712/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 12:58:35 + Build duration: 16 min CHANGE SET Revision a818d2f0ad30bb14718f296690a95ef55ed5

D5409: Queue some connections which cannot be autodetected

2017-04-12 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > KNSBackend.cpp:330 > m_page = 0; > -connect(this, &KNSBackend::receivedResources, stream, > &ResultsStream::resourcesFound); > +connect(this, &KNSBackend::receivedResources, stream, > &ResultsStream::resourcesFound, Qt::Queu

D5309: Hoist the actions overlay out of the frame loader.

2017-04-12 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c5961c16a69d: Hoist the actions overlay out of the frame loader. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5309?vs=13126&id=13356#toc REPOSITORY R119 Plasma Desktop

D5310: Don't close popup when spring-load dragging into it.

2017-04-12 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1aec30d954b7: Don't close popup when spring-load dragging into it. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5310?vs=13112&id=13357

D5408: Don't forward keys until the recipient is ready

2017-04-12 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. I just tested this, I get this error message: `file:///home/apol/devel/kde5/lib64/qml/org/kde/kirigami.2/ScrollablePage.qml:132: TypeError: Cannot read property 'Component' of null`

D5408: Don't forward keys until the recipient is ready

2017-04-12 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D5408#101552, @apol wrote: > I just tested this, I get this error message: > `file:///home/apol/devel/kde5/lib64/qml/org/kde/kirigami.2/ScrollablePage.qml:132: TypeError: Cannot read property 'Component' of null` This seems

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 713 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/713/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 13:41:49 + Build duration: 6 min 3 sec CHANGE SET Revision c5961c16a69d9c31d3c3c52aad5e268

D5410: Fix error text

2017-04-12 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ffe5ff3b1f5b: Fix error text (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5410?vs=13351&id=13360 REVISION DETAIL https://

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Friedrich W. H. Kossebau
kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Having slept over this one night, I still think that this change should be not the way to go to fix the seen issues. The actual problem is bad usage in application code, u

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Luigi Toscano
ltoscano added a comment. I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas, mpyn

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 849 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/849/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 15:47:09 + Build duration: 15 min CHANGE SET Revision ffe5ff3b1f5b00e790d8c46411222ebb05

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Matthias Klumpp
mak added a comment. In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage? Yes. See https://standards.fre

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Andrius Štikonas
stikonas added a comment. In https://phabricator.kde.org/D5405#101575, @mak wrote: > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organi

D5409: Queue some connections which cannot be autodetected

2017-04-12 Thread Aleix Pol Gonzalez
apol requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5409 To: leinir, #discover_software_store, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Friedrich W. H. Kossebau
kossebau added a comment. In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organization domain AND the homepage? In the current KAboutData

D5414: [tabbox] Expose noModifierGrab to QtQuick

2017-04-12 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There is a special mode in TabBox which is the noModifierGrab mode. This is Alt+Tab active without a modifier being hold. This mode is e

D5415: [lnf] Honor the new noModifierGrab in TabBox

2017-04-12 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the TabBox is in the noModifierGrab mode we should activate an item when being clicked/touched. TEST PLAN Tested on X11 and Wayland

D5415: [lnf] Honor the new noModifierGrab in TabBox

2017-04-12 Thread Martin Gräßlin
graesslin added a dependency: D5414: [tabbox] Expose noModifierGrab to QtQuick. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5415 To: graesslin, #kwin, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5414: [tabbox] Expose noModifierGrab to QtQuick

2017-04-12 Thread Martin Gräßlin
graesslin added a dependent revision: D5415: [lnf] Honor the new noModifierGrab in TabBox. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5414 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, seb

D5414: [tabbox] Expose noModifierGrab to QtQuick

2017-04-12 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH tabbox-no-modifier-grab REVISION DETAIL https://phabricator.kde.org/D5414 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mo

D5415: [lnf] Honor the new noModifierGrab in TabBox

2017-04-12 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH lnf-tabbox-no-modifier-grab REVISION DETAIL https://phabricator.kde.org/D5415 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, progwolff, lesliezh

D5416: Polish ItemViewHeader, solve binding loops

2017-04-12 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Don't assume "page" in the namespace of ItemViewHeader, use view instead which we have and symbolizes the same. Don't change the implicitHei

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D5405#101575, @mak wrote: > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the organi

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Andrius Štikonas
stikonas added a comment. In fact API documentation says explicitely that > IMPORTANT: if the organization domain is set, the .desktop file that describes your application should have an entry like X-DBUS-ServiceName=reversed_domain.kmyapp For instance kwrite passes "http://www.kate-edi

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D5405#101577, @kossebau wrote: > In https://phabricator.kde.org/D5405#101574, @ltoscano wrote: > > > I'm still confused. Documentation or not, bad usage or not, is it correct that desktop file name is constructed from both the o

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Luigi Toscano
ltoscano added a comment. One thing for sure: the code should be moved back to the constructor, and not dynamically at each call of desktopFileName(), or it would be a behavioral change. (Or at least it should be probably cached if we get an agreement in breaking this). And regarding th

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged about it, sent mails to KDE devel lists I assume the application ma

D5414: [tabbox] Expose noModifierGrab to QtQuick

2017-04-12 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:259e373bfc93: [tabbox] Expose noModifierGrab to QtQuick (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5414?vs=13361&id=13364 REVISION DETAIL

D5415: [lnf] Honor the new noModifierGrab in TabBox

2017-04-12 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea9489f32a6c: [lnf] Honor the new noModifierGrab in TabBox (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5415?vs=13362&id=13365

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 850 - Still Unstable!

2017-04-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/850/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 12 Apr 2017 17:48:30 + Build duration: 6 min 17 sec CHANGE SET Revision ea9489f32a6ce455b7b91d2f6856

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Nicolás Alvarez
nalvarez added a comment. Are you saying the d-bus service name should be equal to the .desktop filename? I don't see where this requirement comes from. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas, mpyne, kossebau, aacid, ltoscano Cc: nalva

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > > > The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broke

D5378: Adding an option to show popular documents/apps for Kicker and Dash

2017-04-12 Thread Ivan Čukić
ivan added a comment. "most used" is not what it does - it is a combination of most frequently and most recently used. As for 'first', you are right. The source of the word was the possibility to show an infinite list. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabrica

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D5405#101624, @graesslin wrote: > In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > > > In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > > > > > The desktop file name should follow the way how th

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5405#101626, @ltoscano wrote: > In https://phabricator.kde.org/D5405#101624, @graesslin wrote: > > > In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > > > > > In https://phabricator.kde.org/D5405#101615, @grae

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Andrius Štikonas
stikonas abandoned this revision. stikonas added a comment. Ok, so let us not change kcoreaddons now although it's still something that could have better default behaviour in KF6. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas, mpyne, kossebau

D5408: Don't forward keys until the recipient is ready

2017-04-12 Thread Aleix Pol Gonzalez
apol added a comment. Add `BUG: 378339` REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D5408 To: leinir, apol, #kirigami, mart Cc: plasma-devel, apol

D5421: Do not handle ScreenEdges::check for Edges which don't activate for Pointer

2017-04-12 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY On X11 the edges reserved only for pointer started to show the approach geometry. This problem is addressed by this change. Touch s

D5405: Create desktop file name based on organization domain unless set explicitely

2017-04-12 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5405#101628, @stikonas wrote: > Ok, so let us not change kcoreaddons now although it's still something that could have better default behaviour in KF6. My comment was not meant as a stop-this-effort comment. If we can impr