Sry not critical input or anything - but wanted to say "Great work!" :)
On Sunday, 28 May 2017 23.51.19 CEST Łukasz Sawicki wrote:
> Hi,
>
> Here is a Plasma 5.10 video NOT FINAL yet ;). Feel free to post your
> opinions, comments etc about it. I don't plan any radical changes but
> I can still
subdiff added a comment.
In https://phabricator.kde.org/D5928#112368, @cfeck wrote:
> First, the difference between "color management" and "color correction" is
that color correction is only one step in the color management workflow. KWin
would need (again) be able to apply color
urkud added a reviewer: Plasma.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D6003
To: urkud, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
urkud created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In default configuration, `loginctl unlock-sessions` requires root password,
while unlocking another session of the same user doesn't.
Hi,
Here is a Plasma 5.10 video NOT FINAL yet ;). Feel free to post your
opinions, comments etc about it. I don't plan any radical changes but
I can still tweak it a bit if there will be such a need.
https://youtu.be/AtI2DcA70bY
Cheers
Łukasz
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea59c63a815a: Match subsequences in application runner
(authored by rthomas, committed by aacid).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
cfeck added a comment.
In https://phabricator.kde.org/D5928#112364, @subdiff wrote:
> In https://phabricator.kde.org/D5928#112359, @cfeck wrote:
>
> > http://www.color.org/faqs.xalter
>
>
> Sorry, but I can't find the relevant part here. Can you quote it?
I wanted you to
subdiff updated this revision to Diff 14918.
subdiff added a comment.
Adapt to changed KWin DBus interface method names.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5931?vs=14744=14918
REVISION DETAIL
https://phabricator.kde.org/D5931
subdiff added a comment.
In https://phabricator.kde.org/D5928#112359, @cfeck wrote:
> http://www.color.org/faqs.xalter
Sorry, but I can't find the relevant part here. Can you quote it?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5928
To: subdiff, #kwin
subdiff added a comment.
In https://phabricator.kde.org/D5932#111809, @Zren wrote:
> Is there a "daytime" setting or is it hardcoded to be 100% blue? Redshift
Control for example:
Correcting color values in general is part of the later to introduce Color
Correction / Color
subdiff updated this revision to Diff 14917.
subdiff marked 6 inline comments as done.
subdiff added a comment.
- Messages.sh
- Translations in cpp file
- i18n instead of i18nd in qml
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
cfeck added a comment.
In https://phabricator.kde.org/D5928#112357, @subdiff wrote:
> In https://phabricator.kde.org/D5928#112339, @cfeck wrote:
>
> > The difference between gamma correction and color correction is that the
former only uses three 1D LUTs, while the latter can use
subdiff added inline comments.
INLINE COMMENTS
> davidedmundson wrote in nightcolor.cpp:111
> How confusing. In any case we have a race condition.
>
> We're triggering this on timeChangedFd so we have behaviour that basically
> changes depending on whether logind has processed resuming and
Packagers,
We have a major bug with Plasma 5.8.7 with Qt 5.6, our minimum requirement
for that release.
It will compile but the main task bar will not load.
Use with Qt >=5.7.0 is fine. (which AFAIK is most distros)
I will spin a 5.8.7.1 of plasma-desktop ASAP or you can revert 76034a4cd in
subdiff added a comment.
In https://phabricator.kde.org/D5928#112339, @cfeck wrote:
> The difference between gamma correction and color correction is that the
former only uses three 1D LUTs, while the latter can use three 3D LUTs. In
other words, gamma correction cannot tint your blue
subdiff added a comment.
In https://phabricator.kde.org/D5928#111959, @davidedmundson wrote:
> As for your comments:
>
> > The first one is, that the fading phases generate much DBus traffic, as
you said. To solve this we would need to do the fading in KWin. For that we
need timers,
davidedmundson added inline comments.
INLINE COMMENTS
> subdiff wrote in nightcolor.cpp:111
> Yes: https://www.freedesktop.org/wiki/Software/systemd/logind/
>
> It's true between signal `PrepareForSleep` is emitted with arg `true` and
> after sleep again with `false`.
How confusing. In any
subdiff added inline comments.
INLINE COMMENTS
> davidedmundson wrote in nightcolor.cpp:52
> rename the class or the file
Is there a general rule to it? Can I call the class NightColorManager instead
and leave the file name untouched?
Is this about the generic class name or about the class
subdiff updated this revision to Diff 14916.
subdiff marked 2 inline comments as done.
subdiff added a comment.
- No m_platform in ColorCorrect::Manager
- Dbus iface methods renamed
- Give GammaRamp object to DrmCrtc (and use its ramp size)
- Separate GammaRamp struct for better includes
cfeck added a comment.
I agree that this code should not talk about night mode at all. Indeed we
only need code in KWin to control the gamma LUTs per screen, and maybe even
compute the LUTs from a number of gamma/contrast/brightness control points so
that we do not have to transfer a lot of
cfeck added a comment.
In https://phabricator.kde.org/D5928#112334, @subdiff wrote:
> In https://phabricator.kde.org/D5928#111282, @graesslin wrote:
>
> > I wouldn't call it color correction as we used to have a mechanism called
color correction in the past which did something very
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
normally we do that in the main function prior to creating the QApplication.
c.f. kmail or kwin_x11.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
subdiff added a comment.
In https://phabricator.kde.org/D5928#111282, @graesslin wrote:
> I wouldn't call it color correction as we used to have a mechanism called
color correction in the past which did something very different. Personal
suggestion: gamma correction or color temperature
adridg added a comment.
See, e.g., https://build-sandbox.kde.org/view/Plasma/job/Plasma kwallet-pam
kf5-qt5 FreeBSDQt5.7/1/console
That's the compile failure (pam_kwallet.c:39:10: fatal error:
'security/pam_ext.h' file not found) without these changes.
REPOSITORY
R107 KWallet PAM
adridg created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
FreeBSD has neither pam_ext.h nor pam_syslog(), so check for headers
and add defines as appropriate.
TEST PLAN
Builds on FreeBSD, now.
On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote:
On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote:
createWinId();
windowHandle()->setTransientParent(parent()->nativeParentWidget()->windowHan
dle());
Does it makes sense? Would it work?
As far i know, if a qmenu is passed
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f0e45cd42ba7: Use ${X11_XTest_LIB} rather than Xtst.
(authored by tcberner).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5997?vs=14905=14909
REVISION
On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote:
>createWinId();
>
> windowHandle()->setTransientParent(parent()->nativeParentWidget()->windowHan
> dle());
>
> Does it makes sense? Would it work?
As far i know, if a qmenu is passed a parent in the ctor, then at the right
moment a
Hi all,
as you may know in Wayland popup menus are wrongly positioned if they don't
have
a transient parent set on their window.
For QtWidget applications the fix itself is rather easy (at least in the
simplest case):
someMenu->createWinId(); // someMenu is a QMenu
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5997
To: tcberner, #freebsd, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
tcberner retitled this revision from "Include signal.h for kill(), and
prototype kqueue/kevent stuff..." to "kcheckpass: Add support in for non-Linux
platforms via kevent.".
tcberner edited the summary of this revision.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
tcberner updated this revision to Diff 14906.
tcberner retitled this revision from "Include signal.h for kill(), and
prototype kqueue/kevent stuff... " to "Include signal.h for kill(), and
prototype kqueue/kevent stuff...".
tcberner added a comment.
Use sigwaitinfo() to get information on
rthomas added a comment.
@aacid : I have assigned the Plasma-Workspace repo to this revision. Please
commit this patch on my behalf. I think I'll hold on for a while before
applying for commit access.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5870
rthomas set the repository for this revision to R120 Plasma Workspace.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas, #plasma, davidedmundson
Cc: aacid, davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai,
34 matches
Mail list logo
