D7794: create the whole plugin structure in the build directory

2017-09-13 Thread Marco Martin
mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY when building copy all qml files in build/org/kde/kirigami.2 as well generating the binary plugin there. this is neccessary to be able to lo

D7794: create the whole plugin structure in the build directory

2017-09-13 Thread Marco Martin
mart updated this revision to Diff 19473. mart added a comment. - alternative approach REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19472&id=19473 BRANCH cmakehack REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES src/CMak

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-13 Thread Paul Brown
On Thursday, 7 September 2017 16:32:15 CEST Zlatan Todoric wrote: > On 09/07/2017 04:29 PM, Paul Brown wrote: > >> I just talked with Paul, he'll be able to make it as well, so from the > >> KDE side, we get a rather complete set of people together to be useful, > >> technical, UI, and promo people

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-13 Thread Zlatan Todoric
On 09/07/2017 04:29 PM, Paul Brown wrote: >> I just talked with Paul, he'll be able to make it as well, so from the >> KDE side, we get a rather complete set of people together to be useful, >> technical, UI, and promo people involved. I'll ask Jens, our design >> lead to join in as well, but let

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-13 Thread Paul Brown
> I just talked with Paul, he'll be able to make it as well, so from the > KDE side, we get a rather complete set of people together to be useful, > technical, UI, and promo people involved. I'll ask Jens, our design > lead to join in as well, but let's pin down Thursday, 19:00 CEST > (9.00am PDT),

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-13 Thread Todd Weaver
Looks like there was a conversion incorrect in timezone. 19:00 CEST = 10:00am PDT. So we will rejoin in 50minutes. Todd. On Thu, 2017-09-07 at 16:32 +0200, Zlatan Todoric wrote: > > On 09/07/2017 04:29 PM, Paul Brown wrote: > > > I just talked with Paul, he'll be able to make it as well, so >

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-13 Thread Sebastian Kügler
On Thu, 7 Sep 2017 16:32:15 +0200 Zlatan Todoric wrote: > I suggest Jitsi as well and I suggest just the name KDEPurismMeeting > so: https://meet.jit.si/KDEPurismMeeting Quickly, in advance, two documents we've been working on on the KDE side, a roadmap describing our technology plans, and a draf

plasma 5.11 beta tars tonight

2017-09-13 Thread Jonathan Riddell
There's a pr thing being done tomorrow so I've been requested to get the plasma beta out the way in the morning. This means I'll be making the tars and branching tonight (not sure exact time, I've a Catalan independence rally to go to first). You can ask for re-rolls tomorrow morning before the a

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-09-13 Thread Thorsten Bonhagen
thorstenb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY openconnect: patch which add support for seperate pin value for pkcs11 url plasma-nm openconnect should support separate pin value in co

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-09-13 Thread Thorsten Bonhagen
thorstenb added a reviewer: Plasma. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D7795 To: thorstenb, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7794: create the whole plugin structure in the build directory

2017-09-13 Thread Aleix Pol Gonzalez
apol added a comment. Also you maybe can move this code into the tests subdirectory, so it only needs to be run in `BUILD_TESTING`. I am not sure if this is going to work but I agree that if it has any opportunity then it's probably along these lines... INLINE COMMENTS > CMakeLists.txt

D7785: Don't make requests if we didn't manage to connect

2017-09-13 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:8280fa0c802b: Don't make requests if we didn't manage to connect (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7785?vs=19455&id

D7796: Use flatpak_installation_list_installed_refs for listing installed flatpaks

2017-09-13 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of going through a directory. This allows us to have the FlatpakInstalledRef* tuple for each of the resources being able to fully popu

D7797: Add option to disable unlocking modem on detection

2017-09-13 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG:380150 REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7797 AF

D7797: Add option to disable unlocking modem on detection

2017-09-13 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. This wasn't my patch.. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D7797 To: davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D7798: [Folder View] Fix supported drag actions

2017-09-13 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY SetSupportedDragActions is deprecated and doesn't seem to work. This fixes modifier shortcuts for dragging, e.g. dragging with Ctrl+Shift to

D7800: Accessible roles on Plasma NM toolbar checkboxes

2017-09-13 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Tested with orca REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7800 AFF

D7801: Fix the kirigami gallery command line

2017-09-13 Thread Bhushan Shah
bshah created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It tries to start wrong gallery application TEST PLAN works now REPOSITORY R169 Kirigami BRANCH fixgallery REVISION DETAIL https://

D7800: Accessible roles on Plasma NM toolbar checkboxes

2017-09-13 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7800 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha

D7801: Fix the kirigami gallery command line

2017-09-13 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH fixgallery REVISION DETAIL https://phabricator.kde.org/D7801 To: bshah, mart Cc: plasma-devel, apol, mart, hein

D7801: Fix the kirigami gallery command line

2017-09-13 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R169:558521b228d7: Fix the kirigami gallery command line (authored by bshah). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7801?vs=19481&id=19482 REVISION DETAIL h

D7796: Use flatpak_installation_list_installed_refs for listing installed flatpaks

2017-09-13 Thread Jan Grulich
jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FlatpakBackend.cpp:614 > > -AppStream::Component appstreamComponent(metadata.component()); > -FlatpakResource *resource = new >

D7798: [Folder View] Fix supported drag actions

2017-09-13 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7798 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7796: Use flatpak_installation_list_installed_refs for listing installed flatpaks

2017-09-13 Thread Aleix Pol Gonzalez
apol added a comment. Here's an issue related to the next version of the patch: https://github.com/flatpak/flatpak/issues/1014 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7796 To: apol, jgrulich Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, a

D7796: Use flatpak_installation_list_installed_refs for listing installed flatpaks

2017-09-13 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 19486. apol added a comment. Use flatpak_installed_ref_load_metadata to read the metadata REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7796?vs=19476&id=19486 BRANCH arcpatch-D7796 REVISION DETAIL ht

KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Martin Flöser
Hi all, unfortunately I have to inform you that KGlobalAccel has a severe regression [1] in the latest framework release resulting in many shortcuts no longer functioning. As the current frameworks release is the one the next Plasma release is going to depend on, we need to act quickly. In t

Re: plasma 5.11 beta tars tonight

2017-09-13 Thread Martin Flöser
Am 2017-09-13 11:54, schrieb Jonathan Riddell: There's a pr thing being done tomorrow so I've been requested to get the plasma beta out the way in the morning. This means I'll be making the tars and branching tonight (not sure exact time, I've a Catalan independence rally to go to first). You c

Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Jonathan Riddell
This patch? https://phabricator.kde.org/D6234 I think reverting it for now and me or David can make a 5.38.1 release would be easiest Jonathan On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote: > Hi all, > > unfortunately I have to inform you that KGlobalAccel has a severe > regr

D7806: seccomp filter: Handle openat as well

2017-09-13 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY With glibc 2.26, the open syscall is not used anymore as openat is favored. This causes the testcase to fail, which shows that openat is not handled correctly by the seccomp filter. This adds a te

D7806: seccomp filter: Handle openat as well

2017-09-13 Thread Fabian Vogt
fvogt edited the summary of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D7806 To: fvogt, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Martin Flöser
Am 2017-09-13 19:06, schrieb Jonathan Riddell: This patch? https://phabricator.kde.org/D6234 I think reverting it for now and me or David can make a 5.38.1 release would be easiest Yes, that should be the change causing the issue. It could also be the change in KWindowSystem. Best would be

D7806: seccomp filter: Handle openat as well

2017-09-13 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D7806 To: fvogt, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, ab

D7806: seccomp filter: Handle openat as well

2017-09-13 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R133:1d70ac4096ac: seccomp filter: Handle openat as well (authored by fvogt). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7806?vs=19496&id=19497 REVISION DETAI

Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Kai Uwe Broulik
Hi, either of the following reverts fix the problem for me: KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d or KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and 32526718eae99ccb594360627586eebdf793372b but perhaps both KGlobalAccel and KWindowSystem to be sure. Cheers Kai Uw

Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Martin Flöser
Am 2017-09-13 20:28, schrieb Kai Uwe Broulik: Hi, either of the following reverts fix the problem for me: KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d or KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and 32526718eae99ccb594360627586eebdf793372b but perhaps both KGlobalAcc

Re: KGlobalAccel regression in latest frameworks release

2017-09-13 Thread Kai Uwe Broulik
Oki, just KGlobalAccel seems fine, too.   Ursprüngliche Nachricht   Von: mgraess...@kde.org Gesendet: 13. September 2017 8:33 nachm. An: plasma-devel@kde.org; kde-frameworks-de...@kde.org Antworten: kde-frameworks-de...@kde.org Betreff: Re: KGlobalAccel regression in latest frameworks release Am

D7807: When cloning a config also clone supportedFeatures

2017-09-13 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise when KDED applies a config, we lose the features. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https

D7807: When cloning a config also clone supportedFeatures

2017-09-13 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D7807 To: davidedmundson, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D7798: [Folder View] Fix supported drag actions

2017-09-13 Thread Eike Hein
hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7798 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7808: Create a dedicated X11EventFilter for the events used by RootInfo

2017-09-13 Thread Martin Flöser
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Splitting out the handling from events.cpp and moves it into a dedicated class created together with RootInfo. TEST PLAN Test case fo

Re: kwin_wayland and setWindowIcon()

2017-09-13 Thread Elvis Angelaccio
On martedì 12 settembre 2017 23:50:57 CEST, David Edmundson wrote: you'll be getting wl_shell_surface@N.set_class("qtcreator") on current kwin. It's a wl_shell vs xdgv6 difference, but they're both getting the same data from the QtWayland code. It's just different implementations of mShellSurf

Re: kwin_wayland and setWindowIcon()

2017-09-13 Thread David Edmundson
​It won't. The only difference is the 'key name" in the properties. The value "qtcreator" is the same and everything there onwards is the same. David

D7807: When cloning a config also clone supportedFeatures

2017-09-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R110:05498b805259: When cloning a config also clone supportedFeatures (authored by davidedmundson). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7807?vs=19500&

D7796: Use flatpak_installation_list_installed_refs for listing installed flatpaks

2017-09-13 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good now. I haven't tried it yet, but I understand what you did and it should work. REPOSITORY R134 Discover Software Store BRANCH arcpatch-D7796 REVISION DETAIL https://p