D7904: "Close Description" tooltip should instead say "Back"

2017-09-21 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:4d9461f73b6c: Close Description tooltip should instead say Back (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7905 To: ngraham, apol, #discover_software_store Cc: colomar, jensreuterberg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart

D7871: Properly update the visible (icon) name when the caption changes

2017-09-21 Thread Graham Perrin
grahamperrin added a comment. From https://bugs.kde.org/show_bug.cgi?id=384760#c7 under _384760 – absence of proper (current) titles in Task Manager where, for example, many windows are opened in rapid succession by Firefox or SeaMonkey_: > … As far as I can tell, the patch does fix

D7760: Move XRenderUtils init/cleanup into X11 standalone platform

2017-09-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH xrenderutils-x11-platform REVISION DETAIL https://phabricator.kde.org/D7760 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff,

D7894: Only try creating X11 shadow if we have an X11 connection

2017-09-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH shadow-x11 REVISION DETAIL https://phabricator.kde.org/D7894 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7925: Generate the appstream metadata of the gallery app

2017-09-21 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I want to have a flatpak package with the gallery to test stuff and it needs appstream info TEST PLAN

D7924: Support starting kwin_wayland without XWayland support

2017-09-21 Thread Martin Flöser
graesslin added dependencies: D7760: Move XRenderUtils init/cleanup into X11 standalone platform, D7894: Only try creating X11 shadow if we have an X11 connection, D7892: Only call xcb_flush in performCompositing if we have an X11 connection, D7856: Make xstacking order dirty handling work

D7924: Support starting kwin_wayland without XWayland support

2017-09-21 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Just continues with the steps without starting XWayland. This does not yet fully support

D7892: Only call xcb_flush in performCompositing if we have an X11 connection

2017-09-21 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:e8664f83b964: Only call xcb_flush in performCompositing if we have an X11 connection (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. Excellent. Let's continue that discussion in a bug report I just filed to avoid losing it once I can commit the patch (hopefully later tonight): https://bugs.kde.org/show_bug.cgi?id=384936 REPOSITORY R134 Discover Software Store REVISION DETAIL

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. Yes, I totally agree. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7905 To: ngraham, apol, #discover_software_store Cc: colomar, jensreuterberg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas,

Re: KDE Slimbook and its Synaptics-less Touchpad

2017-09-21 Thread Martin Flöser
Am 2017-09-21 16:41, schrieb Aleix Pol: Hey Plasma, One of the things that could be improved in the KDE Slimbook is that since the touchpad is not synaptics-based the kcm is entirely disabled. Nevertheless, Alejandro recently pointed out to me that XInput is still providing some options that

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. Yes, I think that makes sense, but it wouldn't be quite enough, since Plasma ships with three UI options for the launcher button, and Application Dashboard is only one of them. Each one I think needs to prominently highlight recently-installed applications.

D7897: Move X11 specific Workspace initialization code into dedicated method

2017-09-21 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > broulik wrote in workspace.cpp:381 > `kwinApp()->x11Connection()`? Yes, in a future change :-) Currently this only moves code around and tries to not change too much. Some time in the near to distant future connection() will have to die as

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. Application Dashboard in Plasma initially shows recent applications by default (which makes a ton of sense!). Maybe it could make sense to insert newly-installed applications in there? REPOSITORY R134 Discover Software Store REVISION DETAIL

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. I quite agree that we should make launching programs more discoverable in other ways--especially launching new programs ("I just installed this thingy; now where is it!?"). I've recently been thinking about that myself, in fact. In Ubuntu Unity, newly-installed

D7919: [PowerDevil Runner] Obliterate traces of power profiles

2017-09-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They have been removed way back in Plasma 4.7 and are the cause of the "Error contacting the daemon!"

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. Don't worry: After many years working as a usability consultant and UX designer, I know that I have to distinguish between my own needs and user needs. If our users have trouble launching applications, then placing a launch button in Discover is _not_ the

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7905 To: ngraham, apol, #discover_software_store Cc: colomar, jensreuterberg, plasma-devel, ZrenBot, progwolff, lesliezhai,

D7917: [TasksModel] Use std::acumulate on the QHash directly

2017-09-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY `begin()` and `end()` operate on the hash values. This avoids creating a temporary list just for

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham added a comment. I strongly believe that having a visible launch button is critical. The launch button may be meaningless fluff for me, and you, and other developers, but developers don't need to use GUI software center apps. We're not the intended audience. Discover targets

KDE Slimbook and its Synaptics-less Touchpad

2017-09-21 Thread Aleix Pol
Hey Plasma, One of the things that could be improved in the KDE Slimbook is that since the touchpad is not synaptics-based the kcm is entirely disabled. Nevertheless, Alejandro recently pointed out to me that XInput is still providing some options that could be useful to our users and maybe it

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D7905#147514, @jensreuterberg wrote: > The hamburger menu was my suggestion so I should probably say something about it - for me the "launch" option is completely meaningless fluff. Another button to nothing. That being said, if

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Jens Reuterberg
jensreuterberg added a comment. The hamburger menu was my suggestion so I should probably say something about it - for me the "launch" option is completely meaningless fluff. Another button to nothing. That being said, if this is something critical in normal usage then it should be in there

D7898: Only send OutputConfig sendApplied / sendFailed to the right resource

2017-09-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:2b3f9509ac12: Only send OutputConfig sendApplied / sendFailed to the right resource (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D7913: Don't include the control over the bottom decoration

2017-09-21 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 384913 REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

D7912: track the config to monitor, save scale

2017-09-21 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit R104:8719c33eea8f: track the config to monitor, save scale (authored by sebas). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7912?vs=19735=19737 REVISION DETAIL

D7912: track the config to monitor, save scale

2017-09-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH scalechange2 REVISION DETAIL https://phabricator.kde.org/D7912 To: sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7814: Disable shortcuts when an action is disabled

2017-09-21 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R169:69e074a874a2: Disable shortcuts when an action is disabled (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7814?vs=19731=19736 REVISION

D7912: track the config to monitor, save scale

2017-09-21 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When doApplyConfig is called, we forgot to change the monitored config, which means we weren't

D7906: Locate the Back button correctly in the toolbar

2017-09-21 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. I suspected as much. Abandoning. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7906 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7898: Only send OutputConfig sendApplied / sendFailed to the right resource

2017-09-21 Thread Sebastian Kügler
sebas added a comment. FWIW, I tested it, it fixes kwin crashing when adding a setApplied() call on the OutputConfiguration, and it also means the applied signal arrives. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D7898 To: davidedmundson,

D7906: Locate the Back button correctly in the toolbar

2017-09-21 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. This is the wrong fix, let me look into fixing it in Kirigami. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7906 To: ngraham,

D7904: "Close Description" tooltip should instead say "Back"

2017-09-21 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7904 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7898: Only send OutputConfig sendApplied / sendFailed to the right resource

2017-09-21 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Yes, the initial idea was to send applied() to all connected resources. That is not s_allResources, so your patch is correct. The resources that are actually bound are not currently tracked.

D7814: Disable shortcuts when an action is disabled

2017-09-21 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7814 To: leinir, #kirigami, mart Cc: plasma-devel, #kirigami, apol, mart, hein

D7814: Disable shortcuts when an action is disabled

2017-09-21 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 19731. leinir added a comment. Change the approach from performing all the magic inside Kirigami (which resulted in not entirely consistent behaviours, depending on which actions you used), pushing some of the requirements for disabling things onto the

D7814: Disable shortcuts when an action is disabled

2017-09-21 Thread Dan Leinir Turthra Jensen
leinir retitled this revision from "Disable shortcuts for actions not on the current page" to "Disable shortcuts when an action is disabled". leinir edited the summary of this revision. leinir edited the test plan for this revision. REPOSITORY R169 Kirigami REVISION DETAIL