apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kaccess.cpp:722
> we've effectively removed this connect to dialogClosed. Now closing goes to
> noClicked.
>
> Is this a problem?
I noticed. I'm not sure to be honest.
My thinking is that the user shouldn't notice the diffe
davidedmundson added a comment.
nice
INLINE COMMENTS
> kaccess.cpp:722
> -connect(dialog, &KDialog::noClicked, this, &KAccessApp::noClicked);
> -connect(dialog, &KDialog::closeClicked, this,
> &KAccessApp::dialogClosed);
> }
we've effectively removed this connect to dia
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Executed it locally, can start and stop orca
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https:/
mart updated this revision to Diff 20257.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- move to xdg-foreign-unstable-v2
- get rid of setTransientFor
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
mart updated this revision to Diff 20247.
mart added a comment.
- finalize signatures for signals
- todo on font change
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7939?vs=20110&id=20247
BRANCH
mart/colorcontext
REVISION DETAIL
https://phabricat
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:6940b08074fd: Show headset icons for devices identifying
as "Headset" in Description (authored by antlarr, committed by
drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2b67d213871f: remove bogus test (authored by mart).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8109?vs=20241&id=20243
REVISION DETAIL
https://phabricat
bshah added a comment.
+1
REPOSITORY
R119 Plasma Desktop
BRANCH
xkbtest
REVISION DETAIL
https://phabricator.kde.org/D8109
To: mart, #plasma, sebas
Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
xkbtest
REVISION DETAIL
https://phabricator.kde.org/D8109
To: mart, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, s
mart created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
the names in /usr/share/X11/xkb/symbols/us are not stable,
the us keyboard name recently switched from
"English (US, international with dead k
mart added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8109
To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
antlarr updated this revision to Diff 20239.
antlarr added a comment.
- Remove check for currentPort which is no longer needed
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8054?vs=20094&id=20239
BRANCH
master
REVISION DETAIL
https
drosca accepted this revision.
drosca added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> DeviceListItem.qml:29
> icon: {
> if (currentPort) {
> +switch(FormFactor) {
This check is no longer needed.
REPOSITORY
R115 Plasma Audio V
Cheers!
--
sebas
http://www.kde.org | http://vizZzion.orgPlasma Weekly Meeting, 2 October 2017, 12:00 CEST #plasma on freenode
Sho:
* Wrote a proof-of-concept patch for making Sonnet work on Qt Quick TextEdits:
success, we can have spell-checking in Kirigami apps
* Fixed some libtm unit test fa
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
See QTBUG-55460 for details. It's causing our unit test crash when
closing the lock screen wi
15 matches
Mail list logo