D9323: Use ScreenMapper everywhere as a singleton

amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D9323 To: amantia, #plasma, mwolff, hein Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

fvogt created this revision. fvogt added reviewers: Plasma, davidedmundson, anthonyfieroni. Restricted Application added a project: Plasma. REVISION SUMMARY This reverts commit https://phabricator.kde.org/R120:84a29ef86380fab40236bdf934b49bc3cf090853. WidgetExplorer gets destroyed immediat

D9338: [comic] Fix comic updater time interval

davidedmundson added inline comments. INLINE COMMENTS > comicupdater.cpp:56 > +} else { > +mUpdateIntervall = 3; > } wouldn't you still need to call checkForUpdate() if you went into this path? Especially as checkForUpdate is the one that sets up the timer to call itself again

D9338: [comic] Fix comic updater time interval

davidedmundson added a comment. Can you please fill in the "testing done" field on phabricator. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali

D9470: Remove unused background.png

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d2d1b9d3ac9e: Remove unused background.png (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9470?vs=24258&id=24278 REVISION DETAIL

D8446: [Notifications] Allow selecting text with mouse

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2fc5b90b85df: [Notifications] Allow selecting text with mouse (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8446?vs=21233&id=24279

D9391: [effects] Add 'Fullscreen' effect

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. https://phabricator.kde.org/D6799 for the record (I like your patch better, actually, just if you want to look at my implementation) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.o

D9324: [Air theme] Add task bar progress graphic

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3889edd6d6e5: [Air theme] Add task bar progress graphic (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9324?vs=23895&id=24280#toc REPOSITORY R242 Plasma Framework (Lib

D9474: [Kickoff / Kicker] Move "Add to favorites" entry to the bottom of the context menu

broulik created this revision. broulik added reviewers: Plasma, hein, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise draws attention away from jump list actions and other more frequently used actions. T

D9477: Add comments for layout-templates

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently not visible in the plasma UI, but appstream complains about a lack of a summary, wh

D9477: Add comments for layout-templates

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9477 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber

D9477: Add comments for layout-templates

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec2f58f04850: Add comments for layout-templates (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9477?vs=24285&id=24288 REVISION

D9478: Drop use of qtpaths in startkde

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qtpaths doesn't work on some distros (Ubuntu for example, where it's shipped with dev tools)

D9478: Drop use of qtpaths in startkde

apol added a comment. Thanks for looking into this! INLINE COMMENTS > startkde.cmake:41 > fi > +if [ ${XDG_CONFIG_DIRS} ]; then > +sysConfigDirs=$XDG_CONFIG_DIRS `sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}` As we did for https://phabricator.kde.org/D9299 REPOSITORY R120 Plasma Works

D9478: Drop use of qtpaths in startkde

davidedmundson updated this revision to Diff 24293. davidedmundson added a comment. Update with Aleix's change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9478?vs=24292&id=24293 BRANCH master REVISION DETAIL https://phabricator.kde.org/D94

D9478: Drop use of qtpaths in startkde

apol added inline comments. INLINE COMMENTS > apol wrote in startkde.cmake:41 > `sysConfigDirs=${XDG_CONFIG_DIRS:-/etc/xdg}` > > As we did for https://phabricator.kde.org/D9299 No, with this you get to remove the if altogether. > startplasmacompositor.cmake:24 > fi > +if [ ${XDG_CONFIG_DIRS}

D9391: [effects] Add 'Fullscreen' effect

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Restricted Application edited projects, added Plasma; removed KWin. A possibility to solve this problem with gtk would be to restrict to Wayland windows. I'm absolutely again

D9338: [comic] Fix comic updater time interval

anthonyfieroni updated this revision to Diff 24295. anthonyfieroni marked 2 inline comments as done. anthonyfieroni edited the test plan for this revision. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=23936&id=24295 REVISION DETAIL https://ph

D9338: [comic] Fix comic updater time interval

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in comicupdater.cpp:86 > I assume this line is the important change? > > +1 to this bit. Yes. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, b

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added a comment. Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBo

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added a comment. Deletion is needed https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112 https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b4

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

fvogt added a comment. In https://phabricator.kde.org/D9473#182449, @anthonyfieroni wrote: > Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. "Download new widgets" -> Either plasmashell crashes instantly or the dialog does not show

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

fvogt added a comment. In https://phabricator.kde.org/D9473#182454, @anthonyfieroni wrote: > Deletion is needed > https://phabricator.kde.org/source/knewstuff/browse/master/src/downloaddialog.cpp;6de0754aa9258558a7203afc366b49984f0192eb$112 > https://phabricator.kde.org/source/knew

D9338: [comic] Fix comic updater time interval

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9338 To: anthonyfieroni, davidedmundson, broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added a comment. In https://phabricator.kde.org/D9473#182455, @fvogt wrote: > In https://phabricator.kde.org/D9473#182449, @anthonyfieroni wrote: > > > Yes it is. Reverting it you will not fix anything. Please explain step-by-step what not working. > > > "Download

D9479: [widgetexplorer] Fix trying to show deleted dialog

anthonyfieroni created this revision. anthonyfieroni added reviewers: fvogt, davidedmundson, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY WidgetExplorer is destroyed on close which deletes KNS dialog. TEST PLAN

D9479: [widgetexplorer] Fix trying to show deleted dialog

fvogt added a comment. IMO you can delete the empty destructor now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9479 To: anthonyfieroni, fvogt, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

fvogt abandoned this revision. fvogt added a comment. Superseded by https://phabricator.kde.org/D9479 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, al

D9479: [widgetexplorer] Fix trying to show deleted dialog

anthonyfieroni updated this revision to Diff 24297. anthonyfieroni added a comment. Remove entire destructor. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9479?vs=24296&id=24297 REVISION DETAIL https://phabricator.kde.org/D9479 AFFECTED FILES

D9479: [widgetexplorer] Fix trying to show deleted dialog

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9479 To: anthonyfieroni, fvogt, davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

davidedmundson added inline comments. INLINE COMMENTS > widgetexplorer.cpp:448 > d->newStuffDialog.data()->setWindowTitle(i18n("Download New Plasma > Widgets")); > +connect(d->newStuffDialog.data(), SIGNAL(accepted()), > SLOT(newStuffFinished())); > } what's the situation

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in widgetexplorer.cpp:448 > what's the situation with this line? Such a slot not existing at all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmund

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

davidedmundson added a comment. That's nice and easy then :) thanks for confirming. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9473 To: fvogt, #plasma, davidedmundson, anthonyfieroni Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D9473: Revert "[widgetexplorer] Make sure KNS download dialog is destroyed"

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in widgetexplorer.cpp:448 > Such a slot not existing at all. Even more WidgetExplorer is closed upon DownloadDialog is shown, which makes such slot useless. But now it can be opened more than one DownloadDialogs and i

D9479: [widgetexplorer] Fix trying to show deleted dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:acd7034952bc: [widgetexplorer] Fix trying to show deleted dialog (authored by anthonyfieroni). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9479?vs=24297

D9248: Port plasma-integration to explicit wayland AppMenu protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R135:0f3fd179c9e8: Port plasma-integration to explicit wayland AppMenu protocol (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https:/

D9338: [comic] Fix comic updater time interval

This revision was automatically updated to reflect the committed changes. Closed by commit R114:095196ca6438: [comic] Fix update interval (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9338?vs=24295&id=24303 REVISION DETAIL

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 14:39:24 + Build duration: 19 min and counting CONSOLE OUTPUT [...truncated 1.3

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 338 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/338/ Project: Plasma kwin kf5-qt5 SUSEQt5.9 Date of build: Fri, 22 Dec 2017 14:39:24 + Build duration: 39 min and counting CONSOLE OUTPUT [...truncated 1.41 MB.

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 22 Dec 2017 15:48:34 + Build duration: 28 min and counting JUnit Tests Name: (root) Failed

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 339 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/339/ Project: Plasma kwin kf5-qt5 SUSEQt5.9 Date of build: Fri, 22 Dec 2017 15:48:34 + Build duration: 30 min and counting JUnit Tests Name: (root) Failed: 2 t

D9483: "Repository description" -> "Repository URL:"

ngraham created this revision. ngraham added reviewers: apol, andreaska, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Rename "Repository description" to "Repository URL:", which is more accurate

D9483: "Repository description" -> "Repository URL:"

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH package-bulleted-list-387935 REVISION DETAIL https://phabricator.kde.org/D9483 To: ngraham, apol, andreaska, #discover_software_store Cc: plasma-devel, ZrenBot, pro

D9483: "Repository description" -> "Repository URL:"

This revision was automatically updated to reflect the committed changes. Closed by commit R134:34231fc68b47: "Repository description" -> "Repository URL:" (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9483?vs=24313&id=2

D9304: Get the padding into the header

apol added a comment. Ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9304 To: apol, #kirigami Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein