D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25138. safaalfulaij added a comment. - Align header labels to left REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25137&id=25138 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25137. safaalfulaij added a comment. - Just align it correctly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25073&id=25137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786 AFF

D9803: Apply some C++11 niceties, styling consistency

apol added inline comments. INLINE COMMENTS > plasmadesktoptheme.cpp:160 > QPalette pal = palette(); > static const QPalette::ColorGroup states[3] = { QPalette::Active, > QPalette::Inactive, QPalette::Disabled }; > +for (auto state : states) { if you make it `auto` the initializer

KDE and Google Summer of Code 2018

Hello GSoC mentors, and teams supporting mentors, TL;DR: Fill out https://community.kde.org/GSoC/2018/Ideas; read https://community.kde.org/GSoC. Now. Every year, we've asked for more time to get ramped up for GSoC, and so now is the time for organizations to apply[1]. We have begun to write our

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

ngraham accepted this revision as: VDG. ngraham added a comment. +1 from VDG, ship it! REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel,

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

dfaure accepted this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

broulik planned changes to this revision. broulik added a comment. I just saw I need to figure out the translation stuff but then it should be good. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: michaelh, ng

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

broulik added a comment. Nothing, I suppose. If noone objects I'll push this end of this week. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma

D7246: Tooltips

cfeck added inline comments. INLINE COMMENTS > decoration.h:179 > void requestShowWindowMenu(); > +void requestShowToolTip(QString text); > +void requestHideToolTip(); const QString &text > decorationbutton.cpp:292 > +{ > + > +switch (type) { empty line > decorationbutton_p.h

D7246: Tooltips

graesslin accepted this revision. graesslin added subscribers: jriddell, davidedmundson. graesslin added a comment. This revision is now accepted and ready to land. We are close to release and this might create hassles for distributions. Should we include it or wait for master being open again

D9803: Apply some C++11 niceties, styling consistency

Kanedias edited the summary of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25123. Kanedias added a comment. Apply some C++11 niceties, styling consistency REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25122&id=25123 BRANCH master REVISION DETAIL https

D9803: Apply some C++11 niceties, styling consistency

Kanedias added a reviewer: mart. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Kanedias requested review of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/

D9764: [WIP] a basic TabletModeManager

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH mart/tabletMode REVISION DETAIL https://phabricator.kde.org/D9764 To: mart, #plasma, #kwin, graesslin Cc: grae

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

ngraham added a comment. Is anything blocking this? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, al

D9799: [Panel View] Check if it's the same applet we're configuring before just hiding current view

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This fixes opening panel controller while an applet config dialog

D4140: Rework playing of volume feedback

drosca added a comment. In https://phabricator.kde.org/D4140#188956, @Zren wrote: > Is the `onVolumeChange` call delayed? I'm not sure if it's fired when we set it, or PulseAudio gets back to us. > > Does this fire `onVolumeChange` immediately? > > sinkModel.preferredSink.volume

D9689: Add a per-process CPU usage graph shown in the process list

fvogt updated this revision to Diff 25109. fvogt added a comment. Address review comments. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9689?vs=24935&id=25109 BRANCH history REVISION DETAIL https://phabricator.kde.org/D9689 AFFECTED FILES

D4140: Rework playing of volume feedback

Zren added a comment. Is the `onVolumeChange` call delayed? I'm not sure if it's fired when we set it, or PulseAudio gets back to us. Does this fire `onVolumeChange` immediately? sinkModel.preferredSink.volume = volume; If so, you're currently calling playFeedback(); //

D9797: [Task Manager] Let mouse back/forward keys switch tracks

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This allows to change tracks by clicking the respective task

D9763: [Slideshow] Don't repeatedly restart on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:140a1bc2b768: [Slideshow] Don't repeatedly restart on startup (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9763?vs=25018&id=25107#toc REPOSITORY R120 Plasma Workspac

D9352: [libcolorcorrect] Send auto location updates only when desirable

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a9bd6b4af8b8: [libcolorcorrect] Send auto location updates only when desirable (authored by romangg). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9352?v

D9689: Add a per-process CPU usage graph shown in the process list

broulik added a comment. +1 INLINE COMMENTS > ksysguardprocesslist.cpp:124 > +// Draw the history graph > +if(hasHistory) > +{ Coding style > processtest.cpp:221 > +void testProcess::testCPUGraphHistory() { > +KSysGuardProcessList *processList = new K

D9795: Sync the startplasmacompositor with startkde

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d3434a2d34fa: Sync the startplasmacompositor with startkde (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9795?vs=25097&id=25104 REVI

D9755: Move contents into fullRepresentation

This revision was automatically updated to reflect the committed changes. Closed by commit R115:be9b6f6afacf: Move contents into fullRepresentation (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9755?vs=24999&id=25103

D9795: Sync the startplasmacompositor with startkde

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH fix-startplasmacompositor REVISION DETAIL https://phabricator.kde.org/D9795 To: bshah, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesli

D6387: Also try application.name to get iconName

This revision was automatically updated to reflect the committed changes. Closed by commit R115:71da39003f48: Also try application.name to get iconName (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6387?vs=15866&id=25

D9726: Change device "master volume" to be the max of all channels instead of the avg

Zren added a comment. Yes I do. Sorry I didn't get to push it yesterday. Thanks for approving the change! Hmm, it seems the bot didn't recognize "Bug: 388553" in the commit message. Looks like I need to remember to use all caps next time "BUG: 388553". REPOSITORY R115 Plasma Audio Vol

D9788: [Theme Explorer] Quit with Ctrl+Q

This revision was automatically updated to reflect the committed changes. Closed by commit R118:99734367e858: [Theme Explorer] Quit with Ctrl+Q (authored by broulik). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9788?vs=25075&id=25100 REVISION DETAIL h

D9787: [Theme Explorer] Use theme name instead of ID in theme dropdown

This revision was automatically updated to reflect the committed changes. Closed by commit R118:f786132a2f64: [Theme Explorer] Use theme name instead of ID in theme dropdown (authored by broulik). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9787?vs=25072

D9764: [WIP] a basic TabletModeManager

davidedmundson added a comment. Restricted Application edited projects, added KWin; removed Plasma. > maybe one could still work around by connecting blindly to that by hand There's nothing inherently wrong with doing that. Assuming the DBus API is stable is as valid and as easy as assumi

D9764: [WIP] a basic TabletModeManager

mart marked 2 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9764 To: mart, #plasma, #kwin Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai

D9786: [Kickoff] Fix RTL issues

broulik added a comment. Perhaps you could manually set `contentX` to an appropriate value after adding a breadcrumb. I think the issue is that `Flickable` internally is still left-aligned, so I would suggest meddling around with `contentX` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9764: [WIP] a basic TabletModeManager

mart updated this revision to Diff 25099. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. adress comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9764?vs=25022&id=25099 BRANCH mart/tabletMode REVISION DETAIL

D9602: [Lock Screen] Show media controls only if enabled and announce support for that

broulik abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9602 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9601: Make media controls configurable

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D9684 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9601 To: broulik, #plasma, #vdg, graesslin, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progw

D9726: Change device "master volume" to be the max of all channels instead of the avg

This revision was automatically updated to reflect the committed changes. Closed by commit R115:27aa584f7ae9: Make device "master volume" the max of all channels instead of the avg (authored by Zren). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kd

D9795: Sync the startplasmacompositor with startkde

bshah updated this revision to Diff 25097. bshah added a comment. rebase on top of master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9795?vs=25096&id=25097 BRANCH fix-startplasmacompositor REVISION DETAIL https://phabricator.kde.org/D9795

D9764: [WIP] a basic TabletModeManager

mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9764#188872, @graesslin wrote: > In https://phabricator.kde.org/D9764#188862, @mart wrote: > > > In https://phabricator.kde.org/D9764#188354, @graesslin wrote: >

D9795: Sync the startplasmacompositor with startkde

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The config stuff (or correct versions thereof) are already in master. I think your local branch is out of sync. REPOSITORY R120 Plasma Workspace REVISION DE

D9795: Sync the startplasmacompositor with startkde

bshah created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY startplasma/startkde doesn't use qtpaths anymore. TEST PLAN starts wayland session REPOSITORY R120

D9699: Keep fullscreen windows in active layer based on transients not the group

This revision was automatically updated to reflect the committed changes. Closed by commit R108:b7ad4bcf881c: Keep fullscreen windows in active layer based on transients not the group (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KW

D9555: Simulate user activity on fake input events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:b002b2790321: Simulate user activity on fake input events (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. CHANGED PRIOR TO COMMIT https://phabricator.kde.

D9764: [WIP] a basic TabletModeManager

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9764#188862, @mart wrote: > In https://phabricator.kde.org/D9764#188354, @graesslin wrote: > > > In https://phabricator.kde.org/D9764#188268, @mart wrote: >

D9764: [WIP] a basic TabletModeManager

mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9764#188354, @graesslin wrote: > In https://phabricator.kde.org/D9764#188268, @mart wrote: > > > one thing i'm wondering, is how to manage dependencies, as ideally

Re:

Whilst other KDE applications do build and run on Windows, Plasma is not supported outside a Linux or BSD environment. Sorry David

[no subject]

Hello Everyone, I have been trying to build kde-plasma-desktop on windows 10 using visual studio 17, but there are a few errors in the cmake file. Can anybody help me out? Regards, Sonali Patro Contact: 00917381809123/0097455579707

D9792: even slimmer scrollbars

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. I like it. I think it falls in line with a less obtrusive bar and one that demands attention. REPOSITORY R31 Breeze BRANCH phab/slimScrollbars REVISION DETAIL https://phabricator.kd

D9792: even slimmer scrollbars

hpereiradacosta added a comment. Also, checking the patch online, it also indirecly changes color handling. In the previous implementation, focus color was used to render the 'non-mouse-over' scrollbar for the widget with focus. This is not the case anymore with this patch, because "disabled

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:5041 > This whole code feels hackish. > In principle we know (elsewhere in the code), if any part of the scrollbar is > hovered, since it is used to make the groove appear. > I checked that this is

D9506: milti-screen sleep fix

zerg added a comment. According debug info "if (info.isNull())" may be always false and "case true:" never break. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwol

D9575: Only send low peripheral battery notification when in discharging state

This revision was automatically updated to reflect the committed changes. Closed by commit R122:fad8ac422a07: Only send low peripheral battery notification when in discharging state (authored by drosca). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9575?v

D6388: Don't use plasma theme icons for stream/device icons

drosca added a comment. Ping? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6388 To: broulik, #plasma, drosca, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9755: Move contents into fullRepresentation

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9755 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D6387: Also try application.name to get iconName

drosca added a comment. Ping? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6387 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9755: Move contents into fullRepresentation

drosca added a comment. Actually I have a patch https://phabricator.kde.org/D4140 that depends on all models being initialized immediately. But yeah, given the fact that I haven't landed it yet and there are no bug reports about incorrect volume notifications I guess this can go in. REPOSI

D9726: Change device "master volume" to be the max of all channels instead of the avg

drosca added a comment. Do you have dev account? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9726 To: Zren, #plasma, drosca Cc: drosca, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9792: even slimmer scrollbars

hpereiradacosta added a comment. Hi, That looks nice. I don't think it needs a separate settings, since once again the hit area is the same as before. Then: would be nice to have VDG oppinion on that, and see if we can make the code less hackish (on the mouse-over detection side).

D9792: even slimmer scrollbars

mart added a comment. left sidebar: QML, main area: QWidgets F5633964: Spectacle.nS6609.png on mouse over F5633969: Spectacle.lx6609.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org

D9792: even slimmer scrollbars

mart edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hei

D9792: even slimmer scrollbars

mart added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein

D9792: even slimmer scrollbars

mart created this revision. mart added reviewers: Plasma, Kirigami, VDG. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY the scrollbar handle will be very slim normally, and

D9787: [Theme Explorer] Use theme name instead of ID in theme dropdown

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D9787 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D9788: [Theme Explorer] Quit with Ctrl+Q

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D9788 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D9506: milti-screen sleep fix

McPain added a comment. In https://phabricator.kde.org/D9506#188239, @anthonyfieroni wrote: > @McPain can you provide some debug info from qCDebug(KSCREEN_XRANDR), i don't have multi screen setup but we can make better fix. https://pastebin.com/5gkn1qJU Standby https://pastebin.

D7246: Tooltips

McPain updated this revision to Diff 25084. McPain added a comment. fix build CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25083&id=25084 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decoration.cpp src/de

D7246: Tooltips

McPain updated this revision to Diff 25083. McPain marked 11 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=23866&id=25083 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/decoration.cpp sr

D9776: Fix Plastik bottom and right border

This revision was automatically updated to reflect the committed changes. Closed by commit R108:04dbafd75edd: Fix Plastik bottom and right border (authored by davidedmundson). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE h

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. In https://phabricator.kde.org/D9786#188720, @broulik wrote: > I see. > > How about playing with `leftMargin` of the `Flickable` to right-align it? Something along the lines of > > leftMargin: Math.max(0, width - contentWidth) > Well, that

D9787: [Theme Explorer] Use theme name instead of ID in theme dropdown

broulik retitled this revision from "[Theme Explorer] Use theme name instead of ID" to "[Theme Explorer] Use theme name instead of ID in theme dropdown". REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D9787 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, l

D9788: [Theme Explorer] Quit with Ctrl+Q

broulik retitled this revision from "[Theme Editor] Quit with Ctrl+Q" to "[Theme Explorer] Quit with Ctrl+Q". REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D9788 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D9786: [Kickoff] Fix RTL issues

broulik added a comment. I see. How about playing with `leftMargin` of the `Flickable` to right-align it? Something along the lines of leftMargin: Math.max(0, width - contentWidth) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalful

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. I'll answer that here to put some visuals. This is before the patch, all fine, correct direction, but aligned to left: F5633510: step 1.png Here we mirror the graphics of the Flickable: F5633511: step 2.png

D9786: [Kickoff] Fix RTL issues

broulik added inline comments. INLINE COMMENTS > ApplicationsView.qml:127 > depth: 0 > +scale: LayoutMirroring.enabled ? -1 : 1 // Mirror the > already mirrored item back > } Where is it "already mirrored"? I think we're just hiding a di

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. After applying: F5633478: kickoff_after.mp4 Sorry couldn't crop video REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalfulaij, #plasma Cc: plasma-devel, ZrenBot, progw

D9788: [Theme Editor] Quit with Ctrl+Q

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Wires up default key for Quit to quit the application TEST PLAN

D9787: [Theme Explorer] Use theme name instead of ID

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Shows "Breeze" and "Breeze Dark" instead of "default" and "breeze-

D9786: [Kickoff] Fix RTL issues

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REVISION SUMMARY Fix 2 issues: - the breadcrumbs alignment -

D9751: [weather] Add configuration option which weather services providers to use

This revision was automatically updated to reflect the committed changes. Closed by commit R114:18f3b152ca31: [weather] Add configuration option which weather services providers to use (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9751?vs=25049&id=25070#toc REPOS

D9785: [ConfigModel] Set QML context on ConfigModule

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY This will have the ConfigModule use the same

D9784: [ConfigModule] Re-use QML context and engine if any

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the ConfigModule is created within a

D9555: Simulate user activity on fake input events

broulik accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH fake-input-simulate-user-activity REVISION DETAIL https://phabricator.kde.org/D9555 To: graesslin, #kwin, #plasm

D9751: [weather] Add configuration option which weather services providers to use

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH allowconfigureweatherproviderqueried REVISION DETAIL https://phabricator.kde.org/D9751 To: kossebau, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, progwolff, leslie

D9782: [DBusMenuImporter] Just send "opened" in updateMenu()

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We call `updateMenu()` to cache the first level of

D9738: Support font/ttf and font/otf mimetypes in kfontinst

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c9e036e24873: Support font/ttf and font/otf mimetypes in kfontinst (authored by fvogt). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9738?vs=24955&id=25062

D9738: Support font/ttf and font/otf mimetypes in kfontinst

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9738 To: fvogt, #plasma, broulik Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D9642: [User Switcher] Workaround Connections {} not working on "plasmoid"

broulik abandoned this revision. broulik added a comment. Already committed as https://phabricator.kde.org/D9353 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9642 To: broulik, #plasma, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwo

D9780: [Kicker] Enable smooth for IconItem

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f4c3b1155a8c: [Kicker] Enable smooth for IconItem (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9780?vs=25055&id=25059 REVISION DETA

D9779: [Kicker] Allow setting custom icon by dropping it on the icon button

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4ee8304c5f93: [Kicker] Allow setting custom icon by dropping it on the icon button (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9779

D9765: Increase timeout for notification disconnected/connected notification

This revision was automatically updated to reflect the committed changes. Closed by commit R116:cfe45d03e07f: Increase timeout for notification disconnected/connected notification (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabri

D9779: [Kicker] Allow setting custom icon by dropping it on the icon button

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9779 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9780: [Kicker] Enable smooth for IconItem

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9780 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9780: [Kicker] Enable smooth for IconItem

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This should make things a little smoother. REPOSITORY R119

D9779: [Kicker] Allow setting custom icon by dropping it on the icon button

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This makes testing custom images a lot easier. TEST PLAN -