D9804: Add BusyIndicator to the styled controls list

Kanedias added a comment. In https://phabricator.kde.org/D9804#189751, @alexeymin wrote: > Can tier 1 framework depend on other tier 1 framework? Not sure, but qqc2-desktop-style used Kirigami units before this change so we depended on it already. REPOSITORY R858 Qt Quick Contr

D9804: Add BusyIndicator to the styled controls list

alexeymin added a comment. https://api.kde.org/frameworks/index.html says: > Tier 1 frameworks depend only on Qt (and possibly a small number of other third-party libraries), so can easily be used by any Qt-based project. Can tier 1 framework depend on other tier 1 framework? REPOSI

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

kossebau added a comment. @broulik Seems to miss some include with Qt 5.7? build fails now on CI in the patched code: https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/15/ REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9312 To: brouli

D9803: Apply some C++11 niceties, styling consistency

Kanedias added a comment. Will update this today with changes from caching by Alex REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9803: Apply some C++11 niceties, styling consistency

Kanedias marked 3 inline comments as done. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9825: [Task Manager] Show badge count also in tooltip

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9825 To: broulik, #plasma, #vdg, romangg, hein Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, ab

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25198. Kanedias added a comment. Fix palette array allocation REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25123&id=25198 BRANCH c++11 REVISION DETAIL https://phabricator.kde.

D9827: [Task Manager] Limit badge number to 99

hein added a comment. Why can it only be circular? It's Rectangle ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9827 To: broulik, #plasma, #vdg, hein Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9817: Adapt to QQuickWindow hover event synthesis & optimize delegate

hein added a reviewer: broulik. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9817 To: hein, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9835: Bump min cmake version to 3.0

kossebau added a subscriber: hein. kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:99 > > -ecm_configure_package_config_file(LibTaskManagerConfig.cmake.in > +configure_package_config_file(LibTaskManagerConfig.cmake.in > "${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfig.cma

D9835: Bump min cmake version to 3.0

kossebau edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9835 To: kossebau, #plasma, jriddell Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9835: Bump min cmake version to 3.0

kossebau added a comment. Similar fixes could be done to the other Plasma repos. Would care myself for kdeplasma-addons, as I have a build setup for that as well, so can test. INLINE COMMENTS > CMakeLists.txt:12 > find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets Quick

D9835: Bump min cmake version to 3.0

kossebau created this revision. kossebau added reviewers: Plasma, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Allows to drop ECMPackageConfigHelpers for CMakePackag

KDE CI: Plasma kdeplasma-addons stable-kf5-qt5 SUSEQt5.9 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kdeplasma-addons%20stable-kf5-qt5%20SUSEQt5.9/13/ Project: Plasma kdeplasma-addons stable-kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Jan 2018 05:32:46 + Build duration: 6 min 52 sec and counting

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 32 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/32/ Project: Plasma discover stable-kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Jan 2018 05:32:40 + Build duration: 2 min 36 sec and counting CONSOLE OUTPUT

KDE CI: Plasma oxygen kf5-qt5 SUSEQt5.9 - Build # 53 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20oxygen%20kf5-qt5%20SUSEQt5.9/53/ Project: Plasma oxygen kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Jan 2018 03:59:02 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncated 30.59

KDE CI: Plasma plasma-nm kf5-qt5 SUSEQt5.9 - Build # 85 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-nm%20kf5-qt5%20SUSEQt5.9/85/ Project: Plasma plasma-nm kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Jan 2018 03:59:10 + Build duration: 11 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 83 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/83/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 12 Jan 2018 02:17:01 + Build duration: 4 min 47 sec and counting JUnit Tests Name:

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 259 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/259/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Jan 2018 02:14:34 + Build duration: 4 min 36 sec and counting JUnit Tests Name: (root

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 82 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/82/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 12 Jan 2018 02:14:34 + Build duration: 2 min 8 sec and counting CONSOLE OUTPUT [...

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 81 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/81/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 12 Jan 2018 01:33:16 + Build duration: 3 min 20 sec and counting CONSOLE OUTPUT [..

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 258 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/258/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Jan 2018 01:33:16 + Build duration: 1 min 29 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 80 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/80/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 12 Jan 2018 01:25:58 + Build duration: 3 min 25 sec and counting CONSOLE OUTPUT [..

KDE CI: Plasma discover kf5-qt5 SUSEQt5.9 - Build # 257 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20SUSEQt5.9/257/ Project: Plasma discover kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Jan 2018 01:25:59 + Build duration: 1 min 58 sec and counting CONSOLE OUTPUT [...trun

D9803: Apply some C++11 niceties, styling consistency

apol added inline comments. INLINE COMMENTS > Kanedias wrote in plasmadesktoptheme.cpp:160 > I didn't quite get it, you mean we can write `for (auto state : { > QPalette::Active, QPalette::Inactive, QPalette::Disabled })` to get rid of > allocation of `states` array? Yes, or `static const auto

D9833: Increase number of Apps you can see at once in list views

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9833 To: ngraham, apol, #discover_software_store Cc: colomar, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9833: Increase number of Apps you can see at once in list views

apol accepted this revision. apol added a subscriber: colomar. apol added a comment. This revision is now accepted and ready to land. Thanks, agreed by @colomar too. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D9833 To: ngraham, ap

D9833: Increase number of Apps you can see at once in list views

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9833 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9833: Increase number of Apps you can see at once in list views

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9833 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9833: Increase number of Apps you can see at once in list views

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch increases the number of apps that

Re: [plasma-devel] 5.12 announce

Hi Jonathan. Awesome! Thank you. On Jonathan Riddell - 11.01.18, 19:17: > Moved to https://www.kde.org/announcements/plasma-5.11.95.php is > Smoother and Speedier > > We have been concentrating on speed and memory improvements with this long > term support release. When Plasma is running is n

Re: 5.12 announce

Could someone take a screenshot which does work of KScreen under Wayland? Jonathan On 11 January 2018 at 19:05, Martin Flöser wrote: > Am 2018-01-11 19:02, schrieb Jonathan Riddell: >> >> I've made https://www.kde.org/announcements/plasma-5.12.0.php >> >> I don't suppose anyone has done figures

D9804: Add BusyIndicator to the styled controls list

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d3ae9304298f: Add BusyIndicator to the styled controls list (authored by Kanedias). Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY

Re: 5.12 announce

Am 2018-01-11 19:02, schrieb Jonathan Riddell: I've made https://www.kde.org/announcements/plasma-5.12.0.php I don't suppose anyone has done figures or nice bar graphs for the speedups? 'Output resolution can be set through KScreen' I used this for the screenshot for Wayland section but it do

D9803: Apply some C++11 niceties, styling consistency

Kanedias added inline comments. INLINE COMMENTS > apol wrote in plasmadesktoptheme.cpp:160 > if you make it `auto` the initializer_list will be used not requiring the > allocation AFAIU. > That said, I wonder if the compiler can unwind a foreach. I didn't quite get it, you mean we can write `fo

Re: [plasma-devel] 5.12 announce

Do we not have a new wallpaper yet. Ken?

Re: [plasma-devel] 5.12 announce

Moved to https://www.kde.org/announcements/plasma-5.11.95.php On Thu, Jan 11, 2018 at 06:02:52PM +, Jonathan Riddell wrote: > I've made https://www.kde.org/announcements/plasma-5.12.0.php > > I don't suppose anyone has done figures or nice bar graphs for the speedups? > > 'Output resolution

5.12 announce

I've made https://www.kde.org/announcements/plasma-5.12.0.php I don't suppose anyone has done figures or nice bar graphs for the speedups? 'Output resolution can be set through KScreen' I used this for the screenshot for Wayland section but it doesn't let me set resolution or rotation. What's a

D9072: make ksshaskpass work with git-lfs

mkoller added a comment. In https://phabricator.kde.org/D9072#189303, @fvogt wrote: > Looks good to me, but I wonder whether > > > KWallet writes an error to stderr when a 0-winId is given to openWallet() which is received by git-lfs and aborts the operation. > > should be fixed m

D9827: [Task Manager] Limit badge number to 99

broulik added a comment. Good idea. However, QtQuick `Rectangle` can only be circular :D but I'll have a look. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9827 To: broulik, #plasma, #vdg, hein Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali

D9825: [Task Manager] Show badge count also in tooltip

ngraham added a comment. Nice, I love it! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9825 To: broulik, #plasma, #vdg, romangg, hein Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9827: [Task Manager] Limit badge number to 99

ngraham added a comment. Why not expand the badge to become pill-shaped so we can accommodate absurdly numbers? That's what macOS does. You might be surprised by now many people have 1000+ unread emails... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9827

D9827: [Task Manager] Limit badge number to 99

broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's no point in showing a gazillion and it won't fit

D9825: [Task Manager] Show badge count also in tooltip

broulik requested review of this revision. broulik added a comment. tooltip glitch not caused by this patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9825 To: broulik, #plasma, #vdg, romangg, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moh

D9825: [Task Manager] Show badge count also in tooltip

broulik planned changes to this revision. broulik added a comment. Initial size for launcher tooltip is borked, yay QtQuick Layouts REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9825 To: broulik, #plasma, #vdg, romangg, hein Cc: plasma-devel, ZrenBot, progwo

D9825: [Task Manager] Show badge count also in tooltip

broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9825 To: broulik, #plasma, #vdg, romangg, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9825: [Task Manager] Show badge count also in tooltip

broulik created this revision. broulik added reviewers: Plasma, VDG, romangg, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When you panel is too badge icon cannot be show

[Powerdevil] [Bug 377130] Power Saving Settings screen cut off when using resolution scaling. Does not scroll, either.

https://bugs.kde.org/show_bug.cgi?id=377130 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:5046 > +if (StyleConfigData::animationsEnabled()) { > +color.setAlphaF(color.alphaF() * (0.7 + grooveAnimationOpacity)); > +} This generates some warnings here, because 0.7 + grooveAnimationOpaci

D9816: Ensure DesktopIcon paints with the correct aspect ratio

apol added a comment. +1 tested, seems to work for me, bug seems fixed. Remember to add the `BUG: 388737` tag in the commit message! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9816 To: leinir, #kirigami, #discover_software_store Cc: apol, plasma-devel, dav

D9818: [Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3b4be6568579: [Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

D9818: [Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9818 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D9818: [Wallpaper Image Configuration] Set cfg_Image whenever delegate becomes current

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The delete button changes the currentIndex to something else when

D9817: Adapt to QQuickWindow hover event synthesis & optimize delegate

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY As of Qt 5.9, QQuickWindow synthesizes a hover event once per frame. This interferes with keyboard navigation when having the mous

D9735: [Notifications] Don't restart hide timer on reposition while dragging

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ade1817522f6: [Notifications] Don't restart hide timer on reposition while dragging (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9

D9754: [Notifications] Use custom DragHelper instead of Qt's Drag attached property

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:86fe98693474: [Notifications] Use custom DragHelper instead of Qt's Drag attached property (authored by broulik). CHAN

D9754: [Notifications] Use custom DragHelper instead of Qt's Drag attached property

davidedmundson added a comment. You know my rule by now. If we're working round a Qt bug, we should have a Qt bug report. INLINE COMMENTS > draghelper.cpp:50 > +// This allows the caller to return, making sure we don't crash if > +// the caller is destroyed mid-drag (as can happen du

D9816: Ensure DesktopIcon paints with the correct aspect ratio

leinir added a comment. Shows the updated output: F5637928: image.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9816 To: leinir, #kirigami, #discover_software_store Cc: plasma-devel, apol, davidedmundson, mart, hein

D9816: Ensure DesktopIcon paints with the correct aspect ratio

leinir created this revision. leinir added reviewers: Kirigami, Discover Software Store. leinir added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY The simple QML based Icon already provides this correctly

D9764: A basic TabletModeManager

This revision was automatically updated to reflect the committed changes. Closed by commit R108:1be5256b1b43: A basic TabletModeManager (authored by mart). Restricted Application edited projects, added KWin; removed Plasma. CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9764?vs=25099&id=2

D9764: A basic TabletModeManager

mart retitled this revision from "[WIP] a basic TabletModeManager" to "A basic TabletModeManager". Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH mart/tabletMode REVISION DETAIL https://phabricator.kde.org/D9764 To: mart, #plasma, #kwin, g

D9792: even slimmer scrollbars

mart added a comment. so, a slightly different approach now, maybe it's a tad cleaner: don't try to draw the handle twice and cross fade it, but draw it smaller and then animate the handle size (and opacity) on mouse over REPOSITORY R31 Breeze BRANCH phab/slimScrollbars REVISION DETAIL

D9792: even slimmer scrollbars

mart updated this revision to Diff 25152. mart added a comment. - const opacity REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25151&id=25152 BRANCH phab/slimScrollbars REVISION DETAIL https://phabricator.kde.org/D9792 AFFECTED FILES kstyle/b

D9792: even slimmer scrollbars

mart updated this revision to Diff 25151. mart added a comment. - use the same slider, animate its size REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9792?vs=25089&id=25151 BRANCH phab/slimScrollbars REVISION DETAIL https://phabricator.kde.org/D9792 A

D9072: make ksshaskpass work with git-lfs

fvogt added a comment. Looks good to me, but I wonder whether > KWallet writes an error to stderr when a 0-winId is given to openWallet() which is received by git-lfs and aborts the operation. should be fixed more in a more general way as well. REPOSITORY R105 KDE SSH Password Dia

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:5c9eab26ad7b: [ConfigPropertyMap] Don't emit valueChanged on initial creation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9312?vs=238

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9312 To: broulik, #plasma, hein Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9812: [Icon Item] Treat sources starting with a slash as local file

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9812 To: broulik, #plasma, hein, mwolff Cc: mwolff, plasma-devel, #frameworks, ZrenBot, pro

D9792: even slimmer scrollbars

hpereiradacosta added inline comments. INLINE COMMENTS > mart wrote in breezestyle.cpp:5041 > i like the second option, calling by hand drawScrollBarSliderControl, tough > it would still need to call the superclass drawScrollBarComplexControl? which > then would have to know about not drawing t

D7246: Tooltips

McPain updated this revision to Diff 25145. McPain marked 4 inline comments as done. McPain added a comment. const QString & cleanup CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25084&id=25145 REVISION DETAIL https://phabricator.kde.org/D7246 AFFECTED FILES CMakeLis

D9764: [WIP] a basic TabletModeManager

mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9764#188910, @davidedmundson wrote: > > maybe one could still work around by connecting blindly to that by hand > > There's nothing inherently wrong with doing that

D9792: even slimmer scrollbars

mart added inline comments. INLINE COMMENTS > mart wrote in breezestyle.cpp:5041 > you mean making drawScrollBarSliderControl a complete noop? i like the second option, calling by hand drawScrollBarSliderControl, tough it would still need to call the superclass drawScrollBarComplexControl? whic

D9812: [Icon Item] Treat sources starting with a slash as local file

broulik updated this revision to Diff 25144. broulik added a comment. - Incorporate suggestions by milian REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9812?vs=25141&id=25144 REVISION DETAIL https://phabricator.kde.org/D9812 AFFECTED

D9792: even slimmer scrollbars

mart added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:5041 > This whole code feels hackish. > In principle we know (elsewhere in the code), if any part of the scrollbar is > hovered, since it is used to make the groove appear. > I checked that this is done in a

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

broulik added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9312 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9812: [Icon Item] Treat sources starting with a slash as local file

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. lgtm in general, but can be cleaned up INLINE COMMENTS > iconitem.cpp:154 > +// If a file:// URL or a absolute path is passed, take the image > pointed by that from disk

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R824:832aa1b7d96f: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata (authored by broulik). REPOSITORY R

D9813: [Kicker] Also round to icon size custom square images

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a custom //square// image is set, we can assume it's mea

D9812: [Icon Item] Treat sources starting with a slash as local file

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY We have a special case for sources star