D10762: Fix the build on armhf/aarch64

bshah planned changes to this revision. bshah added a comment. Restricted Application edited projects, added KWin; removed Plasma. Appearantly this doesn't fix all the issues. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10762 To: bshah, #plasma, graesslin Cc: plasma

D10762: Fix the build on armhf/aarch64

bshah created this revision. bshah added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. bshah requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REVI

D10294: Init the icon in ShellClient::init

bshah accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH init-icon-5.12 REVISION DETAIL https://phabricator.kde.org/D10294 To: graesslin, #kwin, #plasma, bshah Cc: plasma-

D10755: Add a MsmApp::skillsPath method so the skills folder is not hardcoded

Aiix accepted this revision. This revision is now accepted and ready to land. REPOSITORY R846 Mycroft Plasma integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D10755 To: antlarr, Aiix Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D10756: Reduce sidebar width

cfeck added a comment. Woot! :) In the long term, the drawers probably could use a qtquick splitview to allow the user to adjust the sizes. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc: cfe

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 27825. apol added a comment. Center the title and leave actions to the left and ctx actions to the right REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=27623&id=27825 BRANCH arcpatch-D10475 REVISION DETAIL

D10475: Make it possible to show the title despite having ctx actions

apol added a comment. In D10475#211781 , @abetts wrote: > I am in favor of placing the Titles left aligned, but only if we don't put more than 1 control to the left of the title. If we can't compromise on that, another option is to keep titles c

D10756: Reduce sidebar width

This revision was automatically updated to reflect the committed changes. Closed by commit R134:bfa25177805f: Reduce sidebar width (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10756?vs=27822&id=27824 REVISION DETAIL h

D10756: Reduce sidebar width

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH work-around-huge-sidebar-issue (branched from Plasma/5.12) REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc: acrout

D10756: Reduce sidebar width

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

acrouthamel added a comment. I like it! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10756: Reduce sidebar width

ngraham updated this revision to Diff 27822. ngraham added a comment. Use the right branch REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10756?vs=27821&id=27822 BRANCH work-around-huge-sidebar-issue (branched from Plasma/5.12) REVISION

D10756: Reduce sidebar width

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10756 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D10756: Reduce sidebar width

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 385992 This is a hack to work arou

D10755: Add a MsmApp::skillsPath method so the skills folder is not hardcoded

antlarr created this revision. antlarr added a reviewer: Aiix. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. antlarr requested review of this revision. REVISION SUMMARY The skills folder was hardcoded to /opt/mycroft/skills in MsmView.qm

D10490: Add a method to dbus interface to query information about a window

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH rules-detect-dbus REVISION DETAIL https://phabricator.kde.org/D10490 To: graesslin, #kwin, #plasma, david

D10549: Don't crash if the cursor theme fails to create

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH dont-crash-cursor-theme-failure REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin,

D10723: hide primary display combo when not supported

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH sebas/pcombo REVISION DETAIL https://phabricator.kde.org/D10723 To: sebas, #plasma, dvratil, davidedmundson Cc: kpiwowarski, plasma-devel, ZrenBot, lesliezhai, ali-mohame

D10752: Fix focus being removed from the text input widget

This revision was automatically updated to reflect the committed changes. Closed by commit R846:307fa73adecf: Fix focus being removed from the text input widget (authored by Antonio Larrosa ). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE htt

D10753: Provide the source selection as a contextual action

ngraham added a comment. OK, the i18n error is gone now. But do we really need that "also available in " text at the end of the Description, anyway? Apparently nobody reads it. Maybe we should focus on polishing the main source chooser UI and get rid of that little vestigial one. REPOSI

D10753: Provide the source selection as a contextual action

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I see what you're going for here, but the "Sources" menu you're trying to add still doesn't actually work, same as the Sort menu. Is there an open Kirigami patch that this depen

D10753: Provide the source selection as a contextual action

apol updated this revision to Diff 27816. apol added a comment. Polish REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10753?vs=27814&id=27816 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10753 AFFECTED FILES discover/q

D10752: Fix focus being removed from the text input widget

Aiix accepted this revision. This revision is now accepted and ready to land. REPOSITORY R846 Mycroft Plasma integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D10752 To: antlarr, Aiix Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D10752: Fix focus being removed from the text input widget

antlarr created this revision. antlarr added a reviewer: Aiix. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. antlarr requested review of this revision. REVISION SUMMARY Each time a message is received, the focus was stolen from the tex

D10753: Provide the source selection as a contextual action

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of the dreaded link button. BUG: 390464 REPOSITORY R134 Discover Software Store BRANCH

D10750: wayland: Add support for zwp_linux_dmabuf

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Concerning the tests: the ones requiring OpenGL work best if module vgem is loaded. That normally makes them pass. The tests regarding keyboard layout need env variable XDG_DEFAULT_LAYOUT being unse

D10475: Make it possible to show the title despite having ctx actions

abetts added a comment. I am in favor of placing the Titles right aligned, but only if we don't put more than 1 control to the right of the title. If we can't compromise on that, another option is to keep titles center-aligned. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricato

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. The title is still the primary focus for this header UI, which means (for RTL languages at least), it needs to be left or center aligned. This means the actions have to be on the right, to make sure your eyes don't see them before the title. @abetts, what do you

Re: KDE Neon Developer Unstable - plasmashell crashing on start

Thanks for the fast replys. Will wait for the new packages ;-) One further question. What is the real difference between developer stable / unstable? My understanding was, that (for example) a change to qt5.10 will first be done in unstable and when everything is in place it will be rolled out to

D10722: other preload microoptimizations

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:79fb4ebfa77f: other preload microoptimizations (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANG

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik created this revision. fredrik added reviewers: KWin, Plasma, davidedmundson, mart, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. fredrik requested review of this revision. Restricted Application edited projects, added

Re: KDE Neon Developer Unstable - plasmashell crashing on start

Yeah, there is ongoing migration to qt5.10 So it is known that it is broken... I hope to get this fixed sooner, only few rebuilds remianing On Thu, Feb 22, 2018 at 10:38 PM, Jörn M wrote: > Hello, > > today I noticed that KDE Neon developer unstable updates to Qt 5.10. > The currently rolled out

Re: KDE Neon Developer Unstable - plasmashell crashing on start

Short correction, I'm using: KDE neon developer stable Am 22.02.2018 18:08 schrieb "Jörn M" : > Hello, > > today I noticed that KDE Neon developer unstable updates to Qt 5.10. > The currently rolled out packages leave my system in an unusable state: > > - plasmashell crashes: > > ~> plasmashell

Re: KDE Neon Developer Unstable - plasmashell crashing on start

Bhushan is current landing Qt 5.10 which is why the dev editions are currently in flux. On Thu, Feb 22, 2018 at 6:08 PM, Jörn M wrote: > Hello, > > today I noticed that KDE Neon developer unstable updates to Qt 5.10. > The currently rolled out packages leave my system in an unusable state: > > -

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > broulik wrote in main.qml:121 > Shouldn't this be a binding? not really, as is just an inizialization to have the size it will have when properly reparented when the popup is open, it's put in the StackView, so is them propely anchored and all pu

Re: KDE Neon Developer Unstable - plasmashell crashing on start

Can confirm; I'm seeing the same thing. Nate On 02/22/2018 10:08 AM, Jörn M wrote: Hello, today I noticed that KDE Neon developer unstable updates to Qt 5.10. The currently rolled out packages leave my system in an unusable state: - plasmashell crashes: ~> plasmashell org.kde.plasmaquick: A

D10692: parent full representation to the proper window at start

broulik added inline comments. INLINE COMMENTS > main.qml:121 > +if (applet.fullRepresentationItem) { > +applet.fullRepresentationItem.width = > expandedRepresentation.width > +applet.fullRepresentationItem.width = > expandedRepresentation.height Shouldn't this

D10722: other preload microoptimizations

broulik accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10722 To: mart, #plasma, davidedmundson, broulik Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

KDE Neon Developer Unstable - plasmashell crashing on start

Hello, today I noticed that KDE Neon developer unstable updates to Qt 5.10. The currently rolled out packages leave my system in an unusable state: - plasmashell crashes: ~> plasmashell org.kde.plasmaquick: Applet preload policy set to 1 plasmashell: relocation error: /usr/lib/x86_64-linux-gnu/l

D10722: other preload microoptimizations

mart updated this revision to Diff 27798. mart added a comment. - err forgot typeof REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27797&id=27798 BRANCH arcpatch-D10722 REVISION DETAIL https://phabricator.kde.org/D10722 AF

D10722: other preload microoptimizations

mart updated this revision to Diff 27797. mart added a comment. - fix typo REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27796&id=27797 BRANCH arcpatch-D10722 REVISION DETAIL https://phabricator.kde.org/D10722 AFFECTED FI

D10722: other preload microoptimizations

mart updated this revision to Diff 27796. mart added a comment. - check for function REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27795&id=27796 BRANCH arcpatch-D10722 REVISION DETAIL https://phabricator.kde.org/D10722 A

D10722: other preload microoptimizations

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in svgitem.cpp:50 > > when the component is complete, in many cases i guessthe properties would > > all be already set? > > We know for definitely they will be already set. > > I don't understand what problem you think this is

D10722: other preload microoptimizations

mart updated this revision to Diff 27795. mart added a comment. - Revert most of it - only leave the forcelayout part REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10722?vs=27707&id=27795 BRANCH arcpatch-D10722 REVISION DETAIL ht

D10722: other preload microoptimizations

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mart wrote in svgitem.cpp:50 > when the component is complete, in many cases i guessthe properties would all > be already set? (could add a ch

D10748: drop the setting of c++0x

This revision was automatically updated to reflect the committed changes. Closed by commit R242:11086bb7913f: drop the setting of c++0x (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10748?vs=27790&id=27793 REVISION DETA

D10748: drop the setting of c++0x

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Builds here as before as well. Reducing duplicated flags in the compile commands for me from `-std=c++0x -std=c++0x -std=c++0x -std=gnu++11` to `-std=c++0x -std=c++0x -std=gnu

D10747: Implement zwp_linux_dmabuf_v1

fredrik added inline comments. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. INLINE COMMENTS > linuxdmabuf_v1_interface.h:39 > + > +namespace LinuxDmabuf > +{ Do we want these nested namespaces? We could have LinuxDmabufFlags, LinuxDmabufBuffer etc. instead.

D10747: Implement zwp_linux_dmabuf_v1

mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. +1 on my machine opengl apps seems to work well on wayland (after the first revision in which they were flipped upside down, now they are ok) would need a final ship it by someone more fami

D10748: drop the setting of c++0x

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY this is already done by KDEFrameworkCompilerSettings

D10747: Implement zwp_linux_dmabuf_v1

fredrik created this revision. fredrik added reviewers: KWin, Plasma, graesslin, davidedmundson, mart. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. Restricted Appl

D10722: other preload microoptimizations

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in svgitem.cpp:50 > I don't see how this makes any difference. > > Every setSomeProperty already calls scheduleImageUpdate regardless of whether > we're complete or not. > and if you don't have any properties set, then there's n

D10481: Add FormLayout.qml to kirigami.qrc

mart added a comment. ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10481 To: icota, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10499: [spellcheck runner] Make each suggestion copyable as separate item

This revision was automatically updated to reflect the committed changes. Closed by commit R114:66eb115a9300: [spellcheck runner] Make each suggestion copyable as separate item (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10499?vs=27127&id=27772#toc REPOSITORY

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27767. mart added a comment. remove leftovers REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27715&id=27767 BRANCH arcpatch-D10692 REVISION DETAIL https://phabricator.kde.org/D10692 AFFECTED FILES

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > apol wrote in systemtray.h:30 > Why? eww, leftover REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

Re: What does LTS mean again?

​> - Bugfixes releases All bug fixes, including low priority ones on a steady cycle for a year Security and major bug fixes released on-demand for at least a year Things might be extended, but not shortened. Frameworks isn't something we've communicated with the frameworks ML. Though I

D10736: Do clamping in the model and add missing lower bound check

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10736 To: hein, #plasma, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D10736: Do clamping in the model and add missing lower bound check

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Clamping the window delegate size to stay within the desktop rect was previously done in the QML code, but only for the higher b