D11253: Improve discoverability for changing the wallpaper

richardbowen added a comment. The preferences-desktop-wallpaper icon beside "Configure Desktop" works. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma, davidedmundson Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen,

D11253: Improve discoverability for changing the wallpaper

ngraham added a comment. Is everyone still ambivalent about this? Is there anything I can do to make it more palatable, or should I give up? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma, davidedmundson Cc: mart, hein, broulik,

D11722: If GL context creation fails fall back to the software renderer

graesslin added a comment. I like this change INLINE COMMENTS > desktopview.cpp:63 > [this, corona]() { > +qDebug() << QQuickWindow::sceneGraphBackend(); > // check whether the GL Context supports OpenGL This looks like too much debug or like a

D11663: Add InlineMessage type and Gallery app example page

davidedmundson added a comment. Very nice! INLINE COMMENTS > InlineMessage.qml:225-226 > +wrapMode: Text.WordWrap > +elide: Text.ElideRight > +verticalAlignment: lineCount > 1 ? Qt.AlignVCenter : > Qt.AlignTop > + I don't think either of

D11663: Add InlineMessage type and Gallery app example page

hein added subscribers: broulik, ngraham. hein added a comment. Adding back subscribers, sorry, my arc invocation to do the above removed you. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: ngraham, broulik, plasma-devel, apol,

D11726: Vastly simplify image wallpaper code

davidedmundson updated this revision to Diff 30649. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11726?vs=30648=30649 BRANCH davidedmundson/wallpaperrewrite REVISION DETAIL

D11726: Vastly simplify image wallpaper code

davidedmundson updated this revision to Diff 30648. davidedmundson added a comment. use a better variable name before anyone sees it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11726?vs=30647=30648 BRANCH davidedmundson/wallpaperrewrite

D11726: Vastly simplify image wallpaper code

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The image wallpaper is a mess of 4 different

D11722: If GL context creation fails fall back to the software renderer

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY If we cannot create a GL context, instead of

KDE CI: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-pa%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 17:16:41 + Build duration: 9 min 21 sec and counting CONSOLE OUTPUT

D11721: Fix issues in models to pass ModelTest

This revision was automatically updated to reflect the committed changes. Closed by commit R115:d498ec301bb3: Fix issues in models to pass ModelTest (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11721?vs=30639=30640

D11721: Fix issues in models to pass ModelTest

drosca updated this revision to Diff 30639. drosca added a comment. fix issues REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11721?vs=30638=30639 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11721 AFFECTED FILES

D11721: Fix issues in models to pass ModelTest

drosca added inline comments. INLINE COMMENTS > broulik wrote in maps.h:116 > This creates a temporary list just to iterate it, better use iterators and > then `key()` provided by it (I bet there's even a fancy `std` algorithm for > what you're trying to do here) Some fancy `std` algorithm

D11721: Fix issues in models to pass ModelTest

davidedmundson added a comment. Other than Kai's coments, ++ good stuff. thanks REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D11721 To: drosca, #plasma Cc: davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed,

D11721: Fix issues in models to pass ModelTest

broulik added inline comments. INLINE COMMENTS > maps.h:116 > +int modelIndex = 0; > +const auto keys = m_data.keys(); > +for (quint32 key : keys) { This creates a temporary list just to iterate it, better use iterators and then `key()` provided by it (I bet there's

D11721: Fix issues in models to pass ModelTest

drosca updated this revision to Diff 30638. drosca added a comment. whitespace REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11721?vs=30637=30638 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11721 AFFECTED FILES

D11721: Fix issues in models to pass ModelTest

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. TEST PLAN Did all sort of things with pulseaudio and all ModelTest tests passed.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. In D9848#234654 , @anemeth wrote: > > `GLRenderTarget::setTextureDirty` > > I added this because on line (1101 <---> 1124) the `disable()` function that also sets the texture dirty was moved into a condition. > I

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. In D9848#234268 , @zzag wrote: > > `GLRenderTarget::attachTexture` This was not changed. It was used by old blur and simple blur. Looks like it's not used anymore. >

KDE CI: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-pa%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 14:15:10 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT

D11613: call beginRemoveRows before removing the data

This revision was automatically updated to reflect the committed changes. Closed by commit R115:722ee38399a1: call beginRemoveRows before removing the data (authored by davidedmundson). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D11606: [WebBrowser Plasmoid] Support opening external links

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:0319b3e9c96f: [WebBrowser Plasmoid] Support opening external links (authored by broulik). REPOSITORY R114 Plasma

D11613: call beginRemoveRows before removing the data

drosca added a comment. Into Plasma/5.12 please. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D11613 To: davidedmundson, #plasma, drosca Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

davidedmundson added inline comments. INLINE COMMENTS > libinput_settings.cpp:26 > +{ > +KConfig config("kcminputrc"); > +KConfigGroup group = config.group("Mouse"); KConfig("foo") will load foo and parse it every time. > libinput_settings.h:27 > +template > +T load(QString

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

romangg added a comment. In D11469#234225 , @ngraham wrote: > @romangg so is this more of a request just for code review review, then? Yes. You can also just compile and test it to see if there are no regressions. And in case not accept

D11559: Fix default colour used by Swap monitor

This revision was automatically updated to reflect the committed changes. Closed by commit R114:dad98acf635d: Fix default colour used by Swap monitor (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11559?vs=30149=30621#toc REPOSITORY R114 Plasma Addons

D11712: kcm_energyinfo: Allow changing of the timespan if no data available

This revision was automatically updated to reflect the committed changes. Closed by commit R102:fadf1008e452: kcm_energyinfo: Allow changing of the timespan if no data available (authored by fvogt). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D11712: kcm_energyinfo: Allow changing of the timespan if no data available

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Without this, it's only possible to change the timespan if data is available. Which means that if there is not data available

D11711: Update launchfeedback docbook to 5.12

lueck created this revision. lueck added reviewers: Plasma, Documentation. Restricted Application added a project: Plasma. Restricted Application added subscribers: kde-doc-english, plasma-devel. lueck requested review of this revision. REVISION SUMMARY proofread + update bump date +

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Sure, I'll be updating diff this week, will address concerns raised here REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: alexeymin, plasma-devel, ragreen, schernikov, ZrenBot,

D6096: Add Wayland RemoteAccess capabilities to KRfb

alexeymin added a comment. While I'm here and still remember some things that I don't like here - naming: There is a class `EventsPlugin` and files `eventsplugin.{h,cpp}`, class `EventsManager` and files `eventsmanager.{h,cpp}` and this is fine. But there is also class `EventHandler`,

D11707: [Card] Use own "findIndex" implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e7fd9e62674b: [Card] Use own findIndex implementation (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11707?vs=30598=30606#toc REPOSITORY R169 Kirigami CHANGES SINCE

D11708: [Folder View] Fix selecting text with Shift+Home/End

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5d719c1bb374: [Folder View] Fix selecting text with Shift+Home/End (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11708: [Folder View] Fix selecting text with Shift+Home/End

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 392318 FIXED-IN: 5.12.4 TEST PLAN Home and End

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30603. hein edited the summary of this revision. hein removed subscribers: broulik, ngraham. hein added a comment. Minor fixes to commit message & mention more compact layout; sync summary. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30602. hein added a comment. Drop noisy debug from Kai's findIndex. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30601=30602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED

D11707: [Card] Use own "findIndex" implementation

hein added inline comments. INLINE COMMENTS > Card.qml:107 > +function findIndex(array, cb) { > +console.log("FIND IDX", array); > +for (var i = 0, length = array.length; i < length; ++i) { Debug REPOSITORY R169 Kirigami REVISION DETAIL

D11663: Add InlineMessage type and Gallery app example page

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > broulik wrote in InlineMessage.qml:364 > `findIndex` is new in Qt 5.9 > > [1] https://doc.qt.io/qt-5/qtqml-javascript-functionlist.html Switched to homebrew implementation from your D11707

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30601. hein added a comment. Use homebrew findIndex from D11707 to lower deps below Qt 5.9. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30599=30601 BRANCH master

D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d6e3d6ffbf2f: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11663: Add InlineMessage type and Gallery app example page

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > broulik wrote in InlineMessagesGallery.qml:115 > There's no `start-here` in Breeze, just `start-here-kde` which won't fall > back to `start-here` (which is distro-branded for you apparently) Replaced with

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30599. hein added a comment. Use more generic icon as custom icon example. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30596=30599 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663

D11707: [Card] Use own "findIndex" implementation

broulik updated this revision to Diff 30598. broulik added a comment. Remove unrelated change REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11707?vs=30597=30598 REVISION DETAIL https://phabricator.kde.org/D11707 AFFECTED FILES src/controls/Card.qml

D11707: [Card] Use own "findIndex" implementation

broulik created this revision. broulik added reviewers: Plasma, mart, hein. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `Array.findIndex` has only been added in Qt 5.9 [1]

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30596. hein marked 5 inline comments as done. hein added a comment. - Correct gallery page heading (note to Marco: also wrong in one of the Cards gallery pages). - Use hasOwnProperty. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 122 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/122/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Mar 2018 07:07:57 + Build duration: 33 min and counting JUnit Tests Name: (root)

D11663: Add InlineMessage type and Gallery app example page

hein marked 5 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in InlineMessagesGallery.qml:45 > Wrong class name Thanks, will fix. > broulik wrote in InlineMessagesGallery.qml:115 > There's no `start-here` in Breeze, just `start-here-kde` which won't fall

D11663: Add InlineMessage type and Gallery app example page

broulik added inline comments. INLINE COMMENTS > InlineMessagesGallery.qml:45 > +Layout.fillWidth: true > +text: "CardsLayout" > +} Wrong class name > InlineMessagesGallery.qml:115 > + > +icon: "start-here" > + There's no `start-here` in

D11663: Add InlineMessage type and Gallery app example page

broulik added a comment. Sweet INLINE COMMENTS > InlineMessage.qml:364 > + > +visible: > actionsLayout.overflowSet.findIndex(function(act) { > +return act == modelData}) > -1 && > modelData.visible `findIndex` is new in Qt 5.9

D1230: GBM remote access support for KWin

bshah added a comment. In D1230#234333 , @Kanedias wrote: > I'll take a look once I'm home I've fixed the issue on git master so don't worry. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias,

D1230: GBM remote access support for KWin

Kanedias added a comment. I'll take a look once I'm home REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson,

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. After everyone I talked to universally preferring this option, the code in the latest diff now produces this: F5767042: inlinemessages6.png I'm out of todos on this, so please review now! REPOSITORY R169 Kirigami

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30594. hein added a comment. - Switch to the rounded border + pale fill style most people seem to prefer. This is a proper implementation with better inside corners and the border width matching the seperator width. The radius is the same as for passive

D1230: GBM remote access support for KWin

bcooksley added a comment. Sorry, that was the wrong log - I intended to post https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/121/consoleText REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin

D1230: GBM remote access support for KWin

Kanedias added a comment. @bcooksley this file was merged in D1231 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: bcooksley, kossebau, jgrulich, romangg, ngraham,

D1230: GBM remote access support for KWin

bcooksley added a comment. The introduction of this has broken the FreeBSD Build. Please see https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/120/consoleText REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin,

D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks! :) REVISION DETAIL https://phabricator.kde.org/D11661 To: lueck, #plasma, #localization, #documentation, davidedmundson, hein Cc: kde-doc-english, aacid, hein, plasma-devel, ragreen,