D11757: Polish sidebar header appearance

richardbowen added a comment. The whole area of the Kirigami style back button is clickable. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11757 To: ngraham, mart, #plasma, #vdg Cc: richardbowen, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jen

D11726: Vastly simplify image wallpaper code

davidedmundson added a comment. Thanks, in future can you use arc if you're going to build off another patch. - Only push image item when it's finished (or failed) loading is already this code uploaded here, but wasn't in that branch. :/ I don't understand the need for the wrapp

D11722: If GL context creation fails fall back to the software renderer

graesslin added a comment. An env variable would not work for things like lock screen as the process starting the lock screen is started before Plasmashell. Given that I think persistent storage makes more sense. But a way to get back would be cool. Maybe we could create a test app to se

D11722: If GL context creation fails fall back to the software renderer

davidedmundson updated this revision to Diff 30771. davidedmundson added a comment. Remove debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11722?vs=30643&id=30771 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11722 AFFECTED

D11757: Polish sidebar header appearance

richardbowen added a comment. Yea, the hover border isn't necessary. Maybe the back navigation should work like how it does with Kirigami. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11757 To: ngraham, mart, #plasma, #vdg Cc: richardbowen, plasma-devel,

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer updated this revision to Diff 30744. tillschafer added a comment. update documentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11754?vs=30740&id=30744 BRANCH klipper_notification (branched from master) REVISION DETAIL https

D11757: Polish sidebar header appearance

richardbowen added a comment. I prefer the system settings as it currently is in 5.12, though the submenu heading could be a little bit darker. As for the changes made, I think the person that made the main sidebar header color different from the sub-sidebar header color did so intention

D11757: Polish sidebar header appearance

ngraham added a comment. In D11757#235700 , @richardbowen wrote: > I prefer the system settings as it currently is in 5.12, though the submenu heading could be a little bit darker. > > As for the changes made, I think the person that made th

D11757: Polish sidebar header appearance

ngraham created this revision. ngraham added reviewers: mart, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Polish the category headers in response to user feedback and

D11757: Polish sidebar header appearance

ngraham added a comment. Also, the subcategory header is //already// bold when not in widescreen mode, so the fact that it's still light in widescreen mode is likely a simple bug. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D11757 To: ngraham, mart, #plas

D11754: fix: Klipper notifications visually broken since plasma 5.12

davidedmundson added a subscriber: fvogt. davidedmundson added a comment. Wait for @fvogt and @kbroulik to confirm, but in general ok with me. Please update the text in the .h file. and make it clear that these are in addition to the ones in the spec. REPOSITORY R120 Plasma Workspace REV

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer updated this revision to Diff 30746. tillschafer added a comment. minor formatting REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11754?vs=30745&id=30746 BRANCH klipper_notification (branched from master) REVISION DETAIL https://p

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer updated this revision to Diff 30747. tillschafer added a comment. minor formatting REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11754?vs=30746&id=30747 BRANCH klipper_notification (branched from master) REVISION DETAIL https://p

D11739: Use platform detection from KWorkSpace in KCMShell

fvogt added a comment. In D11739#235478 , @bcooksley wrote: > Please update the dependency metadata in kde-build-metadata. > This has broken the CI builds for kde-cli-tools on all platforms. The issue here is that plasma-workspace requ

D11739: Use platform detection from KWorkSpace in KCMShell

fvogt added a comment. > Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later. Ok, done. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer added a comment. I was thinking if I should also add "th" for a more complete table tag set, but decided to keep it minimal. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11754 To: tillschafer, davidedmundson Cc: fvogt, plasma-devel, ragreen,

D11739: Use platform detection from KWorkSpace in KCMShell

bcooksley added a comment. Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc: bcooksley,

D11757: Polish sidebar header appearance

ngraham updated this revision to Diff 30753. ngraham added a comment. Also improve the widescreen case REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11757?vs=30752&id=30753 BRANCH polish-sidebar-header-appearance (branched from Plasma/5.12) REV

D11739: Use platform detection from KWorkSpace in KCMShell

bcooksley added a comment. Please update the dependency metadata in kde-build-metadata. This has broken the CI builds for kde-cli-tools on all platforms. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc: bcooksley, roma

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer added a comment. IMO, aligned text makes it much more readable at a quick glance. Thus, just from the pure appearance POV I would prefer the current solution. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11754 To: tillschafer, davidedmundson

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. tillschafer requested review of this revision. REVISION SUMMARY Bug: 390375 REPOSITORY R120 Plasma Workspace BRANCH klipper_notification (branched fro

D11754: fix: Klipper notifications visually broken since plasma 5.12

tillschafer updated this revision to Diff 30745. tillschafer added a comment. minor formatting REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11754?vs=30744&id=30745 BRANCH klipper_notification (branched from master) REVISION DETAIL https://p

D11739: Use platform detection from KWorkSpace in KCMShell

This revision was automatically updated to reflect the committed changes. Closed by commit R126:896dd5516cfb: Use platform detection from KWorkSpace in KCMShell (authored by fvogt). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11739?vs=30731&id=307

D11739: Use platform detection from KWorkSpace in KCMShell

bcooksley added a comment. Thanks, I've initiated rebuilds of kde-cli-tools now. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc: bcooksley, romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D11748: Assign notification area category

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense, but let's only commit if and when D11352 goes in, since it doesn't make sense without it. REPOSITORY R134 Discover Software Store BRA

D11757: Polish sidebar header appearance

ngraham added a comment. In D11757#235714 , @richardbowen wrote: > Yea, the hover border isn't necessary. Maybe the back navigation should work like how it does with Kirigami or similar. A Kirigami-style small back button sacrifices the

D11253: Slightly improve discoverability for changing the wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d6bc5f35232a: Slightly improve discoverability for changing the wallpaper (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11253?vs=3075

D11253: Improve discoverability for changing the wallpaper

ngraham updated this revision to Diff 30755. ngraham added a comment. Give up on the unpopular text changes and only change the icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11253?vs=30327&id=30755 BRANCH arcpatch-D11253 REVISION DETAIL h

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 - Build # 22 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/22/ Project: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 Date of build: Tue, 27 Mar 2018 19:32:35 + Build duration: 4 min 30 sec and counting JUnit Tests N

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Mar 2018 19:32:35 + Build duration: 4 min 1 sec and counting JUnit Tests

D11754: fix: Klipper notifications visually broken since plasma 5.12

fvogt added a subscriber: broulik. fvogt added a comment. There was a discussion about this on IRC quite some time ago: 13:01 < d_ed> fvogt: kbroulik_: can I have your opinion on https://bugs.kde.org/show_bug.cgi?id=390375 13:01 < sKreamer> KDE bug 390375 in plasmashell (Notificatio

KDE CI: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-pa%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Mar 2018 18:34:57 + Build duration: 5 min 5 sec and counting

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Mar 2018 18:34:56 + Build duration: 3 min 18 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 - Build # 21 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/21/ Project: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 Date of build: Tue, 27 Mar 2018 18:34:56 + Build duration: 2 min 54 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20SUSEQt5.9/20/ Project: Plasma kde-cli-tools kf5-qt5 SUSEQt5.9 Date of build: Tue, 27 Mar 2018 17:26:29 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Plasma kde-cli-tools kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Mar 2018 17:26:29 + Build duration: 2 min 24 sec and counting CONSOLE OUTPUT

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. TBH, I prefer the "Before" images. The only reason why the symbolic line-art versions exist is because the prettier icons look bad at small sizes on low-dpi screens. Especially for the document icons, IMHO the Before versions look vastly better. REPOSITORY R302 KI

D7481: RFC: Batch window changes events on XCB

broulik added a comment. Monthly ping :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7481 To: davidedmundson, #plasma Cc: ngraham, cfeck, broulik, hein, graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D9984: WIP: Add bookmarks runner

broulik abandoned this revision. broulik added a comment. Not really worth it given it cannot work when the browser isn't running (main usecase for using it) and if we add a caching mechanism we're basically doing the same as the old bookmarks runner. Also, the runner is now (will shortly be)

D10836: Ensure _NET_CURRENT_DESKTOP is set on startup

broulik added a comment. Can this be landed? REPOSITORY R108 KWin BRANCH set-current-desktop-on-startup REVISION DETAIL https://phabricator.kde.org/D10836 To: graesslin, #kwin, #plasma, romangg Cc: broulik, plasma-devel, kwin, ragreen, iodelay, zzag, bwowk, ZrenBot, lesliezhai, ali-m

D11333: introduce candidateContainments

broulik added inline comments. INLINE COMMENTS > desktopview.cpp:55 > +if (items.length() > 0) { > +qDebug()<<"double activity insertion attempted"; > +info->deleteLater(); Remove or cleanup > desktopview.cpp:93 > +{ > +QHash roles; > +roles[Id] = "id"; Use initiali

D11262: KDE logout screen background color fix

Pitel added a comment. I finally got to do some testing and it is not looking good for luminance formula `0.2126*r + 0.7152*g + 0.0722*b`. Screenshot with background color `#5500FF` (blueish, button background on picture), you can see that black text is readable on it, but it has luminan

D11021: [Media controller] Add simple volume control

broulik added inline comments. INLINE COMMENTS > Pitel wrote in multiplexedservice.h:38 > I guess it would look more consistent if it was a job but somehow I fail to > see why any of this is job in the first place: all the actions are very > simple so offloading work to other thread is not need

D10855: Emit clicked when double click expires

broulik added a comment. So, what shall we do with this? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D10855 To: broulik, #plasma, graesslin, #vdg Cc: mart, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10381: [ToolTipArea] Add "aboutToShow" signal

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e5dcc0b47f0e: [ToolTipArea] Add "aboutToShow" signal (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10381?vs=26747&id=30732#toc REPOSITORY R242 Plasma Framework (Libra

D11722: If GL context creation fails fall back to the software renderer

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in main.cpp:186 > So you will permanently force software rendering even for a single hickup > (think of upgrading nvidia driver)? Nvidia driver upgrade is how I ended up in my situation :D Pernament global forcing is what I'

D10251: [RFC] Use mipmap filtering in window thumbnails

broulik closed this revision. broulik added a comment. Committed as https://cgit.kde.org/plasma-framework.git/commit/?id=612494e2b2e9265d33ce148332d5f490b024a3bd REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg, dav

D11722: If GL context creation fails fall back to the software renderer

broulik added a comment. I like the direction but I would like - something that doesn't permanently lock out the user if something failed once, we either need a KCM like KWin has or a SNI ("we had to switch you back to software rendering" with a sad puppy face) - something more generic

D11253: Improve discoverability for changing the wallpaper

mart added a comment. I would prefer the new icon, but still "Configure Desktop" for brevity REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11253 To: ngraham, #plasma, davidedmundson Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen, ZrenBot, lesl

D11726: Vastly simplify image wallpaper code

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Can you please incorporate the changes I did in 34454b17f3c54c701418c0e921ca1bea155b4539 , most notab

D11739: Use platform detection from KWorkSpace in KCMShell

fvogt updated this revision to Diff 30731. fvogt added a comment. Do the same as krunner, unset the variable if platform got detected. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11739?vs=30697&id=30731 BRANCH master REVISION DETAIL https

D11744: Revert "Revert "Get rid of KDELibs4Support""

volkov closed this revision. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D11744 To: volkov, davidedmundson, broulik, #plasma Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11726: Vastly simplify image wallpaper code

mart added inline comments. INLINE COMMENTS > main.qml:62 > } > +loadImage(); > } are you sure none of the *changed signals will be triggered i nthe beginning? this could call loadImage twice > main.qml:80 > +} > +onFillModeChanged: loadTimer.start(); > +onMod

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 30728. Pitel added a comment. - Remove QtQuick.Controls import (was needed only by Checkbox) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=30555&id=30728 BRANCH fixedSizeOverride REVISION DETAIL htt

D11747: Fix warnings on Qt 5.11

This revision was automatically updated to reflect the committed changes. Closed by commit R169:ca8468a2fac8: Fix warnings on Qt 5.11 (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11747?vs=30719&id=30727 REVISION DETAIL https://phabrica

D11739: Use platform detection from KWorkSpace in KCMShell

romangg added a comment. Unset the variable again after app call just to make sure? REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma Cc: romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in libinput_settings.h:27 > this use of templates doesn't match the implementation Do you mean in the cpp file? There are two template specializations defined. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabr

D11750: Assign notification area category

wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352

D11749: Assign notification area category

wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352

D11748: Assign notification area category

wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352

D11747: Fix warnings on Qt 5.11

apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Layouts don't like it when its items anchor to them. Instead use Layout

D11746: Assign notification area category

wsdfhjxc created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352 . REPOSITORY R116 Plasma Ne

D11744: Revert "Revert "Get rid of KDELibs4Support""

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > volkov wrote in CMakeLists.txt:26 > What do you mean? It's revert revert... Urgh, I have trouble reading words. That's clear. sorry REPOSITORY R122 P

Plasma 5.12.4

Plasma 5.12.4 sources are now available for packagers https://www.kde.org/announcements/plasma-5.12.4.php

D11744: Revert "Revert "Get rid of KDELibs4Support""

volkov added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:26 > I'm confused, the commit description doesn't match the diff What do you mean? It's revert revert... REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D11744 To: volkov, davided

D11744: Revert "Revert "Get rid of KDELibs4Support""

davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:26 > find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus > X11Extras) > -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth > IdleTime Config DBusAddons Solid I18n GlobalAccel KIO

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 504 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/504/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Tue, 27 Mar 2018 12:32:17 + Build duration: 24 min and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 212 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/212/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Mar 2018 12:32:17 + Build duration: 15 min and counting CONSOLE OUTPU

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5d65fcbf8bf9: [notifications applet] Fix two qml warnings about assigning [undefined] (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

kossebau updated this revision to Diff 30711. kossebau added a comment. fix hasConfigureAction at the right place by proper init REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11743?vs=30707&id=30711 BRANCH fixnotificationruntimewarnigs REVISIO

D11663: Add InlineMessage type and Gallery app example page

hein added inline comments. INLINE COMMENTS > mart wrote in enums.h:39 > please call this in a more generic way, like MessageSeverity, so can be used > for other kinds of messages if needed, like passivenotification and inline > dialogs Hang on, I focused on disagreeing with Severity, but I un

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. A screenshot including the new dialog-positive icon made by the VDG: F5769344: inlinemessages7.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: davidedmundson, n

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30710. hein marked an inline comment as done. hein added a comment. - Use the new dialog-positive icon (thanks VDG!) for Kirigami.InlineMessageType.Positive. - Flesh out the Gallery example page info text and give it a nicer heading. REPOSITORY R169 Kiri

D11663: Add InlineMessage type and Gallery app example page

hein marked 5 inline comments as done. hein added inline comments. INLINE COMMENTS > mart wrote in InlineMessage.qml:91 > this would make opacity of contentitem 1.0 even when animationg to 0? No, because of `enabled: !root.visible`. implicitHeight is bound to an expression that's recomputed whe

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

kossebau added inline comments. INLINE COMMENTS > broulik wrote in NotificationDelegate.qml:122 > Can you do that in the place where it sets `hasConfigureAction`, I find it > odd that this one needs an explicit check but the other one doesn't Actually I have not found out where model is coming

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

broulik added inline comments. INLINE COMMENTS > NotificationDelegate.qml:122 > hasDefaultAction: model.hasDefaultAction > -hasConfigureAction: model.hasConfigureAction > +hasConfigureAction: model.hasConfigureAction || false > urls: { Can you do

D4939: Get rid of KDELibs4Support

volkov added a comment. D11744 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, #plasma, davidedmundson, volkov, afiestas, broulik, graesslin Cc: graesslin, davidedmundson, broulik, plasma-devel, ragreen,

D11744: Revert "Revert "Get rid of KDELibs4Support""

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY This reverts commit 55603160e9b894270a34e7d01e0aef5bbbfe8025

D8827: experimental support for auto mnemonics

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:cdaa40c64413: experimental support for auto mnemonics (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Deskt

D11743: [notifications applet] Fix two qml warnings about assigning [undefined]

kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Fixes [...]/NotificationDelegate.qml:51:26: Unable to assign

D11663: Add InlineMessage type and Gallery app example page

mart added inline comments. INLINE COMMENTS > hein wrote in InlineMessage.qml:100 > Can you give me a code example of how to use this in the template code? as Action.qml is doing: this is how Action uses it: property ActionIconGroup icon: ActionIconGroup { id: iconGroup } ActionIconGr

D11663: Add InlineMessage type and Gallery app example page

hein marked 4 inline comments as done. hein added inline comments. INLINE COMMENTS > mart wrote in InlineMessagesGallery.qml:61 > add some usage explanation here, like that should be added in the main layout > of the ui you want to put it in, that is not visible by default, needing an > explici

D11663: Add InlineMessage type and Gallery app example page

mart added inline comments. INLINE COMMENTS > InlineMessagesGallery.qml:61 > +wrapMode: Text.WordWrap > +text: "Inline messages allow you to show various types of > messages without an overlay dialog." > +} add some usage explanation here, like that should be add

Minutes for meeting week 12 and 13

Sorry for delay but combined notes on week 12 and 13 -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D 2018-03-19 16:33:26 <@bshah>kbroulik: romangg: notmart Sho_ me ? 2018-03-19 16:33:33

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 503 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/503/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Tue, 27 Mar 2018 07:15:17 + Build duration: 33 min and counting CONSOLE OUTPUT

D11739: Use platform detection from KWorkSpace in KCMShell

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY In a Wayland session, KCMs need to use the wayland platform plugin. TEST PLAN kcmshell5 kscreen now works properly. REPOSITOR

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 211 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/211/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Mar 2018 07:15:17 + Build duration: 9 min 57 sec and counting CONSOLE

D11571: [Battery Monitor] Support "Gaming Input Battery type"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:032fbb83613b: [Battery Monitor] Support "Gaming Input Battery type" (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11571?vs=30197&id