D14050: Fwupd Backend For Review and Improvement

abhijeet2096 marked 18 inline comments as done. abhijeet2096 added a comment. Still, Need to implement Notification Class and some functions in Updater Class. I have to see if we could use the standard Updater Class, after Confirmation I will use directly FwupdResource instead of abstract

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 37778. abhijeet2096 added a comment. Following Updates are made: - Removed Unnecessary Dependencies - Now All strings are constructed by QString - Regularized the indentation and coding style - Removed the soup headers, Now QT libs are used

D14105: Use a broom-style icon for clearing clipboard and notification history

ngraham added a comment. Thanks! @fuchs and/or @broulik? REPOSITORY R120 Plasma Workspace BRANCH broom-style-clear-history-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma, davidedmundson Cc: Zren, plasma-devel,

D14116: Use a better icon for "Remove" on the widget handle

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14116 To: ngraham, #plasma, #vdg, davidedmundson Cc: gregormi, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14116: Use a better icon for "Remove" on the widget handle

ngraham added a comment. Ah yes, I've accidentally removed my panel widgets that way too! I'll submit a similar patch for that shortly. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14116 To: ngraham, #plasma, #vdg Cc: gregormi, plasma-devel, ragreen,

D14116: Use a better icon for "Remove" on the widget handle

gregormi added a comment. +1. I have a similar experience with the red X-Button as shown here for the Activity Manager: F6104707: grafik.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14116 To: ngraham,

D14116: Use a better icon for "Remove" on the widget handle

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY I often find myself clicking the Remove button and

D13931: [KCM] Add speaker placement test

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ed0c58639d12: [KCM] Add speaker placement test (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13931?vs=37743=37753#toc REPOSITORY R115 Plasma Audio Volume Applet

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. Thanks for bearing with me! :) REPOSITORY R115 Plasma Audio Volume Applet BRANCH speakertest REVISION DETAIL https://phabricator.kde.org/D13931 To: nicolasfella, drosca Cc: ngraham, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14112: Fix CMakeLists.txt to work with older versions of CMake

ngraham added a comment. In effect, it's the same. But the `VERSION_GREATER_EQUAL` macro is only present in newer versions of CMake, which makes it not work in, for example, KDE Neon, which ships with an older version of CMake. REPOSITORY R134 Discover Software Store REVISION DETAIL

D14112: Fix CMakeLists.txt to work with older versions of CMake

apol added a comment. uh? isn't that the same? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14112 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D14112: Fix CMakeLists.txt to work with older versions of CMake

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The `VERSION_GREATER_EQUAL` macro was only

D14105: Use a broom-style icon for clearing clipboard and notification history

ngraham updated this revision to Diff 37745. ngraham added a comment. Also use the new icon in the context menu REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14105?vs=37717=37745 BRANCH broom-style-clear-history-icon (branched from master)

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37743. nicolasfella added a comment. - Use brute force approach REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37735=37743 BRANCH speakertest REVISION DETAIL

D13931: [KCM] Add speaker placement test

drosca added inline comments. INLINE COMMENTS > nicolasfella wrote in Advanced.qml:117 > When I remove this line and switch profile e.g. from Stereo to 5.1 the UI > doesn't get updated. I'm no QML expert but it looks like a change to > sinkmodel does not result in reevaluation of data(). I'm

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella added a comment. @hein Ping? REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: nicolasfella, hein, broulik, ngraham Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13931: [KCM] Add speaker placement test

nicolasfella added inline comments. INLINE COMMENTS > drosca wrote in Advanced.qml:117 > What is this doing? > > onDataChanged will be triggered only when some property of data in model > changes, and in that case you overwritten the binding that is set in grid, so > grid.pulseObject will no

D14081: Fix types, improve readability

gladhorn updated this revision to Diff 37736. gladhorn added a comment. Fixed placement of * REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14081?vs=37724=37736 BRANCH arcpatch-D14081 REVISION DETAIL https://phabricator.kde.org/D14081

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37735. nicolasfella marked 9 inline comments as done. nicolasfella added a comment. - Fix unref'ing - Save context in variable - Fix * placement - Fix QML style REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D13734: Make GConf optional dependency

drosca added a comment. Sorry, bad merge. Should be ok now. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13734 To: drosca, #plasma, davidedmundson Cc: rikmills, plasma-devel, asturmlechner, apol, matthiasdahl, ragreen, Pitel, ZrenBot,

D13734: Make GConf optional dependency

rikmills added a comment. Somehow, in some way, the changes to **src/CMakeLists.txt** are in 5.13 branch, but are missing in master branch. So 5.13 builds ok without gconf, but current master fails to build. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D14081: Fix types, improve readability

zzag added inline comments. INLINE COMMENTS > xcbeventlistener.cpp:135 > > -xcb_generic_event_t* e = static_cast(message); > +auto* e = static_cast(message); > const uint8_t xEventType = e->response_type & ~0x80; `auto *e` > broulik wrote in xcbeventlistener.cpp:151 > I prefer

D13931: [KCM] Add speaker placement test

drosca added inline comments. INLINE COMMENTS > canberracontext.cpp:27 > > -class Sink : public Device > +CanberraContext * CanberraContext::s_context = nullptr; > + `*` > canberracontext.cpp:29 > + > +CanberraContext * CanberraContext::instance() > { `*` > canberracontext.cpp:51 > >

KDE CI: Plasma plasma-browser-integration stable-kf5-qt5 SUSEQt5.10 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-browser-integration%20stable-kf5-qt5%20SUSEQt5.10/87/ Project: Plasma plasma-browser-integration stable-kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Jul 2018 06:06:02 + Build duration: 2 min 7

KDE CI: Plasma plasma-browser-integration stable-kf5-qt5 SUSEQt5.10 - Build # 86 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-browser-integration%20stable-kf5-qt5%20SUSEQt5.10/86/ Project: Plasma plasma-browser-integration stable-kf5-qt5 SUSEQt5.10 Date of build: Fri, 13 Jul 2018 04:09:05 + Build duration: 1 day 1 hr