D14806: [AppStream Runner] Reduce verbosity of log output

bruns updated this revision to Diff 41126. bruns added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14806?vs=40774=41126 BRANCH arcpatch-D14806 REVISION DETAIL https://phabricator.kde.org/D14806 AFFECTED FILES

D15306: BookmarksRunner: Avoid multiple connections of identical signal

bruns updated this revision to Diff 41125. bruns added a comment. add context object to disconnect old instance automatically REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15306?vs=41080=41125 BRANCH T9626 REVISION DETAIL

D15305: KRunner: remove no longer existant and unused column from SQL query

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cb99ab735c81: KRunner: remove no longer existant and unused column from SQL query (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15306: BookmarksRunner: Avoid multiple connections of identical signal

bruns added inline comments. INLINE COMMENTS > bruns wrote in bookmarksrunner.cpp:66 > yes, after readding the `dynamic_cast`, m_browser is a non-QObject > interface class. The only syntax which works is connect(this, ::AbstractRunner:teardown, dynamic_cast(m_browser), [this] () {

D15315: Set gtk-modules to auto-load appmenu-gtk-module

broulik updated this revision to Diff 41115. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Support GTK2 too REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15315: Set gtk-modules to auto-load appmenu-gtk-module

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it work out of the box at least for GTK 3 applications TEST PLAN

D15306: BookmarksRunner: Avoid multiple connections of identical signal

bruns added inline comments. INLINE COMMENTS > broulik wrote in bookmarksrunner.cpp:66 > Ah, yeah, right, and then you could connect direcftly: > > connect(this, ::AbstractRunner:teardown, m_browser, > ::teardown); yes, after readding the `dynamic_cast`, m_browser is a non-QObject

D15306: BookmarksRunner: Avoid multiple connections of identical signal

broulik added inline comments. INLINE COMMENTS > bruns wrote in bookmarksrunner.cpp:66 > Hm, just found that auto-disconnect (see @davidedmundson s comment) only > works if you provide a context. The context has to be `m_browser` here. Ah, yeah, right, and then you could connect direcftly:

D15306: BookmarksRunner: Avoid multiple connections of identical signal

bruns planned changes to this revision. bruns added inline comments. INLINE COMMENTS > broulik wrote in bookmarksrunner.cpp:66 > No, four-argument connect: > > connect(this, &..., this, > > Though you just connect from `this` anyway, so I guess this isn't needed Hm, just found that

D15305: KRunner: remove no longer existant and unused column from SQL query

broulik added a comment. Might have confused it with D10610 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D15305 To: bruns, #plasma, davidedmundson Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot,

D15305: KRunner: remove no longer existant and unused column from SQL query

bruns added a comment. In D15305#321346 , @broulik wrote: > Should this go into 5.12 branch as it's quite a common crasher we have there? Crash no, malfunction probably. The schema depends on the first used FF version, FF removes

D15305: KRunner: remove no longer existant and unused column from SQL query

broulik added a comment. Should this go into 5.12 branch as it's quite a common crasher we have there? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D15305 To: bruns, #plasma, davidedmundson Cc: broulik, plasma-devel, ragreen, Pitel,

D15306: BookmarksRunner: Avoid multiple connections of identical signal

broulik added inline comments. INLINE COMMENTS > bruns wrote in bookmarksrunner.cpp:66 > you mean `this->mbrowser->teardown()`? No, four-argument connect: connect(this, &..., this, Though you just connect from `this` anyway, so I guess this isn't needed REPOSITORY R120 Plasma

D15306: BookmarksRunner: Avoid multiple connections of identical signal

bruns added inline comments. INLINE COMMENTS > davidedmundson wrote in bookmarksrunner.cpp:65 > do we not also need a disconnect on m_browser? Browser is just an interface class, but the subclasses also derive from QObject and should auto-disconnect, AFAIK. > broulik wrote in

KDE CI: Plasma plasma-framework kf5-qt5 FreeBSDQt5.11 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20FreeBSDQt5.11/12/ Project: Plasma plasma-framework kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 06 Sep 2018 12:54:12 + Build duration: 2 min 3 sec and counting

D15165: port to PlasmaComponents3

This revision was automatically updated to reflect the committed changes. Closed by commit R120:51d863ce2438: port to PlasmaComponents3 (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15165?vs=40695=41101 REVISION DETAIL

D15201: Move logout-greeter into it's own subdir out of ksmserver

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:171 > > + > # This ensures pressing the eject button on a CD drive ejects the disc Remove > shutdowndlg.cpp:2 >

D15202: Move kcheckrunning into startkde

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:88-96 > -set(kcheckrunning_SRCS > -kcheckrunning.cpp) > - > -add_executable( kcheckrunning ${kcheckrunning_SRCS}) > - >

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets abandoned this revision. sdepiets added a comment. In D15310#321238 , @davidedmundson wrote: > From the docs: > > By default, if CMAKE_MINIMUM_REQUIRED_VERSION is 3.1 or later, or if PKG_CONFIG_USE_CMAKE_PREFIX_PATH is set, the

D15286: Improve arrow key navigation of Kicker search results

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1692ae244bc5: Improve arrow key navigation of Kicker search results (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15286?vs=41061=41095

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

davidedmundson added a comment. From the docs: By default, if CMAKE_MINIMUM_REQUIRED_VERSION is 3.1 or later, or if PKG_CONFIG_USE_CMAKE_PREFIX_PATH is set, the CMAKE_PREFIX_PATH, CMAKE_FRAMEWORK_PATH, and CMAKE_APPBUNDLE_PATH cache and environment variables will be added to pkg-config

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321234 , @sdepiets wrote: > Checking that Qt5Core version is initialized Sorry, but the whole change makes no sense, a big -1. REPOSITORY R135 Integration for Qt applications in Plasma REVISION

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets updated this revision to Diff 41092. sdepiets added a comment. Checking that Qt5Core version is initialized REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15310?vs=41087=41092 BRANCH cmake_qt5_default (branched

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321232 , @sdepiets wrote: > In D15310#321216 , @cgiboudeaux wrote: > > > In D15310#321210 , @davidedmundson wrote:

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets added a comment. In D15310#321216 , @cgiboudeaux wrote: > In D15310#321210 , @davidedmundson wrote: > > > I have this in my dev setup > > > >

D15162: [Folder View] Disable the actions themselves rather than just not adding them to the menu

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7590487788e9: [Folder View] Disable the actions themselves rather than just not adding them… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15162?vs=40687=41091#toc

D15160: [Folder View] Honor editable_desktop_icons KIOSK restriction

This revision was automatically updated to reflect the committed changes. Closed by commit R119:74697d0c9072: [Folder View] Honor editable_desktop_icons KIOSK restriction (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15160?vs=40684=41090#toc REPOSITORY R119

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/17/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 06 Sep 2018 08:23:55 + Build duration: 7 min 48 sec and counting

D15311: [Media Player] Change int to double for positions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1bb02b98cfed: [Media Player] Change int to double for positions (authored by arsenarsen, committed by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15311?vs=41086=41088#toc

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.11 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.11/20/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.11 Date of build: Thu, 06 Sep 2018 08:23:55 + Build duration: 4 min 8 sec and counting JUnit Tests

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321210 , @davidedmundson wrote: > I have this in my dev setup > > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig > > If you had the equivalent, would you need this?

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added inline comments. INLINE COMMENTS > FindQt5PlatformSupport.cmake:72 > +PATH_SUFFIXES > +QtPlatformSupport/${Qt5Core_VERSION}/ > ) This CMake module doesn't know Qt5Core_VERSION, this only works for you because there's a find_package(Qt5 ...) call before looking

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

davidedmundson added a comment. I have this in my dev setup PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig If you had the equivalent, would you need this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D15311: [Media Player] Change int to double for positions

arsenarsen added a comment. Go ahead. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15311 To: arsenarsen, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15311: [Media Player] Change int to double for positions

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! I will commit this on your behalf if you don't mind. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15311 To: arsenarsen, broulik Cc: broulik,

D15311: [Media Player] Change int to double for positions

arsenarsen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arsenarsen requested review of this revision. REVISION SUMMARY In previous versions of Plasma, media player had an overflow bug in positions, leading to the player resetting to 00:00.

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sdepiets requested review of this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH cmake_qt5_default (branched from master) REVISION DETAIL

D15304: [KCM] Port label-bearing controls to QQC2 to fix fractional scaling support

davidedmundson added a comment. s/fix/work round/ Please use the commit message from one of the other patches that does this. I repeatedly have to correct this meme spreading that QQC2 has any relevance to fractional scaling. It leads to other incorrect changes. The only

D15306: BookmarksRunner: Avoid multiple connections of identical signal

davidedmundson added inline comments. INLINE COMMENTS > bookmarksrunner.cpp:65 > +if (m_browser != browser) { > +m_browser = browser; > +connect(this, ::AbstractRunner::teardown, [this]() { > m_browser->teardown(); }); do we not also need a disconnect on m_browser?

D15291: [Folder View] Compare UDS entry times directly instead of going through KFileItem

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2d008a5b931a: [Folder View] Compare UDS entry times directly instead of going through… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D15306: BookmarksRunner: Avoid multiple connections of identical signal

broulik added a comment. Can't you connect to the slot directly and use `Qt::UniqueConnection`? INLINE COMMENTS > bookmarksrunner.cpp:66 > +m_browser = browser; > +connect(this, ::AbstractRunner::teardown, [this]() { > m_browser->teardown(); }); > +} Please provide

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain added a subscriber: ngraham. McPain added a comment. In D14895#320987 , @ngraham wrote: > +1 for the concept. No opinion about the notification, but I think it's fine. Removing myself as a reviewer since I don't feel qualified to offer a

D15304: [KCM] Port label-bearing controls to QQC2 to fix fractional scaling support

drosca added a comment. I'd prefer to port it completely to QQC2. As it is now, in some files you just changed Labels with QQC2 import and in others you changed QQC1->QQC2 import while there are also other QQC items. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL