D15827: [applet] Avoid showing a generic audio-card icon

ngraham added a comment. Possibly related information: I believe the original change that resulted in sound card icons everywhere was D8054 . In particular, read https://phabricator.kde.org/D8054#252877. REPOSITORY R115 Plasma Audio Volume Applet REVISIO

D15827: [applet] Avoid showing a generic audio-card icon

ngraham added a comment. +10 on the end goal of showing speaker or microphone icons instead of a generic sound card icon! I'm not sure this is the best way to achieve that though. I'm sure @drosca will be able to offer some guidance here. REPOSITORY R115 Plasma Audio Volume Applet REVISIO

D15827: [applet] Avoid showing a generic audio-card icon

nicolasfella created this revision. nicolasfella added reviewers: drosca, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY If the hardware reports "internal" as formfactor the generic audio

D12498: Fully remove `Application Name` from Details panel

ngraham added a comment. It's okay, we've all been there. :) Can you maybe take @bruns' `.ui` file for this patch and then we can re-commence review? REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To: sharvey, bruns, ngraham, davided

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. In D12498#333627 , @sharvey wrote: > I believe what you're perceiving in the XML file is in fact the result of a lot of changes made to the layout. Unneeded columns, rows, and spacers were deleted, causing "gaps" in the ol

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. This was copied from D12311: Align lock icon with bold message text; reduce overall size of dialog , which languished unapproved and un-landed for a long time. Indeed, I should have made this a separate patch, but I'd only been a c

D12498: Fully remove `Application Name` from Details panel

ngraham added a comment. In D12498#333627 , @sharvey wrote: > I believe what you're perceiving in the XML file is in fact the result of a lot of changes made to the layout. Unneeded columns, rows, and spacers were deleted, causing "gaps" in the

D15696: Fix qmake build

IlyaBizyaev closed this revision. IlyaBizyaev added a comment. Closed by 8691651c1f0d09430416ba5fe2130647554b06a9 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev, mart

D15824: [Folder View] Fix right/left arrow navigation in popup + list view mode

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview2 (branched from master) REVISION DETAIL https://p

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel updated this revision to Diff 42527. thsurrel added a comment. Sorry, this second commit ended up in the same arc diff, this is not what I intended. I'm still learning... REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15823?vs=42526&id=42

D12498: Fully remove `Application Name` from Details panel

sharvey added a comment. I believe what you're perceiving in the XML file is in fact the result of a lot of changes made to the layout. Unneeded columns, rows, and spacers were deleted, causing "gaps" in the old XML file. In places, I added options like column spans and justifications. The X

Two threads for two new plasma features

Hello everyone, I opened two tasks in phabricator in order to discuss theoretically for solutions around these two features: - Dynamic panel coloring the mobile way for Plasma/Latte panels ( https://phabricator.kde.org/T9769) (this one is too many months in my head) - Support "downward-pointing tr

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel updated this revision to Diff 42526. thsurrel added a comment. [Folder View] Fix right/left arrow navigation in popup + list view mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15823?vs=42524&id=42526 BRANCH arc_folderview (branched

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from master) REVISION DETAIL https://ph

T8066: Fix Bug 390830 = Prevent indexing of Plasma vaults and other fuse filesystems

ngraham added a comment. In T8066#161913 , @smithjd wrote: > > A slightly smarter approach would be for Plasma Vaults itself to add such a rule for whatever mountpoint is chosen during new vault creation. > > What about exposing these config o

D15785: [Slideshow] increase default interval from 10 seconds to 15 minutes

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15785 To: ngraham, #plasma, broulik, mart, #vdg, abetts, davidedmundson Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14949: Add option for whether to show the volume change OSD

ngraham added a comment. Yeah, I saw that too. I'm still against an option to hide it entirely, but I could get behind an option to show a more compact version. I could also support moving all of the square-style OSDs farther down so they're not as close to the center of the screen.

D15304: [KCM] Port (almost) entirely to QQC2

ngraham planned changes to this revision. ngraham marked an inline comment as done. ngraham added a comment. Scrollviews in the tabs are now broken, investigating. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15304 To: ngraham, #plasma, drosca C

D15304: [KCM] Port (almost) entirely to QQC2

ngraham updated this revision to Diff 42512. ngraham added a comment. - Rebase on master - Use Kirigami `Icon` instead of PlasmaCore `IconItem` REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15304?vs=42388&id=42512 BRANCH arcpatch-D1

D15738: [Fonts KCM] remove filler words from anti-aliasing settings' labels

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15738 To: ngraham, #vdg, #plasma, mart Cc: abetts, svenmauch, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 56 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/56/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 28 Sep 2018 17:12:52 + Build duration: 5 min 11 sec and counting

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.11 - Build # 55 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.11/55/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 28 Sep 2018 17:07:57 + Build duration: 1 min 7 sec and counting CONSOLE OUTPUT [...truncated 24.3

D15514: [libbreezecommon] Use box blur instead of FFT blur

zzag updated this revision to Diff 42505. zzag added a comment. Introduce BoxShadowRenderer helper BoxShadowRenderer is a helper to render box shadows. The main benefit of this class is that it takes care of allocating big enough shadow texture, so the resulting shadows are not clipped

D15776: Show the preferred resolution on the combo box

This revision was automatically updated to reflect the committed changes. Closed by commit R104:dfd178e6d093: Show the preferred resolution on the combo box (authored by Your Name , committed by apol). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kd

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

dfaure added a comment. I completely forgot about pushing it, thanks for the reminder and for the target branch information. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D15429 To: dfaure, kfunk, kossebau, br

D15789: Support QXL hotplug_mode_update

apol updated this revision to Diff 42500. apol added a comment. Make sure we don't check the property twice on the same path REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15789?vs=42405&id=42500 BRANCH arcpatch-D15789_1 REVISION DETAIL https:

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

This revision was automatically updated to reflect the committed changes. Closed by commit R135:db3a865c8cbf: Simplify cmake code: link to Qt5::GuiPrivate. (authored by dfaure). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D15789: Support QXL hotplug_mode_update

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in xrandroutput.cpp:212 > why are we querying if the property exists rather than if the property is 1? Because it's poorly specified. In fact, it's always 0 as far as I can tell. REPOSITORY

D13745: Implement support for virtual desktops on Wayland

mart added a comment. Api looks improved to me.. still some todo pieces, but looks good to me INLINE COMMENTS > taskgroupingproxymodel.cpp:724 > +} else if (role == AbstractTasksModel::VirtualDesktops) { > +// FIXME WAYLAND Similar to activities > +// // Returns the lowe

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pagermodel.cpp:444 > for (auto windowModel : d->windowModels) { > -windowModel->setVirtualDesktop(0); > +windowModel->setVirtualDesktop(); >

D15815: Remove expensive blocking call on plasmashell startup

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Nice one REPOSITORY R120 Plasma Workspace BRANCH kuiserver_startup REVISION DETAIL https://phabricator.kde.org/D15815 To: davidedmundson, #plasma, broulik Cc: broulik, plasma-deve

D15815: Remove expensive blocking call on plasmashell startup

davidedmundson added a comment. F6291940: Screenshot_20180928_150857.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15815 To: davidedmundson, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D15815: Remove expensive blocking call on plasmashell startup

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY QDBusInterface is a blocking call that calls introspect. We don't need to i

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns added a comment. Is there anything missing? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15357 To: bruns, #plasma Cc: davidedmundson, zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D15423: System settings: make date/time format preview consistent

davidedmundson added inline comments. INLINE COMMENTS > kcmformats.cpp:322 > +str = m_ui->comboNumbers->currentData().toString(); > +nloc = str.isEmpty() ? QLocale(glob) : QLocale(str); > + I don't understand, why is this sometimes empty? REPOSITORY R119 Plasma Desktop REVISI

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

kossebau added a comment. @dfaure: Was this one pushed already? If not, target would be now Plasma/5.14 branch, with 5.13 EOL REPOSITORY R135 Integration for Qt applications in Plasma BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D15429 To: dfaure, kfunk, kossebau, b

D15789: Support QXL hotplug_mode_update

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Looks mostly good. At some point we'll need to add this property to the wayland output protocols, but that can be later. INLINE COMMENTS > xrandroutput.cpp:1

D15121: Kirigami Pages are required for kcms

This revision was automatically updated to reflect the committed changes. Closed by commit R115:26f77e2c442b: Kirigami Pages are required for kcms (authored by mart). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15121?vs=42466&id=42467 RE

D15121: Kirigami Pages are required for kcms

mart updated this revision to Diff 42466. mart added a comment. - fix wording REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15121?vs=40548&id=42466 BRANCH arcpatch-D15121 REVISION DETAIL https://phabricator.kde.org/D15121 AFFECTED

D15143: Allow creation of separator Actions

dkardarakos updated this revision to Diff 42465. dkardarakos added a comment. Previously introduced "separator mode" removed from AbstractListItem and BasicListItem. Instead of a solution totally inside globaldrawer and contextdrawer I opted for a new BasicListItem alias property (reserv

D15599: Port the "Switch Desktop" containment action to libtaskmanager

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > desktop.cpp:59 > +const QVariantList &desktopIds = s_virtualDesktopInfo->desktopIds(); > +const QStringList &desktopNames = s_virtualDe

D14949: Add option for whether to show the volume change OSD

svenmauch added a comment. In D14949#314343 , @anonym wrote: > Yes; I would be completely happy if the current (size and all) OSD would appear in the periphery of the screen, preferably a corner. So perhaps the missing option is actually a drop-