D15840: [Folder View] Remember selected item when navigating in subfolders

ngraham added a comment. Gotta add `BUG: 359310` to the Summary section, not a comment. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15840 To: thsurrel, #plasma Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 42624. thsurrel added a comment. [Folder View] Restore scrolling position when going back BUG: 359310 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840?vs=42568&id=42624 BRANCH arc_folderview3 (branch

D15863: [MPris Plugin] Support Seek()

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Support `Seek()` command by issuing an appropriate `SetPositio

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added a comment. Having a second look, this bug is related: https://bugs.kde.org/show_bug.cgi?id=359310 As it is, my patch does not fix that though, so far it remembers the selected item but not the scroll position. I will try to improve my patch to fix both issues. REPOSITORY

D15862: option to specify icons spacing for systray

Zren added inline comments. INLINE COMMENTS > Zren wrote in main.qml:310 > Hmm. We might want to scale by DPI. While the default 0px will not be > affected by DPI, if a Look And Feel sets it to 10px, it would look different > for users with 1x DPI and 2x DPI. > > Eg: > > spacing: plasmoid.c

D15862: option to specify icons spacing for systray

Zren added inline comments. INLINE COMMENTS > main.qml:310 > id: tasksRow > -spacing: 0 > +spacing: plasmoid.configuration.iconsSpacing > height: parent.height - (vertical && expander.visible ? > expander.height : 0) Hmm. We might want to scale by DPI. While th

D14542: WIP: Basic KCM using new virtual desktops DBus interface

abetts added a comment. Suggestions from the VDG Channel - Make header "Row 1, Row 2, etc" grey - Add icons (up for review) to the right of each desktop label +1 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson Cc: abetts,

D15862: option to specify icons spacing for systray

mvourlakos added a comment. F6295845: εικόνα.png [new option for icons spacing] F6295852: εικόνα.png [systray demonstrating 10px. icons spacing] REPOSITORY R120 Plasma Workspace REVISION DETAIL https://

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

bruns updated this revision to Diff 42615. bruns added a comment. add inline comments to code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15357?vs=41227&id=42615 BRANCH T9626 REVISION DETAIL https://phabricator.kde.org/D15357 AFFECTED FIL

D15862: option to specify icons spacing for systray

mvourlakos created this revision. mvourlakos added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --added a new configuration option in order for users to alter the systr

D15856: Fix initial focus

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D15856 To: hein, #plasma, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel,

D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now Kickoff doesn't open. When I click on it, I get a little error pop-up that says: Error loading QML file: file:///usr/share/plasma/plasmoids/org.kde.plasma.kickoff/con

D15599: Port the "Switch Desktop" containment action to libtaskmanager

zzag added inline comments. INLINE COMMENTS > desktop.cpp:73 > } else if (m_actions.count() > numDesktops) { > -for (int i = numDesktops +1; i <= m_actions.count(); ++i) { > -delete m_actions[i]; > -m_actions.remove(i); > +for (int i = m_actions.count(

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 42600. hein added a comment. Fix calculating next/prev desktop index REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=42597&id=42600 BRANCH switchdesktop REVISION DETAIL https://phabricator.kde.org/D1

D15856: Fix initial focus

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Now arrow key nav works when opening a panel applet via keyboard shortcut BUG:399185 REPOSITORY R119 Plasma Desktop BRANCH master REVI

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 42597. hein added a comment. Fix list access out of bounds REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=41997&id=42597 BRANCH switchdesktop REVISION DETAIL https://phabricator.kde.org/D15599 AFFE

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein updated this revision to Diff 42596. hein added a comment. Update copyright years REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15855?vs=42595&id=42596 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15855 AFFECTED FILES app

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein updated this revision to Diff 42595. hein added a comment. Focus scope handling. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15855?vs=42594&id=42595 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15855 AFFECTED FILES appl

D15855: Port Kickoff to shared view component using single-MouseArea pattern

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This: - Moves MouseArea out of the item delegate and uses a single MouseArea per view. - Ports all the pages to using a shared view componen

D14542: WIP: Basic KCM using new virtual desktops DBus interface

hein updated this revision to Diff 42592. hein edited the summary of this revision. hein added a comment. Fully implement delayed-apply. Conflicts between user edits and server-side changes are resolved as follows: - If the user hasn't made any edits vs. the server state, the KCM ke