D14949: Add option for whether to show the volume change OSD

rooty added a comment. In D14949#333531 , @ngraham wrote: > > I could also support moving all of the square-style OSDs farther down so they're not as close to the center of the screen. why? REVISION DETAIL https://phabricato

D14949: Add option for whether to show the volume change OSD

rooty added a comment. In D14949#335265 , @svenmauch wrote: > In D14949#334937 , @graesslin wrote: > > > Please don't introduce options based on what's unpopular on Reddit. > > > I'm not sugge

D14949: Add option for whether to show the volume change OSD

graesslin added a comment. It's not about that there are only complaints on Reddit. It's about the user group: do we want to deaign so that the small Reddit community is happy or do we want to design for the rest? Do we want to make the product more complicated (yes that's the result of a co

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e02f3fcb1347: [Bookmarks Runner] Remove duplicate results for bookmarks (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15357?vs=42615&

D15892: [Devicenotifications Engine] Keep at most one notification per UDI

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R120:17380886d9b8: [Devicenotifications Engine] Keep at most one notification per UDI (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1589

D15907: Compare float values in DecorationButton contains check

romangg added inline comments. INLINE COMMENTS > zzag wrote in decorationbutton.cpp:455 > Can you please explain this part? Shouldn't it be `d->geometry.right() < > pos.x()`? If `rect.width()` is smaller 0, then arbitrary QRect `rect` is to the left of its "anchor point" `rect.x()`. The right

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Also, fwiw, comparing floating point numbers with the plain `<` is not quite correct(e.g. 0.3 < 0.1 + 0.2 vs 0.1 + 0.2 < 0.3). Qt does the same so I guess that's fine. INLINE COMMENTS > decorationbutton.cpp:455 > +// additional make sure pos is not on the right or

D15907: Compare float values in DecorationButton contains check

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This restores the bug the last patch fixed. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, z

D15907: Compare float values in DecorationButton contains check

romangg created this revision. romangg added reviewers: KWin, zzag, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY In c9cfd840137b

D14949: Add option for whether to show the volume change OSD

ngraham added a comment. Listening to user feedback is important. We not only have complaints on Reddit, but also someone was motivated enough to submit a patch here. I've also seen it brought up in Bugzilla tickets. REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc:

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

davidedmundson added a comment. I think maybe it should, but it should be changed with surfaceAt REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin, plasm

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

zzag added a comment. > QRectF(QPoint(0, 0), size()).contains(position) Shouldn't it be QRect instead? (again) If it should be QRectF indeed, could someone please explain why? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, grae

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg updated this revision to Diff 42733. romangg added a comment. - Update version number - Do code duplication instead of pointers - Add comment about code duplication REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=42725&id=42733 BRANCH

D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko added a comment. In D15637#335295 , @broulik wrote: > From what I can tell this patch trades one bug (menu closing unexpectedly) for another one (menus erratically resizing/repositioning themselves). As for LyX it's not just menu

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg updated this revision to Diff 42725. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=18059&id=42725 BRANCH inputRegionSubSurfaces REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED FI

D15877: [KonsoleProfiles applet] Fix navigating with the keyboard

thsurrel added a comment. I don't have a developer account, could you land this ? Thanks REPOSITORY R114 Plasma Addons BRANCH arc_konsoleprofiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D15877 To: thsurrel, #plasma, davidedmundson Cc: plasma-devel, ragreen,

D15512: [startplasmacompositor] Add Wayland socket argument

romangg added a comment. On the other side does it sometimes make sense to specify a port manually even if KWin could take the next free one? I would say yes if I have a client to test against, which I can provide with a socket argument (I don't need to query which free socket actually was t

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

abetts added a comment. In D15823#335296 , @thsurrel wrote: > F6299154: screenshot.png > Showing the missing home button in the top left corner. The button would appear again if I would navigate one folde

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel added a comment. F6299154: screenshot.png Showing the missing home button in the top left corner. The button would appear again if I would navigate one folder up or down. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from

D15637: Make DBusMenu work correctly with dynamically generated menus

broulik added a comment. From what I can tell this patch trades one bug (menu closing unexpectedly) for another one (menus erratically resizing/repositioning themselves). I think we should be updating the actions in lockstep rather than adding all the things and then removing the old ones o

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

abetts added a comment. Screenshot? REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D15823 To: thsurrel, #plasma, #vdg, hein Cc: abetts, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D15892: [Devicenotifications Engine] Keep at most one notification per UDI

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > broulik wrote in devicenotificationsengine.cpp:39 > This potentially breaks applets relying on the structure of that name? Not > sure how big of an issue this is as far as "API promise" we give for > dataengi

D15512: [startplasmacompositor] Add Wayland socket argument

fvogt added a comment. In D15512#335264 , @romangg wrote: > Is there a real reason against it besides "not necessary"? Maybe that we can't remove the manual override again without breaking some API promise once we have the grand solution of auto

D14949: Add option for whether to show the volume change OSD

svenmauch added a comment. In D14949#334937 , @graesslin wrote: > Please don't introduce options based on what's unpopular on Reddit. I'm not suggesting we should base new options entirely off reddit opinions. That would be short-sighted

D15512: [startplasmacompositor] Add Wayland socket argument

romangg added a comment. Is there a real reason against it besides "not necessary"? Maybe that we can't remove the manual override again without breaking some API promise once we have the grand solution of automatically taking the next free Wayland socket? Otherwise there is no damage in

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

thsurrel added a comment. I don't have a developer account, can you be the pilot for landing this ? Thanks in advance. REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D15823 To: thsurrel, #plasma, #vdg, hein Cc:

D15637: Make DBusMenu work correctly with dynamically generated menus

poboiko added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15637 To: poboiko, #plasma, broulik, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15887: Fix Klipper popup opening on default screen instead of at cursor position

romangeints updated this revision to Diff 42713. romangeints added a comment. Renamed a variable, removed extra parentheses CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15887?vs=42689&id=42713 REVISION DETAIL https://phabricator.kde.org/D15887 AFFECTED FILES klipper/klipper.c

D15823: [Folder View] In list view mode, fix home button disappearing every other subfolder entered

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice catch! REPOSITORY R119 Plasma Desktop BRANCH arc_folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D15823 To: thsurrel, #plasma, #vdg, hein Cc: hein, pl

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15357: [Bookmarks Runner] Remove duplicate results for bookmarks

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Somehow the usage of `equal_range` and `keyValueBegin` looks quite convoluted but if it works... ship it REPOSITORY R120 Plasma Workspace BRANCH T9626 REVISION DETAIL https://phab

D15892: [Devicenotifications Engine] Keep at most one notification per UDI

broulik added a comment. I think this makes sense INLINE COMMENTS > devicenotificationsengine.cpp:39 > { > -const QString source = QStringLiteral("notification %1").arg(m_id++); > +const QString source = QStringLiteral("%1 notification").arg(udi); > This potentially breaks applets