D16269: Show correct current download and upload speed

jgrulich added a comment. In D16269#370817 , @volkov wrote: > I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed. > One can see the current

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. > That's not a feature we have; the wallpapers of the lock screen, login screen, and desktops are all independent. Whether or not this is desirable is an entirely different issue, but operating with the limitation of not having that, there is no point to a "mild blur"

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. BTW the macOS 10.13 lock/login screen "mild blur" works because it's showing you a blurred version of whatever your actual desktop wallpaper is, so there's continuity between the lock/login screens and the desktop experience. There's never a time when you //only//

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. I don't see the point of an "unobtrusive blur." As I said, if we make the blur less extreme (less blurry, less/no darkening), then we return to having contrast problems with light or visually busy backgrounds. We add that problem back without solving the one here

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. so i take it you're open to the idea of an unobtrusive type of blur? i get that you want to preserve the wallpaper, but sometimes it really does get in the way (snow, mountains, clouds, etc.) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. @raddison You described my work as "not exactly a stroke of genius." That's not being "blunt", it's an insult. We have had this conversation before. I will be forwarding this and earlier exchanges to the KDE Community Working Group. @rooty If you are implying

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#368991 , @ngraham wrote: > You have two options: > > - Stop insulting people and their work > - Go away naaate you're taking all of this way too personally first of all,, @raddison's got a valid

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

raddison added a comment. In D16031#368991 , @ngraham wrote: > In D16031#368953 , @raddison wrote: > > > I've also looked at the test plan and it's not exactly a stroke of genius if it looks like

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

ngraham added a comment. Another revision, please. Thanks for all the great fixes here! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros,

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 added a comment. I managed to fix it, but it the Plasma QML Button code needs to be changed. Should I create a new Phabricator revision or add it here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg Cc: matheusm, ngraham,

D17333: Port digital clock settings to QQc2 and Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R120:39e812d57fd6: Port digital clock settings to QQc2 and Kirigami (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17333?vs=46799=46803#toc REPOSITORY R120 Plasma Workspace

D17335: Install message handler after QApplication

This revision was automatically updated to reflect the committed changes. Closed by commit R856:cf6d43ac6054: Install message handler after QApplication (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D17333: Port digital clock settings to QQc2 and Kirigami

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better! I'd want some padding/whitespace between the checkboxes and the radio buttons, and maybe also between the two comboboxes too. But that's probably a judgment call. :)

D16269: Show correct current download and upload speed

volkov added a comment. I mentioned in D14835 that the total number of received/transmitted bytes is more useful than the current speed. One can see the current speed on the graph. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. F6453133: Screenshot_20181203_172322.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17333 To: mart, #plasma, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17333: Port digital clock settings to QQc2 and Kirigami

mart updated this revision to Diff 46799. mart added a comment. restore Information: label REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17333?vs=46794=46799 BRANCH phab/qqc2time REVISION DETAIL https://phabricator.kde.org/D17333 AFFECTED

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. i can put information again in front of showdate, tough it conveys misleading and wrong info... i really, really hate this abuse of labels as not-really-sections as the label describes the control standing besides it, not any other (btw, chiming in as the historyc

D17335: Install message handler after QApplication

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Well found! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D17335 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel,

D17335: Install message handler after QApplication

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When using `qDebug` et all we will use `Connection::self()->sendMessage` to

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. In D17333#370764 , @ngraham wrote: > Here are some examples (in production, from Dolphin's settings window) of how we integrate diverse controls into a form layout and preserve good alignment: well, in those the

D17333: Port digital clock settings to QQc2 and Kirigami

ngraham added a comment. Here are some examples (in production, from Dolphin's settings window) of how we integrate diverse controls into a form layout and preserve good alignment: F6453053: Screenshot_20181203_085022.png F6453057:

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. ah, like F6453054: Screenshot_20181203_165012.png that can be done only with hacks that will spontaneously break i'm afraid REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17333 To: mart,

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. In D17333#370759 , @ngraham wrote: > The new one doesn't follow the HIG and has poor alignment. Combobox labels are supposed to be to the left of the comboboxes. And having a huge list of checkboxes not aligned to the rest

D17333: Port digital clock settings to QQc2 and Kirigami

ngraham added a comment. The new one doesn't follow the HIG and has poor alignment. Combobox labels are supposed to be to the left of the comboboxes. And having a huge list of checkboxes not aligned to the rest of the controls doesn't look great. This is why we typically add a left label to

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. left old, right new F6453040: Screenshot_20181203_164128.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17333 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17333: Port digital clock settings to QQc2 and Kirigami

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use QQC2 and FormLayout for alignment also, qqc2 combobox doesn't suffer from 390801 anymore

Monday meeting notes for 3/12/2018

Kai Uwe: Work done: - plasma-browser-integration fixes -- Now also exposes actual video URL in metadata -- Fixed Breeze scrollbar CSS causing cross domain access issue -- Fixed cancelling download causing "unknown error" notification in Firefox -- Media sessions are more resilient against

D14444: Use nullptr/override

davidedmundson added a comment. Do you have commit accecss? REPOSITORY R106 KSysguard BRANCH arcpatch-D1 REVISION DETAIL https://phabricator.kde.org/D1 To: al1xz, apol Cc: davidedmundson, zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D16611: Fix build with libc++

This revision was automatically updated to reflect the committed changes. Closed by commit R133:0a5233341ea7: Fix build with libc++ (authored by ktatunov, committed by davidedmundson). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16611?vs=44704=46775

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. In D17192#368233 , @ngraham wrote: > It isn't a title, though. At best, the text in question is a list item, not a title. It surely is, it's the title of that column and says, this column is stuff about "Fonts",

D17212: Port to QQC2 and FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:76eba93be27f: Port to QQC2 and FormLayout (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17212?vs=46465=46770 REVISION DETAIL

D11410: [RFC] Add option to make applet fixed width

mart added a comment. any updates on this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11410 To: Pitel, #plasma Cc: mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17326: Make media session property setter more resilient

This revision was automatically updated to reflect the committed changes. Closed by commit R856:ee0070a6bd03: Make media session property setter more resilient (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D17326: Make media session property setter more resilient

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. > Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read. Of course, but it's not obvious that this behaviour is actually

D17326: Make media session property setter more resilient

broulik added a comment. > Yes, but in there it calls data.value for multiple keys without checking anything Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D17326: Make media session property setter more resilient

fvogt added a comment. In D17326#370546 , @broulik wrote: > It can, `processMetadata(data.value(QStringLiteral("metadata")).toObject());` turns it into an empty object when `null` (or anything but an `Object`) Yes, but in there it calls

D17326: Make media session property setter more resilient

broulik added a comment. It can, `processMetadata(data.value(QStringLiteral("metadata")).toObject());` turns it into an empty object when `null` (or anything but an `Object`) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D17326 To: broulik,

D17326: Make media session property setter more resilient

fvogt added a comment. Can `host/mprisplugin.cpp` deal with payload being null properly? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D17326 To: broulik, #plasma, davidedmundson, fvogt Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17326: Make media session property setter more resilient

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Don't break when it's set to `null` to unset metadata. BUG: 401636