D16918: [dimdisplay] Do not change screen brightness on invalid values

anthonyfieroni added a comment. @thsurrel try this patch, if it not help disable dim display from power saving configuration, is that help? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16918 To: anthonyfieroni, #plasma, broulik, mart Cc: thsurrel, broulik, pla

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.11 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.11/15/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 08 Dec 2018 04:56:12 + Build duration: 1 min 37 sec and counting CONSOLE OUTPUT [...truncated 531 li

D17375: Don't automatically refresh if the user already asked apt to do so

ngraham added a comment. This helps for Kubuntu (and Neon ?) users, but what about everyone else? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17375 To: apol, #kubuntu, sitter, rikmills Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai

D17420: [Device Notifier] Fix action button vertical alignment

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works flawlessly! Very nice. REPOSITORY R120 Plasma Workspace BRANCH arc_alignment (branched from master) REVISION DETAIL https://phabricator.kde.org/D17420 To: thsurrel, #vdg, ng

D17410: Add alternatives button to applet configuration in panel edit mode

ngraham added a comment. Neat, it seems to generally work well. I notice that when I click the new menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we could make it not do that, so it would stay in panel edit mode if invoked while in panel edit mode. REPOSITORY

D17410: Add alternatives button to applet configuration in panel edit mode

ngraham added a comment. In D17410#373011 , @ndavis wrote: > I think we should be using a monochrome icon here. I agree. In D17410#373011 , @ndavis wrote: > It might be outside the scope

D17410: Add alternatives button to applet configuration in panel edit mode

ndavis added a comment. I think we should be using a monochrome icon here. An equivalent monochrome icon would be `favorite`, but I don't think "favorite" is a good symbol for "alternatives". Maybe `preferences-other`/`application-menu` (same icon) would be good? It might be outside the scop

D17412: [kcms/fonts] Don't set minimium DPI value

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great! REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D17412 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, r

D17420: [Device Notifier] Fix action button vertical alignment

abetts added a comment. Love it! +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17420 To: thsurrel, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17420: [Device Notifier] Fix action button vertical alignment

thsurrel updated this revision to Diff 47080. thsurrel added a comment. No more magic :( REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17420?vs=47079&id=47080 BRANCH arc_alignment (branched from master) REVISION DETAIL https://phabricator.kd

D17420: [Device Notifier] Fix action button vertical alignment

ngraham added inline comments. INLINE COMMENTS > DeviceItem.qml:308 > onClicked: actionTriggered() > +y: mounted ? deviceLabel.height + (freeSpaceBar.height - > height) / 2 - 2 : (deviceLabel.height + actionMessage.height - height) / 2 > } `- 2` loo

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. I made another patch that fixes the alignment D17420 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel,

D17420: [Device Notifier] Fix action button vertical alignment

thsurrel created this revision. thsurrel added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH arc_alignment (branched from master) REVISION DETAIL https://phabrica

D17415: Fix event type checking

davidedmundson added a comment. Seems to be an XCB bug. We should have wrappers for both: XkbNewKeyboardNotify, XkbMapNotify, etc. and XkbNewKeyboardNotifyMask, XkbMapNotifyMask, etc. the latter being used for event selection masks. That's what XKB.h from X11 has,

D17415: Fix event type checking

amantia created this revision. amantia added reviewers: Plasma, Plasma Accessibility, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY The ev->xkbType looks to be a value that is defined in xkb.xml (usuall

D17412: [kcms/fonts] Don't set minimium DPI value

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The QML port added a minimum value for the font DPI, the old widgets code g

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47058. GB_2 added a comment. Hide the tooltip if you click on it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47045&id=47058 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES deskto

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

Codezela added a comment. In D17323#372754 , @GB_2 wrote: > In D17323#372752 , @Codezela wrote: > > > when resizing the panel can we show the width of it > > 48px ,36px etc > > because now when

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 added a comment. It's okay :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17323 To: GB_2, #plasma, #vdg, ngraham Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, cro

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 added a comment. In D17323#372752 , @Codezela wrote: > when resizing the panel can we show the width of it > 48px ,36px etc > because now when I resize the panel I guess what better visually > but if I know the size exactly It will m

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

Codezela added a comment. when resizing the panel can we show the width of it 48px ,36px etc because now when I resize the panel I guess what better visually but if I know the size exactly It will much better like all other panels latte dock for example REPOSITORY R119 Plasma Desktop

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 updated this revision to Diff 47054. GB_2 added a comment. Update TODO text. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=47051&id=47054 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/conten

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY There is a configure button and an alternatives button in the context menu of an applet, but there i

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47045. GB_2 added a comment. Fix tooltip text color (for real this time). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47041&id=47045 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. @ngraham I know this is going back to the dependent revision, but what do you think about maybe tightening the shadows around the clock? Currently the shadows can look a bit blobby, and because the radius is so wide, the interior textual elements get filled up wit

D17408: Make accessibility warning dialog usable again

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY Layout was completely broken, resulting in an empty dialog. REPOSITORY R119 Plasma Desktop BRANCH accessbility-fixes REVISION

D17402: [Device Notifier] Disable the possibility to unmount the root partition

abetts added a comment. If this patch deals with the UI, is it possible to align the eject button to the middle using the progress bar as the center? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc: abetts, ngraham, brou

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47041. GB_2 added a comment. Fix text color. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47038&id=47041 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES desktoppackage/contents/con

D17402: [Device Notifier] Disable the possibility to unmount the root partition

ngraham added a comment. Ah, I see! Lol it never even occurred to me to try to configure the plasmoid. Given that, I think this patch makes sense. No point in allowing people to do invalid things. Should we also give the same treatment to the partition that `~` lives on, if it's differen

D17401: [Device Automounter KCM] Improve the tree view header spacing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:66e05cb9c097: [Device Automounter KCM] Improve the tree view header spacing (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17401?vs=4

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc:

D17401: [Device Automounter KCM] Improve the tree view header spacing

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R119 Plasma Desktop BRANCH arc_automounter_kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D17401 To: thsurrel, #vdg, davidedmundson, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, Z

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

GB_2 updated this revision to Diff 47038. GB_2 added a comment. Improve wording. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47033&id=47038 REVISION DETAIL https://phabricator.kde.org/D17323 AFFECTED FILES desktoppackage/contents/co

D17402: [Device Notifier] Disable the possibility to unmount the root partition

ngraham added a comment. My root and home partitions don't appear in the devices notifier (they're on an internal NVMe SSD). How do you get in this state? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc: ngraham, broulik

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This looks great to me now! Just one tiny little minor suggested wording change. Let's see what the #plasma folks think too. INLINE COMMENT

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

GB_2 updated this revision to Diff 47033. GB_2 added a comment. Add tooltip for the resize button, change tooltip text and increase tooltip timeout. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17323?vs=47011&id=47033 REVISION DETAIL https://ph

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. Can you develop why ? Is because of the added code ? From a usability point of view, does it not make sense to disable something that is not possible ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma,

D17402: [Device Notifier] Disable the possibility to unmount the root partition

broulik added a comment. I'm not very happy with all this root and home special casing all over the place (e.g. Places panel now also has something like this, etc) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc: broulik

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH arc_unmountroot (branched from master) REVISION DETAIL https:/

D17398: [xscreensaverpoller] Flush after reset screensaver

This revision was automatically updated to reflect the committed changes. Closed by commit R274:de990fe48ff4: [xscreensaverpoller] Flush after reset screensaver (authored by anthonyfieroni). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R274 KId

D17394: [Device Notifier] Fix transition animation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ab47422c1b41: [Device Notifier] Fix transition animation (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17394?vs=47001&id=47023 RE

D17394: [Device Notifier] Fix transition animation

thsurrel added a comment. In D17394#372523 , @broulik wrote: > Is this Bug 379759? I don't think so, but I will have a look at that one too. If any of you guys can have a look at my other device notifier patches, that would be really

D17394: [Device Notifier] Fix transition animation

thsurrel added inline comments. INLINE COMMENTS > davidedmundson wrote in DeviceItem.qml:197 > alwaysRunToEnd : true That does not work by itself. REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D17394 To: thsur

D17394: [Device Notifier] Fix transition animation

broulik added a comment. Is this Bug 379759? REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D17394 To: thsurrel, #plasma, #vdg, ngraham Cc: broulik, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenB

D17394: [Device Notifier] Fix transition animation

davidedmundson added inline comments. INLINE COMMENTS > DeviceItem.qml:197 > NumberAnimation { > property: "opacity" > from: 0 alwaysRunToEnd : true REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) RE

D17401: [Device Automounter KCM] Improve the tree view header spacing

thsurrel created this revision. thsurrel added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arc_automounter_kcm (branched from master) REVISION DETAIL https://phab

D16918: [dimdisplay] Do not change screen brightness on invalid values

thsurrel added a comment. This bug is bothering me too and I haven't found a fix either. I use an external screen connected to my laptop and I turn my laptop screen off by setting its brightness to 0. Then whenever I go away for a moment and the screen is turned off because energy saving ki

D16918: [dimdisplay] Do not change screen brightness on invalid values

anthonyfieroni updated this revision to Diff 47017. anthonyfieroni retitled this revision from "[brightnesscontrol] Do not change screen brightness on invalid values" to "[dimdisplay] Do not change screen brightness on invalid values". REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE ht

D15423: System settings: make date/time format preview consistent

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmformats.cpp:322 > I don't understand, why is this sometimes empty? Sorry for delayed reply. In KCMFormats::initCombo we add locales to combo boxes. First we add a QString() for "No change" option and then we add all poss

D17398: [xscreensaverpoller] Flush after reset screensaver

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, broulik, aacid. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY XResetScreenSaver does not flush X message queue https://git

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.11 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.11/35/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 07 Dec 2018 08:13:22 + Build duration: 19 min and counting