D17706: Fix lock screen focus

andreyby added a comment. **davidedmundson ** //we don't want to cursor grab in testing mode, this change is lost//yes, did not notice //This is still relevant A cursor can be in none.//I think this is superfluous, because the default focus is on the first screen. //why are we c

D17706: Fix lock screen focus

andreyby updated this revision to Diff 47933. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=47879&id=47933 REVISION DETAIL https://phabricator.kde.org/D17706 AFFECTED FILES greeter/greeterapp.cpp To: andreyby, davidedmundson Cc: abetts, d

KDE CI: Plasma » kscreen » stable-kf5-qt5 FreeBSDQt5.11 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20FreeBSDQt5.11/15/ Project: stable-kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 21 Dec 2018 07:28:13 + Build duration: 13 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.11 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.11/17/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Fri, 21 Dec 2018 07:28:13 + Build duration: 27 sec and counting CONSOLE OUTPUT [...truncate

[Plasma Workspace Wallpapers] [Bug 346251] Default wallpaper cannot be found in desktop settings

https://bugs.kde.org/show_bug.cgi?id=346251 Christoph Feck changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REPORTED

[kdeplasma-addons] [Bug 378823] EPOD POTD display header image instead of the real photo

https://bugs.kde.org/show_bug.cgi?id=378823 Christoph Feck changed: What|Removed |Added Component|general |Picture of the Day Product|Plasma W

[kwrited] [Bug 386067] Use seperate notifications for each message

https://bugs.kde.org/show_bug.cgi?id=386067 --- Comment #1 from Christoph Feck --- Are messages separated by some fixed text? Otherwise I doubt it is fixable. -- You are receiving this mail because: You are the assignee for the bug.

D17652: Fix logic error in kioclient noninteractive argument handling

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I'm not sure anymore what the best default is. There are two different use cases, that's all. REPOSITORY R126 KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde

D17717: Remove KDE3 reference in kdeeject

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There is no org.kde.kdesktop and we don't show mount points by default on t

D17652: Fix logic error in kioclient noninteractive argument handling

davidedmundson updated this revision to Diff 47922. davidedmundson edited the summary of this revision. davidedmundson added a comment. update REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17652?vs=47894&id=47922 BRANCH master REVISION DETAIL

D17652: Fix logic error in kioclient noninteractive argument handling

davidedmundson added a comment. > Why would we want to break compatibility yet again? ;-) It's the better default. I've removed the TODO, but I've deliberately not said which is default in the --help output which hopefully will encourage people to still type --noninteractive if they g

D17653: Keep kioclient alive whilst we're showing error messages

This revision was automatically updated to reflect the committed changes. Closed by commit R126:c05e88533de1: Keep kioclient alive whilst we're showing error messages (authored by davidedmundson). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17653?

D17703: Fix KIOClient non-interactive mode handling renamed prompts

This revision was automatically updated to reflect the committed changes. Closed by commit R126:36a59ad77f5e: Fix KIOClient non-interactive mode handling renamed prompts (authored by davidedmundson). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D177

D17711: [kuiserver] Avoid double warning on terminated jobs

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c4dcba898a97: [kuiserver] Avoid double warning on terminated jobs (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17711?vs=478

D17709: Remove outdated note about autostart not working

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fb1570f4804d: Remove outdated note about autostart not working (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17709?vs=47893&id

D17711: [kuiserver] Avoid double warning on terminated jobs

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > jobview.cpp:56 > { > +qDebug() << "is terminated" << errorMessage; > QDBusConnection::sessionBus().unregisterObject(m_objectPath.path(), > QDBusConnection::

D17652: Fix logic error in kioclient noninteractive argument handling

dfaure added a comment. Looks good except for the TODO comment. I think the comment that is actually needed is one about why we have a "noninteractive" option and it has no effect whatsoever ;) INLINE COMMENTS > kioclient.cpp:278 > +// interactive used to be the default, but due to

D17704: Copy to clipboard always copy English texts

cfeck added a comment. Or make the button have a drop-down, see e.g. "Save As..." button in Spectacle. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma Cc: ngraham, gregormi, cfeck, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliez

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. In D17704#380016 , @ngraham wrote: > I recall in the original patch that copying translated text was something that various folks specifically asked for. Is it really that useless? @gregormi, do you remember the context

D17711: [kuiserver] Avoid double warning on terminated jobs

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY When a job is terminated, it isn't necessarily removed from the job owners

D17704: Copy to clipboard always copy English texts

ngraham added subscribers: gregormi, ngraham. ngraham added a comment. I recall in the original patch that copying translated text was something that various folks specifically asked for. Is it really that useless? @gregormi, do you remember the context? REPOSITORY R102 KInfoCenter REVISI

D17704: Copy to clipboard always copy English texts

guoyunhe updated this revision to Diff 47897. guoyunhe added a comment. Use untranslated texts for clipboard label pairs REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17704?vs=47877&id=47897 BRANCH master REVISION DETAIL https://phabricator.kde.o

D17709: Remove outdated note about autostart not working

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, totally works. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17709 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel,

D17652: Fix logic error in kioclient noninteractive argument handling

davidedmundson updated this revision to Diff 47894. davidedmundson added a comment. Make non-interactive default REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17652?vs=47760&id=47894 BRANCH master REVISION DETAIL https://phabricator.kde.org

D17709: Remove outdated note about autostart not working

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Just tested, worked fine. That line has been th

D17677: Add workaround for gtk file chooser filter patterns

davidedmundson added inline comments. INLINE COMMENTS > jgrulich wrote in filechooser.cpp:287 > Does it really support regexp in this form? If so, why it doesn't work when > used by plasma-integration? I see plasma-integration internally uses > KFileWidget and passes filters to it. It should d

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. In D17704#379978 , @cfeck wrote: > If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels. Yes, the patch doesn't do what I want to do. I will update it.

D17704: Copy to clipboard always copy English texts

cfeck added a comment. If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma Cc: cfeck, plasma-devel, GB_2, ragreen, Pitel, Zre

D17706: Fix lock screen focus

abetts added a comment. Can you show a video or gif of this behavior? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreute

D17677: Add workaround for gtk file chooser filter patterns

jgrulich added inline comments. INLINE COMMENTS > davidedmundson wrote in filechooser.cpp:287 > KFileWidget::setFilter exists and takes regular expressions already. Does it really support regexp in this form? If so, why it doesn't work when used by plasma-integration? I see plasma-integration i

D17659: Set parent window for dialogs

volkov added a comment. Is it possible to implement support for foreign windows in KWin QPA plugin? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.14 REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: graesslin, broulik, apol

D17707: FolderView: set sort mode to unserted after catching insert signal

McPain created this revision. McPain added reviewers: hein, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY When new item is created, the initMaps() is called. Positioner will init his maps relyi

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

hein added a comment. Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17689 To: McPain, #plasma, hein, davidedmundson Cc: plasma-de

D17706: Fix lock screen focus

davidedmundson added inline comments. INLINE COMMENTS > greeterapp.cpp:436 > + > +view->setFlags(view->flags() | Qt::X11BypassWindowManagerHint); > + why are we changing the window flags? > greeterapp.cpp:451-453 > -if (!w) { // fallback solution > -w = m_views.first();

D17652: Fix logic error in kioclient noninteractive argument handling

broulik added a comment. > note how it said "ninteractive", the "no" was toggling the value). I assumed it was a typo. Yay :) REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D17652 To: davidedmundson, #plasma, nerdopolist, dfaure Cc: broulik, plasma-dev

D17652: Fix logic error in kioclient noninteractive argument handling

dfaure added a comment. Good find. However for users who didn't want a progress dialog, and who never got a conflict (e.g. if they were copying into an empty dir), kioclient was non-interactive, so I think our previous reasoning still holds. REPOSITORY R126 KDE CLI Utilities REVISION DETA

D17706: Fix lock screen focus

andreyby created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. andreyby requested review of this revision. REVISION SUMMARY When the screen is locked, the focus always remains on the main screen, this patch fixes the problem. Now the focus is on the scr

D17073: Do not crop albumArt

trmdi updated this revision to Diff 47876. trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=46007&id=47876 REVISION DETAIL https://phabricator.kde.org/D170

D17704: Copy to clipboard always copy English texts

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Usually users copy this info to report bugs or get help from community. English texts are more useful and readable. REPOSITORY