D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

davidedmundson added a comment. If we are going to effectively remove it, I would like to see it removed fully. Otherwise we'll get some crufty code that doesn't make sense forever as well as quirky bugs. INLINE COMMENTS > componentchooserbrowser.cpp:69 > + > +if

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure added a comment. OK, here's a bit of historical information, and then my opinion. The idea of that option was that when you click on a (e.g. HTTP) link to a PDF (e.g. in an email), the best application to view that PDF is Okular. Similarly, if it's an image, the best application

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.11 - Build # 132 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.11/132/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 09:00:24 + Build duration: 7 min 48 sec and counting JUnit Tests Name: (root)

Google Summer of Code Ideas

Hi folks, a few teams have added their ideas to https://community.kde.org/GSoC/2019/Ideas but many have not yet done so. Those of you reading this plea have participated in the past but do not have ideas posted yet. PLEASE get this done before the end of the year! We need to submit our

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 259 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/259/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 22 Dec 2018 20:30:57 + Build duration: 53 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.11 - Build # 121 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.11/121/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 13:30:13 + Build duration: 8 min 2 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.11 - Build # 144 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.11/144/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 08:01:39 + Build duration: 23 min and counting BUILD ARTIFACTS

D17677: Add workaround for gtk file chooser filter patterns

davidedmundson added a comment. Thanks for working on this. Given we need a kio patch if you want to put this in just the stable branch, go for it. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17677 To: jgrulich, broulik Cc:

D17154: Go back to SCSS

gepardo updated this revision to Diff 48031. gepardo added a comment. More imrovements: - remove gtk-3.18 as it's not rebuilt. The theme is still usable under GTK+ 3.18 (files are actually located in gtk-3.0) - add python as a dependency in CMakeLists.txt REPOSITORY R98 Breeze for

D17154: Go back to SCSS

gepardo updated this revision to Diff 48030. gepardo added a comment. Use CMake for building themes The following changes are made: - cmake/FindSass.cmake is now used to detect SASS compiler presence - build scripts are invoked from cmake, so everythings builds using simple cmake

D17738: Use KFileWidget instead of QFileDialog

jgrulich added a comment. Yes, it does work with your patch, thank you for that and sorry for my laziness. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17738 To: jgrulich, davidedmundson Cc: plasma-devel, GB_2, ragreen, Pitel,

D17738: Use KFileWidget instead of QFileDialog

jgrulich updated this revision to Diff 48029. jgrulich added a comment. Use QScopedPointer for file dialogs REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17738?vs=48018=48029 BRANCH master REVISION DETAIL

D17154: Go back to SCSS

gepardo added a comment. In D17154#380574 , @ngraham wrote: > On that subject, rebuilding the theme should be done as a part of the default build target when running `make` rather than requiring the use of a script. It's a requirement that all

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 258 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/258/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 22 Dec 2018 19:26:37 + Build duration: 5 min 49 sec and counting CONSOLE OUTPUT [...truncated 4603

D17738: Use KFileWidget instead of QFileDialog

davidedmundson added a comment. > https://phabricator.kde.org/D17677 will be still needed. My rule about working round KDE code still applies. Does this work: https://phabricator.kde.org/P285 on KIO for the remaining case? INLINE COMMENTS > filechooser.cpp:289 > +QUrl url

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 257 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/257/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 22 Dec 2018 17:37:14 + Build duration: 5 min 43 sec and counting CONSOLE OUTPUT [...truncated 4612

D17677: Add workaround for gtk file chooser filter patterns

jgrulich added a comment. In D17677#380859 , @davidedmundson wrote: > > but the "automatic extension" feature will add the file extension unmodified > > Can you expand on what this means. If you try to save a file and you use for

D17738: Use KFileWidget instead of QFileDialog

jgrulich added a comment. This still doesn't resolve bug 399889 so review https://phabricator.kde.org/D17677 will be still needed. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17738 To: jgrulich, davidedmundson Cc:

D17738: Use KFileWidget instead of QFileDialog

jgrulich created this revision. jgrulich added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY It would be used anyway, because QFileDialog in Plasma uses KFileWidget through QPA

D17677: Add workaround for gtk file chooser filter patterns

davidedmundson added a comment. > but the "automatic extension" feature will add the file extension unmodified Can you expand on what this means. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17677 To: jgrulich, broulik Cc:

D17677: Add workaround for gtk file chooser filter patterns

jgrulich added a comment. I have now a new version using KFileWidget and it still suffers from the same problem. It does filter properly when I use regexp, but the "automatic extension" feature will add the file extension unmodified so it results into the same problem. It looks that my

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure added a comment. Please add a KIO version ifdef to avoid breaking compilation with older versions of KIO. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham,

D17725: [RFC] Fix model updates in RunnerMatchesModel

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I don't think it's necessary to optimize the `dataChanged` emits at this time - in the common case the roles the delegate is visualizing (label, icon) will always change, and the other rules

D17677: Add workaround for gtk file chooser filter patterns

jgrulich added a comment. In D17677#380566 , @ngraham wrote: > Is there a new version of this patch somewhere else? Not yet, will be soon. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL