KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 06:57:15 + Build duration: 14 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 05:10:36 + Build duration: 1 hr 50 min and counting JUnit Tests Name:

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/8/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 04:43:37 + Build duration: 2 hr 8 min and counting CONSOLE OUTPUT

D18005: Include only the largest size for each wallpaper

ngraham added a comment. Feel free to accept, but I really want some input from a #plasma person on this whole idea before it lands. They have been silent on the matter so far but now that there are patches, I think it's important that we get the

D18005: Include only the largest size for each wallpaper

ndavis added a comment. Should I accept now or should I wait until that gets sorted out? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham, #vdg, #plasma Cc: ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18005: Include only the largest size for each wallpaper

ndavis added a comment. In D18005#387324 , @ngraham wrote: > However, just removing files from the repo doesn't actually remove them from users' machines; their packaging system does that. Perhaps we should alert packagers that for the 5.15

D18005: Include only the largest size for each wallpaper

ngraham added a comment. However, just removing files from the repo doesn't actually remove them from users' machines; their packaging system does that. Perhaps we should alert packagers that for the 5.15 release, they shouldn't remove these files from users' machines when they disappear

D18005: Include only the largest size for each wallpaper

ngraham added a comment. Just tested that out and the results aren't great: you get a black background instead of the wallpaper until you go to the wallpaper chooser and re-choose it. :/ REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham,

D18005: Include only the largest size for each wallpaper

ngraham added a comment. Probably a question best asked in D18006 REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham, #vdg, #plasma Cc: ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel,

D18005: Include only the largest size for each wallpaper

ndavis added a comment. What happens if my wallpaper is set to the 1080p version of the default wallpaper and then that version is removed with only the highest resolution version left? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham,

D18006: Include only the largest size for the "Next" wallpaper

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Companion to D18005 ; everything there applies here.

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 04:29:08 + Build duration: 41 min and counting CONSOLE OUTPUT

D18005: Include only the largest size for each wallpaper

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY In this patch, we remove all the versions of each wallpaper that are not the largest size.

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d1bc0842839: Use Scaled and Cropped as the default wallpaper image fill mode (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 It works for the majority of wallpapers much better than just scaling. REPOSITORY R120 Plasma Workspace BRANCH scaled-and-cropped-by-default (branched from master) REVISION

D18004: Use "Scaled and Cropped" as the default wallpaper image fill mode

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The current default setting is "Scaled", which results in images that don't match the

D17997: SDDM don't handle enter key when blurred

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Meaning pressing enter just wakes up the display. Behaviour now matches

D17834: Allow the use of One-Time Password

enriquem added inline comments. INLINE COMMENTS > jgrulich wrote in fortisslvpnwidget.cpp:201 > I don't understand why you hare check for prevData.value(), but later on you > get optFlag from data (not prevData). Still I don't think this is needed at > all. I would go back and use your

D17834: Allow the use of One-Time Password

enriquem updated this revision to Diff 48760. enriquem added a comment. I implemented all of your comments, reverting to my previous approach REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17834?vs=48750=48760 REVISION DETAIL

D17996: Remove blur on login screen when pressing a modifier

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Clone of b9f9581f99ef3f50c30b26d87a0258e0d2531f4d

D17834: Allow the use of One-Time Password

jgrulich added inline comments. INLINE COMMENTS > fortisslvpnauth.cpp:44 > +const NetworkManager::Setting::SecretFlags otpFlag = > static_cast(data.value(NM_FORTISSLVPN_KEY_OTP"-flags").toInt()); > +if (otpFlag == NetworkManager::Setting::NotSaved){ > +

D17834: Allow the use of One-Time Password

enriquem updated this revision to Diff 48750. enriquem added a comment. Treat otp-flags the same way NetworkManager-fortisslvpn does REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17834?vs=48744=48750 REVISION DETAIL

D17834: Allow the use of One-Time Password

enriquem added a comment. >> I see. Maybe do not set it at all if one-time password is not used and let NM to set the default value? That way we won't be using a wrong value in case this changes in future. > > Fair enough. I will update the diff with this. However, judging from the

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 05 Jan 2019 16:27:59 + Build duration: 3 min 55 sec and counting JUnit Tests Name:

[plasma-workspace] kcms/translations: Add copy of writeexports.h

Git commit 46148f70835acd9a6037929266e3e1283d730f48 by Bhushan Shah. Committed on 05/01/2019 at 16:25. Pushed by bshah into branch 'master'. Add copy of writeexports.h todo: we should probably move this to some framework? so that both formats kcm or translations kcm can use this. Alternatively

D17834: Allow the use of One-Time Password

enriquem updated this revision to Diff 48744. enriquem added a comment. Removed setting the otp-flag in case it is not needed for the connection REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17834?vs=48701=48744 REVISION DETAIL

D17834: Allow the use of One-Time Password

enriquem added a comment. > I see. Maybe do not set it at all if one-time password is not used and let NM to set the default value? That way we won't be using a wrong value in case this changes in future. Fair enough. I will update the diff with this. However, judging from the current

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.11 - Build # 159 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.11/159/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sat, 05 Jan 2019 16:07:29 + Build duration: 1 min 49 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 05 Jan 2019 16:07:29 + Build duration: 1 min 29 sec and counting CONSOLE OUTPUT

D17834: Allow the use of One-Time Password

jgrulich added a comment. In D17834#386573 , @enriquem wrote: > I implemented all of your comments except one. I created a new VPN setting wit nm-connection-editor, and it sets it to 0, that is, to NetworkManager::Setting::None. Thus, I believe

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

davidedmundson added a comment. > Sorry, this is my first time. How can I check access to a commit before doing it? Congrats on your first patch. I'll sort it out. REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D17960 To: kvanton, #plasma

D17975: [WIP, Notifications] Add padding to notifications

davidedmundson added inline comments. INLINE COMMENTS > rooty wrote in NotificationItem.qml:175 > Is there any way around this? Because if it's not 0.75 then it's shifted too > far down (uneven padding) > Is there any way around this? Because if it's not 0.75 then it's shifted too > far down

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

davidedmundson added a comment. > Thoughts? Valid comment. Lets use this for now, request an icon from the VDG in the actions folder, and then update this when that happens. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17963 To: GB_2, #plasma,

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pino requested review of this revision. REVISION SUMMARY Setting an overlay by name results in a QIcon for it created; OTOH, this icon is never used to create the final image in case the

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

GB_2 added a comment. In D17963#386701 , @ngraham wrote: > Hmm, this results in the menu having one colored icon and two monochrome icons. > > My gut feeling is that if we're going to use KMenuEdit's icon, perhaps we should mention it by