D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#390336 , @rooty wrote: > Is there a way to give the icon itself padding? I've been using anchors but there's nothing I can think of to anchor it to? If I anchor it to the notification text in any way, I can add

D17975: [Notifications] Add padding to notifications

rooty added a comment. There is one small problem, with almost every version I've submitted so far. The padding above the icon and below the icon is the same (7 px with 1x scaling) if Noto Sans is used as the default font, which is basically perfect. However, if another font is used,

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49132. rooty added a comment. Remove unnecessary comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49131=49132 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 AFFECTED

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49131. rooty added a comment. Use margin in bottomPart instead REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49110=49131 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 AFFECTED

D18147: Change certain integers to decimals for even padding; fix uneven padding with heading only notifications

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18147 AFFECTED FILES

D17975: [Notifications] Add padding to notifications

davidedmundson added a comment. > The end result is the same though. If the code's neater, lets see it. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham, davidedmundson Cc: broulik, Codezela,

D17975: [Notifications] Add padding to notifications

rooty added a comment. Hey @davidedmundson I know I'm a little late but should I use your suggestion instead? I just figured out how to do it using Layout.bottomMargin :D REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty,

D18145: Add an X-DocPath link to the Activities KCM

ngraham added a comment. That's correct. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18145 To: ltoscano Cc: ngraham, kde-doc-english, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg,

D18145: Add an X-DocPath link to the Activities KCM

ltoscano added a comment. If this is accepted, could it land to Plasma/5.12 and then merged directly to master? If I understand it correctly, no more releases of Plasma/5.14 are planned at this point, is it correct? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18145: Add an X-DocPath link to the Activities KCM

ltoscano created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ltoscano requested review of this revision. REVISION SUMMARY Even if the documentation does not explain the KCM in details, at least it provides a basic introduction to the concept.

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49110. rooty added a comment. Change certain integers to decimals for more even padding; fix padding in heading-only notifications REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48943=49110 BRANCH

D5189: Partial rewrite to add and update info.

ltoscano added a comment. @lueck , have your concerned been addressed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5189 To: ivanthekdefan, ltoscano, yurchor, lueck, davidedmundson Cc: kde-doc-english, plasma-devel, kvanton, jraleigh, GB_2, ragreen,

D5189: Partial rewrite to add and update info.

yurchor added a comment. Can somebody else give their +1/-1 for this differential be processed eventually? Or can Plasma team push it if they like it? Thanks in advance for your thoughts. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5189 To:

D18006: Include only the largest size for the "Next" wallpaper

ngraham added a subscriber: davidedmundson. ngraham added a comment. According to @davidedmundson, runtime memory is unchanged because we internally store a version that's resized and cropped according to the actual screen dimensions and pixel density. REPOSITORY R31 Breeze REVISION

D17659: Set parent window for dialogs

graesslin added a comment. In D17659#389728 , @volkov wrote: > I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa That is KWin's own plugin. No binary except KWin can use it. REPOSITORY R838 Flatpak Support: KDE Portal

D17706: Fix lock screen focus

graesslin added inline comments. INLINE COMMENTS > greeterapp.cpp:460 > // w->setFocus(Qt::OtherFocusReason); // FIXME > +w->setFlags(w->flags() | Qt::X11BypassWindowManagerHint); > } David already said it: we cannot do this. Changing the X11BypassWindowManagerHint flag after the

D18006: Include only the largest size for the "Next" wallpaper

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. has runtime memory been taken into account? (better with massif than with the unreliable top/ksysguard) runtime memory usage should be taken into account as well, loading a big

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart accepted this revision. mart added a comment. bah, seems very tricky to make it work properly across distributions. to me, it speaks mostly as a failure for us to control the look of our product, due to broken fonts in distros and qt font rendering still buggy, issue that

D18121: Don't lose the widget layout after Default is pressed

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18121 To: amantia, dvratil, #plasma, davidedmundson Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18121: Don't lose the widget layout after Default is pressed

amantia created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. amantia requested review of this revision. REVISION SUMMARY BUG: 400302 REPOSITORY R104 KScreen BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D18121 AFFECTED FILES

D17706: Fix lock screen focus

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > so it needs to be removed, change the focus, put flag back. We can't do that. REPOSITORY R133 KScreenLocker REVISION DETAIL

D17975: [Notifications] Add padding to notifications

rooty added a comment. @broulik If the consensus is that the notifications should stay "tight" (no padding), I'd very much prefer to add padding to the left and right of the icon (it's really stuck-on right now), and to push the notification icon down a bit if there's a bodyText.lineCount >

D17975: [Notifications] Add padding to notifications

filipf added a comment. In D17975#389769 , @rooty wrote: > In D17975#389760 , @filipf wrote: > > > FWIW if I backport the spacings and margins prior to D3560 it

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389760 , @filipf wrote: > FWIW if I backport the spacings and margins prior to D3560 it works great for me. The symmetry around the icon is better than with this diff. (only

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389695 , @broulik wrote: > We explicitly removed the padding in Plasma 5.9 to reduce popup sizes, this effectively reverts this decision… Sort of. This is basically what they looked like: F6537353:

D17975: [Notifications] Add padding to notifications

filipf added a comment. FWIW if I backport the spacings and margins prior to D3560 it works great for me. The symmetry around the icon is better than with this diff. This diff: F6537366: Screenshot_20190109_000448.png

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. In D17906#389751 , @fabianr wrote: > You are not using the default font, are you? In D17906#389713 , @mart wrote: > uuh, that's the wrong color.. that's

D17906: [kirigami] Do not use light font styles for headings (2/3)

fabianr added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D17906: [kirigami] Do not use light font styles for headings (2/3)

fabianr added a comment. The HIG states: "When the visual design calls for an area of exceptional focus, a larger typeface size may be used. In this case use a Light typeface weight to keep the stroke width similar to other styles throughout the interface" I think, if you want to have

D17659: Set parent window for dialogs

volkov added a comment. I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D17659 To: volkov, jgrulich, apol Cc: graesslin, broulik, apol, plasma-devel, kvanton,

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388803 , @ngraham wrote: > F6531451: Screenshot_20190107_145258.png > In this one, the fact that it's a header is connoted by its much larger font size and wider

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 287 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/287/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 09 Jan 2019 09:11:12 + Build duration: 5 min 47 sec and counting CONSOLE OUTPUT [...truncated 1485

D17706: Fix lock screen focus

andreyby added a comment. What do you think? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D17706 To: andreyby, davidedmundson Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

broulik added a comment. > Actually my proposal is to always show the text on the button, so you wouldn't need to drag it to see the text. And then people will complain even more about this "useless button" being "even bigger" by default now REPOSITORY R119 Plasma Desktop REVISION

D17975: [Notifications] Add padding to notifications

broulik added a comment. We explicitly removed the padding in Plasma 5.9 to reduce popup sizes, this effectively reverts this decision… REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham Cc: broulik, Codezela, abetts,

D16170: [Device Notifier] Restore busy indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a7b2ecdb12b8: [Device Notifier] Restore busy indicator (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16170?vs=46093=49060