D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 50698. enriquem added a comment. Changed tooltips No need for a new enum CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=50665=50698 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES

D18651: [Task Manager] Sort manually by default

ndavis accepted this revision. ndavis added a comment. I agree with this. REPOSITORY R119 Plasma Desktop BRANCH allow-task-re-ordering-by-default (branched from Plasma/5.15) REVISION DETAIL https://phabricator.kde.org/D18651 To: ngraham, #vdg, #plasma, hein, ndavis Cc: ndavis,

D18654: [fonts:/ KIO] Implement stat() call

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, it works great! Original coding style is kinda funky, but this seems sane enough. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18654 To:

D18651: [Task Manager] Sort manually by default

alexeymin added a comment. In D18651#403466 , @broulik wrote: > +1 first thing I change on a fresh setup me too, along with single click to open to double click  REPOSITORY R119 Plasma Desktop BRANCH

D18651: [Task Manager] Sort manually by default

broulik added a comment. +1 first thing I change on a fresh setup REPOSITORY R119 Plasma Desktop BRANCH allow-task-re-ordering-by-default (branched from Plasma/5.15) REVISION DETAIL https://phabricator.kde.org/D18651 To: ngraham, #vdg, #plasma, hein Cc: broulik, mart, plasma-devel,

D18655: Use correct window for getting ComboBox current icon pixmap

broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In widgets: - `windowHandle()` only works for top level widgets (windows),

D18654: [fonts:/ KIO] Implement stat() call

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Needed for thumbnailer to work. BUG: 234754 FIXED-IN: 5.16.0 TEST PLAN Depends

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added inline comments. INLINE COMMENTS > hein wrote in Task.qml:155 > Getting close, but `pid` is not reliable. It's not available for all tasks > (e.g. remote X11 clients). You need to use the window id role instead. I do not find a window id role, maybe I am not looking in the right

D18651: [Task Manager] Sort manually by default

hein added a subscriber: mart. hein added a comment. I suggested this, so it would be weird to say no. I'd like to get at least one more take, e.g. from @mart, though, since it's a big change. REPOSITORY R119 Plasma Desktop BRANCH allow-task-re-ordering-by-default (branched from

D18651: [Task Manager] Sort manually by default

ngraham created this revision. ngraham added reviewers: VDG, Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch changes the default Task Manager sort order to `Manually`, which better

D18646: [Colors KCM] Add search and filter

broulik updated this revision to Diff 50667. broulik edited the test plan for this revision. broulik added a comment. - Change filter into a simple `ComboBox`, simplifies code a lot - Change placeholder to "Search..." to be consistent with other KCMs - Fixed left-to-right layout issues

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.11 - Build # 324 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.11/324/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 24 Jan 2019 03:03:00 + Build duration: 45 min and counting BUILD ARTIFACTS

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 50665. enriquem added a comment. Herald added 1 blocking reviewer(s): jgrulich. Removed updateLog calls Properly initialize d->tokens Change the config dialog so that (a) 'Apply' does not become active when the user clicks on the 'Show Tokens'

D18451: [KdePlasma-Addons/POTD/EOPD] Fixed RegEx string to accommodate both HTTP/HTTPS protocols

This revision was automatically updated to reflect the committed changes. Closed by commit R114:9a2dd476cae3: [KdePlasma-Addons/POTD/EOPD] Fixed RegEx string to accommodate both HTTP/HTTPS… (authored by tagorechandanreddy, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

This revision was automatically updated to reflect the committed changes. Closed by commit R126:484a7dc89a75: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior (authored by achauvel, committed by ngraham). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D18646: [Colors KCM] Add search and filter

broulik planned changes to this revision. broulik added a comment. Alright, will change it to a `ComboBox`. We might lose the filter icon, which I quite liked, in the process, though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18646 To: broulik,

D18646: [Colors KCM] Add search and filter

ngraham added a comment. In D18646#403270 , @broulik wrote: > An alternative would be > F6581375: Screenshot_20190201_162719.png I would prefer this, but with the filter being a real combobox. In

D18620: Display shortcut badges while holding Super

This revision was automatically updated to reflect the committed changes. Closed by commit R878:6f1c66f7d202: Display shortcut badges while holding Super (authored by mvourlakos). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18620?vs=50574=50661#toc REPOSITORY R878 Latte Dock

D18101: Don't reset the moved display position

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2c5af49d3de7: Dont reset the moved display position (authored by amantia). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18101?vs=50659=50660 REVISION DETAIL

D18101: Don't reset the moved display position

amantia updated this revision to Diff 50659. amantia added a comment. Rebased REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18101?vs=49003=50659 BRANCH fix_reset_output_pos REVISION DETAIL https://phabricator.kde.org/D18101 AFFECTED FILES

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D18093 To: amantia, #plasma, dvratil Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18093: Calculate screen scaling dynamically, so it always fits to the page

amantia updated this revision to Diff 50657. amantia added a comment. Make it work with Qt 5.9 REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18093?vs=49002=50657 BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18093 AFFECTED FILES

D18596: Set combobox popups to be modal

ngraham added a comment. After living with this for a few days, I notice that now the behavior is reversed: clicking anywhere else will close but pop-up, but clicking on the button will not! REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D18091: Backport "Show unconnected displays at the right side of the main screen"https://phabricator.kde.org/D17682

amantia updated this revision to Diff 50656. amantia added a comment. Don't use QQuickItem size(), use width() directly, so it builds with Qt 5.9 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18091?vs=48951=50656 REVISION DETAIL https://phabricator.kde.org/D18091 AFFECTED FILES

D18647: Use the correct cursor when hovering over the editable part of a spinbox

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Use the I-Beam cursor when hovering the mouse over the editable part of a spinbox, just

D18646: [Colors KCM] Add search and filter

broulik added a comment. An alternative would be F6581375: Screenshot_20190201_162719.png which is a lot more obvious than a tiny filter icon. Your decision, also whether it should highlight when filtered or not (it does not in Widget Explorer

D18646: [Colors KCM] Add search and filter

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a search bar to search for schemes in the list as well as a filter to show only

D18559: Use correct sidebar back button press color

This revision was automatically updated to reflect the committed changes. Closed by commit R124:cad722aa0fa0: Use correct sidebar back button press color (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18559?vs=50363=50651 REVISION

D18640: Reset tooltip delegate label height to defaults

ngraham added inline comments. INLINE COMMENTS > main.qml:227 > width: contentWidth > -height: contentHeight > +height: undefined > If we do end up going with this patch, I'd like to see comments explaining why these are set to `undefined`. REPOSITORY R119 Plasma

D18561: Use same intro page system settings icon as in the desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R124:d5740e73d070: Use same intro page system settings icon as in the desktop file (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

pwegner created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. pwegner requested review of this revision. REVISION SUMMARY This allows e.g to tint icons specified in Action. REPOSITORY R169 Kirigami REVISION DETAIL

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. pwegner requested review of this revision. REVISION SUMMARY This allows to disable icon tinting through setting tint color to transparent. REPOSITORY R169 Kirigami REVISION DETAIL

D18642: [kio_applications] Install binary into kf5/kio subdir, like other kio binaries

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. TEST PLAN applications: & programs: urls still work. REPOSITORY R120 Plasma Workspace BRANCH

D18641: [kio_applications] Fix last dir item being shown twice

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY During porting to the new KIO::SlaveBase::listEntry() API accidentally the listEntry(entry,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel added a comment. It’s perso at hack-libre dot org REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, GB_2, ragreen, Pitel,

D18182: Fix new file creation leading to dupe items on a fresh view

McPain added inline comments. INLINE COMMENTS > davidedmundson wrote in foldermodel.cpp:170 > Also I don't think I understand this: > > - Delay this via queued connection, such that the row is available and can be > mapped > > at the point of rowsInserted() the row should be available, If not

D18182: Fix new file creation leading to dupe items on a fresh view

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:4a3fbf9116f5: Fix new file creation leading to dupe items on a fresh view (authored by hein). REPOSITORY R119

D18640: Reset tooltip delegate label height to defaults

broulik added a comment. Supposedly fixed in Qt 5.12.1? https://bugreports.qt.io/browse/QTBUG-71684 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18640 To: broulik, #plasma, #vdg Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18182: Fix new file creation leading to dupe items on a fresh view

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in foldermodel.cpp:170 > I'm a bit worried about queuing something with indexes. Indexes are only > valid at that exact moment. > > If the source model does the following: >

D18640: Reset tooltip delegate label height to defaults

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It seems Qt 5.12 changed the behavior of `contentHeight` to not include any font padding.

D18596: Set combobox popups to be modal

broulik added a comment. It's still a bit weird that the closing of combobox popups fails to function in embedded view like System Settings. Still +1 as this makes the behavior consistent with what we have on X elsewhere. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D18621: Add again a button to manually scan for wireless networks

broulik added inline comments. INLINE COMMENTS > Toolbar.qml:116 > +id: wifiRefreshButton > +enabled: false > + I would do it declaratively: enabled: !coolDownTimer.running > Toolbar.qml:124 > + > +tooltip: i18ndc("plasma-nm", "button tooltip", "Scan for new >