KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 04:37:01 + Build duration: 2 hr 0 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 100 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/100/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 04:38:21 + Build duration: 3 min 1 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 115 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/115/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Feb 2019 04:37:56 + Build duration: 2 min 55 sec and counting CONSOLE OUTPUT [...truncated

D19077: Fix long labels not being wrapped

rooty added a comment. In D19077#413826 , @filipf wrote: > If I just change Text to Labels and remove hardcoded sizes, we won't be able to fit all the text in. We would then have to increase the root height to accommodate the text. This would

D19077: Fix long labels not being wrapped

filipf added a comment. If I just change Text to Labels and remove hardcoded sizes, we won't be able to fit all the text in. We would then have to increase the root height to accommodate the text. This would only give us a good solution for the default font settings (10pt Noto Sans) with no

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added inline comments. INLINE COMMENTS > ListItemBase.qml:306 > +menuItem = newMenuItem(); > +menuItem.text = i18n("Switch all applications here"); > +menuItem.clicked.connect(function() { How about "Play all audio using this device"

D19079: Make look of Font Management KCM UI more consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks! REPOSITORY R119 Plasma Desktop BRANCH make-look-of-font-management-kcm-ui-more-consistent (branched from master) REVISION DETAIL

D19077: Fix long labels not being wrapped

ngraham added a comment. There's nothing inherently wrong with using a QQC2 `GridLayout`, BTW. We typically port these to use a Kirigami `FormLayout` when it's a settings UI with a lot of controls, but this doesn't really fall under that category. For this, the layout probably doesn't need

D19077: Fix long labels not being wrapped

filipf added a comment. Yeah this whole KCM is ... less than ideal. The problem is QML is explicitly only given an area of 360x320. To make sure all of the text fits in, the author had to resort to doing an awkward grid layout and to hardcoding font sizes (and even colors before heh).

D19079: Make look of Font Management KCM UI more consistent

GB_2 updated this revision to Diff 51877. GB_2 added a comment. Use /Cancel style message box buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51866=51877 BRANCH make-look-of-font-management-kcm-ui-more-consistent (branched from

D19077: Fix long labels not being wrapped

rooty added a comment. @ngraham can we also make the rectangle background color match the color above and below it? it kinda sticks out... REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: rooty,

D19079: Make look of Font Management KCM UI more consistent

GB_2 added a comment. In D19079#413663 , @ngraham wrote: > While we're at it, can we turn those Yes/No messageboxes into /Cancel style instead? Sure REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19079

D19079: Make look of Font Management KCM UI more consistent

ngraham added a comment. While we're at it, can we turn those Yes/No messageboxes into /Cancel style instead? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19079 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D19077: Fix long labels not being wrapped

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. +1 for the fix, but let's also use the opportunity to clean up the code a bit here and correct the improper use of hardcoded font sizes. See inline comments. INLINE COMMENTS >

D19079: Make look of Font Management KCM UI more consistent

GB_2 updated this revision to Diff 51866. GB_2 added a comment. Remove unneeded ellipses REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51855=51866 BRANCH arcpatch-D19079 REVISION DETAIL https://phabricator.kde.org/D19079 AFFECTED

D19079: Make look of Font Management KCM UI more consistent

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > Heh I think that may be a typo and the word was supposed to be "excluding". I > specifically remember having a conversation about this and we concluded that > confirmation prompts didn't count because then you

D19079: Make look of Font Management KCM UI more consistent

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in KCmFontInst.cpp:236 > The HIG says "Indicate a command that needs additional information (including > confirmation) by adding an ellipsis at the end of the button label." Heh I think that may be a typo and the word was supposed to

D19079: Make look of Font Management KCM UI more consistent

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > This one doesn't need an ellipsis. If the window/dialog that pops up when you > click on it is nothing more than a confirmation box, we don't use ellipsis. > > However the confirmation dialog that results from

D19079: Make look of Font Management KCM UI more consistent

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > KCmFontInst.cpp:236 > +itsDeleteGroupControl=new CPushButton(KGuiItem(QString(), "list-remove", > +

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. I would love some input about: - The wording of the menu entry. - The possibility of having an icon for the menu entry. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca Cc:

D19013: [plasma-pa] Increase minimum size of expanded plasmoid

vpilo updated this revision to Diff 51862. vpilo added a comment. - Review comments REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19013?vs=51698=51862 BRANCH vpilo/minimumSize REVISION DETAIL https://phabricator.kde.org/D19013

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 51858. rooty added a comment. Improve indentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=51857=51858 BRANCH lift-up-noto (branched from master) REVISION DETAIL

D19036: [notifications] Lift up notification content if one line of body text droops

rooty updated this revision to Diff 51857. rooty added a comment. Remove first two else branches / simplify REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19036?vs=51823=51857 BRANCH lift-up-noto (branched from master) REVISION DETAIL

D19079: Make look of Fonts KCM UI more consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG and make tooltips, buttons and others more consistent and better looking.

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 51852. filipf added a comment. Add topMargin so the label isn't glued to the preview image REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51851=51852 BRANCH master REVISION DETAIL

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 51851. filipf added a comment. Don't need wrapMode when lineCount is 1 REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51850=51851 BRANCH master REVISION DETAIL

D19077: Fix long labels not being wrapped

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adjusts the labels in the preview theme window so that long names do not ruin the grid layout. BUG: 372844

KDE CI: Plasma » user-manager » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/user-manager/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:32:57 + Build duration: 30 sec and counting CONSOLE OUTPUT [...truncated

D19070: Use AuthCore instead of Auth

aacid closed this revision. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D19070 To: aacid, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » sddm-kcm » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/sddm-kcm/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:32:18 + Build duration: 26 sec and counting CONSOLE OUTPUT [...truncated 250

D19069: Use AuthCore instead of Auth

aacid closed this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19069 To: aacid, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19068: Use AuthCore instead Auth

This revision was automatically updated to reflect the committed changes. Closed by commit R258:03d4bab121eb: Use AuthCore instead Auth (authored by aacid). REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19068?vs=51814=51837 REVISION DETAIL

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 104 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/104/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:27:01 + Build duration: 2 min 58 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 99 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/99/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:25:52 + Build duration: 3 min 11 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:23:07 + Build duration: 4 min 13 sec and counting CONSOLE OUTPUT

D19066: Link to AuthCore instead of Auth

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a748fb9e9be1: Link to AuthCore instead of Auth (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19066?vs=51812=51835#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

D19067: Use AuthCore instead of Auth

aacid closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19067 To: aacid, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 114 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/114/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 16 Feb 2019 09:20:52 + Build duration: 5 min 35 sec and counting CONSOLE OUTPUT [...truncated

D19063: Use AuthCore instead of Auth

This revision was automatically updated to reflect the committed changes. Closed by commit R111:cd17327111d4: Use AuthCore instead of Auth (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19063?vs=51808=51834#toc REPOSITORY R111 KSysguard Library CHANGES SINCE LAST

D19062: Link against AuthCore instead of Auth

This revision was automatically updated to reflect the committed changes. Closed by commit R134:916ff7fa7a46: Link against AuthCore instead of Auth (authored by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19062?vs=51807=51833#toc REPOSITORY R134 Discover Software Store

D19055: Use the new KAuthCore

aacid closed this revision. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D19055 To: aacid, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a subscriber: broulik. GB_2 added a comment. It seems like this is quite difficult, me and @broulik couldn't figure it out. If someone wants to take over this revision then please do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: