D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#445829 , @dfaure wrote: > Is the makeURL function still used, or should it be removed now? Yep, it is still used in a bunch of other places. INLINE COMMENTS > dfaure wrote in urlinfo.h:39 > const

D20399: [Kickoff] Anchor subtitle in KickoffItem to arrow.right

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY I meant to do this in D19874 , but I must have accidentally

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

bruns updated this revision to Diff 55793. bruns added a comment. use const REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20383?vs=55748=55793 BRANCH arcpatch-D20383 REVISION DETAIL https://phabricator.kde.org/D20383 AFFECTED FILES

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

jen6 updated this revision to Diff 55792. jen6 added a comment. remove toUpper when string comparing QString::localeAwareCompare is insensitive by default. So toUpper is not needed. and return without (); REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

jen6 added a comment. In D20386#446314 , @cfeck wrote: > Are the `toLower()` calls really needed? I would have expected that `localeAwareCompare()` is case insensitive by default. > > Also, please use `return x` instead of `return (x)`.

D20043: digitalclock: have it display a context menu onPressAndHold

apol abandoned this revision. apol added a comment. We discussed it and decided long tap is not the way to go, will have to find alternative ways to access the options on the context menu on a case-by-case basis. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

apol added a comment. I'm not sure what we win but I'm not against the optimization. INLINE COMMENTS > view.cpp:370 > +// Avoid removing the same item from the front and prepending it again > +if (!m_history.isEmpty() && m_history.first() == item) { > +return;

D20043: digitalclock: have it display a context menu onPressAndHold

GB_2 added a comment. Ping REPOSITORY R120 Plasma Workspace BRANCH digiclock REVISION DETAIL https://phabricator.kde.org/D20043 To: apol, #plasma, ngraham Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20093: Show a context menu on pressAndHold

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20093 To: apol, #plasma, mart Cc: GB_2, davidedmundson, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

cfeck added a comment. Are the `toLower()` calls really needed? I would have expected that `localeAwareCompare()` is case insensitive by default. Also, please use `return x` instead of `return (x)`. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D20386

D20203: desktoppackage: add "panelMask" property for Panel.qml

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2af721b37741: desktoppackage: add panelMask property for Panel.qml (authored by kossebau). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20113: [Desktop Theme KCM] Adapt clock to new hand rotation center options

kossebau updated this revision to Diff 55781. kossebau added a comment. Adapt to latest proposal in D20112 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20113?vs=55027=55781 BRANCH fixclockshadowhandcenter

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

kossebau added a comment. Looking around on store.kde.org, I saw quite some clocks of (old) themes which have hands that are e.g. only indicators directly at the border. Or are ghost-like pointers floating disconnected from the center. They usually compensate by having an empty region

D20112: [analog-clock] Allow themes to define hand shadow offset & hand rot center

kossebau updated this revision to Diff 55777. kossebau added a comment. Instead of using the size of a hint to define the rotation center of a hand shape, use the relative position of the (center of) hint. This allows to define rotation centers outside of the hand element, like useful

D18419: Adjust some KCMs to implement new Appearance section layout

ngraham added a comment. In D18419#446142 , @GB_2 wrote: > In D18419#400163 , @davidedmundson wrote: > > > > Improve text on existing QWidgets KCMs to conform to the HIG > > > > After this. >

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

jen6 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jen6 requested review of this revision. REVISION SUMMARY In TreeItem, there has two compare function itemNameLessThan and itemDescriptionLessThan. Those two functions were use < operator to

D19209: [sddm-kcm] Adjust Background label and button

GB_2 closed this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. In D18419#400163 , @davidedmundson wrote: > > Improve text on existing QWidgets KCMs to conform to the HIG > > After this. > > > Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG > >

D20370: [Folder View] Implement a user-configurable setting for label width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bad5d2b8973c: [Folder View] Implement a user-configurable setting for label width (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20204: Fix always full rect blur mask for panels ignoring shape from Plasma themes

This revision was automatically updated to reflect the committed changes. Closed by commit R120:65367689ea5e: Fix always full rect blur mask for panels ignoring shape from Plasma themes (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20370: [Folder View] Implement a user-configurable setting for label width

ngraham updated this revision to Diff 55749. ngraham added a comment. Rebase on master, use a JavaScript array, localize text REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20370?vs=55717=55749 BRANCH folder-view-label-width-combobox (branched

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

bruns created this revision. bruns added reviewers: Plasma, broulik, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY It is not uncommon to run the same command repeatedly. In this case, the history is

D20382: [KRunner] Move trivial check in addToHistory to the front

bruns created this revision. bruns added reviewers: Plasma, broulik, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY No functional change. TEST PLAN compiles, runs REPOSITORY R120 Plasma Workspace

KDE CI: Plasma » plasma-integration » kf5-qt5 SUSEQt5.12 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Apr 2019 15:04:51 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-integration » kf5-qt5 SUSEQt5.12 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Apr 2019 15:01:06 + Build duration: 3 min 43 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 08 Apr 2019 15:03:26 + Build duration: 1 min 14 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 08 Apr 2019 15:01:06 + Build duration: 1 min 25 sec and counting CONSOLE OUTPUT

D20381: [KDEPlatformSystemTrayIcon] Use generated DBus XML

This revision was automatically updated to reflect the committed changes. Closed by commit R135:4aa762c0a472: [KDEPlatformSystemTrayIcon] Use generated DBus XML (authored by broulik). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D20381: [KDEPlatformSystemTrayIcon] Use generated DBus XML

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. <3 INLINE COMMENTS > CMakeLists.txt:48 > > +qt5_add_dbus_interface(platformThemeSRCS > ../src/platformtheme/org.kde.StatusNotifierWatcher.xml >

D20370: [Folder View] Implement a user-configurable setting for label width

broulik added inline comments. INLINE COMMENTS > ConfigIcons.qml:266 > + > +model: ListModel { > +ListElement { text: "Narrow" } You can just use a JavaScript `Array`: model: [ i18n("Narrow"), i18n("Medium"), i18n("Wide") ] This way you can

D20381: [KDEPlatformSystemTrayIcon] Use generated DBus XML

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Saves an introspection call TEST PLAN Tray still works in VLC REPOSITORY R135 Integration

D19823: Port to the new install directory for knsrc files

bruns added a comment. Now plasma-workspace depends on KNewStuff 5.57 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19823 To: apol, ngraham Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D20368: [Folder View] Use a more reasonable minimum cell width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1c2dd97e8cd4: [Folder View] Use a more reasonable minimum cell width (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20378: Make KNS applications act more like applications

apol added inline comments. INLINE COMMENTS > KNSResource.cpp:213 > +if (knsBackend()->hasApplications()) { > +return entry().installedFiles(); > +} else if (knsBackend()->engine()->hasAdoptionCommand()) { Can't we do this in the adoption command? This way we won't have another

D20266: Add new notification plasmoid

ngraham added a comment. In D20266#445888 , @broulik wrote: > > It seems like there's no Do Not Disturb mode that stays on until manually turned off though? > > Yeah. I can add that, I guess. What should that menu entry look like?

D20378: Make KNS applications act more like applications

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This patch adds

D20377: do no install .so symlinks for private libraries

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY since they are private and we don't install any headers there is no point in installing the .so

D20266: Add new notification plasmoid

broulik added a comment. > It seems like there's no Do Not Disturb mode that stays on until manually turned off though? Yeah. I can add that, I guess. What should that menu entry look like? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20266 To:

D20375: if no xcursor is found, don't build the kcm at all

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY the code path of kcm without xcursors was broken since over a year, meaning is not tested at all and

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #26 from goodmi...@goodmirek.com --- (In reply to Nate Graham from comment #24) > *** Bug 405344 has been marked as a duplicate of this bug. *** The bug 405344 is not a duplicate of this bug 348529, although it is related. The bug 405344

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 goodmi...@goodmirek.com changed: What|Removed |Added Version|5.3.1 |5.15.4 -- You are receiving this

[Powerdevil] [Bug 348529] Turn off screen after lock screen

https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #25 from goodmi...@goodmirek.com --- (In reply to arne anka from comment #22) > (In reply to goodmirek from comment #19) > > arne anka: The issue seems to be there is not enough people able to > > contribute their manpower or money to buy

Notes for monday meeting meeting of 8/4/2019

Kai Uwe: Work done: - Attended Augsburger Linux-Info-Tag -- Feedback about Plasma was overwhelmingly positive, people love what we're doing :) - Mostly finished notification rewrite -- Patches up on phabricator, split in lib D20265 and plasmoid D20266 Diff 20265 "Introduce

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.12 - Build # 37 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

D20227: Remove player from known players list when it disappears

fvogt added inline comments. INLINE COMMENTS > content-script.js:417 > > // TODO remove it again when it goes away > players.push(player); Can be removed now? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20227 To: broulik, #plasma,

D20218: Don't hardcode default kwallet path

This revision was automatically updated to reflect the committed changes. Closed by commit R107:fd556ab25365: Dont hardcode default kwallet path (authored by davidedmundson). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20218?vs=55318=55725

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Is the makeURL function still used, or should it be removed now? INLINE COMMENTS > urlinfo.h:39 > + */ > +UrlInfo(QString path) > +: line(0), column(0) const