D20445: signalplotter: Add highdpi support

davidedmundson added a comment. > To avoid artifacts when painting beams. It might avoid it, but it doesn't explain why it makes sense. setWidth should be in logical sizes. It gets affected by the view transform. REPOSITORY R111 KSysguard Library REVISION DETAIL

D20585: [FormLayout] RFC: Use even top and bottom spacing for separator

filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The Kirigami separator has spacing below it, but not above it when in a Form Layout. I know this is not the right solution, but I

D19077: Redesign the theme preview window

filipf updated this revision to Diff 56329. filipf added a comment. add authorship info, @GB_2 you can do the same REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56314=56329 BRANCH master REVISION DETAIL

D19077: Redesign the theme preview window

ngraham added a comment. Yeah, go ahead. It's kind of a judgment call, but so much of the file is changed that I say do it. :) REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham,

D19077: Redesign the theme preview window

filipf added a comment. In D19077#450746 , @GB_2 wrote: > Fix "No Preview" icon Thanks, that fixed it! Should @GB_2 and I add ourselves as the file's authors? (never read up on how that works) REPOSITORY R123 SDDM Configuration

D20584: ProcessList: add NoNewPrivileges

topimiettinen added a comment. This is related to D20583 . Example output: ksysguardd> ps? NamePID PPIDUID GID Status User Time System Time NiceVmSize VmRss VmURss Login TracerPID TTY

D20584: ProcessList: add NoNewPrivileges

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Show Linux flag NoNewPrivileges in ksysguardd output. REPOSITORY R106 KSysguard REVISION DETAIL

D20583: process: add NoNewPrivileges

topimiettinen added a comment. F6774811: screenshot.bmp REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20583 To: topimiettinen Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D20583: process: add NoNewPrivileges

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Display Linux process flag NoNewPrivileges. REPOSITORY R111 KSysguard Library REVISION DETAIL

D20582: Only consider player gone if really no longer part of the visible DOM

fvogt added a comment. I see an opportunity for code decuplication here... Not sure how though - maybe var players = Array.prototype.slice.call(node.querySelectorAll("video,audio")); if (node.matches("video,audio")) { players.unshift(node); } REPOSITORY R856 Plasma

D20582: Only consider player gone if really no longer part of the visible DOM

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the player is reparented we get a DOM removal event which prompts us to forget the

D19857: [DownloadJob] Report total size only if known

broulik updated this revision to Diff 56318. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19857?vs=54234=56318 REVISION DETAIL https://phabricator.kde.org/D19857 AFFECTED FILES host/downloadjob.cpp To: broulik, #plasma, fvogt Cc:

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

ngraham accepted this revision. ngraham added a reviewer: broulik. ngraham added a comment. This revision is now accepted and ready to land. Perfect, UI-wise. Now it just needs a #plasma /@broulik code review. :) REPOSITORY R258 Plymouth KCM BRANCH

D20576: Add new notifications KCM

ngraham added a comment. The trash icons in the app list make me think that it's going to uninstall those apps lol REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

ngraham added a comment. In D20533#450711 , @broulik wrote: > -1 please let's cleanup / rewrite the energy info kcm first using Kirigami FormLayout and kcm components before making it prominently accessible from the UI Yeah, that makes

D19077: Redesign the theme preview window

GB_2 accepted this revision. GB_2 added a comment. Now it's great. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham, GB_2 Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty,

D19077: Redesign the theme preview window

GB_2 updated this revision to Diff 56314. GB_2 added a comment. Fix "No Preview" icon REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56310=56314 BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077

D19077: Redesign the theme preview window

ngraham accepted this revision. ngraham added a comment. ...And it saves memory too. :) REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham, GB_2 Cc: mart, GB_2, mmustac, davidedmundson,

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 56312. GB_2 added a comment. Fix initial selection bug and add load indication REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=56222=56312 BRANCH improve-the-look-of-the-plymouth-boot-splash-screen-kcm-ui

D19077: Redesign the theme preview window

filipf updated this revision to Diff 56310. filipf added a comment. set sourceSize width and height (wow that's even better than mipmap) REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56309=56310 BRANCH master REVISION

D19077: Redesign the theme preview window

ngraham added a comment. In D19077#450725 , @filipf wrote: > Also the scaled down image quality isn't that great, can I use `mipmap`? No, instead set `sourceSize` to be the size you want it displayed at. REPOSITORY R123 SDDM

D19077: Redesign the theme preview window

filipf added a comment. Also the scaled down image quality isn't that great, can I use `mipmap`? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham, GB_2 Cc: mart, GB_2, mmustac,

D19077: Redesign the theme preview window

filipf updated this revision to Diff 56309. filipf added a comment. somewhat smarter code REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56301=56309 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19077

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

broulik added a comment. I think remaining time is way too unreliable for this. We first need a way to calculate a moving average before showing it i this context imho REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D20492 To: meven, #plasma, broulik, ngraham,

D20533: Display two shortcuts to the kcm Energy Information from the battery applet

broulik added a comment. -1 please let's cleanup / rewrite the energy info kcm first using Kirigami FormLayout and kcm components before making it prominently accessible from the UI REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20533 To: meven, #plasma,

D20445: signalplotter: Add highdpi support

volkov added inline comments. INLINE COMMENTS > zzag wrote in ksignalplotter.cpp:897-899 > Could you please explain why we have to do this? To avoid artifacts when painting beams. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20445 To: volkov Cc: zzag,

D20576: Add new notifications KCM

broulik added inline comments. INLINE COMMENTS > zzag wrote in sourcesmodel.cpp:243 > A bit stupid question: how it gets deleted? Not a stupid question, most likely a leftover REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc:

D20576: Add new notifications KCM

zzag added inline comments. INLINE COMMENTS > sourcesmodel.cpp:243 > + > +KConfig *config = new KConfig(file, KConfig::NoGlobals); > + > config->addConfigSources(QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, A bit stupid question: how it gets deleted?

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 198 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/198/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 15 Apr 2019 14:54:35 + Build duration: 26 min and counting JUnit Tests Name: projectroot

D19077: Redesign the theme preview window

filipf added a comment. In D19077#450657 , @ngraham wrote: > I think that looks great! Thanks! Tiny problem though, the icon and the text get messed up when sddm-kcm is opened in System Settings, as opposed to standalone: F6774535:

D20576: Add new notifications KCM

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This completely rewrites the notifications KCM using `libnotificationmanager`. All

D20445: signalplotter: Add highdpi support

zzag added inline comments. INLINE COMMENTS > ksignalplotter.cpp:897-899 > +pen.setWidthF(1.0 / dpr); > else > +pen.setWidthF(2.0 / dpr); Could you please explain why we have to do this? REPOSITORY R111 KSysguard Library REVISION DETAIL

D19077: Redesign the theme preview window

ngraham added a comment. I think that looks great! REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham, GB_2 Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh,

D19077: Redesign the theme preview window

filipf added a comment. No preview thumbnail looks like this: F6774505: image.png REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham, GB_2 Cc: mart,

D19077: Redesign the theme preview window

filipf updated this revision to Diff 56301. filipf added a comment. - add a dummy "No preview available" rectangle when there is no preview image - adjust shadows to mimick GridDelegate REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D15423: System settings: make date/time format preview consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d4671edc8198: System settings: make date/time format preview consistent (authored by McPain, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15423?vs=41398=56302#toc

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#450414 , @dvratil wrote: > I realized we still need an icon for Thunderbolt (and thus for this KCM) - @abetts, @andreask, @trickyricky26, @ndavis - could one of you help me out, please? I have no clue about

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

abetts added a comment. Love it! REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D20569: RFC: Use more compact OSD

abetts added a comment. I like the way that this is going. I also like the way that mobile does volume. Very understated. I think this is going the right direction. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc:

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 197 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/197/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 15 Apr 2019 14:32:14 + Build duration: 4 min 1 sec and counting CONSOLE OUTPUT [...truncated

D20569: RFC: Use more compact OSD

ngraham added a comment. In D20569#450552 , @davidedmundson wrote: > There's *currently* no standalone category. If we create one, I could see that being an adequate solution, and then this could go there. REPOSITORY R120 Plasma

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

ngraham added a comment. Neato, thanks! Bugs I found: - The current splash screen isn't selected in the KCM when you open it (regression from current version) - After changing the theme and clicking Apply, the whole window hangs for about 20 seconds (happens with current version,

D20569: RFC: Use more compact OSD

davidedmundson added a comment. > Umm, just took that from the old code. What's the alternative? I guess I can just do width then without taking into acount panels Can do. We're in a layer above panels so it's fine to overlap if it ever does come up. > I don't think store.kde.org

D20569: RFC: Use more compact OSD

ngraham added a comment. In general I feel like I have to agree with Eike that this might reduce the visual distinctiveness of the system. I think the current square one has character, though I don't hate the proposed new one. However I'm not sure this design would actually solve the

motes for monday meeting of 15/4/2019

administrative: next week no meeting as many people will be in public holiday Eike: * i figured out the background for those semi-regular "my deleted favorites are coming back" user bug reports * if you switch/add menu plasmoids that use the kastats-backed favorites store, the way their code to

D20569: RFC: Use more compact OSD

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdItem.qml:31 > Screen.desktopAvailableWidth is all screens. Do you mean that? > > --- > > Dialog should understand Layout attached properties of mainItem, so you can > write the slightly more semantic: > > Layout.max

D20569: RFC: Use more compact OSD

davidedmundson added a comment. I'd like us to get in the habbit of putting new designs of theme changes on the store before we change defaults. INLINE COMMENTS > OsdItem.qml:31 > > -PlasmaCore.IconItem { > -id: icon > - > -height: parent.height -

D20569: RFC: Use more compact OSD

hein added a comment. Personally I'm not a big fan. I think the square OSD has more character and visual flair. The change proposed here looks rather cramped and removes some identity from the system. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569

D20569: RFC: Use more compact OSD

Fuchs added a comment. In D20569#450462 , @broulik wrote: > > No matter where you place it, given that you can e.g. press the volume button multiple times whilst notifications are incoming, placement will be tricky and, depending on how it is

D20569: RFC: Use more compact OSD

broulik added a comment. > Great i hope we can make notifications more compact too They will be, see D20266 , but that's not the point of this discussion REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To:

D20569: RFC: Use more compact OSD

Codezela added a comment. Great i hope we can make notifications more compact too because its too big now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: Codezela, Fuchs, filipf, zzag, plasma-devel, jraleigh, GB_2,

D19011: Thunderbolt KCM and KDED module

zzag added inline comments. INLINE COMMENTS > kded_bolt.h:34 > +class KNotification; > +namespace Bolt { > +class Device; Coding style nitpick: > Function implementations, class, struct and namespace declarations always > have the opening brace on the start of a line. > dbushelper.cpp:35 > +

D20569: RFC: Use more compact OSD

broulik added a comment. > No matter where you place it, given that you can e.g. press the volume button multiple times whilst notifications are incoming, placement will be tricky and, depending on how it is solved, jumpy. With the new system shouldn't it be too bad. I can stick the

D20569: RFC: Use more compact OSD

Fuchs added a comment. I like the first, small but centered variant. But I can see how people might want it differently: most of the time I use my PC for work. I assume if you are watching movies on it, a centered design is more of a bother than a corner one, whilst for work the center

D20569: RFC: Use more compact OSD

filipf added a comment. +1 on making the OSD more efficient, I think it's the right direction to be going in. Looking at the positioning though, it feels a bit weird to have an elongated shape more or less in the center of the screen. What about the idea to have OSDs spawn as

D20569: RFC: Use more compact OSD

zzag added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20569: RFC: Use more compact OSD

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A frequent complaint over the years is the size of the OSD. It was tried to alleviate that

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. I realized we still need an icon for Thunderbolt (and thus for this KCM) - @abetts, @andreask, @trickyricky26, @ndavis - could one of you help me out, please? I have no clue about icons... REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20492: Display time remaining to fill/empty the battery in the notification when the ac adapter is plugged/unplugged.

meven added a comment. In D20492#450265 , @ngraham wrote: > These are notifications that aren't shown by default, right? I believe so, and that the plugged out event is notified by a sound by default. But I am not sure at the moment.

D19011: Thunderbolt KCM and KDED module

GB_2 added a comment. Looks ok to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner,

D15423: System settings: make date/time format preview consistent

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein, #vdg Cc: GB_2, davidedmundson, abetts, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart