D17105: Add a new lookandfeel runner

apol added a comment. In D17105#452061 , @ngraham wrote: > That's all true, yeah. I see more and more people asking for an automatic color scheme switching system these days. So we might want to consider adding this feature in some manner. >

D17105: Add a new lookandfeel runner

kossebau added a comment. Having predefined themes for bright and dark environments might be nice, so things are more under control (and LnF themes could even come prepared with a bright & dark mode). One could even assign some key shortcuts to switch. BTW, recently someone showed off

D20583: process: add NoNewPrivileges

topimiettinen added a comment. It's not static, the thread can enable the mode with prctl(PR_SET_NO_NEW_PRIVS). I suppose Process::Status could be used? Maybe I made a mistake, now there is D20645 . REPOSITORY R111 KSysguard Library REVISION DETAIL

D20645: process: add NoNewPrivileges

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Signed-off-by: Topi Miettinen REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL

D17105: Add a new lookandfeel runner

ngraham added a comment. That's all true, yeah. I see more and more people asking for an automatic color scheme switching system these days. So we might want to consider adding this feature in some manner. Technically, I feel like for this purpose ("it's dark, I want my UI to be dark

D17105: Add a new lookandfeel runner

apol added a comment. In D17105#365231 , @ngraham wrote: > Hmm, I'm not sure how I feel about this. Seems like this could make it easy to accidentally change your LNF by accident. Changing LNF packages is in some sense a destructive since

D20612: [RFC] [Kickoff] Modernize settings window layout

GB_2 added a comment. In D20612#451981 , @ngraham wrote: > Use `onPressed` And `Layout.preferredHeight` (still doesn't fix the button height though) Just use `implicitWidth` and `implicitHeight`. REPOSITORY R119 Plasma Desktop

D20638: [Widget Explorer] Continue using a trash can icon for deleting delegates

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7cb8db2d1b30: [Widget Explorer] Continue using a trash can icon for deleting delegates (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20637: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3cbd317a3d38: [Widget Explorer] Continue using a trash can icon for Uninstallable category (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20583: process: add NoNewPrivileges

davidedmundson added a comment. Is NoNewPriveleges static for the lifespan of the process? If not, we need to expand ProcessModelPrivate::processChanged REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20583 To: topimiettinen Cc: davidedmundson,

D20612: [RFC] [Kickoff] Modernize settings window layout

ngraham updated this revision to Diff 56458. ngraham marked 2 inline comments as done. ngraham added a comment. Use `onPressed` And `Layout.preferredHeight` (still doesn't fix the button height though) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20638: [WIdget Explorer] Continue using a trash can icon for deleting delegates

ngraham created this revision. ngraham added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY After D20623 , some icons change a bit. This patch keeps

D20637: [Widget Explorer] Continue using a trash can icon for "Uninstallable" category

ngraham created this revision. ngraham added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY After D20623 , some icons change a bit. This patch keeps

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added a comment. @broulik Do you want to commandeer this revision and do the rest? REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: abetts, ngraham, broulik, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 updated this revision to Diff 56446. GB_2 marked 8 inline comments as done. GB_2 added a comment. Address some comments REPOSITORY R258 Plymouth KCM CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20549?vs=56312=56446 BRANCH

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in kcm.cpp:211 > This isn't a signal, also why do you need to reload when saving? It's not > like any themes could magically appear here? It resets it if you cancel the action, so the apply button is enabled again and the selection

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

broulik added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:74 > I think it really does. Otherwise the whole UI freezes for 20 seconds and you > think it's died. At least with the progress bar, you know something's > happening. Ah, it calls `update-alternatives` internally,

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

ngraham added inline comments. INLINE COMMENTS > broulik wrote in main.qml:74 > I don't think this "progress" bar adds much value I think it really does. Otherwise the whole UI freezes for 20 seconds and you think it's died. At least with the progress bar, you know something's happening.

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

broulik added inline comments. INLINE COMMENTS > kcm.cpp:88 > +m_newStuffDialog->winId(); // so it creates the windowHandle(); > connect(m_newStuffDialog.data(), ::DownloadDialog::accepted, > this, ::load); > connect(m_newStuffDialog.data(),

D20635: Show Vaults action only for local folders

broulik created this revision. broulik added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN I got "Mount this vault" entries in `remote:/` KIO, now I don't get them anymore `mountPoint` was empty

D17410: Add alternatives button to applet configuration in panel edit mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c308122688ee: Add alternatives button to applet configuration in panel edit mode (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 updated this revision to Diff 56435. GB_2 added a comment. Move `currentApplet.applet.prepareContextualActions();` to `onVisualParentChanged` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55960=56435 BRANCH arcpatch-D17410

D20576: Add new notifications KCM

GB_2 added a comment. In D20576#451805 , @ngraham wrote: > Yeah, I was thinking of the Breeze icon theme one, which IMO looks better: > > F6777816: Screenshot_20190417_074431.png > > I agree that

D20576: Add new notifications KCM

ngraham added a subscriber: ndavis. ngraham added a comment. In D20576#451796 , @GB_2 wrote: > Hmm, it seems like the Plasma theme `list-remove` is different from the normal Breeze icon theme `list-remove`. I think we should have the icon from

D17410: Add alternatives button to applet configuration in panel edit mode

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigOverlay.qml:227 > > +currentApplet.applet.prepareContextualActions(); > handle.x = currentApplet.x; This is never triggered when

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, jguidon, hannahk,

D20576: Add new notifications KCM

GB_2 added a comment. Hmm, it seems like the Plasma theme `list-remove` is different from the normal Breeze icon theme `list-remove`. I think we should have the icon from the Plasma theme in the Breeze icon theme too, but with a different name, so we don't overwrite the existing one.

D20576: Add new notifications KCM

mmustac added a comment. What about edit-clear-symbolic or window-close (I think this would be the same as for the dismiss action in the widget?) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: mmustac, ngraham, zzag,

D20576: Add new notifications KCM

broulik added a comment. List-remove looks awful in this context F6777476: Screenshot_20190417_105550.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: ngraham, zzag,

D20631: Support CriticalNotification window type

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D20631

D20624: Add missing window types to WindowInfo

This revision was automatically updated to reflect the committed changes. Closed by commit R130:9436a2c1afe4: Add missing window types to WindowInfo (authored by broulik). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE

D20624: Add missing window types to WindowInfo

broulik created this revision. broulik added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `Notification` and `ToolTip` could be set but not queried for TEST PLAN Compiles REPOSITORY

D19077: Redesign the theme preview window

This revision was automatically updated to reflect the committed changes. Closed by commit R123:9094e982ff0c: Redesign the theme preview window (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56329=56411

D20612: [RFC] [Kickoff] Modernize settings window layout

broulik added a comment. +1 INLINE COMMENTS > ConfigGeneral.qml:44 > Layout.minimumWidth: previewFrame.width + units.smallSpacing * 2 > Layout.maximumWidth: Layout.minimumWidth > Layout.minimumHeight: previewFrame.height + units.smallSpacing * > 2 Did