D20746: Remove disable for showing only minimized tasks on Icons only task manager

broulik added a comment. But what happens if you have an app pinned and minimize its window? Then the app will always show regardless of whether it's minimized or not. On the other hand, we have the same issue for windows from the same activity or desktop, so I don't see why this particular

D20773: [Task Manager] Bring to current desktop with middle-click

thsurrel updated this revision to Diff 56865. thsurrel added a comment. Fixes as per Nate's comments. Thanks for the review! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20773?vs=56842&id=56865 BRANCH arc_middleclick REVISION DETAIL https:/

D20645: process: add NoNewPrivileges

topimiettinen updated this revision to Diff 56866. topimiettinen added a comment. update also remote protocol REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20645?vs=56551&id=56866 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D20773: [Task Manager] Bring to current desktop with middle-click

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a416f16b562b: [Task Manager] Bring to current desktop with middle-click (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20773?vs=56865

D19924: [TabBar] Update height when TabButtons are added dynamically

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. the code looks super weird but yeah, seems needed :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19924 To: broulik, #plasma, mart Cc: pl

D19857: [DownloadJob] Report total size only if known

This revision was automatically updated to reflect the committed changes. Closed by commit R856:3989f42ac5f0: [DownloadJob] Report total size only if known (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19857?vs=56318&

D19924: [TabBar] Update height when TabButtons are added dynamically

This revision was automatically updated to reflect the committed changes. Closed by commit R858:4cc5649da9b6: [TabBar] Update height when TabButtons are added dynamically (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.k

D20265: Introduce libnotificationmanager

mart added inline comments. INLINE COMMENTS > jobsmodel.cpp:72 > +{ > +static QWeakPointer s_instance; > +if (!s_instance) { any reason to go this way instead of Q_GLOBAL_STATIC ? I guess you want to have cases in which none of it is ever created? tough the case would be when there are

D20490: Rewrite notifications dataengine to work with libnotificationmanager

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. without the new plasmoid running shis actually doesn't work REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20490 To: broulik, #plasma, mart Cc: pla

D20491: Rewrite applicationjobs dataengine to work with libnotificationmanager

mart added inline comments. INLINE COMMENTS > kuiserverengine.cpp:80 > +// don't init, applicationjobs engine should just passively listen > +//m_jobsModel->init(); > this is actually needed for retrocompatibility REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricat

D20490: Rewrite notifications dataengine to work with libnotificationmanager

mart added inline comments. INLINE COMMENTS > notificationsengine.cpp:64 > +} > +}); > } needs to call init() here and Server::self().init(); needs to be somewhere REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20490 To: broulik, #plasma, mart C

D20786: ProcessList: add support for cgroups

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Signed-off-by: Topi Miettinen REPOSITORY R106 KSysguard BRANCH processlist-add-cgroup REVISION DETAIL https://

D20786: ProcessList: add support for cgroups

topimiettinen added a comment. Sample output: ksysguardd> ps? NamePID PPIDUID GID Status User Time System Time NiceVmSize VmRss VmURss Login TracerPID TTY Command IO Priority Class IO Priority NNP CGroup s d

D20787: process: add support for cgroups

topimiettinen created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. topimiettinen requested review of this revision. REVISION SUMMARY Signed-off-by: Topi Miettinen REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabrica

D20787: process: add support for cgroups

topimiettinen added a comment. F6790730: screenshot2.png REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20787 To: topimiettinen, #plasma, hein Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, al

D20266: Add new notification plasmoid

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CompactRepresentation.qml:101 > +font.pointSize: -1 > +// FIXME fontSizeMode is awful but FontMetrics also doesn't cut > it > +font.pixe

D20788: Reset model when there are new available connections

McPain created this revision. McPain added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. McPain requested review of this revision. REVISION SUMMARY BUG: 406765 NetworkManager will remove all conn

D20787: process: add support for cgroups

apol added inline comments. INLINE COMMENTS > process.h:215 > > +QString& cGroup() const; // REF, make non-ref later! > +void setCGroup(const QString &cGroup); ///< Linux Control Group (cgroup) Just don't return &? I don't understand the comment. REPOSITORY R111 KSysguard Library R

D20576: Add new notifications KCM

mart added inline comments. INLINE COMMENTS > broulik wrote in sourcesmodel.cpp:243 > Not a stupid question, most likely a leftover delete? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20576 To: broulik, #plasma, #vdg Cc: mart, ndavis, GB_2, mmustac, ngraham

D20787: process: add support for cgroups

davidedmundson added a comment. Thanks INLINE COMMENTS > process.h:215 > > +QString& cGroup() const; // REF, make non-ref later! > +void setCGroup(const QString &cGroup); ///< Linux Control Group (cgroup) may as well make it non-ref now. I assume that ref pattern existed as an old

D20645: process: add NoNewPrivileges

davidedmundson added a comment. Do you have KDE commit access? REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D20645 To: topimiettinen, davidedmundson Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, a

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

ngraham added a comment. This doesn't actually work for me. Upon opening, the following is printed to the console: org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared library was not found." Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins", "/us

App Stores in Plasma

We have entered a new era where software is delivered direct to the user. Well new for Linux desktop users anyway. Our Discover app now delivers software from Flatpaks, Snaps and now Appimagehub. With Flatpaks I think we just let whoever installed Flatpak on the system say which sources to use an

D20533: Display a shortcut to the kcm Energy Information from the battery applet context menu

meven updated this revision to Diff 56903. meven added a comment. Check the energy information is available before showing a link to it, don't show a link to it from the battery applet REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20533?vs=56602&

D19011: Thunderbolt KCM and KDED module

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Should we really wait until those are merged and not have the new layout in Plasma 5.16? Merging these will take quite some time and I don't see how it would make a difference layout-wise. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D

D20645: process: add NoNewPrivileges

topimiettinen added a comment. In D20645#455416 , @davidedmundson wrote: > Do you have KDE commit access? No, I only started hacking KDE a few days ago... REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://ph

D20787: process: add support for cgroups

topimiettinen updated this revision to Diff 56908. topimiettinen added a comment. update per comments from @davidedmundson and @apol REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=56891&id=56908 BRANCH master REVISION DETAIL https:/

D20645: process: add NoNewPrivileges

ngraham added a comment. I can land it for you now since you used `arc` to submit the patch. :) REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D20645 To: topimiettinen, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_

D20645: process: add NoNewPrivileges

This revision was automatically updated to reflect the committed changes. Closed by commit R111:10ba98f7eebb: process: add NoNewPrivileges (authored by topimiettinen, committed by ngraham). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20645?vs=5686

D20583: process: add NoNewPrivileges

topimiettinen abandoned this revision. topimiettinen added a comment. Abandoned in favour of D20645 . REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D20583 To: topimiettinen Cc: davidedmundson, plasma-devel, jraleigh, GB_

D20792: Avoid nesting Controls in TextField

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Label now has an extra mousearea conflicting with TextField's mouse area.

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham updated this revision to Diff 56919. ngraham added a comment. Remember checked state for Color radio button REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20747?vs=56840&id=56919 BRANCH modernize-fifteenpuzzle-settings-window (branched from

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout

ngraham updated this revision to Diff 56920. ngraham marked an inline comment as done. ngraham added a comment. Tweak UI according to review comments REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20747?vs=56919&id=56920 BRANCH modernize-fifteenpuz

D20792: Avoid nesting Controls in TextField

This revision was automatically updated to reflect the committed changes. Closed by commit R858:06ea48cd5d4a: Avoid nesting Controls in TextField (authored by davidedmundson). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20792?vs=5

D20747: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and improve UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:ad8f253d8c76: [FifteenPuzzle] Port configuration window to QQC2 and Kirigami.FormLayout and… (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

ngraham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout - Adjust some strings to be more natural - Fix some incorrect strings when being an Activity

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

ngraham updated this revision to Diff 56926. ngraham added a comment. Also correct category icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20796?vs=56925&id=56926 BRANCH modernize-pager-settings-window (branched from master) REVISION DETAIL

D20797: [dict] Modernize configuration window

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch bumps the QtQuickControls from version 1 to 2 and makes use of Kirigami's ScrollablePage since the mouse scroll wheel work

D20797: [dict] Modernize configuration window

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Why doesn't mouse wheel scrolling with with `ScrollView`? That seems odd and unexpected. I would recommend we use that component and figure out why it doesn't work. Also it seem

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

GB_2 added a comment. Looks good UI-wise. INLINE COMMENTS > configGeneral.qml:136 > +} > +QtControls.RadioButton { > +id: noTextRadio Default radio buttons should be at the top. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20796 To: ngrah

D20797: [dict] Modernize configuration window

filipf added a comment. In D20797#455651 , @ngraham wrote: > Why doesn't mouse wheel scrolling with with `ScrollView`? Not sure, but will investigate further. Another issue with the QQC2 ScrollView is that it's also kind of inferior

Re: App Stores in Plasma

On Wed, Apr 24, 2019 at 5:29 PM Jonathan Riddell wrote: > > We have entered a new era where software is delivered direct to the user. > Well new for Linux desktop users anyway. Our Discover app now delivers > software from Flatpaks, Snaps and now Appimagehub. > > With Flatpaks I think we just

D20797: [dict] Modernize configuration window

ngraham added a comment. You can add internal padding yourself, and the scrollbad floating above everything is an implementation issue IIRC REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20797 To: filipf, dfaure, ngraham, #vdg, #plasma Cc: plasma-devel, jrale

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

ngraham updated this revision to Diff 56941. ngraham marked an inline comment as done. ngraham added a comment. Re-arrange radio buttons so the default one is on top REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20796?vs=56926&id=56941 BRANCH mod