D21228: [Touchpad KCM] Load previous setting on reboot

fvogt added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:34 > > +const QSet configProps = { > +QStringLiteral("enabled"), `static`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21228 To: atulbi, ngraham, romangg, davidedmundson Cc: fvogt, da

Re: Review Request: plasma-thunderbolt

On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > > Thus I'd kindly ask you to take one more look at the codebase [1] and let > > me know if there are any more issues to fix, or if we can proceed to > > includ

Re: Review Request: plasma-thunderbolt

On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote: > El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > > Hi all, > > > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt > > KCM for Plasma. I initially submitted the code as a

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/23/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 16 May 2019 09:13:56 + Build duration: 2 min 41 sec and counting CONSOLE OUTPUT [...tr

D20972: [sidebar] Make search field not glued to the separator

davidedmundson added a comment. > When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it From what? Should they be there? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D20972 To: filipf, #vdg, ngraham, davi

D21239: Port knsbackendtest to ecm_add_test

palimaka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. palimaka requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D21239 AFFECTED FILES libdiscover/backen

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 09:59:37 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT [...truncated 2

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/24/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 16 May 2019 09:59:22 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 09:59:37 + Build duration: 28 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 13 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 10:28:21 + Build duration: 2 min 24 sec and counting JUnit Tests Name: (root) Fai

D20585: [FormLayout] Use even top and bottom spacing for separator

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. I don't like adding a new property to separator for doing duck typing... even is really ugly and errorprone as well, but i would prefer Layout.topMargin: item.toString().indexOf

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 233 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/233/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 10:02:57 + Build duration: 42 min and counting CONSOLE OUTPUT [...truncated 527 line

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 10:28:22 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.12/38/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 10:10:45 + Build duration: 44 min and counting CONSOLE OUTPUT [...truncated

D21228: [Touchpad KCM] Load previous setting on reboot

romangg updated this revision to Diff 58164. romangg added a comment. - Fix loading, code style, shared cfg ptr REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21228?vs=58131&id=58164 BRANCH arcpatch-D21228 REVISION DETAIL https://phabricator.kd

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 10:47:39 + Build duration: 1 hr 1 min and counting JUnit Tests Name: projec

D21228: [Touchpad KCM] Load previous setting on reboot

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > touchpadconfigcontainer.cpp:59 > +backend->applyConfig(); > +} > +else if (backend->getMode() == TouchpadInputBackendMode::XSynaptics) {

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 234 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/234/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 10:47:55 + Build duration: 1 hr 24 min and counting JUnit Tests Name: projectroot F

D21228: [Touchpad KCM] Load previous setting on reboot

This revision was automatically updated to reflect the committed changes. romangg marked an inline comment as done. Closed by commit R119:5afc24db67ed: [Touchpad KCM] Load previous setting on reboot (authored by atulbi, committed by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/25/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 16 May 2019 13:16:20 + Build duration: 3 min 19 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 13:16:27 + Build duration: 3 min 33 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 13:16:27 + Build duration: 5 min 58 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 30 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/30/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 13:20:23 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncated 263 l

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 13:20:10 + Build duration: 14 min and counting CONSOLE OUTPUT [...truncated 258 lines

Plasma 5.16 branched

I have branched master into Plasma/5.16 for the released git repos bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi kactivitymanagerd kde-cli-tools kdecoration kde-gtk-config kdeplasma-addons kgamma5 khotkeys kinfocenter kmenuedit kscreen kscreenlocker ksshaskpass ksysguard

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.12/39/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 13:20:23 + Build duration: 38 min and counting

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 14:08:15 + Build duration: 3 min 10 sec and counting JUnit Tests Name: (root) Fai

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 14:08:16 + Build duration: 4 min 55 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 15 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 14:08:17 + Build duration: 9 min 9 sec and counting JUnit Tests Name: (root) Fail

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 16 May 2019 14:08:19 + Build duration: 1 hr 1 min and counting JUnit Tests Name: projec

[Powerdevil] [Bug 189456] powerdevil should not suspend when computer is being shutdown

https://bugs.kde.org/show_bug.cgi?id=189456 Manuel López-Ibáñez changed: What|Removed |Added CC||lopeziba...@gmail.com --- Comment #30 fro

D21228: [Touchpad KCM] Load previous setting on reboot

atulbi added a comment. Thank you so much for fixing it. Wanted it to on beta. INLINE COMMENTS > romangg wrote in libinputtouchpad.cpp:426 > Why this write back? What's configProps. Yeah realized later that there is no need to write config here. So no need for configProps. Should I open a

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/13/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 18:10:41 + Build duration: 4 min 44 sec and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/14/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 May 2019 18:46:08 + Build duration: 2 min 6 sec and counting JUnit Tests Name: (roo

D16425: Added new Suspend then Hibernate option

reverendhomer added a comment. Hi, In D16425#465325 , @avaldes wrote: > In D16425#465321 , @ngraham wrote: > > > UI looks good enough for now. But is this the full diff? It seems like something

D21246: Search also legacy location for knsrc files

arojas created this revision. arojas added reviewers: leinir, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY Discover 5.16 beta only searches for knrsc files in the new /usr/share/knsrcfiles location, but

D21246: Search also legacy location for knsrc files

arojas updated this revision to Diff 58177. arojas added a comment. Actually remove the conditional since 5.16 depends on KF 5.58 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21246?vs=58176&id=58177 REVISION DETAIL https://phabricator.k

D21147: Null pointer dereference at ksysguard

davidedmundson added a comment. > I don't know the procedure though; should I do anything? You can update a diff REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21147 To: gkaragiannidis Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D20222: Plasma-Workspace. The last checkbox in the widget settings

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Generally I don't like things being blocked for no discernable reason. It makes toggling between two things order dependent. > If the user disables the last checkbox, al

D20901: Hide the new NNP column by default

This revision was automatically updated to reflect the committed changes. Closed by commit R111:7904e204a12c: Hide the new NNP column by default (authored by topimiettinen, committed by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D19865: Linux softraid: Define _GNU_SOURCE for pipe2

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D19865 To: awilcox, #plasma, davidedmundson, broulik Cc: plasma-devel,

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

davidedmundson added a comment. > @broulik Do you want to commandeer this revision and do the rest? What is "the rest" ? REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: davidedmundson, abetts, ngraham, bro

D18884: Workaround to prevent recursive handling of wakeup

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > Under certain circumstances, Core::onResumingFromIdle triggers an action, which causes Core::resumingFromIdle to be emitted. Can you expand on what action ca

D18579: Rework Sensor Browser

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as requst changes due till we get the minor comments from zzag done REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D18579 To: t

D17704: Copy to clipboard always copy English texts

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Am I right that this can be closed as D17773 obsoletes this. Please reopen this if it's still relevant. REPOSITORY R102

D16425: Added new Suspend then Hibernate option

avaldes added a comment. > This patch doesn't seem to work for me. I have Arch Linux, powerdevil-5.15.5-1 and your patch applied. After clicking the check-box the "Apply" button doesn't get active. Therefore, this setting is not being saved. Did you enable the Suspend Session option too?

D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 added a comment. In D20549#466129 , @davidedmundson wrote: > What is "the rest" ? The open inline comments. REPOSITORY R258 Plymouth KCM REVISION DETAIL https://phabricator.kde.org/D20549 To: GB_2, #plasma, #vdg, ngraham, brou

D20222: Plasma-Workspace. The last checkbox in the widget settings

pavelmos added a comment. In D20222#466116 , @davidedmundson wrote: > Generally I don't like things being blocked for no discernable reason. It makes toggling between two things order dependent. > > > If the user disables the last checkbox,

D21246: Search also legacy location for knsrc files

arojas abandoned this revision. arojas added a comment. OK I see in https://phabricator.kde.org/D19340 this is intentional REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21246 To: arojas, leinir, apol Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel,