D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread Eike Hein
hein added a comment. I wouldn't call this implementation ready for frameworks, though - it just resets all the time, which is very slow as it forces views to destroy and recreate delegates instead of just updating them. A better implementation would just (re)filter source rows corresponding

D21357: User Switcher Plasma applet: Option to not lock screen on switch user session action

2019-05-22 Thread Alexey Murz Korepov
Murz updated this revision to Diff 58527. Murz added a comment. Add skip locking on New Session action too. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21357?vs=58525&id=58527 REVISION DETAIL https://phabricator.kde.org/D21357 AFFECTED FILES applets/userswitcher/package/cont

D21357: User Switcher Plasma applet: Option to not lock screen on switch user session action

2019-05-22 Thread Alexey Murz Korepov
Murz updated this revision to Diff 58525. Murz added a comment. Fixed saving configuration value and swap actions CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21357?vs=58522&id=58525 REVISION DETAIL https://phabricator.kde.org/D21357 AFFECTED FILES applets/userswitcher/packag

D21357: User Switcher Plasma applet: Option to not lock screen on switch user session action

2019-05-22 Thread Alexey Murz Korepov
Murz created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Murz requested review of this revision. REVISION SUMMARY On home computers for family usage users very often switch between family member account sessions, so always entering passwords is very a

D21341: Call KRunner KRunner

2019-05-22 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21341 To: ngraham, #vdg, #plasma, ndavis Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ma

D21343: Call KRunner KRunner

2019-05-22 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0c8fe93982e: Call KRunner KRunner (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21343?vs=58478&id=58503 REVISION DETAIL https://ph

D21341: Call KRunner KRunner

2019-05-22 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:98b53a3667f2: Call KRunner KRunner (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21341?vs=58499&id=58501 REVISION DETAIL https://

D21341: Call KRunner KRunner

2019-05-22 Thread Nathaniel Graham
ngraham updated this revision to Diff 58499. ngraham added a comment. Found one more REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21341?vs=58472&id=58499 BRANCH call-krunner-krunner (branched from master) REVISION DETAIL https://phabricator

D21343: Call KRunner KRunner

2019-05-22 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Makes sense to me. "Run command" is far too vague. The first time I saw it, I thought it would let me run a command or bash script instead of opening KRunner. REPOSITORY R119 Plasma Deskt

D21341: Call KRunner KRunner

2019-05-22 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Makes sense to me. "Run command" is far too vague. The first time I saw it, I thought it would let me run a command or bash script instead of opening KRunner. REPOSITORY R120 Plasma Works

D21348: Add simple README

2019-05-22 Thread Simon Redman
sredman created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sredman requested review of this revision. REVISION SUMMARY Add a simple README for the PulseAudio Qt project TEST PLAN Read the README and verify that it seems to make sense REPOSITORY

D21347: [Night Light KCM] Display the kcm on X11 platform

2019-05-22 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21347 AFFECTED FILES

D21346: [libcolorcorrect] Allow color correction on X

2019-05-22 Thread Vlad Zagorodniy
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH native-redshift REVISION DETAIL https://phabricator.kde.org/D21346 AFFECTED FIL

Proposal: passing user idle time to systemd-logind

2019-05-22 Thread Germano Massullo
Hello, I am writing to you to propose the following reasoning, hoping that it can help making easier (just a bit) third parties development work on Linux. I am currently developing BOINC client user idle time detection on Linux systems (both graphical or tty sessions) After some studies I started w

D21335: Don't write a anti-aliasing settings from startkde

2019-05-22 Thread Bhushan Shah
bshah added a comment. This revision have a follow up revisions to plasma-desktop, please wait before reviewing this one. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21335 To: bshah Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, l

D21343: Call KRunner KRunner

2019-05-22 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Plasma uses inconsistent terminology to refer to KRunner, callin

D21082: Fix lid open/closed configurations

2019-05-22 Thread Robert Hoffmann
hoffmannrobert added a comment. I added some more fixes: - The OSD was displayed even on a closed laptop panel. - With more than two screens, using the OSD always generated an "extend to right" configuration, even if "extend to left", "clone", or "disable external/internal" was selecte

D21082: Fix lid open/closed configurations

2019-05-22 Thread Robert Hoffmann
hoffmannrobert added a comment. In D21082#463848 , @romangg wrote: > This is the real issue. Why are the screen positions scrambled around although there should be a config from before shutdown/suspend (not the lidOpened one), that has the curre

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:ccec47da6d36: Get PaginateModel class ready for frameworks (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21336?vs=58465&id=5847

D21341: Call KRunner KRunner

2019-05-22 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We are currentlly very inconsistent how we refer to KRunner, impairing comprehensibility am

D21082: Fix lid open/closed configurations

2019-05-22 Thread Robert Hoffmann
hoffmannrobert updated this revision to Diff 58471. hoffmannrobert added a comment. - Fix OSD displayed on closed laptop panel. - Fix generated configurations if there are more than two screens. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21082?vs=5776

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. nice 🐿 REPOSITORY R134 Discover Software Store BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21336 To: apol, davidedmundson Cc: davidedmundson, pla

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 58465. apol added a comment. More documentation REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21336?vs=58464&id=58465 BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21336 AFFECTED F

D21336: Get PaginateModel class ready for frameworks

2019-05-22 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Some API documentation of the properties Added a d-pointer Coding style REPOSITORY R134 Discover Software Store BRANCH Plasma/5.

D21335: Don't write a anti-aliasing settings from startkde

2019-05-22 Thread Bhushan Shah
bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Writing a config files in $HOME at start-up is wrong way of setting defaults, If defaults needs to be set, they should be set by krdb

D15247: Show tooltips in krunner

2019-05-22 Thread Oleg Solovyov
McPain added a comment. In D15247#364814 , @mart wrote: > In D15247#341864 , @McPain wrote: > > > Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386