D21507: Remove DefaultListItemBackground animation

2019-05-30 Thread Nathaniel Graham
ngraham added a comment. I would guess that the code is somewhere in https://cgit.kde.org/kirigami.git/tree/src/controls/private/ActionButton.qml REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH remove-defaultlistitembackground-animation (branched from master) REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 26 - Still Failing!

2019-05-30 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/26/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 31 May 2019 03:14:27 + Build duration: 2 min 13 sec and counting CONSOLE OUTPUT

A call for contributors as I'm stepping down as Breeze GTK's maintainer

2019-05-30 Thread OldSchoolThemer
I believe it is time to look for a new Breeze GTK maintainer. The truth is that the numerous issues surrounding GTK have demotivated me over the years and other contributors have carried on while I've become more of a drive-by contributor. The entire theme was refactored in SASS without me

D21494: Close KSplash when the desktops are visible

2019-05-30 Thread Kai Uwe Broulik
broulik added a comment. Also mind that we load the image asynchronously, so maybe we need a signal that a wallpaper plugin can emit to signal it's ready. Perhaps have the QML define a `signal` and connect from c++ and only if it's present wait for it (for compat) REPOSITORY R120 Plasma

D21494: Close KSplash when the desktops are visible

2019-05-30 Thread Aleix Pol Gonzalez
apol added a comment. In D21494#472154 , @davidedmundson wrote: > Whilst I love this patch, I think we may need another patch somewhere in the stack to make the desktops not announce they're done till they've actually loaded their wallpaper.

D21507: Remove DefaultListItemBackground animation

2019-05-30 Thread Björn Feber
GB_2 added a subscriber: mart. GB_2 added a comment. In D21507#472295 , @ngraham wrote: > Nice. Also needs to be done for dropdown menus in Kirigami; see Discover's "sources" pop-up menu for an example that's not affected by this (but probably

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

2019-05-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=304696 Christoph Feck changed: What|Removed |Added CC||yst...@posteo.net --- Comment #15 from

D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-05-30 Thread Aleix Pol Gonzalez
apol added a comment. Trying it locally I don't have the feeling that it's slower, networkmanager has the information internally after all. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D21501 To: apol, #plasma, jgrulich Cc: ngraham,

D21507: Remove DefaultListItemBackground animation

2019-05-30 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. Also needs to be done for dropdown menus in Kirigami; see Discover's "sources" pop-up menu for an example that's not affected by this (but probably should be...) REPOSITORY R858

D21507: Remove DefaultListItemBackground animation

2019-05-30 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This makes it consistent with the QWidget style. TEST PLAN Hover over QQC2 combobox items.

D15247: Show tooltips in krunner

2019-05-30 Thread Nathaniel Graham
ngraham added a comment. I am still not actually getting any tooltips when I hover over an elided entry. F6860589: Screenshot_20190530_114108.png REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D15247 To: McPain, #plasma,

D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-05-30 Thread Nathaniel Graham
ngraham added a comment. Will this delay the full representation's ability to quickly display the network list when opened? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D21501 To: apol, #plasma, jgrulich Cc: ngraham, plasma-devel,

D21497: fill layouts from X server when there are no layouts in config

2019-05-30 Thread Nathaniel Graham
ngraham added a comment. The paths in this diff seem wrong (`BUILD/plasma-desktop-5.15.4/kcms/keyboard/keyboard_config.cpp`). Also the repo it's intended for is not specified. It would be very helpful if you could use `arc` for patches in the future.

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

2019-05-30 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Calculator widget's button labels were not scaling in size as the widget got bigger,

D21435: [ActionTextField] Make QML tooltip consistent

2019-05-30 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R169:e5bf8cff95c7: [ActionTextField] Make QML tooltip consistent (authored by GB_2). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21435?vs=58738=58916 REVISION

D21435: [ActionTextField] Make QML tooltip consistent

2019-05-30 Thread Björn Feber
GB_2 added a comment. @mart Can I land this? REPOSITORY R169 Kirigami BRANCH actiontextfield-make-qml-tooltip-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D21435 To: GB_2, #plasma, #vdg, #kirigami, ngraham Cc: ngraham, mart, ognarb, #vdg,

D19829: kicker: add option to make root level icons visible

2019-05-30 Thread Björn Feber
GB_2 added a comment. Ping @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-05-30 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. apol requested review of this revision. REVISION SUMMARY This was implemented as an optimisation in Plasma

D14830: Add "Configure Displays" context menu entry on the desktop

2019-05-30 Thread Marco Martin
mart added a comment. if this would be done, i would prefer for the kcm once ported to qml to be embedded in the desktop settings window REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14830 To: broulik, #plasma, #vdg, fischbach, harmathy, davidedmundson

D21497: fill layouts from X server when there are no layouts in config

2019-05-30 Thread Oleg Solovyov
McPain updated this revision to Diff 58911. McPain added a comment. 1. Overwrite `configureLayouts` based on whether `layouts` is empty or not 2. Make sure fetched layouts were saved to config CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58889=58911 REVISION DETAIL

D21494: Close KSplash when the desktops are visible

2019-05-30 Thread David Edmundson
davidedmundson added a comment. Whilst I love this patch, I think we may need another patch somewhere in the stack to make the desktops not announce they're done till they've actually loaded their wallpaper. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21492: Remove double look-ups

2019-05-30 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1abcdd51839d: Remove double look-ups (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21492?vs=58876=58896#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21492: Remove double look-ups

2019-05-30 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > shellcorona.cpp:1068 > +auto itDesktop = m_desktopViewforId.find(idx); > +if (itDesktop == m_desktopViewforId.constEnd()) { > return; Compare with

D21497: fill layouts from X server when there are no layouts in config

2019-05-30 Thread Oleg Solovyov
McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY BUG: 348198 TEST PLAN 1. move ~/.config/kxkbrc 2. connect a USB keyboard 3. layout changing works REPOSITORY R119 Plasma

D15247: Show tooltips in krunner

2019-05-30 Thread Oleg Solovyov
McPain added a comment. In D15247#364814 , @mart wrote: > In D15247#341864 , @McPain wrote: > > > Additionally, tooltips are glitching if you move the mouse pointer too fast between items{F6324386

D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

2019-05-30 Thread Antonio Rojas
arojas added a comment. Just a FYI, Arch is going switch away from mkinitcpio https://lists.archlinux.org/pipermail/arch-dev-public/2019-May/029570.html (Not saying this wouldn't be useful for the time being) REPOSITORY R258 Plymouth KCM REVISION DETAIL