D16425: Added new Suspend then Hibernate option

avaldes marked 5 inline comments as done. avaldes added a comment. Added changes based on recent comments. INLINE COMMENTS > abalaji wrote in suspendsessionconfig.cpp:106 > Stray line swap Done on purpose to change the UI: F6822188: suspendThenHibernate.png

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 58969. avaldes added a comment. Added new Suspend then Hibernate option Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like the following

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Friendly ping! Since the behaviour is already different, can we merge this one and work on the SDDM part in a later PR? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc:

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. In D19829#472621 , @ngraham wrote: > @i.Dark_Templar can you land this yourself? I don't think I have access for that. Also I don't have Arc at the moment, and there's no indication in web interface that I

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure added a comment. Writing into the user's home dir is a "hack". There are better ways for distros to set defaults (such as the global mimeapps.list) but it seems KIO ignores that... (to be checked...) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham planned changes to this revision. ngraham added a comment. I don't think it's a "distro hack" to set a default browser, which is why they all do it. Not having a default browser set seems like an error condition to me. However I see what you meanabout the bugginess and will work on

D19829: kicker: add option to make root level icons visible

ngraham added a comment. @i.Dark_Templar can you land this yourself? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg, GB_2 Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D19829: kicker: add option to make root level icons visible

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I'm still a bit grumpy about this and dragging my feet! My gut still says it's both option clutter and UI noise :-) However: - There's a fair amount of people calling for this now.

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I agree that we shouldn't remove the underlying feature, in fact it's still used on other protocols than http. But we have to ensure the default behaviour matches the KCM and

D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet

dfaure created this revision. dfaure added reviewers: mart, apol, broulik. Herald added a project: Plasma. dfaure requested review of this revision. REVISION SUMMARY This file checks for controlRoot being undefined, everywhere else. TEST PLAN `qmlscene tests/testComboBox.qml` showed

D21513: queue load() after all deleteLater() in unload() are done

ngraham added a comment. Stable branch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21513 To: mart, #plasma, davidedmundson Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D21513: queue load() after all deleteLater() in unload() are done

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b059097a5bc1: queue load() after all deleteLater() in unload() are done (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21513: queue load() after all deleteLater() in unload() are done

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Put load in queue of the event loop to wait for the whole set of containments to have been deleteLater(),

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. Can you update the test plan to provide examples of themes that are correctly tagged so we can test this? - Plasma 5 only theme - Plasma 4 only theme - Theme that works on both Plasma 4 and 5 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham added reviewers: Frameworks, dfaure. ngraham added a comment. I'm still not sure whether the feature needs to be removed entirely. I feel that this minimal patch probably stands on its own well enough as-is. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17372 To: ngraham, #plasma, #vdg Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#472514 , @ngraham wrote: > Is the content actually tagged appropriately yet? When I test this out I see no effect, i.e. old Plasma 4 themes like OLED Orange (https://store.kde.org/p/998790/) are still visible.

D21497: fill layouts from X server when there are no layouts in config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good and works for me, though I'm not super familiar with this code so I'd appreciate a review from @hein or @broulik. REVISION DETAIL https://phabricator.kde.org/D21497 To:

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58951. McPain added a comment. style: for CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58950=58951 REVISION DETAIL https://phabricator.kde.org/D21497 AFFECTED FILES kcms/keyboard/keyboard_config.cpp

D21497: fill layouts from X server when there are no layouts in config

ngraham added inline comments. INLINE COMMENTS > keyboard_config.cpp:112 > +QList x11layouts = X11Helper::getLayoutsList(); > +for(const LayoutUnit& layoutUnit : x11layouts) { > +layouts.append(layoutUnit); Style: space between `for` and `(` >

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58950. McPain added a comment. foreach -> for use const CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58932=58950 REVISION DETAIL https://phabricator.kde.org/D21497 AFFECTED FILES kcms/keyboard/keyboard_config.cpp

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. Is the content actually tagged appropriately yet? When I test this out I see no effect, i.e. old Plasma 4 themes like OLED Orange (https://store.kde.org/p/998790/) are still visible. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21507: Remove DefaultListItemBackground and MenuItem animation

This revision was automatically updated to reflect the committed changes. Closed by commit R858:59d06ca5df04: Remove DefaultListItemBackground and MenuItem animation (authored by GB_2). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D21507: Remove DefaultListItemBackground and MenuItem animation

GB_2 added a comment. In D21507#472482 , @mart wrote: > no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed Ok, but if the DefaultListItemBackground animation there doesn't get removed there is

D21507: Remove DefaultListItemBackground and MenuItem animation

GB_2 added a comment. In D21507#472482 , @mart wrote: > no, it's MenuItem.qml in qqc2-desktop-style, animations in kirigami repo shouldn't be removed Thanks! REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH

D21507: Remove DefaultListItemBackground animation

GB_2 updated this revision to Diff 58947. GB_2 added a comment. Change MenuItem too REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21507?vs=58922=58947 BRANCH remove-defaultlistitembackground-animation (branched from master)

D21497: fill layouts from X server when there are no layouts in config

ngraham added a comment. Thanks, it works now! INLINE COMMENTS > keyboard_config.cpp:112 > +QList x11layouts = X11Helper::getLayoutsList(); > +foreach(LayoutUnit layoutUnit, x11layouts) { > +layouts.append(layoutUnit); While you're touching this, port away from

D21507: Remove DefaultListItemBackground animation

mart added a comment. it's MenuI In D21507#472376 , @GB_2 wrote: > In D21507#472356 , @ngraham wrote: > > > I would guess that the code is somewhere in

D15247: Show tooltips in krunner

ngraham added a comment. In D15247#472419 , @McPain wrote: > In D15247#472255 , @ngraham wrote: > > > I am still not actually getting any tooltips when I hover over an elided entry. > > > >

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir updated this revision to Diff 58937. leinir added a comment. - Add TagFilter (for top level tags), and don't explicitly reject 4 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21510?vs=58935=58937 BRANCH filter-themes-by-download-tags

D15247: Show tooltips in krunner

McPain added a comment. In D15247#472255 , @ngraham wrote: > I am still not actually getting any tooltips when I hover over an elided entry. > > F6860589: Screenshot_20190530_114108.png strange

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Following a lengthy discussion on the topic[1], the first step towards getting themes cleaned up and hidden when they don't work

D21507: Remove DefaultListItemBackground animation

GB_2 added a comment. In D21507#472356 , @ngraham wrote: > I would guess that the code is somewhere in https://cgit.kde.org/kirigami.git/tree/src/controls/private/ActionButton.qml Removing all animations there doesn't affect it :(

D21497: fill layouts from X server when there are no layouts in config

McPain updated this revision to Diff 58932. McPain set the repository for this revision to R119 Plasma Desktop. McPain added a comment. updated paths REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58911=58932 REVISION DETAIL

D21501: Don't keep a full NetworkModel instance alive when it's not visible

jgrulich added a comment. Doesn't seem to have any impact on performance. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D21501 To: apol, #plasma, jgrulich Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,