D22817: Port KRunner to Plasma Components 3

broulik added a comment. > To add the clear button, maybe you can use Kirigami.SearchField instead? Not sure if that can do Plasma styling? INLINE COMMENTS > apol wrote in RunCommand.qml:56 > The button's height is by default really big and krunner then looks rather > comical. > Here we

D22868: Revamp Kirigami.AboutPage

hein updated this revision to Diff 62883. hein added a comment. Don't hit Kirigami.Label (deprecated) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22868?vs=62880&id=62883 BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 AFFECTED

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack added a comment. In D22845#504927 , @ngraham wrote: > Neato mosquito! > > Unfortunately, it doesn't build: > > [ 75%] Building CXX object kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o > Installing into /home/nate/kde/bu

D22868: Revamp Kirigami.AboutPage

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Super duper better now. REPOSITORY R169 Kirigami BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham Cc: ngraham,

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack updated this revision to Diff 62882. cblack added a comment. Forgot to add you REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62881&id=62882 BRANCH colordefs (branched from master) REVISION DETAIL https://phabricator.kde.org/D228

D22868: Revamp Kirigami.AboutPage

hein added a comment. Discover: F7130049: Screenshot_20190801_100601.png Material style: F7130053: Screenshot_20190801_100645.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack updated this revision to Diff 62881. cblack added a comment. Fix CMakeLists.txt REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62858&id=62881 BRANCH colordefs (branched from master) REVISION DETAIL https://phabricator.kde.org/D22

D22868: Revamp Kirigami.AboutPage

hein added a comment. Before: F7130036: Screenshot_20190801_15.png After: F7130037: Screenshot_20190801_100033.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868

D22868: Revamp Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, VDG, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY - Use a FormLayout to work nicely in both portrait and landscape orientations - Don

D22493: [Notifications] Move history items' icons over to the left a bit

ngraham added a comment. Oops. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22493 To: ngraham, broulik, #vdg, #plasma, filipf Cc: filipf, alexde, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai

D20972: [sidebar] Make search field not glued to the separator

ngraham requested changes to this revision. ngraham added a comment. In general +1, let's not let this tiny UI improvement die. However the implementation is not quite finished: Whenever you set a rightMargin to make something look better next to a scrollbar, you need to conditionalize t

D22817: Port KRunner to Plasma Components 3

ngraham added a comment. In D22817#504049 , @ognarb wrote: > To add the clear button, maybe you can use Kirigami.SearchField instead? +1, IMO this makes more sense than manufacturing our own search field, especially since the current impl

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

romangg added inline comments. INLINE COMMENTS > filipf wrote in main.qml:118 > @romangg you wrote the feature, should we capitalize its name? :) I would leave it with the capital C since it's part of the name. REPOSITORY R119 Plasma Desktop BRANCH nightcolor-kcm-tweaks (branched from mast

D22845: [GTK3] Convert all colors to use GTK color definitions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Neato mosquito! Unfortunately, it doesn't build: [ 75%] Building CXX object kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o Installing into /home/nate/kde/bui

D22481: Do not show play/pause button when no media is playing

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. -1 for all the previously given reasons. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22481 To: shubham, broulik, #plasma, #vdg, ngraham Cc

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22867 AFFECTED FILES src/controls/private/GlobalDrawerActionI

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

filipf added a subscriber: romangg. filipf added inline comments. INLINE COMMENTS > GB_2 wrote in main.qml:118 > Lowercase c? @romangg you wrote the feature, should we capitalize its name? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22863 To: filipf, #pl

D22866: [Kickoff] Always select previous category in Applications View when navigating backwards

akozlovskiy added a comment. Example in case the description is a little confusing :) F7129177: KickoffRememberCategory.mp4 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22866 To: akozlovskiy, #plasma Cc: plasma-devel

D22866: Current version of the code positions view on the previous category but doesn't set the category itself. I think that selecting the previous category and not the first one is more convenient f

akozlovskiy created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. akozlovskiy requested review of this revision. REVISION SUMMARY ...right category, for example). REPOSITORY R119 Plasma Desktop BRANCH kickoff-appview-remember-previous-category (bra

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

GB_2 added inline comments. INLINE COMMENTS > main.qml:118 > +RowLayout { > Kirigami.FormData.label: i18n("Night Color temperature:") > enabled: activator.checked Lowercase c? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.k

D22863: [kcms/nightcolor] Minor UI tweaks to the KCM

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY - the slider is now of the same width as the comobox below it - the slider's value has been placed to the right of the slider, as th

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

ndavis added a comment. I was hesitant about making this change before I committed it, so it's not a knee jerk reaction, but I also don't think it's important for me to land this quickly. I might want to see if I can come up with the real solution. REPOSITORY R119 Plasma Desktop BRANCH

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Some users complained about the buttons being smaller or the size not being configurable when it previously was. Whatever you change some users will always complain.

D22481: Do not show play/pause button when no media is playing

filipf added a comment. In D22481#496040 , @davidedmundson wrote: > Why? Seconded, why does the plasmoid need to be empty? Note that other plasmoids also specify if some thing A is not available. REPOSITORY R120 Plasma Workspace REVI

D22861: [Kicker/Kickoff] Use better "Remove from Favorites" icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Don't use a minus, because there is no plus next to it. F7127189: Kickoff Remove from Favorites Icon.png

D22858: [Notifications] Workaround NativeRendering with non-integer scaling

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e3035bbcebbf: [Notifications] Workaround NativeRendering with non-integer scaling (authored by broulik). REPOSITORY

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik updated this revision to Diff 62863. kezik added a comment. > Should it queue up a sound so that it plays one sound at the final volume when you've stopped dragging? I made that it plays the sound at the final volume when you release the mouse button REPOSITORY R115 Plasma Audio

D22858: [Notifications] Workaround NativeRendering with non-integer scaling

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since it is a custom `TextEdit` to make text selectable the workaround in the style didn't apply

D22857: [Notifications KCM] Add checkbox for enabling do not disturb mode when screens are mirrored

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Depends on D22856 F7126794: Screenshot_20190731_164705.png

D22856: Enable do not disturb mode when screens are mirrored

broulik created this revision. broulik added reviewers: Plasma, VDG, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When two screens overlap during e.g. a presentation, automatically enable do not dist

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 62859. cblack added a comment. Dump the rest of the colors. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62847&id=62859 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabric

D22122: use pwquality_strerror to get error strings

ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. My bad, there were some typos in the value of the variable. I confirm that it works. +1 from the translation point of view. REPOSITORY R128 User Manager BRANCH master REVISION

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack updated this revision to Diff 62858. cblack added a comment. Fix some issues with incorrect colors being used REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62825&id=62858 BRANCH colordefs (branched from master) REVISION DETAIL h

D22122: use pwquality_strerror to get error strings

sitter added a comment. Is that with the latest diff (the one changed to fromUtf8)? LANGUAGE=uk seems to work for me F7126679: Screenshot_20190731_162607.png REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D22122 To: s

D22122: use pwquality_strerror to get error strings

ltoscano added a comment. Sorry, I totally missed the notifications (but I received them). I think that there is an encoding issue with any characters over the canonical 127 base ones. Observed with Italian and Ukrainian, see F7126642: user-manager-pwquality-it.png

D22738: Remove some uses on QDesktopWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a8efa8653b09: Remove some uses on QDesktopWidget (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22738?vs=62725&id=62857 REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

davidre added a comment. Sorry my bad, I misread the diff. I thought you added a new flag (as proposed above) and looked at `exportGtkTheme` but that flag is an existing one. And to my shame it doesn't even have a green background. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://

D22589: Embrace X-KDE-Wayland-Interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e561df722bc1: Embrace X-KDE-Wayland-Interfaces (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22589?vs=62771&id=62852 REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

cblack added a comment. In D22844#504691 , @davidre wrote: > It seems the header with the new flag is missing from the diff. I put it alongside the content in the existing `exportColors` flag because there's no reason to make a flag for e

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

davidre added a comment. It seems the header with the new flag is missing from the diff. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22844 To: cblack, #plasma Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Zre

D21619: Wallpaper: delay calling UIReady until the image is actually loaded

davidedmundson updated this revision to Diff 62849. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21619?vs=59259&id=62849 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21619 AFFECTED FILES

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

cblack updated this revision to Diff 62847. cblack added a comment. Incorporate feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62819&id=62847 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL https://phabricator.kde

D22327: [libnotificationmanager] Port to lighter KProcessList

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. With D22471 does what it should REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22327 To: davidedm

D22316: Avoid garbling the sound if the volume slider is moved fast

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Should it queue up a sound so that it plays one sound at the final volume when you've stopped dragging? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https

D22316: Avoid garbling the sound if the volume slider is moved fast

filipf added a comment. Ah I can definitely reproduce it. I agree, it sounds bad. +1 for fixing it. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #plasma, drosca Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik added a comment. In D22316#503998 , @filipf wrote: > Removed VDG as the reviewer, seems like a technical issue all together. Sorry > Also wanted to contribute, but I don't really perceive any issues when moving the slider fast

D22851: [SplitterProxy] Don't manually mapToGlobal

broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The constructor of `QMouseEvent` actually expects `windowPos` and/or `screenPos`

D22823: Restore Mouse Keyboard navigation accessibility feature

This revision was automatically updated to reflect the committed changes. Closed by commit R119:826dc413a9b7: Restore Mouse Keyboard navigation accessibility feature (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22823?vs=62783&id

D22832: Fix build with pango 1.44

sitter added a comment. Sure, don't take my bubbling to mean that I object to the diff. I'm just musing on it's long-term necessity When I dump the variables created by the initial PKG_CHECK_MODULES call in the finder they do have the requirements in the LIBRARIES and INCLUDES. So in po

D22846: Port KeyboardLayout component to use generated DBus interface

This revision was automatically updated to reflect the committed changes. Closed by commit R120:18010b1a89c7: Port KeyboardLayout component to use generated DBus interface (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22

D22847: [runners/kill] Port old style connects

This revision was automatically updated to reflect the committed changes. Closed by commit R120:edaa70cbdb34: [runners/kill] Port old style connects (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22847?vs=62826&id=62831