D24683: [KWindowSystem] in icon() return realistic icon size

meven added a subscriber: ngraham. meven added a comment. @ngraham In Wayland this allows the Tooltips from the taskmanager to display centered icon for wayland windows. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D24683 To:

D24683: [KWindowSystem] in icon() return realistic icon size

meven updated this revision to Diff 68012. meven added a comment. Clean up REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24683?vs=68011=68012 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24683

D24683: [KWindowSystem] in icon() return realistic icon size

meven created this revision. meven added reviewers: KWin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The icon function did not take into account the fact that icons have limited size options

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

yerilov added a comment. Thanks @apol I've built it from your branch and testing it now. Here is a list of issues I have faced so far: 1. Layout switch doesn't work on Lock screen. Visually layouts are shown as switched, but actually it's always English. 2. I have 3 layouts:

Re: Monday meeting notes for 14/10/2019

Leinir: * The new Qt Quick components for KNewStuff were released as part of Frameworks 5.63, so whenever Plasma's able to depend on that we can start scattering that all over the place :) Plasma 5.18 will depend on Frameworks 5.66, so that means this porting work can start to happen in

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

ngraham added a comment. In D24635#547820 , @apol wrote: > I understand what you say but I don't think that's even feasible. Does it really make sense that from e.g. KMail you need to ask the Plasma KCM for permission to send feedback? >

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol added a comment. > Ok, just tried this out. The problem is that the global on/off switch that's presented to the user is still reversed from what it should be: instead of saying, "forbid KDE software from bla bla bla", it should say "allow KDE software to bla bla bla". Otherwise the

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

apol added a comment. So I decided to rebase the patch onto current master. I pushed it rebased into a branch called `apol/D14796` because I didn't know whether to take over this review. I would appreciate it if someone could help me tell why it wasn't merged. I see: > It needs a

D13243: [applet] Add checkbox to show virtual streams

ngraham added a comment. Now that I think about this some more, might it make sense to have the option in the KCM, and then checking it would show virtual streams in both the applet and the KCM? Otherwise it might be a bit odd to have this apply only to the applet. REPOSITORY R115 Plasma

D24447: Fix compatibility of build_theme.sh with Dash

This revision was automatically updated to reflect the committed changes. Closed by commit R98:91c16f284c18: Fix compatibility of build_theme.sh with Dash (authored by gepardo, committed by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D24447: Fix compatibility of build_theme.sh with Dash

cblack added a comment. In D24447#547774 , @gepardo wrote: > Thanks. Can you please merge it? I don't have a developer access to KDE repos. Sure, I'll do that. REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL

D24447: Fix compatibility of build_theme.sh with Dash

gepardo added a comment. Thanks. Can you please merge it? I don't have a developer access to KDE repos. REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D24447 To: gepardo, cblack, svuorela Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24447: Fix compatibility of build_theme.sh with Dash

cblack accepted this revision. cblack added a comment. LGTM  REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D24447 To: gepardo, cblack, svuorela Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24679: [Notifications] Also consider enabled and connected for screen to be checked against

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Fixes erroneously enabling do not disturb mode in some situations when having screens mirrored

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

ngraham added a comment. In D24635#547168 , @apol wrote: > In D24635#547136 , @ngraham wrote: > > > Thanks. Can we just surface that then? We'd show a UI for the global on/off switch and than

D24677: Add `sudo` to the lines in install-sessions.sh that need it so you don't need to sudo the whole thing

ngraham created this revision. ngraham added reviewers: apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Because this script copies things to /, it needs to be run with `sudo`. But two of the

D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0

fvogt added a comment. In D24664#547710 , @broulik wrote: > Since we watch the file, we will update it as neccessary once kconf_update has written it, right? Yup. > When it is deleted after that, we won't ever recreate it, though?

D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0

broulik added a comment. Since we watch the file, we will update it as neccessary once kconf_update has written it, right? When it is deleted after that, we won't ever recreate it, though? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24664 To: fvogt,

D24674: Fix Kirigami template image

dkardarakos created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. dkardarakos requested review of this revision. REVISION SUMMARY Kirigami template image file is empty. An image file that shows a Kirigami application was added. TEST PLAN Try to

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. When those land I'll have a PR for EnvCan provider/ion to support those too REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr,

D24503: Integrate the normal keyboard layout switcher

apol added a comment. This got landed by arc together with another patch. I didn't mean to land it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24666: Be explicit about X11 or Wayland for the dev session names

ngraham added a comment. @davidedmundson is this okay now given the decision in D22210 ? Or should we massage the strings some more? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24666 To: ngraham, fvogt,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. In D22210#547637 , @davidedmundson wrote: > 1. A period where both X and wayland say "Plasma". > > 1 is super super bad. Which means we need to patch one of the Plasma entries first. I would block this

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson accepted this revision. davidedmundson added a comment. +1 but wait for fvogt and whoever else to ack. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt Cc: ngraham, pino, rdieter,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner updated this revision to Diff 67992. asturmlechner added a comment. Switch back to Plasma (Wayland) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=62165=67992 BRANCH arcpatch-D22210 REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. In D22210#547637 , @davidedmundson wrote: > Ok, so there are exactly 3 outcomes of events. > > 1. A period where both X and wayland say "Plasma". > 2. A period where we see Plasma (X11) and Plasma > 3. A period

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson added a comment. Ok, so there are exactly 3 outcomes of events. 1. A period where both X and wayland say "Plasma". 2. A period where we see Plasma (X11) and Plasma 3. A period where we see Plasma (wayland) (wayland) (a combo of 2 & 3 is also possible, but that

D24530: [XembedSNIProxy] If available, always use 32-bit color.

kmaterka added a comment. In D24530#547085 , @ngraham wrote: > FWIW since you landed this on master rather than `Plasma/5.17`, it will only be in Plasma 5.18, not 5.17.1. > > At this point, if it's critical to go into 5.17.1, you should

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. In D22210#547621 , @ngraham wrote: > "Plasma on Xorg" is a yucky string to display to users. well, it is what Gnome apparently does, so at least it would have lead to some uniformity. But no strong opinion

D24666: Be explicit about X11 or Wayland for the dev session names

ngraham added a comment. In D24666#547625 , @davidedmundson wrote: > > Ideally https://github.com/sddm/sddm/pull/997 would get done first. > > Why would we want that first? It'd put us in the situation where we have two different things

D24666: Be explicit about X11 or Wayland for the dev session names

davidedmundson added a comment. > Ideally https://github.com/sddm/sddm/pull/997 would get done first. Why would we want that first? It'd put us in the situation where we have two different things with the same name. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. Got it. My very strong preference is to append the session name for Wayland, not X11. "Plasma on Xorg" is a yucky string to display to users. IMO it would be preferable to display "Plasma on Wayland (Wayland) for a limited period of time while the Plasma and

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. In D22210#547608 , @ngraham wrote: > I thought this change was introduced with 0.18.1 though? Aren't distros with an old SDDM using something older than that? That pull request hasn't been merged yet, so all

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. I thought this change was introduced with 0.18.1 though? Aren't distros with an old SDDM using something older than that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt Cc:

D24666: Be explicit about X11 or Wayland for the dev session names

ngraham added a comment. In D24666#547565 , @fvogt wrote: > See https://phabricator.kde.org/D22210 for a discussion about this. > > > Maybe @fvogt can shed some light on the situation. > > We have https://github.com/sddm/sddm/pull/997 in

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. In D22210#547602 , @ngraham wrote: > FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we would rename the sessions upstream here. My preference would be to make the Wayland session say "Plasma

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we would rename the sessions upstream here. My preference would be to make the Wayland session say "Plasma (Wayland)" rather than renaming the X11 session ("Plasma on Xorg" sounds pretty

D24670: KCM fonts : Rearrange code

bport created this revision. bport added reviewers: Plasma, ervin, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Don't mix KFonts and FontAASettings method implementation REPOSITORY R119 Plasma Desktop

D24669: Port fonts KCM to KConfigXT

bport created this revision. bport added reviewers: Plasma, ervin, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24669 AFFECTED FILES

D24668: Simplify kcms cmake file

bport created this revision. bport added reviewers: Plasma, ervin, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24668 AFFECTED FILES

D24666: [RFC] Be explicit about X11 or Wayland for the dev session names

fvogt added a comment. See https://phabricator.kde.org/D22210 for a discussion about this. > Maybe @fvogt can shed some light on the situation. We have https://github.com/sddm/sddm/pull/997 in sddm for consistency with non-Plasma sessions. REPOSITORY R120 Plasma Workspace

D24666: [RFC] Be explicit about X11 or Wayland for the dev session names

ngraham created this revision. ngraham added reviewers: fvogt, davidedmundson, apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY I just switched to openSUSE Tumbleweed and noticed that the session

D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0

fvogt created this revision. fvogt added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY BUG: 412970 TEST PLAN Not tested yet. REPOSITORY R120 Plasma Workspace BRANCH gtkfix

D24653: discover: check package status before trying to install/update it

This revision was automatically updated to reflect the committed changes. Closed by commit R134:dd9ba961d7e9: discover: check package status before trying to install/update it (authored by alnikiforov, committed by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

Plasma 5.17 out

Plasma 5.17 is out now https://kde.org/announcements/plasma-5.17.0.php

D24653: discover: check package status before trying to install/update it

alnikiforov added a comment. In D24653#547385 , @apol wrote: > Please submit to master. I've updated patch and removed additional parenthesis in condition. But I don't see how I can submit this change to repository, I probably don't have

D24649: Set new icon for battery applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6ae88953a37e: Set new icon for battery applet (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24649?vs=67935=67963 REVISION

D24653: discover: check package status before trying to install/update it

alnikiforov updated this revision to Diff 67961. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24653?vs=67941=67961 REVISION DETAIL https://phabricator.kde.org/D24653 AFFECTED FILES

D24653: discover: check package status before trying to install/update it

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Please submit to master. INLINE COMMENTS > PackageKitBackend.cpp:586 > > +if ((info == PackageKit::Transaction::InfoRemoving) || (info == > PackageKit::Transaction::InfoObsoleting)) { >

D24517: Port kcm cursor to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f53d7844fbb5: Port kcm cursor to KConfigXT (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24517?vs=67948=67951 REVISION DETAIL

D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method

This revision was automatically updated to reflect the committed changes. Closed by commit R119:29f8346063a4: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24519: Delegate KCM cursor theme config management to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fec538fb02e0: Delegate KCM cursor theme config management to KConfigXT (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b2f75f13e0e: Fix a bug in KCM cursor theme, after applying change, cursor preview dont work (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24520?vs=67607=67954#toc

D24518: On KCM cursor theme update attribute name

This revision was automatically updated to reflect the committed changes. Closed by commit R119:186ab6e9b75e: On KCM cursor theme update attribute name (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24518?vs=67608=67952 REVISION

D24519: Delegate KCM cursor theme config management to KConfigXT

bport updated this revision to Diff 67949. bport added a comment. Add notify to setPreferredSize REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24519?vs=67606=67949 REVISION DETAIL https://phabricator.kde.org/D24519 AFFECTED FILES

D24517: Port kcm cursor to KConfigXT

bport updated this revision to Diff 67948. bport added a comment. Move install line to the good section REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24517?vs=67605=67948 REVISION DETAIL https://phabricator.kde.org/D24517 AFFECTED FILES

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 421 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/421/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 10 Oct 2019 11:41:07 + Build duration: 37 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 440 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/440/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 10 Oct 2019 03:37:07 + Build duration: 16 min and counting BUILD ARTIFACTS

D24519: Delegate KCM cursor theme config management to KConfigXT

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmcursortheme.cpp:157 > { > -return m_selectedThemeRow; > -} > - > -void CursorThemeConfig::setSelectedSizeRow(int row) > -{ > -Q_ASSERT (row <

D24517: Port kcm cursor to KConfigXT

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Just a last nitpick. INLINE COMMENTS > CMakeLists.txt:24 > +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc > GENERATE_MOC) > +install(FILES

D24654: [Notifications] Don't bind model inside headerItem

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since Qt 5.12.5 and newer this causes infinite recursion in component creation as setting the

D24653: discover: check package status before trying to install/update it

alnikiforov created this revision. alnikiforov added reviewers: jriddell, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY With latest changes to packagekit, it may now return more packages from