KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 154 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/154/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 6 min 59 sec and counting JUnit Tests Name: p

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 289 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/289/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 6 min 17 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 155 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/155/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 5 min 37 sec and counting JUnit Tests

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 284 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/284/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Feb 2020 07:32:31 + Build duration: 4 min 42 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 154 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/154/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 05:55:09 + Build duration: 1 hr 1 min and counting CONSOLE OUTPU

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 153 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/153/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 04 Feb 2020 05:55:09 + Build duration: 1 hr 1 min and counting CONSOLE OUTPUT [...tr

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 283 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/283/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Feb 2020 05:55:08 + Build duration: 18 min and counting CONSOLE OUTPUT [.

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 288 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/288/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 04 Feb 2020 05:55:08 + Build duration: 16 min and counting CONSOLE OUTPUT [...truncated 94

D26514: Delay popup when dropping things into containments

This revision was automatically updated to reflect the committed changes. Closed by commit R119:36e918b09780: Delay popup when dropping things into containments (authored by trmdi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26514?vs=74264&id=74978

D27149: Scroll the truncated song/artist text when long hovering over it

cblack added a comment. Be sure to add a copyright/license header to the new QML file you added. REPOSITORY R119 Plasma Desktop BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D27149 To: trmdi, #plasma, #vdg, ndavis Cc: cblack, ndavis,

D27149: Scroll the truncated song/artist text when long hovering over it

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R119 Plasma Desktop BRANCH add-tooltip-textWrapper (branched from master) REVISION DETAIL https://phabricator.kde.org/D27149 To: trmdi, #plasma, #vdg, ndavis Cc: ndavi

D27149: Scroll the truncated song/artist text when long hovering over it

trmdi created this revision. trmdi added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - When the text is truncated, we could hover over it to read the full text TEST PLAN Everything w

D27143: moved do not disturb to the bottom

gvgeo added a comment. Calling it footer would be more appropriate now instead of header. But when there is a separate qml, it is called Toolbar. And other applets(e.g. volume), don't mention any name. Can we choose a single name(or style)? REPOSITORY R120 Plasma Workspace BRANCH

D27117: [Applet]Fix device label problems

gvgeo updated this revision to Diff 74971. gvgeo edited the summary of this revision. gvgeo added a comment. Add comment REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27117?vs=74936&id=74971 BRANCH labelWidth2 (branched from master)

D27117: [Applet]Fix device label problems

ngraham added a comment. Ah I see why you did it then. That makes some sense. Can you add a comment explaining this? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27117 To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson Cc: cfeck, plasma-

D27117: [Applet]Fix device label problems

gvgeo added a comment. It works like you said. The problem is that will be too easy, accidentally to change the default device. It is not right for the empty space, without any indication, to change your device. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabrica

D27138: [Applet]Restore naming convention for devices.

gvgeo added a comment. In D27138#605645 , @ngraham wrote: > > Makes 1 check and apply both for playback and recording devices. > > Are you sure that makes sense? If I have two outputs but only one input (a common setup) then I don't want my m

D25006: Make sure -dpi value is valid

gcraciunescu marked 2 inline comments as done. gcraciunescu added a comment. In D25006#605578 , @filipf wrote: > David's suggestion to just turn `dpiValue` into an int sounds sensible to me. @gcraciunescu do you want to finish this patch?

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

ngraham abandoned this revision. ngraham added a comment. All right, sounds like this isn't a clear winner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27077 To: ngraham, #vdg, #plasma Cc: ahiemstra, rikmills, broulik, cfeck, davidedmundson, plasma-devel

D27144: Moved toggles to the bottom according to T10470

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now when Bluetooth is on but there are no devices, the applet looks like this: F8083748: Screenshot_20200203_150046.png This popu

D27138: [Applet]Restore naming convention for devices.

ngraham added a comment. > Makes 1 check and apply both for playback and recording devices. Are you sure that makes sense? If I have two outputs but only one input (a common setup) then I don't want my microphone having an unnecessarily long description. Might be nicer to keep the curren

D27117: [Applet]Fix device label problems

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:120 > This feels wrong. The radio button shouldn't need a maximum width set on it. Replace this line with `Layout.fillWidt

D27136: [Cuttlefish] Remove last traces of themes and plasma themes

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me since we actually don't have a UI for this anymore, so the code is orphaned. REPOSITORY R118 Plasma SDK BRANCH remove-plasma REVISION DETAIL https://phabricator.

D27144: Moved toggles to the bottom according to T10470

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R97 Bluedevil BRANCH move_toggle_to_bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D27144 AFFECTED F

D26895: Introduce an Info Center mode

ngraham added a comment. In D26895#605255 , @ovichiro wrote: > Not sure it's my place to do so, but I'd like to make a small comment. > Instead of passing `mode` around and all the `if` statements, wouldn't it be better to have a single deci

D27142: Have authhelper define config file paths on its own

davidedmundson added inline comments. INLINE COMMENTS > sddmkcm.cpp:55 > > -mSddmConfig = > KSharedConfig::openConfig(QStringLiteral(SDDM_CONFIG_FILE), > KConfig::CascadeConfig); > +mSddmConfig = KSharedConfig::openConfig(QString > {QLatin1String(SDDM_CONFIG_DIR "/") + QStringLiteral

D27143: moved do not disturb to the bottom

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY As per T10470 , I moved the notification do not disturb buttons to the bottom TEST PLAN

D26813: Have user-manager write to SDDM's new config file

filipf planned changes to this revision. filipf added inline comments. INLINE COMMENTS > accountmodel.cpp:45 > { > -KConfig config(QStringLiteral(SDDM_CONFIG_FILE)); > +KConfig config(QStringLiteral("kde_settings")); > m_autoLoginUser = config.group("Autologin").readEntry("User", QS

D25006: Make sure -dpi value is valid

filipf added a comment. David's suggestion to just turn `dpiValue` into an int sounds sensible to me. @gcraciunescu do you want to finish this patch? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D25006 To: gcraciunescu, filipf, #plasma, ngra

D26813: Have user-manager write to SDDM's new config file

filipf added a comment. In D26813#598252 , @davidedmundson wrote: > We could move the full file path to the helper rather than having the calling user send it. > I'll be more secure that way. This should work now with the dependent re

D27142: Have authhelper

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Suggested for D26813 . Prerequiste if user-manager is to not send any SDDM config file path on it

D26813: Have user-manager write to SDDM's new config file

filipf updated this revision to Diff 74954. filipf added a comment. don't define any sort of sddm config file path in user manager (needs an additional sddm patch I'm going to send in now) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26813?vs=74035&

D27037: [Notifications] Fixup setSourceModel

davidedmundson added a comment. QAbstractSortFilterProxyModel has docs that say you need it, but QSortFilterProxyModel which you inherit from does reset the model in setSourceModel. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27037 To: broulik, #plasma

D27117: [Applet]Fix device label problems

gvgeo added a subscriber: cfeck. gvgeo added a comment. Tried couple themes, but could not reproduce the color problem. https://bugs.kde.org/show_bug.cgi?id=417106 Hopefully this change make sense. INLINE COMMENTS > ListItemBase.qml:126 > > -Label { > +

D27079: Don't escape search text in search page title

ngraham updated this revision to Diff 74948. ngraham added a comment. Just strip all html tags REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27079?vs=74822&id=74948 BRANCH show-search-text-un-escaped (branched from Plasma/5.18) REVISION

D27138: [Applet]Restore naming convention for devices.

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Restores naming convention for devices, before the Layout update. Display both de

D27079: Don't escape search text in search page title

apol added a comment. They shouldn't that doesn't mean we should style it when they do. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev,

D26895: Introduce an Info Center mode

ovichiro added inline comments. INLINE COMMENTS > main.cpp:68 > +aboutData = KAboutData(QStringLiteral("systemsettings"), > i18n("System Settings"), QLatin1String(PROJECT_VERSION), i18n("Central > configuration center by KDE."), KAboutLicense::GPL, i18n("(c) 2009, Ben > Cooksley")); >

D27079: Don't escape search text in search page title

ngraham added a comment. Why would the user enter `my potato`? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbamp

D26891: Upgrade theme to Breeze GTK on startup

fvogt accepted this revision. fvogt added a comment. In D26891#605464 , @ngraham wrote: > LGTM now. @meven and @fvogt, you good with this too? Not sure what the rename was about, but yes, still LGTM. REPOSITORY R99 KDE Gtk Configuration

D26891: Upgrade theme to Breeze GTK on startup

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM now. @meven and @fvogt, you good with this too? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH apply-theme-on-startup (branched from master) REVISION DETAIL https://phabrica

D27137: Handle spawning kinfocenter with a full path

ngraham added a comment. If you manually create a symlink called `my-kinfocenter` that points to `systemsettings` then clearly you're actually trying to make kinfocenter open just with a different binary name for your own convenience, so this new code is actually more correct. REPOSITORY

D27137: Handle spawning kinfocenter with a full path

pino added a comment. In D27137#605459 , @davidedmundson wrote: > If you run /usr/bin/my-kinfocenter you wouldn't spawn this executable in the first place Hello symlink my old friend... REPOSITORY R124 System Settings BRANCH master

D27137: Handle spawning kinfocenter with a full path

davidedmundson added a comment. If you run /usr/bin/my-kinfocenter you wouldn't spawn this executable in the first place REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27137 To: davidedmundson, #plasma, ngraham Cc: pino, ngraham, plasma-dev

D27137: Handle spawning kinfocenter with a full path

pino added inline comments. INLINE COMMENTS > main.cpp:42 > +BaseMode::ApplicationMode mode = BaseMode::SystemSettings; > +if (executableName.endsWith(QLatin1String("kinfocenter"))) { > +binaryName = QStringLiteral("kinfocenter"); This will consider also `/usr/bin/my-kinfocenter`

D27137: Handle spawning kinfocenter with a full path

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice fix. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27137 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, L

D27137: Handle spawning kinfocenter with a full path

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY /usr/bin/kinfocenter doesn't match "kinfocenter" it also cannot be using

D27136: [Cuttlefish] Remove last traces of themes and plasma themes

davidre created this revision. davidre added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY As far as I can tell plasma theme support was only used for a checkbox to override icons with p

D27090: Replace config.h with target_compile_definitions

apol added a comment. I wouldn't say it's simpler. If anything it's easier to inspect the value that is being passed from your editor. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27090 To: gikari Cc: apol, plasma-devel, Orage, LeGast00n, The-Fe

D27079: Don't escape search text in search page title

apol added a comment. Because if you enter `my potato` it gets styled, which shouldn't happen. I suggest just doing the following: diff --git a/discover/qml/ApplicationsListPage.qml b/discover/qml/ApplicationsListPage.qml index 4445a195..e094b667 100644 --- a/discover/qml/

D27134: [Notifications] Don't dodge notification popups

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Clever! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27134 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-De

D27135: Add PagePoolAction to QRC file

masonm created this revision. masonm added a reviewer: VDG. masonm added projects: Kirigami, VDG. Herald added a subscriber: plasma-devel. masonm requested review of this revision. REVISION SUMMARY Missing PagePoolAction causes crash on static builds TEST PLAN Create/launch static build befor

D27134: [Notifications] Don't dodge notification popups

broulik updated this revision to Diff 74941. broulik added a comment. - Remove check for self since we know that this is always a popup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27134?vs=74939&id=74941 REVISION DETAIL https://phabricator.kd

D27134: [Notifications] Don't dodge notification popups

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This wasn't an issue before as notification popups could never have focus. However, now with qui

D27117: [Applet]Fix device label problems

gvgeo updated this revision to Diff 74936. gvgeo edited the test plan for this revision. gvgeo added a comment. Code style REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27117?vs=74933&id=74936 BRANCH labelWidth2 (branched from master)

D27131: [Applet]Fix device label problems

gvgeo abandoned this revision. gvgeo added a comment. A mistake... REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27131 To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachu

D27131: [Applet]Fix device label problems

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Limit label maximum width, to avoid breaking UI. Change label to

D27117: [Applet]Fix long device name

gvgeo updated this revision to Diff 74933. gvgeo added a comment. Simplify. Fix label color issues. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27117?vs=74898&id=74933 BRANCH labelWidth2 (branched from master) REVISION DETAIL h

D27126: [SNI] Fix race condition in item registration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:31303ad3542b: [SNI] Fix race condition in item registration (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27126?vs=74929&id=74932

D27130: [Notifications] For group parents combine the child bodies

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This enables some basic grouping when pointing a list at the group parents instead of the individ

D27126: [SNI] Fix race condition in item registration

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kmaterka wrote in statusnotifierwatcher.cpp:69 > Is this OK? Are mid-method returns allowed? They are REPOSITORY R120 Plasma Workspace BRANCH mast

D27129: [Notifications] Allow expiring an entire group

broulik updated this revision to Diff 74930. broulik added a comment. - Don't expire when already expired REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27129?vs=74928&id=74930 REVISION DETAIL https://phabricator.kde.org/D27129 AFFECTED FILES

D27126: [SNI] Fix race condition in item registration

kmaterka added inline comments. INLINE COMMENTS > statusnotifierwatcher.cpp:69 > +if (m_registeredServices.contains(notifierItemId)) { > +return; > +} Is this OK? Are mid-method returns allowed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2

D27129: [Notifications] Allow expiring an entire group

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Similar to how we can close an entire group at once. This is in preparation for being able to ha

D27126: [SNI] Fix race condition in item registration

kmaterka updated this revision to Diff 74929. kmaterka added a comment. Updated the code. This time I was not event able to reproduce race condition. Is something like this OK? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27126?vs=74924&id=74929

D27128: [Cuttlefish] --warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R118:fcd8b650d119: [Cuttlefish] --warnings (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27128?vs=74926&id=74927#toc REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D27117: [Applet]Fix long device name

gvgeo planned changes to this revision. gvgeo added inline comments. INLINE COMMENTS > ListItemBase.qml:132 > id: soloLabel > +Layout.maximumWidth: > defaultButton.Layout.maximumWidth > text: defaultButton.text This will

D14562: Introduce Theme.smallestFont

mart added inline comments. INLINE COMMENTS > volkov wrote in kirigamiplugin.cpp:173 > So, should it be registered for both versions 2.2 and 2.6? > I tried to use revisions, but it looks like they don't work for properties of > attached property objects: > https://doc.qt.io/qt-5/qtqml-cppintegra

D27128: [Cuttlefish] --warnings

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.18 please REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D27128 To: davidre, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

ngraham added a comment. Conceptually +1. It's not related to this patch, but looking at the table, it would be nice to move from a tree view into a list view with section headers, like how the GLobal Shortcuts KCM does. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabri

D27117: [Applet]Fix long device name

ngraham added inline comments. INLINE COMMENTS > ListItemBase.qml:120 > id: defaultButton > +Layout.maximumWidth: controlsRow.width - > (clientIcon.visible ? clientIcon.width + units.smallSpacing : 0) > +

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

kossebau resigned from this revision. kossebau added a comment. Good. So stepping out here :) REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D27036 To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D27128: [Cuttlefish] --warnings

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D27128 AFFECTED FILES cuttlefish/package/contents/ui/Ic

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven created this revision. meven added reviewers: ervin, ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY - Make default button work - Move connection from cpp to .ui - Slight label change T

D26895: Introduce an Info Center mode

ovichiro added a comment. Not sure it's my place to do so, but I'd like to make a small comment. Instead of passing `mode` around and all the `if` statements, wouldn't it be better to have a single decision point in `main.cpp`, like a factory class? Use polymorphism and create somethin

D27126: [SNI] Fix race condition in item registration

davidedmundson added a comment. Well identified, it is racey. But the solution seems off on line 68 we check on line 75 we implicitly check again now we're checking a 3rd time! I think we can instead solve it with some re-arranging m_serviceWatcher->addWatchedService(

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

ahiemstra added a comment. > So maybe this isn't actually a destructive action at all. After all, an app with unsaved changes or active processed will block the logout/shutdown absent user interaction. That only happens if you happen to have unsaved changes. Many applications will simpl

D27126: [SNI] Fix race condition in item registration

kmaterka added a comment. It is hard to reproduce, but with enough tries you should get empty items in "hidden" area of system tray. I used this script: for i in `seq 1 100`; do echo $i telegram-desktop & sleep 2 killall telegram-desktop

D27126: [SNI] Fix race condition in item registration

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY If StatusNotifierItem is registered and then immediately destroyed, it is possible that QDBusServiceWatcher will n

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven updated this revision to Diff 74920. meven added a comment. Improved flag function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74782&id=74920 BRANCH onattabch REVISION DETAIL https://phabricator.kde.org/D27057 AFFECTED FILES

Re: The Role of KInfoCenter

I agree with your sentiment. Putting a command line tool in a window is useless. I think there is scope for /something/ even if it's not the current state. The system information page is really good The energy page is really good (as a concept at least. The graph implementation isn't something I

D26271: [Applet]Update layout based on T10470

gvgeo added a comment. Change to implicitHeight in D27117 . That line should be in D26574 , messed up splitting the patches. It keeps the height of the row fixed, so that it won't change when the button gets hidden

The Role of KInfoCenter

Ahoi! I was hoping we can have a bikeshed discussion about KInfoCenter :) The past couple of weeks I've been spending some time on KIC and what became apparent quickly is that I have not the faintest idea who the application is for, or when/how one would use it. That makes it nigh impossible to s

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec4dd2cc7ad0: [Colors KCM] Consider settings dirty if currently active scheme is edited (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D27072: [Colors KCM] Fix roles mixup

This revision was automatically updated to reflect the committed changes. Closed by commit R119:43001f7977af: [Colors KCM] Fix roles mixup (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27072?vs=74807&id=74899 REVISION DETAIL h

D27117: [Applet]Fix long device name

gvgeo added a comment. @ davidedmundson Is this monstrosity correct? I tried to avoid binding loops by setting minimum maximum sizes. And the origin of the values is contextMenuButton.implicitHeight. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/

D27117: [Applet]Fix long device name

gvgeo added inline comments. INLINE COMMENTS > ListItemBase.qml:111 > id: column > -spacing: 0 > +Layout.minimumHeight: contextMenuButton.implicitHeight * 2 + > units.smallSpacing > +Layout.maximumHeight: Layout.minimumHeight With

D27117: [Applet]Fix long device name

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Limit label maximum width. Set and use implicit sizes to avoid bi

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

crossi accepted this revision. crossi added a comment. This revision is now accepted and ready to land. Both patch applied and tested, it works for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27073 To: broulik, #plasma, crossi, ervin Cc: plasma-devel,

D27116: KCM/Component email: simplify code, add a const

meven created this revision. meven added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Clean up adding entries for Added Associations section of mimeapplist Just find the application

D27113: Delete cache when resetting user settings

filipf added a comment. In D27113#604956 , @davidedmundson wrote: > Can you explain what happens that would require us to delete the cache and why this isn't the case when you change colour themes on a regular session. The difference is

D26842: Fix fonts KCM button state

bport added a comment. In D26842#602522 , @ngraham wrote: > We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, so I guess it would be nice if this made it into 5.18. Ok I will land it to 5.18 and then merge to maste