D27199: [Applet]Update layout based on T10470

jgrulich added a comment. In D27199#611665 , @ngraham wrote: > In D27199#611308 , @gvgeo wrote: > > > I made 3 smaller patches, to decrease this patch's size. D27391

D27449: [applets/mediacontroller] Fix Playback button icon sizes

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Same as D27260 . Following D27396

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

ngraham added a comment. Can you update the text plan with detailed instructions for how to make this work? It is not working for me, and with no such text plan, I don't know why. REPOSITORY R119 Plasma Desktop BRANCH colors-kcm-recolor-gtk2 (branched from master) REVISION DETAIL

D24324: [GTK2] Add program to libexec for GTK2 recoloration

ngraham added a comment. The program is created non-executable, FYI. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24324 To: cblack, #breeze Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27448: [kcms/feedback] Improve default kcmshell window size

This revision was automatically updated to reflect the committed changes. Closed by commit R120:285155fad1f3: [kcms/feedback] Improve default kcmshell window size (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27448: [kcms/feedback] Improve default kcmshell window size

ngraham added a comment. In D27448#612644 , @apol wrote: > Okay. > > I wonder if we should be launching systemsettings rather than kcmshell... Please place relevant thoughts and opinions in

D27448: [kcms/feedback] Improve default kcmshell window size

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Okay. I wonder if we should be launching systemsettings rather than kcmshell... REPOSITORY R120 Plasma Workspace BRANCH better-default-size-for-feedback-kcm (branched from

D27448: [kcms/feedback] Improve default kcmshell window size

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 417747 FIXED-IN: 5.18.1 TEST PLAN Better default size when showing the most info:

D26813: Have user-manager write to SDDM's new config file

ngraham added a comment. +1, we can to the refactoring on master. REPOSITORY R128 User Manager BRANCH write-autologin-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D26813 To: filipf, #plasma, davidedmundson, ngraham Cc: plasma-devel, Orage, LeGast00n,

D27391: [Applet]Fix dimensions of traffic Monitor

ngraham added inline comments. INLINE COMMENTS > TrafficMonitor.qml:64 > top: parent.top > -topMargin: units.gridUnit > +topMargin: Math.round(labels.labelHeight / 2) > } We could probably just use a smaller predefined unit, like `largeSpacing`,

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75804. The-Feren-OS-Dev added a comment. One more patch update to keep the change consistent with the rest of the code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75803=75804 BRANCH

D27438: Increase System Tray Plasmoid spacing value slightly

kmaterka added a comment. There is already a margin added around icons, "units.smallSpacing / 2" if I remember correctly. IMO it is OK without additional spacing (maybe because I'm used to it?). Anyway, VDG should decide what is the best and what is consistent with other elements of

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham accepted this revision as: ngraham. ngraham added a comment. Hopefully people won't murder us over one pixel. :) IMO time to finish the bikeshedding if VDG people are happy with it and everyone else can tolerate it. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26813: Have user-manager write to SDDM's new config file

filipf added a comment. For 5.18.1 though maybe we could just roll this version out? REPOSITORY R128 User Manager BRANCH write-autologin-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D26813 To: filipf, #plasma, davidedmundson, ngraham Cc: plasma-devel,

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. Fair point, just checked that now and they're indeed the same. Got confused with 0.65 as 0.65 looks different to 0.5. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: filipf, ndavis,

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75803. The-Feren-OS-Dev added a comment. Went to 0.5, because 0.6 indeed looks just like 0.5 in execution REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75800=75803 BRANCH master REVISION

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. 2*0.7 rounded down is going to be 1. Just divide `units.smallSpacing` by two if you want 1. But then I have to wonder... is it really worth it to add one pixel of spacing? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438

D27438: Increase System Tray Plasmoid spacing value slightly

filipf added a comment. copy paste from Telegram > fwiw I like units.smallSpacing / 2 more but it's not that big of a difference REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: filipf, ndavis, anthonyfieroni,

Re: 2 kirigami fixes for a point release

El diumenge, 16 de febrer de 2020, a les 22:34:51 CET, David Faure va escriure: > On dimanche 16 février 2020 22:17:17 CET Albert Astals Cid wrote: > > This is their fault, they as a distribution have decided to support a random > > KDE Frameworks version for longer than we do support it, so they

Re: 2 kirigami fixes for a point release

On dimanche 16 février 2020 22:17:17 CET Albert Astals Cid wrote: > This is their fault, they as a distribution have decided to support a random > KDE Frameworks version for longer than we do support it, so they are the > ones that should be the job of supporting it. > > It's like you are trying

Re: 2 kirigami fixes for a point release

El dissabte, 15 de febrer de 2020, a les 20:35:23 CET, Nate Graham va escriure: > On 2020-02-15 11:55, Ben Cooksley wrote: > > My point above was that the version you decide to freeze on should > > only be the version you depend on during development. > > The version you depend on when you release

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev updated this revision to Diff 75800. The-Feren-OS-Dev added a comment. Changed value to Math.round(units.smallSpacing * 0.7) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75785=75800 BRANCH master REVISION DETAIL

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Nevermind, then, I guess something changed between now and Plasma 5.18.1 master code meaning that no longer works, back to the old method... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg

D27189: Created a top area based on widgets/toparea.svg

niccolove added a comment. See D27444 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev planned changes to this revision. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Managed to come to a good compromise, however now I've hit a bit of a roadblock. I've found that by editing these lines: property int left:

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

davidedmundson added a comment. > More generally, should we be porting towards Kirigami.Units everywhere? "everywhere" is complex. If it was using the API from kirigami's theme plugin, it should be ported. If it was resolving against the one from PlasmaCore, that's fine.

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. After a bit more digging around the code, I found another alternative way to do this which also fixes a bug I just noticed with this patch (there's clicking deadzones in-between the tray icons), however the method for doing it causes this spacing:

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

davidre added a comment. I think the commit message got bit messed up David, pls fix before commiting :) In D27442#612482 , @ngraham wrote: > More generally, should we be porting towards `Kirigami.Units` everywhere? I think

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

davidre added a comment. After clicking through the before after I still think it's to much REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. In D27438#612484 , @ngraham wrote: > Also, it's nice to have the "after" versions right after each corresponding "before" version so you can more easily compare them by clicking on one and navigating between

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ngraham added a comment. Also, it's like to have the "after" versions right after each corresponding "before" version so you can more easily compare them by clicking on one and navigating between them with the arrow keys. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

ngraham added a comment. More generally, should we be porting towards `Kirigami.Units` everywhere? REPOSITORY R104 KScreen BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27442 To: davidedmundson, #plasma, apol Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. In D27438#612463 , @ngraham wrote: > To make this patch easier to review without applying it, please add all the various sets of before-and-after images to the Test Plan section, not in comments. Done.

D27189: Created a top area based on widgets/toparea.svg

ngraham added a comment. Can you submit the patch that adds `widgets/toparea` so I can play around with this here? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: ngraham, ndavis, plasma-devel, Orage,

D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY units lowercase is defined by PlasmaCore as a singleton (which we

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ngraham resigned from this revision. ngraham added a comment. I have a vertical panel and use large tray icons but intentionally minimize their number, and the result looks fine to me IMO: F8107338: Screenshot_20200216_115030.png However I'll admit

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. VS same but with / 2: F8107328: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: ndavis, anthonyfieroni, davidre, ngraham,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. In D27438#612459 , @ndavis wrote: > Please check how this looks with a vertical panel. Looks a whole lot better on Vertical than without spacing IMHO (unitSpacing): F8107323: image.png

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ndavis added a comment. Please check how this looks with a vertical panel. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ndavis added a comment. In D27438#612440 , @The-Feren-OS-Dev wrote: > Which one would people prefer? > Units.smallSpacing: > F8107285: image.png > > Units.smallSpacing / 2: > F8107287:

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Which one would people prefer? Units.smallSpacing: F8107285: image.png Units.smallSpacing / 2: F8107287: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

davidedmundson added a comment. I thought the bug was that we weren't checking the RC from KService::serviceByStorageId before using it REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi, davidedmundson, #plasma Cc:

D27189: Created a top area based on widgets/toparea.svg

niccolove added a comment. I'm afraid I need help here, I can't figure out the layout. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27189 To: niccolove, #vdg, #plasma, ngraham Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Would people prefer that above design to 4px? ^ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Here's it with / 2 added to the spacing value: F8107253: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: anthonyfieroni,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

anthonyfieroni added a comment. F8107246: Screenshot_20200216_195252.png How it looks now with 0 spacing, with 2 will have no space in panel at all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To:

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

anthonyfieroni added a comment. Maybe units.smallSpacing / 2, i'm pretty sure people that use show all entries in systray will be unhappy to see no free space in their panels. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

davidre added a comment. I think 0 doesn't look cramped at all. Increasing the spacing also increases the space usage . -1 from me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: davidre, ngraham, plasma-devel,

D27438: Set System Tray Plasmoid spacing value from 0 to 3

The-Feren-OS-Dev updated this revision to Diff 75785. The-Feren-OS-Dev added a comment. Changed spacing to units.smallSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75783=75785 BRANCH master REVISION DETAIL

D27438: Set System Tray Plasmoid spacing value from 0 to 3

The-Feren-OS-Dev added a comment. Before: F8107198: image.png After: F8107205: image.png Patch update coming in a bit. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27422: [KCM]Update Device item layout based on applet

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Don't use PlasmaComponents in KCMs; it's for Applets and other elements of the Plasma shell itself. Kirigami is the correct choice for a KCM. REPOSITORY R115 Plasma Audio

D27438: Set System Tray Plasmoid spacing value from 0 to 3

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:290 > id: tasksRow > -spacing: 0 > +spacing: 3 > height: parent.height - (vertical && expander.visible ? >

D27438: Set System Tray Plasmoid spacing value from 0 to 3

The-Feren-OS-Dev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. The-Feren-OS-Dev requested review of this revision. REVISION SUMMARY In my honest opinion Plasma's System Tray Plasmoid's current spacing value is currently set to 0, which leads to

D26111: Runner: make recentdocument use KActivityStats data

ngraham accepted this revision. ngraham added a comment. Works for me with documents on my samba share. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n,

D27420: [Applet]Improvements for unavailable port.

ngraham added inline comments. INLINE COMMENTS > gvgeo wrote in ListItemBase.qml:357 > I wanted to do this change, but this is old code from 5.17. I believe that > translated history must exist, and will automatically be used. Better to change it now to avoid the string puzzle entirely IMO

D27436: Use task rather than tabs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is more semantically correct and a visual improvement IMO. Looks fine to me with Breeze dark and light but we should probably wait for confirmation from heavy Breeze Dark users.

D27436: Use task rather than tabs

niccolove added a comment. ...but that does not seem simple and would be inconsistent with the task view, so we might want to leave that for another patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27436 To: niccolove, #vdg Cc: The-Feren-OS-Dev,

D27436: Use task rather than tabs

niccolove added a comment. In D27436#612343 , @The-Feren-OS-Dev wrote: > To make it stretch to the borders, simply just remove padding from panel.svgz and from the Plasmoid highlight SVG. But themes should be able to set their padding,

D27436: Use task rather than tabs

The-Feren-OS-Dev added a comment. To make it stretch to the borders, simply just remove padding from panel.svgz and from the Plasmoid highlight SVG. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27436 To: niccolove, #vdg Cc: The-Feren-OS-Dev, plasma-devel,

D27436: Use task rather than tabs

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Switch from tabs for pressed applets to tasks. - Tabs should be avoided because it's quite semantically incorrect and I

D27435: Move checked menu item always into range

cordlandwehr created this revision. cordlandwehr added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY This allows to use backend logic, which e.g. has next/previous buttons to

D26871: [examples/simplechatapp] Always set isMenu to true

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2d5674da7b60: [examples/simplechatapp] Always set isMenu to true (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26871?vs=74239=75778

D27109: Fix duplicate results for sessions, simplify and optimize

This revision was automatically updated to reflect the committed changes. Closed by commit R114:2c832dbdd087: Fix duplicate results for sessions, simplify and optimize (authored by alex, committed by cullmann). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27391: [Applet]Fix dimensions of traffic Monitor

gvgeo updated this revision to Diff 75770. gvgeo marked 3 inline comments as done. gvgeo added a comment. Remove double space.te REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27391?vs=75670=75770 BRANCH monitor (branched from

D27393: [Applet]Fix details layout.

gvgeo updated this revision to Diff 75769. gvgeo added a comment. Remove unnecessary anchors. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27393?vs=75674=75769 BRANCH details (branched from master) REVISION DETAIL

D27388: Fix being unable to set the right permissions for kde_settings.conf

This revision was automatically updated to reflect the committed changes. Closed by commit R123:cc33ec575c5e: Fix being unable to set the right permissions for kde_settings.conf (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D26111: Runner: make recentdocument use KActivityStats data

meven marked an inline comment as done. meven added a comment. Please if someone could review/test, it makes the recent document krunner so much more useful, with longer history and gtk apps history. It seems to me like a worthwhile feature. REPOSITORY R120 Plasma Workspace REVISION

Re: 2 kirigami fixes for a point release

On Sun, Feb 16, 2020 at 8:35 AM Nate Graham wrote: > > On 2020-02-15 11:55, Ben Cooksley wrote: > > My point above was that the version you decide to freeze on should > > only be the version you depend on during development. > > The version you depend on when you release will be the next release

D19947: systray: show a small animation on the icons when activated

ndavis added a comment. I don't know why, but this effect has very low FPS, to the point where it's not even visible sometimes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma, ngraham Cc: ndavis, filipf, broulik, anthonyfieroni,

D27422: [KCM]Always allow port selection

gvgeo updated this revision to Diff 75760. gvgeo added a comment. Use PC3 and remove unused imports. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75758=75760 BRANCH kcmports2 REVISION DETAIL

D27422: [KCM]Always allow port selection

gvgeo updated this revision to Diff 75758. gvgeo added a comment. Update Layout REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75743=75758 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 AFFECTED FILES

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. before F8106544: Screenshot_20200216_100603.png after F8106545: Screenshot_20200216_102852.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26861

D27420: [Applet]Improvements for unavailable port.

gvgeo added a comment. > ...it solves the reporter's problem... Not exactly. When an available port gets selected(or is active) port option will disappear again. Only enables complete port selection while an unavailable is the default. > Or has the code diverged between 5.18 and

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

ivan added a comment. Cool idea, I'll have to think of something similar for the regular activity switcher REVISION DETAIL https://phabricator.kde.org/D27322 To: wstephenson, davidedmundson, #plasma, hein Cc: ivan, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,