D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. I'm of mixed minds on the group boxes. With L2TP/IPsec connection setup instructions for macOS and iOS, they typically have screenshots of the "User Authentication" and "Machine Authentication" settings. Many Linux users try to match what they see for other

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. #VDG Does a better way exist, to measure the width of transfer speed text? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27792 To: gvgeo, #vdg, #plasma, jgrulich, ngraham Cc:

D26946: Changed leftMargins to smallSpacing to be consistent

gvgeo added inline comments. INLINE COMMENTS > PopupDialog.qml:120 > boundsBehavior: Flickable.StopAtBounds > -spacing: Math.round(units.gridUnit / 2) > +spacing: Math.round(units.smallSpacing / 2) > I don't see why decrease this spacing. Were you able to

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

ngraham added a comment. -1 for using group boxes. :) I don't think they're needed at all. Just change the "Type:" label to "Authentication:" and that section is clear enough, then just separate the logical sections with whitespace REPOSITORY R116 Plasma Network Management Applet

D27595: Watch for language change events, and forward those to the QML engine

ngraham added a comment. `git bisect` says this caused https://bugs.kde.org/show_bug.cgi?id=418447. F8148416: Spacing sometimes too high.mp4 Would be nice to fix that regression before it gets shipped with Frameworks 5.68. REPOSITORY R169

D24706: [RFC] Change button style

ngraham added a comment. In D24706#595764 , @ngraham wrote: > Thanks Noah. > > So you're the boss after all (as the de- facto Breeze maintainer now), and I think we should follow your lead design-wise. But it might also be interesting to

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76884. gvgeo added a comment. Fix rebase. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76874=76884 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

apol added inline comments. INLINE COMMENTS > iconmodel.h:100 > QStringList m_icons; > QString m_category; > QStringList m_categories; m_category can be removed? > iconmodel.h:102 > QStringList m_categories; > QString m_filter; > QHash m_data; m_filter can be

D27608: Fixes for applet configuration layout.

filipf added a comment. Seems to run pretty well, but there is a tiny padding regression introduced. Using `plasmashell --reverse --replace` to test a right to left layout we see that there is excessive padding between the content and the sidebar. F8148094: image.png

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

davidre added a comment. Ping REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D27421 To: davidre, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76874. gvgeo added a comment. Math round. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76873=76874 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76873. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76519=76873 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27608: Fixes for applet configuration layout.

gvgeo marked an inline comment as done. gvgeo added a comment. I'll give a bit more time, so @filipf gets a chance to check again and accept if possible. REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608

D27608: Fixes for applet configuration layout.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep! Everything else looks good to me. REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo,

D27645: [KCM]Align volume controls row

ngraham added a comment. Needs a rebase REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27422: [KCM]Update Device item layout based on applet

This revision was automatically updated to reflect the committed changes. Closed by commit R115:606c6499750a: [KCM]Update Device item layout based on applet (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76869. gvgeo edited the test plan for this revision. gvgeo added a comment. Restore code for vertical line. Cannot find a reason this happens or replicate. But realized that the change was unnecessary. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D27422: [KCM]Update Device item layout based on applet

ngraham accepted this revision. ngraham added a comment. Ship it, the jagginess is clearly caused by something lower in the stack. REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma,

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg added a reviewer: romangg. romangg added a comment. I am currently working on some projects. But if you don't hear till Sunday from me about this, ping me. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27675 To: dvratil, #plasma, romangg Cc: romangg,

D27697: WIP: Added top area to notification header

ngraham added a comment. Man this looks nice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27697 To: niccolove, broulik Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

ahmadsamir updated this revision to Diff 76868. ahmadsamir added reviewers: broulik, ervin, meven. ahmadsamir added a comment. Tweak REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27785?vs=76779=76868 BRANCH l-fonts-kcm-nearest (branched from

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, broulik, ervin, meven. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY When using ajustAllFonts(), try to set the fixed width/Monospace font from the font

D27807: Changed style of pressed list item to be consistent

ngraham added a comment. In D27807#621347 , @ndavis wrote: > It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. Because then people who are both subscribed to the mailing list and

D27608: Fixes for applet configuration layout.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. So with this patch, I see a new visual issue: the first time I open an applet config window, the vertical separator is not visible: F8147412: Screenshot_20200303_093031.png

D27807: Changed style of pressed list item to be consistent

ndavis added a subscriber: plasma-devel. ndavis added a comment. It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove,

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Right, this is good to go now. We should remove the margin in the checkbox too. REPOSITORY R120 Plasma Workspace BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D27806: fix: consider DSI display to be embedded panel

This revision was automatically updated to reflect the committed changes. Closed by commit R110:624ff86e4766: fix: consider DSI display to be embedded panel (authored by bshah). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27806?vs=76857=76859

D27806: fix: consider DSI display to be embedded panel

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems that way: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_modeset_helper.c#L61 REPOSITORY R110 KScreen Library BRANCH bshah/dsi-embedded

D27806: fix: consider DSI display to be embedded panel

bshah created this revision. bshah added a reviewer: romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY DSI connector type is widely used in mobile and tablet devices. Consider them embedded so

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich added a comment. In D27764#621204 , @dkosovic wrote: > In D27764#621173 , @jgrulich wrote: > > > @dkosovic will you update the review to address my comments? > > > I agree with all

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

dkosovic added a comment. In D27764#621173 , @jgrulich wrote: > @dkosovic will you update the review to address my comments? I agree with all your comments and they are great nitpicks and suggestions. Sorry I didn't have time tonight

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/7/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 03 Mar 2020 12:36:29 + Build duration: 3 min 35 sec and counting CONSOLE OUTPUT

D27799: Use system color scheme from Kirigami instead of Plasma theme color

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c9b2684a49d3: Use system color scheme from Kirigami instead of Plasma theme color (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich added a comment. @dkosovic will you update the review to address my comments? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27764 To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. In D27422#614236 , @ngraham wrote: > I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: > > F8112849: Screenshot_20200219_075319.png > >

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76840. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76475=76840 BRANCH kcmports3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27422

D27577: [KCM]Fix content below scrollbars

This revision was automatically updated to reflect the committed changes. Closed by commit R115:552b0384ffd2: [KCM]Fix content below scrollbars (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76467=76836

D27782: expose IncludeUsage to QML api

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0775faf25323: expose IncludeUsage to QML api (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27782?vs=76774=76835 REVISION DETAIL

D27155: libnotificationmanager : add app-specific kconfig settings

crossi updated this revision to Diff 76834. crossi added a comment. use parentGroup attribute REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=75090=76834 REVISION DETAIL https://phabricator.kde.org/D27155 AFFECTED FILES

D27734: [Applet/TaskManager]Don't create extra PulseAudio component

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bfcc6df32396: [Applet/TaskManager]Dont create extra PulseAudio component (authored by gvgeo). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27799: Use system color scheme from Kirigami instead of Plasma theme color

jgrulich updated this revision to Diff 76830. jgrulich added a comment. Don't use deprecated color REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27799?vs=76824=76830 BRANCH bug-418416 REVISION DETAIL

D27799: Use system color scheme from Kirigami instead of Plasma theme color

davidre added inline comments. INLINE COMMENTS > main.qml:43 > focus: true > -color: theme.backgroundColor > +color: Kirigami.Theme.viewBackgroundColor > } viewBackgroundColor is deprecated `WARNING: viewBackgroundColor is deprecated, use backgroundColor with

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/6/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 03 Mar 2020 09:38:49 + Build duration: 5 min 26 sec and counting CONSOLE OUTPUT

D27776: focus email input line by default

This revision was automatically updated to reflect the committed changes. Closed by commit R871:ed33c2803511: focus email input line by default (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27776?vs=76753=76827 REVISION DETAIL

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/6/ Project: stable-kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 03 Mar 2020 09:38:49 + Build duration: 3 min 14 sec and counting CONSOLE

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. F8146611: Screenshot_20200303_103831.png Seems aligned to me, the problem is that the new small checkbox has a margin to the left by default. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27799: Use system color scheme from Kirigami instead of Plasma theme color

jgrulich added a comment. One thing I'm not sure about whether to use **viewBackgroundColor** or just **backgroundColor**, because I want the buttons to look like they are part of the view. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27697: WIP: Added top area to notification header

niccolove updated this revision to Diff 76825. niccolove added a comment. Components and rounding REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27697?vs=76674=76825 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27697 AFFECTED

D27799: Use system color scheme from Kirigami instead of Plasma theme color

jgrulich created this revision. jgrulich added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY BUG: 418416 REPOSITORY R116 Plasma Network Management Applet BRANCH bug-418416

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 76823. niccolove added a comment. Make anchors fill parent REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76530=76823 BRANCH topbar (branched from master) REVISION DETAIL

D27698: Fix PrivateActionToolButton behaviour with showText vs IconOnly

This revision was automatically updated to reflect the committed changes. Closed by commit R169:6f27f90cfa1e: Fix PrivateActionToolButton behaviour with showText vs IconOnly (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27700: Add an autotest for ActionToolBar

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fd0f3ea202f3: Add an autotest for ActionToolBar (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27700?vs=76556=76820 REVISION DETAIL

D27608: Fixes for applet configuration layout.

gvgeo added a comment. > I'm starting to agree that this is the wrong place to add the titlebar separator. Can this go as is, for now? I don't believe there is an alternative in the near future. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: