Re: Problems in KWayland causes by API and ABI compatibility promises

Am 05.03.20 um 17:27 schrieb Nate Graham: What are the known users of KWayland outside of KWin? Are there any? Quick lxr suggests there's actually a bunch: In Plasma (for which we could do an "integration" library without Frameworks guarantees in plasma-workspace, similar to e.g. LibTaskMana

D27685: Remove extra top and bottom padding from dock widgets

cblack added a comment. This LGTM visually for Dolphin, but I'm not sure how this would look when there's actually content in the areas you're adjusting pixel metrics for. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27685 To: ngraham, #vdg, #breeze, cblack, ndavis

D27565: Hide configure action in Info center mode

ngraham added a comment. Not sure about that, since it's shown in icons view too. So we would need to conditionally show it for icons+systemsettings view and sidebar+systemsettings view. This patch just hides it for sidebar+kinfocenter view, which seems simpler to me. Or maybe I'm misun

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. @broulik I get the sense that you're boycotting this patch :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26718: aggregate text for KRunner in DesktopView

pdabrowski added a comment. In D26718#622311 , @ngraham wrote: > Are you planning to work on that other part in this patch, or in a separate one? I do not plan to change this patch. As for solving the issue with KRunner invoked from sho

D27877: Make panel edit mode tooltip not unexpectedly disappear under certain circumstances

ngraham updated this revision to Diff 77059. ngraham added a comment. Whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27877?vs=77058&id=77059 BRANCH stickier-panel-tooltip (branched from Plasma/5.18) REVISION DETAIL https://phabricato

D27877: Make panel edit mode tooltip not unexpectedly disappear under certain circumstances

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The panel edit mode tooltip can currently disappear in an irritating manner under two circumstanc

D27669: WIP: [kstyle] Tools area

cblack added a comment. In D27669#623035 , @ngraham wrote: > It still crashes with the same backtrace. :( Even with a QPointer wrapper, this crashes. Seems like a Qt bug? There's no reason the object should segfault trying to access

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 77057. cblack added a comment. Use QPointer for tools area animation REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77056&id=77057 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D27669: WIP: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezehelper.cpp:1726 > Then shouldn't you divide device pixel ratio ? > Also, someone else should double check. To me that does not make sense. > Everything else (*everything*) scales with device pixel ratio. Why

D27669: WIP: [kstyle] Tools area

ngraham added a comment. It still crashes with the same backtrace. :( REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGa

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 77056. cblack added a comment. Ensure that pointers are non-null before trying to use them REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77055&id=77056 BRANCH cblack/toolsarea REVISION DETAIL https://phabri

D27669: WIP: [kstyle] Tools area

ngraham added a comment. This latest iteration makes Telegram crash for me now. Backtrace: Thread 1 "telegram-deskto" received signal SIGSEGV, Segmentation fault. QAbstractAnimation::setDirection (this=0x583e16a0, direction=QAbstractAnimation::Forward) at animation/qabs

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 77055. cblack added a comment. Make less crashy, address feedback REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76706&id=77055 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFF

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#623019 , @mart wrote: > In D27845#622178 , @ngraham wrote: > > > Not as touch-friendly, but the clock text looks better and it won't be so huge for people using lo

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

mart added a comment. In D27845#622178 , @ngraham wrote: > Not as touch-friendly, but the clock text looks better and it won't be so huge for people using low-DPI screens. However 38 is not easy to calculate by our existing units so it would lik

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

filipf added inline comments. INLINE COMMENTS > layout.js:28 > +// For an Icons-Only Task Manager on the bottom, *3 is too much, *2 is too > little > +panel.height = Math.round(gridUnit * 2.5) > can we do `Math.round(gridUnit * 2.25)` or at least `Math.round(gridUnit * 2.33)` ? That's about

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#622970 , @kmaterka wrote: > Should System Tray icons be larger then? Here's how it would look to go from `iconSize=1` to `iconSize=2` (i.e, 16px to 22px): F815: Bigger.png

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 77053. ngraham added a comment. Use a gridUnit-based measurement again, and increase the thickness a bit to effectively 46px tall, which I really don't think is excessive REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D27608: Fixes for applet configuration layout.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d6731530bb43: Fixes for applet configuration layout. (authored by gvgeo). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=77046&id=77050 REVISION DE

D27823: Use consistent highlight

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConnectionItem.qml:54 > > +onContainsMouseChanged: { > +if (containsMouse) { `ConnectionItem.qml` already has `onContainsMouseChanged` (at the

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

kmaterka added a comment. Should System Tray icons be larger then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: kmaterka, gvgeo, davidedmundson, ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeG

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. @davidedmundson one problem here is that a `gridUnit` is a fairly coarse unit of measurement, and gridUnit * 3, or 54px is a bit larger than we'd like, but the current thickness (gridUnit *2, or 36px) is too thin. We initially settled on something in the mid 40s, but

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

gvgeo added a comment. IMO better use Math.round(gridUnit*2.1) than fixed value that will not always look good with a scaled display. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: gvgeo, davidedmundson, ndavis, KonqiDra

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. @davidedmundson Nate says smallSpacing doesn't work here. Do you know why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: davidedmundson, ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev, plasma-de

D27870: [applets/systemtray] Right align popup heading when in RTL mode

gvgeo added a comment. It seems that QQC2 as long a horizontal value is set, will flip it around. Otherwise will use the default direction left. Agree, looks like a bug. Kirigami and frameworks are the places where this should be set. Already have corrected the other patch. REPOSITORY R1

Re: Problems in KWayland causes by API and ABI compatibility promises

Moving it into KWin itself seems sane to me, on the surface. What are the known users of KWayland outside of KWin? Are there any? Nate On 3/5/20 5:21 AM, Vlad Zahorodnii wrote: Hi, KWayland is a library that provides convenience wrappers for Wayland protocols. Usually, when we want to impl

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

davidedmundson added inline comments. INLINE COMMENTS > layout.js:28 > > -panel.height = gridUnit * 2 > +// Same as the default height of the Windows panel > +panel.height = 38 I'm seeing this on too many tickets where we replace doing any design and thinking for being lazy copy cats. If peo

D27870: [applets/systemtray] Right align popup heading when in RTL mode

ngraham added a comment. I doubt it. left-alignment is already the effective default anyway, so I'm actually surprised that explicitly setting it here makes RTL work. This hints at a deeper bug somewhere, unfortunately. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricato

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in layout.js:29 > why is this no longer unit based Because VDG people wanted a size that isn't a multiple or clean divisor of `gridUnit` and none of the other units values would evaluate for some reason. Some people think 38

D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

ahmadsamir added a comment. FTR, I had submitted this https://codereview.qt-project.org/c/qt/qtbase/+/292695 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27830 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport Cc: plasma-devel, Orage, L

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

davidedmundson added inline comments. INLINE COMMENTS > layout.js:29 > +// Same as the default height of the Windows panel > +panel.height = 38 > why is this no longer unit based REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 77046. gvgeo added a comment. Remove title alingment for kirigami change. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=77017&id=77046 BRANCH configscollcat (branched from master) REVISION DETAIL ht

D27874: Disable the audio stream indicator for IOTM

ndavis updated this revision to Diff 77045. ndavis added a comment. - Use an option instead REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27874?vs=77043&id=77045 BRANCH disable-audioindicator-iotm (branched from master) REVISION DETAIL https:/

D27874: Disable the audio stream indicator for IOTM

ndavis added a comment. Do we really want a feature that new users have to learn to dodge? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh

D27874: Disable the audio stream indicator for IOTM

gvgeo added a comment. Disable the mute function then. And maybe add as an option. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,

D27869: Separate processcore/{formatter,unit} into its own library

zzag added inline comments. INLINE COMMENTS > ahiemstra wrote in unit.h:81 > Blame @zzag for that who wrote the original code. :P > > That said, we probably should consider how to deal with localization issues > like that at some point in the future. Oops, sorry. REPOSITORY R111 KSysguard L

D27874: Disable the audio stream indicator for IOTM

ndavis updated this revision to Diff 77043. ndavis added a comment. - Hide audio indicator setting for IOTM REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27874?vs=77040&id=77043 BRANCH disable-audioindicator-iotm (branched from master) REVISION

D27870: [applets/systemtray] Right align popup heading when in RTL mode

filipf added a comment. In D27870#622843 , @ngraham wrote: > Feels like this should be set by default in the `Heading` item, or else we'll be doing this everywhere, no? Sounds like a better solution. I'm not sure if it would interfere wit

D27869: Separate processcore/{formatter,unit} into its own library

ahiemstra added a subscriber: zzag. ahiemstra added inline comments. INLINE COMMENTS > ngraham wrote in unit.h:81 > No Fahrenheit for us poor Americans? :) Blame @zzag for that who wrote the original code. :P That said, we probably should consider how to deal with localization issues like that

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#622739 , @ndavis wrote: > I don't want to turn this into bikeshedding, but I think a size of 42 is better because that raises the size of task manager icons to 32px. 22px is pretty small for an IOTM. > With

D27874: Disable the audio stream indicator for IOTM

ngraham added a comment. I can't say that it's gotten in the way for me either, with my thick panel. It does overlap the badge icon though which is a bit annoying. Also yes, if you want to remove this from the IOTM, you need to hide the setting on the IOTM's config page too. REPOSITORY

D27874: Disable the audio stream indicator for IOTM

broulik added a comment. -1 to removing this feature. You also need to remove the checkbox on the settings page then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: broulik, cblack, plasma-devel, Orage, LeGast00n, The-

D27874: Disable the audio stream indicator for IOTM

cblack added a comment. -1, the badge hasn't gotten in my way since the first week or so using it, despite the small size of my panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: cblack, plasma-devel, Orage, LeGast00n,

D27870: [applets/systemtray] Right align popup heading when in RTL mode

ngraham added a comment. Feels like this should be set by default in the `Heading` item, or else we'll be doing this everywhere, no? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27870 To: filipf, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27874: Disable the audio stream indicator for IOTM

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY After having used it for months, it still gets in the way when used with the Icons-only Task Man

D27155: libnotificationmanager : add app-specific kconfig settings

ervin accepted this revision. ervin added a comment. Although might become "parentGroupName" depending on what you do about my comments on the review introducing sub-group handling. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27155 To: crossi, ervin, br

D27869: Separate processcore/{formatter,unit} into its own library

ahiemstra updated this revision to Diff 77038. ahiemstra added a comment. - Fix qmldir file - Also register meta type of MetricPrefix so it can actually be used - Add a manual test to test how Formatter works from QML REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https:/

D27868: [plasma-session] Continue to start kdeinit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:45ca31099613: [plasma-session] Continue to start kdeinit (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27868?vs=77023&id=770

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. In D27845#622434 , @KonqiDragon wrote: > Why Show/Hide Desktop icon is so huge? Because icon sizing in panels is a mess. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To:

D27870: [applets/systemtray] Right align popup heading when in RTL mode

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY In RTL modes headings should be on the right, not on the left as is currently the case. Filling the layout's width is not enough

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. I don't want to turn this into bikeshedding, but I think a size of 42 is better because that raises the size of task manager icons to 32px. 22px is pretty small for an IOTM. With that said, I think something we'll have to work on is finding ways to improve the way p

D27868: [plasma-session] Continue to start kdeinit

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fixes thumbnail generation and other issues for me. Short-term this is fine. But since this kdeinit stuff is layered in wrappers upon wrappers I think getting rid of it entirely is a

D27608: Fixes for applet configuration layout.

filipf accepted this revision. filipf added a comment. Good stuff REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf, ngraham Cc: ngraham, filipf, plasma-devel, Orage, LeGast00

D27869: Separate processcore/{formatter,unit} into its own library

ngraham added inline comments. INLINE COMMENTS > unit.h:81 > -// Misc units. > -UnitCelsius = 500, > -UnitDecibelMilliWatts, No Fahrenheit for us poor Americans? :) REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D27869 To: ahiemstra, #plasma Cc:

D27869: Separate processcore/{formatter,unit} into its own library

ahiemstra updated this revision to Diff 77027. ahiemstra added a comment. - More minor corrections REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27869?vs=77025&id=77027 BRANCH formatter_lib REVISION DETAIL https://phabricator.kde.org/D27869

D27869: Separate processcore/{formatter,unit} into its own library

ahiemstra updated this revision to Diff 77025. ahiemstra added a comment. - Correct comment REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27869?vs=77024&id=77025 BRANCH formatter_lib REVISION DETAIL https://phabricator.kde.org/D27869 AFFEC

D27869: Separate processcore/{formatter,unit} into its own library

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This moves Formatter and Unit out of ProcessCore and into its own Formatter library. This

D26718: aggregate text for KRunner in DesktopView

ngraham added a comment. In D26718#622618 , @davidedmundson wrote: > > Are you planning to work on that other part in this patch, or in a separate one? > > To do what exactly? Find another way to fix the problem of keystrokes getting

D27868: [plasma-session] Continue to start kdeinit

davidedmundson added a comment. I kinda feel this is a bodge fix and we should find what's wrong with whoever is autoactivating kdeinit, but I don't like leaving master with a regression. So I'll let someone else decide if we accept this or not. REPOSITORY R120 Plasma Workspace REVISI

D27868: [plasma-session] Continue to start kdeinit

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This was a deliberate decision to remove this in c673a832263036e239587c9a2b

D27867: Rename tests to autotests

This revision was automatically updated to reflect the committed changes. Closed by commit R111:78d78d2ace48: Rename tests to autotests (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27867?vs=77019&id=77020#toc REPOSITORY R111 KSysguard Library CHANGES SINCE L

D27867: Rename tests to autotests

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This matches frameworks and allows for a separate manual tests dir. TEST PLAN Tests still

D27792: [Applet]Fix traffic monitor labels width

This revision was automatically updated to reflect the committed changes. Closed by commit R116:986341a3fae8: [Applet]Fix traffic monitor labels width (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27792?vs=76797&i

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 77017. gvgeo added a comment. Prevent vertical scrollbar from popping on/off internally. Fix title alignment for RTL. I tried splitting into two patches, to separate the height loop changes, but could not find a good point to cut the patch. All the

D27866: Make it compile against qt5.15. ::unite is deprecated.

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Make it compile against qt5.15 REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH build_against_qt5.15 (branched from mas

Problems in KWayland causes by API and ABI compatibility promises

Hi, KWayland is a library that provides convenience wrappers for Wayland protocols. Usually, when we want to implement some Wayland protocol, first, we add corresponding wrappers in KWayland and after that we actually implement the protocol in KWin. Unfortunately, we made a bad design choice

D26718: aggregate text for KRunner in DesktopView

davidedmundson added a comment. > Are you planning to work on that other part in this patch, or in a separate one? To do what exactly? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ng

D27838: Port to new QML Connections syntax

davidedmundson added a comment. Relevant temporary "fix": https://codereview.qt-project.org/c/qt/qtdeclarative/+/293011 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27838 To: jbbgameich, #frameworks, apol Cc: davidedmundson, apol, plasm

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

KonqiDragon added a comment. In D27845#622551 , @niccolove wrote: > The plasma logo is also quite big. For reference, here's my 38px panel: > F8152196: image.png It's looks so small (to me), but f

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. The plasma logo is also quite big. For reference, here's my 38px panel: F8152196: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: KonqiDragon, ni

D27824: Use consistent highlight

niccolove added a comment. Seems correct to me - rather, the nm button is way too on the right. I could make that one consistent instead. REPOSITORY R97 Bluedevil BRANCH highlight (branched from master) REVISION DETAIL https://phabricator.kde.org/D27824 To: niccolove, #plasma, #vdg,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77004. niccolove added a comment. Nope REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77003&id=77004 BRANCH highlight (branched from master) REVISION DETAIL https://phabricator.

D27823: Use consistent highlight

niccolove updated this revision to Diff 77003. niccolove added a comment. Right margin of button REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77001&id=77003 BRANCH highlight (branched from master) REVISION DETAIL ht

D27824: Use consistent highlight

niccolove updated this revision to Diff 77002. niccolove added a comment. Remove previous highlight REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27824?vs=76912&id=77002 BRANCH highlight (branched from master) REVISION DETAIL https://phabricator.kde

D27823: Use consistent highlight

niccolove added a comment. Ah, this one. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen

D27823: Use consistent highlight

niccolove updated this revision to Diff 77001. niccolove added a comment. Remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=76911&id=77001 BRANCH highlight (branched from master) REVISION DETAIL http

D27823: Use consistent highlight

niccolove added a comment. In D27823#621958 , @ngraham wrote: > This needs a rebase. Also you probably need to delete the existing mouseover highlight effect. Git is telling me this is up to date. Also, what existing mouseover effect? RE

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

KonqiDragon added a comment. In D27845#622178 , @ngraham wrote: > Some folks in the #VDG channel have objected to the panel being 48px tall, so here's how it would look at 38 (the default Windows panel heig