KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.14 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.14/7/ Project: kf5-qt5 SUSEQt5.14 Date of build: Tue, 07 Apr 2020 05:09:28 + Build duration: 42 min and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 07 Apr 2020 05:09:28 + Build duration: 18 min and counting CONSOLE OUTPUT [...t

D28214: Add background portal

This revision was automatically updated to reflect the committed changes. Closed by commit R838:0cefb5e18db4: Add background portal (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28214?vs=79515&id=79551#toc REPOSITORY R838 Flatpak Support: KDE Portal for XDG Des

D28643: WIP, RFC: Add ColorInfo class

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY ColorInfo is an object that computes colour information about a given item. TEST PLAN WIP.

D28214: Add background portal

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > jgrulich wrote in background.cpp:194 > Doesn't need to? I think it just specifies that the desktop file should > ignore the exec line and start it through DBus (assuming co

D27979: Add top area to notifications

ngraham added a comment. So I think the padding issue isn't related to fonts after all. I noticed while doing a backup today that there's no spacing between the header and the content underneath it even when there's no text. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabr

D28631: Remove Icons from system tray item tooltips

ngraham updated this revision to Diff 79545. ngraham added a comment. Remove no-longer-relevant reference to icon in `AbstractItem.qml` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28631?vs=79511&id=79545 BRANCH remove-systemtray-tooltip-icons

Re: Looking for GSoC 2020 mentor

TL:DR: If you are willing to mentor please: 1. write to kde-soc-managem...@kde.org and ask to be invited to the GSoC webapp 2. subscribe to kde-soc-men...@kde.org ML if you are not now subbed. Valorie On Mon, Apr 6, 2020 at 4:05 AM Marco Martin wrote: > On Mon, Apr 6, 2020 at 12:13 PM Debarpan

D28631: Remove Icons from system tray item tooltips

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. In D28631#643116 , @davidre wrote: > I would argue that the implementation is free to ignore it > `Data structure that descri

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 34 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/34/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 20:53:41 + Build duration: 7 min 41 sec and counting JUnit Tests Name: p

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.14 - Build # 12 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.14/12/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Mon, 06 Apr 2020 20:53:38 + Build duration: 6 min 30 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.14 - Build # 16 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.14/16/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 20:53:39 + Build duration: 4 min 51 sec and counting JUnit Tests

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/26/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 20:53:42 + Build duration: 4 min 19 sec and counting JUnit Tests Name: pro

D28134: Add ColorUtils

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:4c7780ea5cf7: Add ColorUtils (authored by cblack). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28134?vs=7952

D28134: Add ColorUtils

mart added a comment. thanks, almost ready to go :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart, davidedmundson Cc: fvogt, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart

D28134: Add ColorUtils

cblack updated this revision to Diff 79525. cblack added a comment. ​ REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=79333&id=79525 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES CMakeLists.tx

D28517: Send notification when screencasting fails

cblack updated this revision to Diff 79524. cblack marked 4 inline comments as done. cblack added a comment. Address feedback REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28517?vs=79237&id=79524 BRANCH arcpatch-D2851

D28034: [Applet] Port to ExpandableListItem

jgrulich added a comment. In D28034#643194 , @ngraham wrote: > Yeah, the PC3 busy indicator component itself seems to be to blame for items 1 and 3. I'll look into it. > > I hadn't really considered #2 as a valid use case while working on the

D27271: [kcms/colors] RFC: Accent Colours

ngraham added a comment. Whoops, my bad. Tested this and found that setting an accept color seems to work for apps and Plasma (yay), but unsetting it doesn't go back to the color-scheme-provided one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271

D28034: [Applet] Port to ExpandableListItem

ngraham added a comment. Yeah, the PC3 busy indicator component itself seems to be to blame for items 1 and 3. I'll look into it. I hadn't really considered #2 as a valid use case while working on the component, but I can look into it. REPOSITORY R116 Plasma Network Management Applet

D27271: [kcms/colors] RFC: Accent Colours

cblack added a comment. In D27271#643189 , @ngraham wrote: > This doesn't compile for me: > > /home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp: In member function ‘void SchemeEditorColors::updateColorSchemes()’: >

D28034: [Applet] Port to ExpandableListItem

jgrulich added a comment. Both issues fixed, however I found two news: 1. Getting file:///usr/lib64/qt5/qml/org/kde/plasma/extras/ExpandableListItem.qml:438:13: QML BusyIndicator: Binding loop detected for property "implicitHeight" spammed in terminall from plasmashell process, but this

D27271: [kcms/colors] RFC: Accent Colours

ngraham added a comment. This doesn't compile for me: /home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp: In member function ‘void SchemeEditorColors::updateColorSchemes()’: /home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp:378:16: erro

D28034: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 79522. ngraham added a comment. - Don't switch to the details tab when showing the expanded view - Re-enable the Connect button when hiding the password field REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabric

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.14/11/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Mon, 06 Apr 2020 18:54:29 + Build duration: 41 sec and counting CONSOLE OUTPUT [..

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.14 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.14/15/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 18:54:29 + Build duration: 27 sec and counting CONSOLE OUTPUT

D28632: use the decoded url for launcherPosition

ngraham added a comment. Not `Plasma/5.18`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28632 To: mart, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himce

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. The blocking bug was just fixed with D28632 , therefore... ping! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: mart, filipf, kmaterka, gvgeo, davidedmu

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 33 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/33/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 18:30:44 + Build duration: 2 min 57 sec and counting CONSOLE OUTPUT [...t

D28632: use the decoded url for launcherPosition

This revision was automatically updated to reflect the committed changes. Closed by commit R120:627920bdfe14: use the decoded url for launcherPosition (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28632?vs=79512&id=79518 REVISION

D28632: use the decoded url for launcherPosition

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This completely fixes the issue for me. Stable branch, probably. REPOSITORY R120 Plasma Workspace BRANCH phab/launchers REVISION DETAIL https://phabricator.kde.org/D28632 To:

D28214: Add background portal

jgrulich updated this revision to Diff 79515. jgrulich marked 5 inline comments as done. jgrulich added a comment. Update to fix review comments REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78272&id=79515 BRAN

D28214: Add background portal

jgrulich added inline comments. INLINE COMMENTS > apol wrote in background.cpp:69 > I don't really understand why we're exposing this. Is it for contained apps? This is actually not API exposed to the clients, this is purely for xdg-desktop-portal needs, while the client interface (xdg-desktop-

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 79514. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=77053&id=79514 BRANCH iotm-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D27845

D27271: [kcms/colors] RFC: Accent Colours

cblack updated this revision to Diff 79513. cblack added a comment. Emit global settings change when accent colour changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27271?vs=75318&id=79513 BRANCH arcpatch-D27271 REVISION DETAIL https://pha

D28632: use the decoded url for launcherPosition

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY launchersOrder and the actual url data can be different: in case of preferred:/ urls launcherorder will h

D28631: Remove Icons from system tray item tooltips

davidre added a comment. In D28631#643111 , @kmaterka wrote: > For SNI, maybe we should consider showing an icon, but only if it is explicitly set? It is part of the specification

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. I looked at the `IconItem` implementation. Before add theme directory support I would like to perform some refactoring - D28470 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To: davidr

D28631: Remove Icons from system tray item tooltips

kmaterka added a comment. For SNI, maybe we should consider showing an icon, but only if it is explicitly set? It is part of the specification after all. From the other side it will be inconsistent... R

D28631: Remove Icons from system tray item tooltips

ngraham updated this revision to Diff 79511. ngraham marked an inline comment as done. ngraham added a comment. Revert change to remove code from the Data Engine REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28631?vs=79510&id=79511 BRANCH remov

D28631: Remove Icons from system tray item tooltips

davidre added a reviewer: kmaterka. davidre added inline comments. INLINE COMMENTS > statusnotifieritemsource.cpp:342 > setData(QStringLiteral("ToolTipSubTitle"), QString()); > -setData(QStringLiteral("ToolTipIcon"), QString()); > -} else { we conside

D28631: Remove Icons from system tray item tooltips

ngraham created this revision. ngraham added reviewers: Plasma, davidre, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY It was decided in T12778 to remove icons fr

Re: KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Failing!

*18:17:26* /usr/home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 FreeBSDQt5.14/applets/taskmanager/plugin/backend.cpp:27:10: fatal error: 'KNotificationJobUiDelegate' file not found*18:17:26* #include should be just a case of waiting for knotifications to sync.

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/25/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 17:15:13 + Build duration: 2 min 21 sec and counting CONSOLE OUTPUT [...tru

D28629: [WIP] Port KCM to SettingStateBinding

crossi updated this revision to Diff 79508. crossi added a comment. port KCM cursor theme REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28629?vs=79507&id=79508 REVISION DETAIL https://phabricator.kde.org/D28629 AFFECTED FILES kcms/baloo/packag

D28629: [WIP] Port KCM to SettingStateBinding

crossi updated this revision to Diff 79507. crossi added a comment. fix import REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28629?vs=79506&id=79507 REVISION DETAIL https://phabricator.kde.org/D28629 AFFECTED FILES kcms/baloo/package/contents/

D28629: [WIP] Port KCM to SettingStateBinding

crossi created this revision. crossi added reviewers: ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY same as D27841 , depends on D27840

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

ngraham added a comment. Dang this looks so good. +1 for the visuals at least. REPOSITORY R169 Kirigami BRANCH card_shadowrect REVISION DETAIL https://phabricator.kde.org/D28625 To: ahiemstra, #kirigami, #vdg, cblack Cc: ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2,

D28627: WIP: Made panel opaque on maximized window

ngraham added a comment. In D28627#643038 , @davidedmundson wrote: > Why? See the discussion in D28353 . Essentially, we ran into a design issue whereby increasing the transparency of the panel lo

D28627: WIP: Made panel opaque on maximized window

davidedmundson added a comment. Why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, hi

D28461: In sidebar mode show if a module is in default state or not

bport updated this revision to Diff 79499. bport added a comment. Change icon with a blue dot REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28461?vs=78970&id=79499 REVISION DETAIL https://phabricator.kde.org/D28461 AFFECTED FILES core/MenuIte

D28383: Add PageRouter component

cblack added inline comments. INLINE COMMENTS > mart wrote in pagerouter.h:12 > is this still needed for routes that are a composition of PageRoute objects > like /path/to/some/thing? This is an internal struct for keeping track of internal state and to have a C++ representation of a a QJSValu

D28383: Add PageRouter component

cblack updated this revision to Diff 79498. cblack marked 4 inline comments as done. cblack added a comment. Better documentation comment REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79320&id=79498 BRANCH cblack/pagerouter REVISION DETAIL

D28462: [KCM] Add color state probe to allow system settings to display current default state

bport updated this revision to Diff 79497. bport added a comment. Adapt to kcmutils update and add cursor, fonts, spellchecking example REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28462?vs=78971&id=79497 REVISION DETAIL https://phabricator.kde.

D28627: WIP: Made panel opaque on maximized window

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY The idea is to offer an option, possibly default, to make the panel opaque when a window is maximized on the same screen. Th

D28192: WIP: Refactor dictionary runner

sitter added inline comments. INLINE COMMENTS > alex wrote in dictionaryrunner_config.cpp:29 > That makes sense but one question: The doc says: `...However, if you for some > reason reimplement it and also are using KConfigXT, you must call this > function`, does this mean we can assume that th

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

nicolasfella added a comment. This fixes https://bugs.kde.org/show_bug.cgi?id=415526 REPOSITORY R169 Kirigami BRANCH card_shadowrect REVISION DETAIL https://phabricator.kde.org/D28625 To: ahiemstra, #kirigami, #vdg, cblack Cc: nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, do

D28626: [plasma-session] Don't prematurely cache systemEnvironemnt

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY plasma-session goes to great lengths to make sure we have the latest env va

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Looks like a nice visual improvement. Are the changes to the scenegraph stuff related? They don't look like a related change to making the Kirigami.Card use the ShadowedRectangle to me.

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

ahiemstra created this revision. ahiemstra added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This switches cards to use ShadowedRectangle for their background. It also refreshe

D28614: Add better player tab crash handling

ngraham accepted this revision. ngraham added a comment. I have the same issue with Firefox and can confirm that this fixes it! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack, ngraham Cc: ngraham, plasma-d

D28034: [Applet] Port to ExpandableListItem

ngraham planned changes to this revision. ngraham added a comment. Thanks for the review. Will fix. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28034 To: ngraham, #vdg, #plasma, jgrulich Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Fere

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 79488. gikari added a comment. - Add missed Licence header - Remove unnecessary CMake commands REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=79485&id=79488 BRANCH decorations-appearance (

D28192: WIP: Refactor dictionary runner

alex added inline comments. INLINE COMMENTS > sitter wrote in dictionaryrunner_config.cpp:29 > That's an implementation detail though, is it not? From the outside we > shouldn't make assumption about what the implementation does unless the > documentation says what we can assume. > Today the ba

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Currently GTK applications with Client Side Decoration always use decorations from the respected GTK CSS theme. Because of CSS natur

D28576: Converted to page and added Heading

niccolove added a comment. Ok, should be fine now REPOSITORY R120 Plasma Workspace BRANCH notification_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28576 To: niccolove, #plasma, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jral

D28576: Converted to page and added Heading

niccolove updated this revision to Diff 79484. niccolove added a comment. Fixed layouts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28576?vs=79347&id=79484 BRANCH notification_page_heading (branched from master) REVISION DETAIL https://pha

D28192: WIP: Refactor dictionary runner

sitter added inline comments. INLINE COMMENTS > alex wrote in dictionaryrunner.cpp:90 > The current behavior is that KRunner closes when a match is selected. > But if you set the data, for instance: > `match.setData(QStringLiteral("Hello There!"));` > The text `Hello There!` will show up in KRunn

D28575: Make headings of systray and applet merge

niccolove added a comment. Should be fixed now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28575 To: niccolove, #plasma, #vdg Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 79483. niccolove added a comment. Unnecessary newline REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79482&id=79483 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL https://p

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 79482. niccolove added a comment. There was a wrong spacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79477&id=79482 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL htt

D28314: Allow setting separate corner radii for ShadowedRectangle

This revision was automatically updated to reflect the committed changes. Closed by commit R169:eb4e9064e7e4: Allow setting separate corner radii for ShadowedRectangle (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=79075&id=7

D28027: fix line rating for new format when function name is missing

This revision was automatically updated to reflect the committed changes. Closed by commit R871:113b91bfee13: fix line rating for new format when function name is missing (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28027?vs=77562&id=79

D28026: further constrict line parsing of .so files

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R871:dd180bb4d057: further constrict line parsing of .so files (authored by sitter). CHANGED PRIOR TO COMMIT https://phab

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 79477. niccolove added a comment. Generic fixes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79344&id=79477 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL https://phabric

D28214: Add background portal

apol added inline comments. INLINE COMMENTS > background.cpp:69 > +qCDebug(XdgDesktopPortalKdeBackground) << "GetAppState called: no > parameters"; > +return m_appStates; > +} I don't really understand why we're exposing this. Is it for contained apps? > background.cpp:133 > + > +

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

ahiemstra added inline comments. INLINE COMMENTS > acpi.c:73 > > -void registerBatteryRate(int number, struct SensorModul *sm) > +void registerBatteryEnergy(char name, int number, struct SensorModul *sm) > { Uhm, this should be `const char *name` right? I don't really see how this can work o

D28461: In sidebar mode show if a module is in default state or not

bport added inline comments. INLINE COMMENTS > mart wrote in CategoriesPage.qml:207 > try to keep the item count as small as possible, especially in item delegates. > I would really prefer if we could do without this wrapper Indeed this wrapper is not needed > mart wrote in SubCategoryPage.qml:

D28616: Split KWin startup out of KSMServer

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Direction is beautiful, so much red! INLINE COMMENTS > logout.cpp:229 > +auto saveSessionCall = > m_kwinInterface->aboutToSaveSession(currentSession()); >

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. > I would argue for just removing the `grp.writeEntry("dbfile", m_dbFile)` line. This keeps the current behavior for the second group, and still solves the problem for the first group when there is no config yet. Only users of the second group with an existing config ha

D28619: BookmarksRunner: Remove caching of profile database path

bruns added a comment. There are two possible ways of changing the caching, and each one will break behavior for one of two different groups of users: 1. People who rely on the krunner following the default profile. 2. People who rely on krunner using the dbfile config entry. I wou

D28618: ScreenSharing: close dialogs when session is closed

This revision was automatically updated to reflect the committed changes. Closed by commit R838:a1128f123e3b: ScreenSharing: close dialogs when session is closed (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.

Re: Looking for GSoC 2020 mentor

On Mon, Apr 6, 2020 at 12:13 PM Debarpan Debnath wrote: > > One way to do that could be, we could have a prompt for the user asking > whether they would like to switch to night mode now, or change to night mode > after x minutes, or ask again in y minutes, or don't change. perhaps a notification

monday meeting notes from 6/4/2020

Nico: * Attempted to make the call UI in plasma-dialer a bit less horrible https://invent.kde.org/kde/plasma-dialer/-/merge_requests/12 * Hide the notification close button on mobile as per VDG request Diff 28526 "[notifications] Hide close/configure buttons on mobile" [Needs Review] https://p

D28619: BookmarksRunner: Remove caching of profile database path

alex created this revision. alex added reviewers: Plasma, bruns, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY As requested in D28196 this patch removes the caching

Re: Looking for GSoC 2020 mentor

One way to do that could be, we could have a prompt for the user asking whether they would like to switch to night mode now, or change to night mode after x minutes, or ask again in y minutes, or don't change. Get Outlook for Android From:

D28618: ScreenSharing: close dialogs when session is closed

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY When session is closed, for example when user cancells the request through a browser dialog, we also need to close the portal d

D28614: Add better player tab crash handling

broulik added a comment. Waiting for @cblack since they were who mentioned this issue REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28614: Add better player tab crash handling

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. For false positives the player would get added again by the `playing` event, which is not ideal, but as it doesn't require a reload it's IMO close enough. REPOSITORY R856 Plasma Browser Int

Re: Looking for GSoC 2020 mentor

Am 06.04.20 um 11:34 schrieb Marco Martin: in general the idea is nice.. tough a concern is that the theme switching is a quite expensive operation and quite abrupt and not gradual.. it may interrupt the work of the user in an unexpected way when the switch is done Yeah, I would like to ha

D28616: Split KWin startup out of KSMServer

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This patch removes startup of window manager out of KSMServer. It also removes the usage of SM pr

D28614: Add better player tab crash handling

fvogt added a comment. In D28614#642630 , @broulik wrote: > > If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? > > I believe whenever a player starts playing agai

Re: Looking for GSoC 2020 mentor

in general the idea is nice.. tough a concern is that the theme switching is a quite expensive operation and quite abrupt and not gradual.. it may interrupt the work of the user in an unexpected way when the switch is done On Thu, Apr 2, 2020 at 11:14 AM Nghĩa Nguyễn Hồ Hữu wrote: > Dear Plasma

D28575: Make headings of systray and applet merge

manueljlin added a comment. The last one doesn't have a sidebar and goes back to the list after pressing the back button. It looks a bit cleaner but UX wise it's a bit worse too, having to click two times to do what currently only requires one. I prefer the first and second design but since

D28461: In sidebar mode show if a module is in default state or not

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in CategoriesPage.qml:207 > `Kirigami.Units.iconSizes.small` and elsewhere > > Why do you need this wrapper `Item`, though? try to keep the item co

D28526: [notifications] Hide close/configure buttons on mobile

mart added a comment. having just the circle anim and no closebutton would be fine i think.. at least, i would prefer if it would retain some sort of visual countdown REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28526 To: nicolasfella, #plasma, #plasma:_

D28575: Make headings of systray and applet merge

mart added a comment. I like the idea of that back button in the sidebar. @manueljlin how would the last mockup work? (back button and no sidebar) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28575 To: niccolove, #plasma, #vdg Cc: mart, manueljlin, ogna

D28576: Converted to page and added Heading

niccolove added a comment. Yes, also the notifications don't fill width, just noticed, I'm investigating REPOSITORY R120 Plasma Workspace BRANCH notification_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28576 To: niccolove, #plasma, mart Cc: plasma-

D28576: Converted to page and added Heading

mart added a comment. is the no notification message now uncentered related to this commit? REPOSITORY R120 Plasma Workspace BRANCH notification_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28576 To: niccolove, #plasma, mart Cc: plasma-devel, Orage,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 32 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/32/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 08:46:56 + Build duration: 26 min and counting CONSOLE OUTPUT [...truncat

  1   2   >