D29359: Add context for "Automatic" strings

yurchor updated this revision to Diff 81774. yurchor added a comment. Use "comment" instead of "context", fix extracomment according to https://tsdgeos.blogspot.com/2011/05/qt-designer-texts-disambiguation-vs.html REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDA

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

ngraham added a comment. You need to set it in the config file by hand IIRC. It's quite hidden now, and will inevitably bit-rot. :/ I wonder if we should just bite the bullet and fully kill it, or expose a super hidden GUI for it somewhere, REPOSITORY R119 Plasma Desktop REVISION DETAIL

D29359: Add context for "Automatic" strings

ecuadra requested changes to this revision. ecuadra added a comment. This revision now requires changes to proceed. I think the right attribute to adding context to .ui files is "comment" instead of "context". The attribute "context" is only for .rc and .kcfg files ;-) See https://api.kde.o

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 01, 2020 at 09:25:18AM -0400, Allen Winter wrote: > On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va > > escriure: > > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > > > We hav

Re: Information regarding upcoming Gitlab Migration

On Sun, May 3, 2020 at 2:13 AM Michał Policht wrote: > > Hi all, Hi Michal, > > Sorry for late response, but project "cutehmi" fits into "sdk" category > better than "applications" (technically it's a framework, but I guess > "frameorks" is reserved for well integrated KDE Frameworks). I have n

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf added a comment. In D29366#661834 , @ngraham wrote: > Technically it still does exist, it's just hidden. If a person does enable this, perhaps the message is still nice to have? Or maybe we should not show it because the expectation would

D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

davidedmundson added inline comments. INLINE COMMENTS > romangg wrote in Output.qml:60 > Is the change making this unnecessary? I.e. do the graphics still look > "smooth"? Default is true so it makes no difference. There's generally no reason to set it to false. REPOSITORY R104 KScreen REV

D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

This revision was automatically updated to reflect the committed changes. Closed by commit R104:cfd95e6bff4b: fix(kcm): avoid recursive OpacityMask which leads to teardown crash (authored by davidedmundson). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29340

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

ngraham added a comment. Technically it still does exist, it's just hidden. If a person does enable this, perhaps the message is still nice to have? Or maybe we should not show it because the expectation would be that your admin/technically competent grandson has enabled it for your own good

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf created this revision. filipf added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Widget locking no longer exists so we can remove the inline message that warned of locked widgets.

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Plasma System settings can set only 11 values for touchpad acceleration. The option accept a float number between -1 and 1 but, b

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

broulik added a comment. Very lovely idea! INLINE COMMENTS > main.qml:36 > > +property var kscreenAction: Kirigami.Action { > +visible: KCMShell.authorize("kcm_kscreen.desktop").length > 0 Why this as a `property`, not just an `Action` with an `id`? > main.qml:70 > +

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

ngraham added a comment. I know, but that's what the menu item says. I'm saying we should make then consistent somehow: either both should say "until turned off" (even if that's a lie) or they should both say "for a year", or "for three months", or whatever. REPOSITORY R120 Plasma Wor

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. Technically we don't have a "until turned off" state, just a date. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28740 To: broulik, #plasma Cc: ngraham, bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81750. niccolove added a comment. Fix very long notification titles REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81748&id=81750 BRANCH fix_notifications (branched from master) REVISION DETAIL

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

ngraham added a comment. Alternative proposal: since showing any date in the UI will be weird, how about we say "until turned off" instead? That would mirror the text in the menu item. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28740 To: broulik, #pla

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81748. niccolove added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81733&id=81748 BRANCH fix_notifications (branched from master) REVISION DETAIL https://phabrica

Re: Information regarding upcoming Gitlab Migration

On Fri, May 1, 2020 at 10:14 PM Ben Cooksley wrote: > On Sat, May 2, 2020 at 6:17 AM Alexander Potashev > wrote: > > I have a similar use case. Sometimes I need to share a URL to a > > project. For this purpose I used to share e.g. > > https://cgit.kde.org/releaseme.git/about > > > > Does this m

D27098: Konsole Runner: optimize and simplify

This revision was automatically updated to reflect the committed changes. Closed by commit R114:50c93e3c94e2: Konsole Runner: optimize and simplify (authored by alex). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=80485&id=81735 REVISION DETAI

D29359: Add context for "Automatic" strings

yurchor created this revision. yurchor added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. yurchor requested review of this revision. REVISION SUMMARY "Some of these topics are masculine gender and others are femin

D29234: Fix various bugs introduced with heading

broulik added inline comments. INLINE COMMENTS > NotificationItem.qml:116 > +Layout.fillWidth: true > +implicitHeight: !notificationItem.inGroup ? > notificationHeading.implicitHeight : 0 > + When `inGroup` the height will be zero so you effectively leak the item contents outsi

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81733. niccolove added a comment. Move lineSvg to root element REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81732&id=81733 BRANCH fix_notifications (branched from master) REVISION DETAIL http

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81732. niccolove added a comment. Fix visibility REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81730&id=81732 BRANCH fix_notifications (branched from master) REVISION DETAIL https://phabricato

D29234: Fix various bugs introduced with heading

niccolove planned changes to this revision. niccolove added a comment. Ah, there's a mistake on visibility, just a sec REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Fere

D29234: Fix various bugs introduced with heading

niccolove added a comment. Keyboard navigation is now working again; however, pressing tab to focus buttons seem to no longer be possible after this patch; looking at the code, I'm given the impression that it was true before porting notifications to page as well. Is that correct, or should

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81730. niccolove added a comment. Fix keyboard navigation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81727&id=81730 BRANCH fix_notifications (branched from master) REVISION DETAIL https://p

D29234: Fix various bugs introduced with heading

niccolove added a comment. I used the Svg instead of the plasmoidHeading to avoid using a Control. User-wise, it works correctly, but can I get your opinion code-wise? INLINE COMMENTS > broulik wrote in FullRepresentation.qml:454 > Move the `Svg` somewhere outside the delegate, I don't want

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81727. niccolove added a comment. Remove plasmoidHeading element as it's a control REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81389&id=81727 BRANCH fix_notifications (branched from master) RE

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

kmaterka added a comment. Fix exctracted from D29344 , to make things clear - one commit, one change. INLINE COMMENTS > main.qml:81 > target: plasmoid > -function onUserConfiguringChanged(userConfiguring) { > -if (userConfiguri

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Some `onXyzChanged` signals do not send value - fix connectio

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka updated this revision to Diff 81724. kmaterka added a comment. Extract unrelated fix to seprate patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29344?vs=81698&id=81724 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added inline comments. INLINE COMMENTS > apol wrote in main.qml:92 > Why's this needed? This is needed to fix different bug. I will create a separate patch for this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspac

D29326: Bookmarks Runner: Fix extraction of firefox profile

meven added a comment. We should not have screenshots in git commit message as they are not durable. (Only in test plan section is tolerable) I think you can change your comment, to include the ini text instead, and add comments saying `; here marked default` `; here real default` REPOSIT