Re: Gitlab workboards

On Mon, May 18, 2020 at 08:29:42PM -0600, Nate Graham wrote: > In Phab, a task can exist in multiple projects' workboards, which is useful > for tracking VDG-related work across multiple projects. This is something I > wouldn't want to lose, but maybe we can approximate it somehow in GitLab? For G

Re: Gitlab workboards

On Tue, May 19, 2020 at 07:08:59AM +0530, Bhushan Shah wrote: > > - Do we want to keep issues enabled and use them for "tasks"? > > - Do we want to have separate "tasks" boards under invent.kde.org/teams ? > > Nico: vote for 2 > > Marco: vote for 2 I am in highly favor of the option 1, for sev

D29766: [applets/taskmanager] Match default tooltip spacing in custom tooltip

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29766 To: ngraham, #vdg, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, a

Re: Gitlab workboards

In Phab, a task can exist in multiple projects' workboards, which is useful for tracking VDG-related work across multiple projects. This is something I wouldn't want to lose, but maybe we can approximate it somehow in GitLab? Nate On 5/18/20 7:38 PM, Bhushan Shah wrote: Hello! On Mon, May 1

Gitlab workboards

Hello! On Mon, May 18, 2020 at 01:20:07PM +0200, Marco Martin wrote: > Bhushan: We have few questions at this point > - Do we want to keep issues enabled and use them for "tasks"? > - Do we want to have separate "tasks" boards under invent.kde.org/teams ? > Nico: vote for 2 > Marco: vote for 2

D29264: New tabs for Breeze

ndavis added a comment. Would you mind moving this to GitLab? You'll just need to fork the breeze repo, add your fork as a remote to the existing repo you're working on and push your branch to the fork. For instance, this is what I do for myself: git remote add ndavis_fork g...@invent.

D29268: [WIP] Add Date/Time dialog

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in androidutils.h:29 > `const QDate &` Actually clazy disagrees, QDate and QTime should be passed by value REPOSITORY R1047 Kirigami Addons REVISION DETAIL https://phabricator.kde.org/D29268 To: nicolasfella, davidedmunds

D29268: [WIP] Add Date/Time dialog

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in TimeDialog.qml:15 > Generally conversions between C++ timedate and JavaScript `Date` is bad. > There's no way to represent just a time with no date and timezone associated > wit

D29268: [WIP] Add Date/Time dialog

nicolasfella updated this revision to Diff 83053. nicolasfella marked 10 inline comments as done. nicolasfella added a comment. - fix - Address some comments REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29268?vs=81471&id=83053 BRANCH work R

D29268: [WIP] Add Date/Time dialog

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in CMakeLists.txt:69 > Why this only on Android? or is that used for that dummy library? It's for the dummy library only > broulik wrote in FindGradle.cmake:2 > Feels like this should go into ECM? Yep > broulik wrote in DateD

Re: Gitlab and plasma dev

On Monday, 18 May 2020 16:46:57 CEST Harald Sitter wrote: > On Mon, May 18, 2020 at 3:48 PM Nate Graham wrote: > > Personally I would prefer it if we don't automatically send everything > > to the mailing list. That way people can subscribe to only what they > > really care about using the web UI,

D22702: [fileitemaction] Clean up includes

nicolasfella closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D22702 To: nicolasfella, ivan Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol added a comment. This is on https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/1 now. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28884 To: apol, jgrulich Cc: davidedmundson, jgrulich, plasma-devel, Ora

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R838:0d2bd657963c: screencasting: Adoption of the org_kde_plasma_video_streaming protocol (authored by apol). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https

D29694: Introduce Avatar component

cblack added a comment. This is being moved to GitLab. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29694 To: cblack, #kirigami, #vdg, mart Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmunds

D29694: Introduce Avatar component

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:cce0214570af: Introduce Avatar component (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28873: Add SwipeNavigator component

cblack abandoned this revision. cblack added a comment. Moving to a GitLab MR REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#672598 , @mart wrote: > what should happen in this case? > F8331924: Screenshot_20200518_114607.png My answer would be "set a minimum window size", though on mobi

D29784: Hardcode fewer colorSets

apol closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29784 To: apol, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, al

D29476: WIP: Port klipper to use wayland clipboard

davidedmundson abandoned this revision. davidedmundson added a comment. Moving to invent REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29476 To: davidedmundson, #kwin Cc: ngraham, cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren

D22868: Revamp Kirigami.AboutPage

nicolasfella added a comment. can this be closed? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ah

D22702: [fileitemaction] Clean up includes

nicolasfella updated this revision to Diff 83047. nicolasfella added a comment. Update REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22702?vs=62441&id=83047 BRANCH foo REVISION DETAIL https://phabricator.kde.org/D22702 AFFECTED FILES fileitem

D25984: Load translations

broulik abandoned this revision. broulik added a comment. Looks like D27595 fixes the issue REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: vkrause, mart, davidedmund

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

broulik updated this revision to Diff 83044. broulik edited the summary of this revision. broulik added a comment. - Drop `placeholderText` since the Kirigami issue has been resolved REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25462?vs=78891&id=83

D29771: [Notifications] Don't take updated time into account for sorting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d71181245f13: [Notifications] Don't take updated time into account for sorting (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29771?vs=82909&id=83042#toc REPOSITORY R1

Re: Gitlab and plasma dev

On 5/18/20 8:46 AM, Harald Sitter wrote: from personal experience nothing is more annoying than subscribing to a list of a project you are only loosely associated with to discuss something and then getting drowned for a week by 7 different kinds of services also sending crap to the list. it makes

D29771: [Notifications] Don't take updated time into account for sorting

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29771 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-

Re: Gitlab and plasma dev

On Mon, May 18, 2020 at 3:48 PM Nate Graham wrote: > > Personally I would prefer it if we don't automatically send everything > to the mailing list. That way people can subscribe to only what they > really care about using the web UI, which is very simple and > straightforward--and then the mailin

Re: Gitlab and plasma dev

On 5/18/20 8:07 AM, Luca Beltrame wrote: I'm of the opposite opinion: the mails don't affect me (they're sorted in subfolders by filters), but sometimes I've jumped in discussions and found regressions merely by reading mails as they arrived to the mailing lists. Subscribing to everything would

Re: Gitlab and plasma dev

In data lunedì 18 maggio 2020 15:48:34 CEST, Nate Graham ha scritto: > discussions and announcements. That would help the signal-to-noise ratio > stay high for the mailing list. I'm of the opposite opinion: the mails don't affect me (they're sorted in subfolders by filters), but sometimes I've j

Re: Gitlab and plasma dev

Personally I would prefer it if we don't automatically send everything to the mailing list. That way people can subscribe to only what they really care about using the web UI, which is very simple and straightforward--and then the mailing list can just be used for discussions and announcements.

Re: Monday meeting notes for 18/5/2020

On 5/18/20 5:20 AM, Marco Martin wrote: Bhushan: We have few questions at this point - Do we want to keep issues enabled and use them for "tasks"? - Do we want to have separate "tasks" boards under invent.kde.org/teams ? Nico: vote for 2 Marco: vote for 2 Retroactive vote for #2 from me!

D29785: Always use Window colorset for AbstractApplicationHeader

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5a716f3947dd: Always use Window colorset for AbstractApplicationHeader (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29785?vs=82968&id=8304

D29785: Always use Window colorset for AbstractApplicationHeader

ngraham added a comment. Not all of the headers use toolbars, but I thought the idea was for them all to use a consistent base appearance? @mart? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29785 To: ngraham, #kirigami, mart Cc: apol, plasma-devel, fbampaloukas

D29785: Always use Window colorset for AbstractApplicationHeader

apol added a comment. I wonder if this should be specified in ToolBarApplicationHeader instead. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29785 To: ngraham, #kirigami, mart Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, ahiemstra, d

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e3b251fd5b06: [IconApplet] Port KRun to ApplicationLauncherJob (authored by ahmadsamir). REPOSITORY R120 Plasma Work

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. Hmm, this is good idea, I'm not really happy about the implementation though. It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic num

D29630: Use the new KSysGuard namespace for KSysGuard related targets

ahiemstra closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29630 To: ahiemstra, #plasma, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-moh

D29682: Elide sensor names in config view

This revision was automatically updated to reflect the committed changes. Closed by commit R111:b62b7719c7e1: Elide sensor names in config view (authored by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29682?vs=82670&id=83037 REVI

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

This revision was automatically updated to reflect the committed changes. Closed by commit R120:97e843d3ead3: [Free Space Notifer] Use critical notification instead of tray icon and monitor… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

Monday meeting notes for 18/5/2020

First: any blocker for 5.19: there seems to be a crash in systemmonitor charts KDE bug 421623 in frameworks-kquickcharts (general) "Plasmashell crash probably related o kquickcharts or Ksysguard plasmoids" [normal,] https://bugs.kde.org/show_bug.cgi?id=421623 Kai Uwe Notifications: * Refactored fr

Gitlab and plasma dev

Pasting relevant gitlab factoids from the meeting: All of Plasma is on gitlab now. New review requests should go there. New review requests are *not* currently coming to come to this mailing list. If you are a maintainer you can subscribe to all of plasma by going to: https://invent.kde.org/plas

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.14 - Build # 75 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.14/75/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 19:17:06 + Build duration: 6 min 41 sec and counting JUnit Tests Name: (root) Fa

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 91 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/91/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 11 May 2020 12:48:21 + Build duration: 9 min 15 sec and counting BUILD ARTIFACTS abi-compa

D29784: Hardcode fewer colorSets

apol added a comment. addressed REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29784 To: apol, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, leslie

D29784: Hardcode fewer colorSets

apol updated this revision to Diff 83035. apol marked an inline comment as done. apol added a comment. Address comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29784?vs=82964&id=83035 BRANCH Plasma/5.19 REVISION DETAIL https://ph

D29691: Restore ability to send tel: URLs to the phone

broulik closed this revision. broulik added a comment. https://invent.kde.org/plasma/plasma-browser-integration/commit/8c4c240c0c1064893aaba0cd94fadf73f0e908ce REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D29691 To: broulik, #plasma, fvogt Cc: p

D28873: Add SwipeNavigator component

mart added a comment. what should happen in this case? F8331924: Screenshot_20200518_114607.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolo

D28873: Add SwipeNavigator component

mart added a comment. can you add an example about it in /examples ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson,