Re: Sunsetting PowerDevil's XRandrBrightness

Hi Kai, On Wed, May 20, 2020 at 09:31:07PM +0200, Kai Uwe Broulik wrote: > XRandR is doing X calls and we have some lovely animated screen brightness > change. However, the UPower "backend" in PowerDevil is quite a spaghetti > class and having multiple ways to control LEDs doesn't help. I have on

Sunsetting PowerDevil's XRandrBrightness

Hi all, PowerDevil has two (three, if you count DDC) means of controlling screen brightness: * Writing to sysfs (/sys/class/backlight and /sys/class/leds) * Using XRandr output property XRandR is doing X calls and we have some lovely animated screen brightness change. However, the UPower "ba

D28154: Add users KCM

cblack updated this revision to Diff 83095. cblack added a comment. Rename to kcm_users REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=83079&id=83095 BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos added a comment. Sorry I don't like the idea adding such option. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D29823 To: parsa, mvourlakos Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, jraleigh, zachus, mbehrendt, fbam

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

parsa added a comment. @mvourlakos Yes this is subjective .But it would be left as an option for users who are after a more customizable dock. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D29823 To: parsa, mvourlakos Cc: plasma-devel, acemond, Orage, LeGast00n,

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos added a comment. if you want to increase the bouncing level the right line is at: https://invent.kde.org/plasma/latte-dock/-/blob/master/plasmoid/package/contents/ui/main.qml#L982 you just need to increase the value of 1.65 to something bigger. Otherwise the calculated masks

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos requested changes to this revision. mvourlakos added a comment. This revision now requires changes to proceed. 5. this patch only increases the thickness of launcher animation I dont consider this an improvement. This is subjective REPOSITORY R878 Latte Dock REVISION DETAIL ht

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos added a comment. 1. Provide videos with before and after 2. I dont think I am interested in adding a bounce slider in Tasks for this 3. You increase the max zoom factor to 500% this is out of scope 4. I can accept an improvement for bouncing animation but without [2] and [3] a

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

parsa created this revision. parsa added a project: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. parsa requested review of this revision. REVISION SUMMARY I want to make the parabolic zoom effect more customizable.And in order to achieve that I had to eli

D7724: [ListItemBase] Open options menu on right click

broulik added a comment. https://invent.kde.org/plasma/plasma-pa/-/merge_requests/1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jral

D7724: [ListItemBase] Open options menu on right click

broulik abandoned this revision. broulik added a comment. Will revisit on GitLab. Code has changed too much REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Fer

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

ngraham abandoned this revision. ngraham added a comment. All right, I'll abandon this revision and turn it into a Phab task: T13180: Make it easier to apply the wallpaper to the desktop(s), lock screen, and login screen all at once REPOSITORY R120 Plas

D28154: Add users KCM

meven added a comment. So next step would be to shadow user_manager ? A naive ripgrep gave : $ rg user_manager .. ../kxmlgui/src/kbugreport.cpp 352:m_process->start(QStringLiteral("kcmshell5"), QStringList() << QStringLiteral("user_manager")); ../systemsettings

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

niccolove added a comment. I agree with a single KCM called wallpapers used to set all wallpaper in System Settings. Not a fan of having so many apply buttons, but I'm sure we can come up with something good. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

sandsmark added inline comments. INLINE COMMENTS > sandsmark wrote in ConnectionMapping.cpp:167 > instead of 87 + 1, maybe have a `constexpr int lineLength = strlen("0: > 0100:0277 : > 0A : 00:

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

sandsmark added inline comments. INLINE COMMENTS > ConnectionMapping.cpp:157 > +// Should be within the first 16 characters. > +size_t data_start = data.find(':'); > +if (data_start >= 16) { if we're going for ultra optimized, const everything I guess. > ConnectionMappin

D29808: KSysGuard Network Plugin: Don't use std::regex to parse the network files.

sandsmark added a comment. > It's all C code whereas the rest of the helper is C++. It also relies very heavily on magic numbers now. > I think a much simpler implementation would be to split each line on " ", select the fields we want and clean them up. I assume this is for p