D27650: ItemContainer: disconnect signals in destructor

alnikiforov added a comment. In D27650#618492 <https://phabricator.kde.org/D27650#618492>, @davidedmundson wrote: > Can I have your full name + email address please. Aleksei Nikiforov REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D27650: ItemContainer: disconnect signals in destructor

alnikiforov updated this revision to Diff 76462. alnikiforov edited the summary of this revision. alnikiforov added a comment. Got rid of two disconnects and updated summary formatting. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27650: ItemContainer: disconnect signals in destructor

alnikiforov added inline comments. INLINE COMMENTS > davidedmundson wrote in itemcontainer.cpp:68 > Right, this one line makes a lot of sense. > > I can imagine QQuickItem::~QuickItem changes parent, and calling > ItemContainer::setLayout after we've run our ItemContainers destructor means >

D27650: ItemContainer: disconnect signals in destructor

alnikiforov added a comment. In D27650#618207 , @davidedmundson wrote: > > And this used QWeakPointer leads to premature destruction of object m_layout points to. > > Do you have commit access? Yep, original description was not

D27650: ItemContainer: disconnect signals in destructor

alnikiforov added a comment. Fix consists of following line: disconnect(this, ::parentChanged, this, nullptr); Two other disconnects are just in case of similar issues arising and for code consistency. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27650: ItemContainer: disconnect signals in destructor

alnikiforov updated this revision to Diff 76439. alnikiforov retitled this revision from "Don't use guarded pointers for AppletsLayout" to "ItemContainer: disconnect signals in destructor". alnikiforov edited the summary of this revision. alnikiforov added a comment. Uploaded updated change

D27650: Don't use guarded pointers for AppletsLayout

alnikiforov added a comment. In D27650#617550 , @davidedmundson wrote: > > This function takes a plain pointer and wraps it into weak shared pointer. > > That's QWeakPointer. > > QPointer is something else that doesn't have an equivalent

D27650: Don't use guarded pointers for AppletsLayout

alnikiforov created this revision. alnikiforov added reviewers: ngraham, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY Using these pointer types incorrectly leads to premature

D27276: Powerdevil: allow using qt5widget classes with powerdevil

alnikiforov abandoned this revision. alnikiforov added a comment. Abandoning in favour of D27279 and D27357 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 To: alnikiforov, apol,

D27276: Powerdevil: allow using qt5widget classes with powerdevil

alnikiforov added a comment. Thanks, I'll try reworking KIdleTime. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 To: alnikiforov, apol, davidedmundson Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

alnikiforov updated this revision to Diff 75350. alnikiforov added a comment. Updated remaining conditions REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27278?vs=75348=75350 REVISION DETAIL https://phabricator.kde.org/D27278 AFFECTED FILES

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

alnikiforov added a comment. In D27278#608788 , @broulik wrote: > Makes sense, this can go into 5.18 branch. > Do I need to land this for you? Yes, please land it when you think it's ready to be merged. AFAIK, I have no push

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

alnikiforov marked an inline comment as done. alnikiforov added a comment. In D27278#608791 , @broulik wrote: > There seem to be a bunch of additional `m_helper.isNull()` that could be ported to be consistent? In D27278#608814

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

alnikiforov updated this revision to Diff 75348. alnikiforov added a comment. Fixed superfluous parenthesis in one of conditions. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27278?vs=75344=75348 REVISION DETAIL https://phabricator.kde.org/D27278

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

alnikiforov added inline comments. INLINE COMMENTS > broulik wrote in powerdevildpmsaction.cpp:196 > There's a superfluous parenthesis. Right. Thanks for finding it. I've just recently made additional changes in all functions except for initial change in

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

alnikiforov created this revision. alnikiforov added reviewers: apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY When DPMS extension isn't available, powerdevil unexpectedly exits due

D27276: Powerdevil: allow using qt5widget classes with powerdevil

alnikiforov planned changes to this revision. alnikiforov added a comment. I've hit this crash trying to use KDE via x2go (https://wiki.x2go.org/doku.php) with both x2go client and server running in two separate VMs. Here's backtrace of crash: Application: Система управления

D27276: Powerdevil: allow using qt5widget classes with powerdevil

alnikiforov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 AFFECTED FILES daemon/powerdevilapp.cpp

D24653: discover: check package status before trying to install/update it

alnikiforov added a comment. In D24653#547385 , @apol wrote: > Please submit to master. I've updated patch and removed additional parenthesis in condition. But I don't see how I can submit this change to repository, I probably don't have

D24653: discover: check package status before trying to install/update it

alnikiforov updated this revision to Diff 67961. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24653?vs=67941=67961 REVISION DETAIL https://phabricator.kde.org/D24653 AFFECTED FILES

D24653: discover: check package status before trying to install/update it

alnikiforov created this revision. alnikiforov added reviewers: jriddell, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY With latest changes to packagekit, it may now return more packages from

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. In D19829#472621 , @ngraham wrote: > @i.Dark_Templar can you land this yourself? I don't think I have access for that. Also I don't have Arc at the moment, and there's no indication in web interface that I

D19829: kicker: add option to make root level icons visible

i.Dark_Templar updated this revision to Diff 57202. i.Dark_Templar added a comment. Rebased to master, but it needs testing. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19829?vs=54094=57202 REVISION DETAIL https://phabricator.kde.org/D19829

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. In D19829#456234 , @GB_2 wrote: > Can you please update this patch? It doesn't apply anymore. It would also be nice if you used Arcanist/`arc` in the future:

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it may be enabled if this change is applied. And in my opinion it looks more

D19829: kicker: add option to make root level icons visible

i.Dark_Templar added a comment. Attaching screenshot with current look of menu (or with disabled option) and new look with enabled option and also a configuration widget. F6698363: kde-menu-changes.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19829: kicker: add option to make root level icons visible

i.Dark_Templar created this revision. i.Dark_Templar added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. i.Dark_Templar requested review of this revision. REVISION SUMMARY In file applets/kicker/package/contents/config/main.xml an option

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. Any news on this bug and this change yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: broulik, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. > With this patch the "Bookmarks" menu in KWrite does no longer open (as if it were empty) with global menu enabled. Hmm, for some reason it still works for me. But when I use global menu, I see a small flickering: menu appears, hides and reappears. I

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar updated this revision to Diff 18717. i.Dark_Templar added a comment. Updated patch for plasma-workspace 5.10, I'm using it with 5.10.4, but it should apply to master too. I've tried adding appmenu panel to desktop, still works fine for me. A bit of clarification. I'm not sure

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. > That's not entirely true. We do show the cached version, but also immediately call aboutToShow which will update the subtree. In theory at least :) There's condition in function 'void

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added a comment. Current implementation is buggy. Cached menu items may be invalid: after 'LayoutUpdate' event updated menu all of it submenus are no longer valid (and thus cache contains invalid data) and should be updated. Menu itself is updated, but it's submenus are not.

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar added reviewers: Plasma, davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7260 To: i.Dark_Templar, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D7260: System tray icon's context menu isn't updated properly in plasma/x11

i.Dark_Templar created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a fix for a bug I recently reported at: https://bugs.kde.org/show_bug.cgi?id=383202 Basically, if you make system tray