Re: KRunner and KActivities

Heyho, as stated in #Plasma, I will take care of it shortly ;) Regards Alex On 11/20/23 18:57, Jonathan Riddell wrote: I've just seen that KRunner uses KActivities but we moved activities to Plasma and Runner is in Frameworks.  Whatever shall we do? Joanthan

Re: Move krunner also to plasma bundle?

Heyho, I discussed with David Edmundson that it might be a good idea to move the milou QML bits to plasma-workspace. That allows easier codesharing for some KFileItemActions integrations that Kai (and I in an abandoned patch) have been working on. Though, this has the same issues regarding the KW

KF6 KCModule & KQuickAddons::ConfigModule changes

Hello everyone, I write regarding the KCModule refactoring. This evening, I have merged the MRs that removed the old KCModule/KQuickAddons(Managed)ConfigModule classes. In order to avoid issues with your leftover files from previous installations, please delete the following files: ~/kde/usr/in

Loading RunCommand.qml file in KRunner using QRC

Hello everyone,   I write this mail regarding the proposed change of https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2032. Currently we load the main KRunner QML file “RunCommand.qml” from the look and feel KPackage. However, this has caused issues repeatedly in the past, because

Cleanup of previous Applet builds

Hello, with the accompanying MRs https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/458 a few plugin files got renamed to ensure that their file name matches the plugin id. Please ensure that the old plugins are deleted, with kdesrc-build the directory is ~/kde/usr/lib/x86_64-

Aw: Re: kcm_bluetooth changed ?

t where I can not rely on compatibility even > between minor versions, that is really not fun. > Perhaps the breakage is due to these commits [1-3]. Need to ask Alexander Lohnau if there is a proper solution. I added him to the Cc list. Sorry for the inconven

Re: plasma_install_package vs plasma_install_bundled_package

Hi, in https://invent.kde.org/frameworks/kpackage/-/blob/master/ KF5PackageMacros.cmake#L109[1] there is the a JSON file created. The initial discussion about this function was in https://phabricator.kde.org/D9197[2]. In https://phabricator.kde.org/D19383[3] the topic was also discussed, but wit

D29807: Change Chrome API design

alex added a comment. Friendly Ping :-) Or should I just move this to gitlab? REPOSITORY R120 Plasma Workspace BRANCH api_inconsistencies (branched from master) REVISION DETAIL https://phabricator.kde.org/D29807 To: alex, broulik, #plasma, ngraham, meven Cc: anthonyfieroni, plasm

D28544: RecentDocuments Runner: Cleanup and formatting

alex abandoned this revision. alex added a comment. Will continue on gitlab REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29326: Bookmarks Runner: Fix extraction of firefox profile

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:a960c028c71d: Bookmarks Runner: Fix extraction of firefox profile (authored by alex). REPOSITORY R120 Plasma Workspa

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29326 To: alex, #plasma, ngraham, bruns, broulik, meven Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham

D29726: BookmarksRunner: Change caching databases

alex closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29726 To: alex, #plasma, ngraham, meven, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, leslie

D29807: Change Chrome API design

alex updated this revision to Diff 83131. alex added a comment. Use iterator, remove unused include REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83118&id=83131 BRANCH api_inconsistencies (branched from master) REVISION DETAIL https

D29807: Change Chrome API design

alex updated this revision to Diff 83118. alex added a comment. Formatting, remove debug statement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83116&id=83118 BRANCH api_inconsistencies (branched from master) REVISION DETAIL https:

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

alex abandoned this revision. alex added a comment. Task will proceed on GitLab. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29384 To: alex, #plasma, ngraham, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouk

D29807: Change Chrome API design

alex updated this revision to Diff 83116. alex retitled this revision from "WIP: Change Chrome API design" to "Change Chrome API design". alex edited the summary of this revision. alex added reviewers: ngraham, meven. alex added a comment. Change import, formatting REPOSITORY R120 Plasma Wo

D29807: WIP: Change Chrome API design

alex updated this revision to Diff 83029. alex marked an inline comment as done. alex added a comment. Create test cases REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83028&id=83029 BRANCH api_inconsistencies (branched from master) RE

D29807: WIP: Change Chrome API design

alex updated this revision to Diff 83028. alex added a comment. Make constructor private REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83019&id=83028 BRANCH api_inconsistencies (branched from master) REVISION DETAIL https://phabrica

D29807: WIP: Change Chrome API design

alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY - The FindProfile class was only for Chrome implemented => removed - Having ProfileBookmarks and Profile class is unnecessary, especiall

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex added a comment. Friendly Ping @bruns or may I land this already ? And should this land on `Plasma/5.19`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29326 To: alex, #plasma, ngraham, bruns, broulik, meven Cc: meven, plasma-devel, Orage, LeGast00n

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82954. alex added a comment. Adjust docstring for Browser::updateCacheFile REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29726?vs=82946&id=82954 BRANCH avid_unnecessary_copying (branched from master) REVISION

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82946. alex added a comment. Use enum for caching return type REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29726?vs=82790&id=82946 BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL htt

D29726: BookmarksRunner: Change caching databases

alex added inline comments. INLINE COMMENTS > meven wrote in chrome.cpp:55 > Might as well check the returned value for error If this fails only the icons are affected and the default icon will be displayed, this case will be handled in the FetchSqlite class > meven wrote in fetchsqlite.cpp:42

D29726: BookmarksRunner: Change caching databases

alex added inline comments. INLINE COMMENTS > meven wrote in fetchsqlite.cpp:87 > We might want to reuse database connection as long as the databaseFile did > not change I will do that in a follow up patch :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82790. alex added a comment. Add space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29726?vs=82789&id=82790 BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL https://phabricator.kde.or

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82789. alex retitled this revision from "WIP BookmarksRunner: Change caching databases" to "BookmarksRunner: Change caching databases". alex edited the summary of this revision. alex edited the test plan for this revision. alex added a comment. Copy chrome fi

D29726: WIP BookmarksRunner: Change caching databases

alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The copying/updating of the cache has been removed from the FetchSqlite class. This allows the browsers to have handle the caching diffe

D27513: Kill Runner: Remove duplicate function calls and refactor

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f103ebd7b3a: Kill Runner: Remove duplicate function calls and refactor (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=82669&i

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 82669. alex added a comment. Formatting REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=82666&id=82669 BRANCH arcpatch-D27513_1 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES ru

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 82666. alex added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=81006&id=82666 BRANCH arcpatch-D27513_1 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runner

D27576: Kill Runner: Move config keys to new file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:63deb6a0125b: Kill Runner: Move config keys to new file (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27576?vs=79224&id=82462 REVISIO

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex added a comment. @bruns LGTM? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29326 To: alex, #plasma, ngraham, bruns, broulik, meven Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

alex updated this revision to Diff 81801. alex added a comment. Formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29384?vs=81800&id=81801 BRANCH append_runner_service_file (branched from master) REVISION DETAIL https://phabricator.kde.o

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

alex created this revision. alex added reviewers: Plasma, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY This is required for T13079: Make runner KCMs easier to use

D27098: Konsole Runner: optimize and simplify

This revision was automatically updated to reflect the committed changes. Closed by commit R114:50c93e3c94e2: Konsole Runner: optimize and simplify (authored by alex). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=80485&id=81735 REVISION DETAI

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex updated this revision to Diff 81720. alex added a comment. Anchor in regex, comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29326?vs=81664&id=81720 BRANCH firefox_bookmarks_fix_extraction (branched from master) REVISION DETAIL htt

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex added inline comments. INLINE COMMENTS > bruns wrote in firefox.cpp:185 > Can this ever be > 1? For normal use not but if you have multiple versions of Firefox with multiple profiles installed and want to launch a profile in a specific version. REPOSITORY R120 Plasma Workspace REVISION

D27098: Konsole Runner: optimize and simplify

alex added a comment. In D27098#661482 , @meven wrote: > So yo won't be able to type "konsole myprofile" but I guess this is just fine. Yes you can do it :-) F8277455: Screenshot_20200502_081208.png

D29319: KCM Plasmasearch: Do not intialize runners in config module

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a07b68a0093c: KCM Plasmasearch: Do not intialize runners in config module (authored by alex). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29319?vs=81692&i

D29319: KCM Plasmasearch: Do not intialize runners in config module

alex updated this revision to Diff 81692. alex added a comment. Change username from commit And thanks for the fast reviews! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29319?vs=81645&id=81692 BRANCH arcpatch-D29319 REVISION DETAIL http

D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4f3835904ccd: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29320?

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

alex abandoned this revision. alex added a comment. Is handled in separate patches. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28196 To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbl

D29326: Bookmarks Runner: Fix extraction of firefox profile

alex created this revision. alex added reviewers: Plasma, ngraham, bruns, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY BUG 418526 The profile group with the value `Default=1` is not always the default

D28619: BookmarksRunner: Remove caching of profile database path

This revision was automatically updated to reflect the committed changes. Closed by commit R120:768e6a0a229d: BookmarksRunner: Remove caching of profile database path (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=80580&id

D28473: BookmarksRunner: Early return and formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e518d45a4d61: BookmarksRunner: Early return and formatting (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79086&id=81648 REVI

D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service

alex created this revision. alex added reviewers: Plasma, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Because the actions are always the same the X-Plasma-Request-Actions-Once property can be set to tru

D29319: KCM Plasmasearch: Do not intialize runners in config module

alex created this revision. alex added reviewers: Plasma, davidedmundson, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The runners are loaded from the plugin info list `Plasma::RunnerManager::li

D27576: Kill Runner: Move config keys to new file

alex added a comment. @meven and others, may I ship this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28473: BookmarksRunner: Early return and formatting

alex added a comment. Ping, regarding the question :-) REPOSITORY R120 Plasma Workspace BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL https://phabricator.kde.org/D28473 To: alex, bruns, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-

D26111: Runner: make recentdocument use KActivityStats data

alex added inline comments. INLINE COMMENTS > recentdocuments.cpp:98 > +QString destUrlString = url.adjusted(QUrl::RemoveFilename).path(); > +if (destUrlString.startsWith(homePath)) { > +destUrlString = QLatin1String("~") + > destUrlString.mid(homePath.length()); You

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 81006. alex added a comment. Fix small issue from splitting up patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76149&id=81006 BRANCH arcpatch-D27513 REVISION DETAIL https://phabricator.kde.org/

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c55ffdca923a: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. Friendly Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol, broulik, davidedmundson Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngra

D28473: BookmarksRunner: Early return and formatting

alex added a comment. Should this(and the following patches) go to a stable branch, because they fix a bug that has been reported (418526)? REPOSITORY R120 Plasma Workspace BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL https://phabricator.kde.org/D2847

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80580. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=80578&id=80580 REVISION DETAIL https://phabricator.kde.org/D28619 AFFECTED FILES runners/bookmarks/browsers/firefox.cpp To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage, LeGa

D28619: BookmarksRunner: Remove caching of profile database path

alex updated this revision to Diff 80578. alex added a comment. Implement requested changes Thanks, I will do that after the bugfix is done :-) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28619?vs=79466&id=80578 BRANCH arcpatch-D28619 R

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. Friendly ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28619 To: alex, #plasma, bruns, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf

D27098: Konsole Runner: optimize and simplify

alex added a comment. @ngraham and others, may I ship this? REPOSITORY R114 Plasma Addons BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg, broulik Cc: apol, plasma-devel, Orage, LeG

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 80485. alex added a comment. Minor issue when rebasing REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=80484&id=80485 BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 AFFECTED

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 80484. alex added a comment. Rebase REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=79560&id=80484 BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 AFFECTED FILES runners/kon

D28684: Kate Runner: Implement drag and drop for sessions

alex added a comment. The usecase is that you can pin the sessions to the taskbar. For instance if you have a quicklaunch widget in your panel for your favorite applications. And yeah I get the point about including this logic into Kate itself. REPOSITORY R114 Plasma Addons REVISION D

D28684: Kate Runner: Implement drag and drop for sessions

alex created this revision. alex added reviewers: Plasma, Kate, cullmann, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY You can now drag the sessions from the runner to the taskbar or the desktop. TEST

D28663: Kate Runner: Cleanup and improvements

alex created this revision. alex added reviewers: Plasma, Kate, cullmann, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The overview feature has been removed, because this is already handled using the

D27098: Konsole Runner: optimize and simplify

alex updated this revision to Diff 79560. alex added a comment. Suspend matching if the profiles are empty REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=75930&id=79560 BRANCH arcpatch-D27098_1 REVISION DETAIL https://phabricator.kde.or

D28192: WIP: Refactor dictionary runner

alex added inline comments. INLINE COMMENTS > sitter wrote in dictionaryrunner_config.cpp:29 > That's an implementation detail though, is it not? From the outside we > shouldn't make assumption about what the implementation does unless the > documentation says what we can assume. > Today the ba

D28619: BookmarksRunner: Remove caching of profile database path

alex added a comment. > I would argue for just removing the `grp.writeEntry("dbfile", m_dbFile)` line. This keeps the current behavior for the second group, and still solves the problem for the first group when there is no config yet. Only users of the second group with an existing config ha

D28619: BookmarksRunner: Remove caching of profile database path

alex created this revision. alex added reviewers: Plasma, bruns, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY As requested in D28196 this patch removes the caching

D28544: RecentDocuments Runner: Cleanup and formatting

alex added a comment. I didn't knew this patch existed and that it introduces coneptual changes. This is just a patch with smaller improvements/cleanup. Because of this I suggest waiting for your patch to be merged and than rebasing 😃. REPOSITORY R120 Plasma Workspace REVISION DETAIL h

D28544: RecentDocuments Runner: Cleanup and formatting

alex updated this revision to Diff 79244. alex added a comment. Change import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28544?vs=79243&id=79244 BRANCH recentdocuments_cleanup (branched from master) REVISION DETAIL https://phabricator.kde

D28544: RecentDocuments Runner: Cleanup and formatting

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY - Instead of early returning in the match method if the list of recen

D27576: Kill Runner: Move config keys to new file

alex added a comment. Thanks! 😃 And may I ship this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27576: Kill Runner: Move config keys to new file

alex updated this revision to Diff 79224. alex added a comment. Fix wrong username REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27576?vs=78137&id=79224 BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 AFFECTED FI

D27576: Kill Runner: Move config keys to new file

alex added a comment. Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch). What is the best way to solve this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576 REVISION DETAIL https://p

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79086. alex added a comment. Use categories for warnings, cleanup imports REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79083&id=79086 BRANCH bookmarksrunner_firefox_fix_prep (branched from master) R

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79083. alex added a comment. Implement warnings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79019&id=79083 BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL https://p

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79019. alex added a comment. Implement requested changes. PS: I had already tested the migration locally and added it to the test plan. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79017&id=79019

D28473: BookmarksRunner: Early return and formatting

alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY As requested in D28196 this patch handles the early return and the formatting. Additionally QRegul

D28458: Bugfix ConverterRunner

alex added a comment. I don't know why but I cant land this patch(`arc land --preview` looks fine) and the previous commits worked: `fatal: remote error: service not enabled: /kdeplasma-addons` I would be thankful if you could commit this. REPOSITORY R114 Plasma Addons BRANCH conv

D28458: Bugfix ConverterRunner

alex created this revision. alex added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Skip empty parts when splitting the units(D27166: Refactor converter runner

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. In D28439#638357 , @bruns wrote: > In D28439#638188 , @davidedmundson wrote: > > > QIcon isn't thread safe. > > > I think this is related to https://phabricator.kde.org/D5

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. In D28439#638188 , @davidedmundson wrote: > QIcon isn't thread safe. Sorry, I wasn't aware about that and haven't found anything when I had a quick look at the docs before submitting this patch. But if I may as

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex updated this revision to Diff 78906. alex added a comment. Remove unused includes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28439?vs=78905&id=78906 BRANCH bookmarks_change_icon_handling_in_matches REVISION DETAIL https://phabricator

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex created this revision. alex added reviewers: apol, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Before: A pointer to the favicon gets written in the BookmarkMatch and using this po

D28192: WIP: Refactor dictionary runner

alex added inline comments. INLINE COMMENTS > sitter wrote in dictionaryrunner.cpp:90 > You could simply use the lastPartOfSpeech I would guess. From what I've seen > and what Kai tells me you really only need to set setData if you want to > implement actions (`::actionsForMatch`) and need to c

D27513: Kill Runner: Remove duplicate function calls and refactor

alex added a comment. Friendly Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27513 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, r

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Sh**t, should I make a new patch to fix this? And sorry ... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

This revision was automatically updated to reflect the committed changes. Closed by commit R114:5e760a0586bb: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call (authored by davidedmundson, committed by alex). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Thanks! REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouka

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Small issue: Currently this patch can't be applied (from the master branch) because in R114:47381a65debe01a0a015e1aa423cbb78af649648 the line: `QStringList terms = query.split(QLatin1Char(' '

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dceb791c0779: WebShortcuts Runner: Refactor foreach, remove unnecessary method (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex updated this revision to Diff 78338. alex added a comment. Coding style: put space before { REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=76144&id=78338 BRANCH arcpatch-D27566 REVISION DETAIL https://phabricator.kde.org/D27566

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

alex added a comment. Ping @broulik :-) REPOSITORY R120 Plasma Workspace BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 To: alex, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D26799: Apply KDE coding style, minor optimizations

alex abandoned this revision. alex added a comment. Abandoning this, because there have been a few patches to the same kcm and this is mostly formatting. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26799 To: alex, ngraham, meven, davidedmundson Cc: davide

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 78336. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=78335&id=78336 REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES runners/spellchecker/spellcheck.cpp runners/spellchecker/spellcheck.

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 78335. alex added a comment. Minor improvements I had another look at the project and changed some other things: - optimize some overloads with QStringLiteral/QLatin1String - rename loaddata to loadData - remove the unnecessary check for the acti

D27166: Refactor converter runner

alex updated this revision to Diff 78281. alex added a comment. Allow +/- before values, add testcase Small detail I forgot to add and a testcase for this. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=78121&id=78281 BRANCH arcpatch-

D27098: Konsole Runner: optimize and simplify

alex added inline comments. INLINE COMMENTS > alex wrote in konsoleprofiles.cpp:155 > It has been refactored and is now in line 132/188: > `match.setRelevance((float) term.length() / (float) > data.displayName.length());` Ups, 118 not 188 REPOSITORY R114 Plasma Addons BRANCH konsole_bugfi

D26904: Use Qt5 syntax for signal, rename files

alex abandoned this revision. alex added a comment. Abandoning this because of D27503: [KCM Spellchecking] port to KPropertySkeletonItem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26904 To: alex, mlaurent, davidedmund

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex added inline comments. INLINE COMMENTS > apol wrote in konsoleprofiles.cpp:155 > Why has the relevance code been removed? It has been refactored and is now in line 132/188: `match.setRelevance((float) term.length() / (float) data.displayName.length());` REPOSITORY R114 Plasma Addons BRA

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex added a comment. Ping :-) REPOSITORY R114 Plasma Addons BRANCH konsole_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27098 To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-De

  1   2   >