D26185: Also disable automatic scaling on Qt >= 5.14

ahartmetz added a comment. @fvogt Yeah thanks, that made more sense than you spoon-feeding me the information for the commit message ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson, fvogt Cc: acooligan,

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. So what do we do here? The Qt bug has been fixed but still I'm not sure what should be done about the environment variables. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: ac

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#584249 , @davidedmundson wrote: > Thanks for following up! > > > I'll open a Qt bug and see how it goes. > > Can you link it please. Somebody was faster. I added a comment and a link to this di

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#583991 , @anthonyfieroni wrote: > Can forcing bigger font DPI make things better? AFAICS no. If scaling is conceptually enabled, i.e. if an application //would// be scaled //if// you attached a high D

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. It's probably okay to still say that scaling is enabled "in general" but for scaling <2, and why not, maybe even greater, hinting should not be inhibited. The screen is still made of pixels. Qt is not going to be able to throw out all the hinting and subpixel code

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. I think I see the problem. You pay for the //possibility// to have scaling with unhinted fonts. I am pretty sure that that isn't an acceptable way of handling it. Most Linux desktop fonts are intended to be used with some hinting (slight hinting usually?). QHighDpi

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. Just to make this extra clear, I have nothing against auto-scaling. There is probably a KCM to set it however I want if I don't like the default. My problem is with blurry and in some cases ("-=") disfigured font rendering. That should never happen regardless of ph

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#582095 , @anthonyfieroni wrote: > Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+ That unfortunately does not seem to help. I set the environment in a shell inside konso

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. Compiled against Qt 5.14 before this change: F7832282: before.png Compiled against Qt 5.14 after this change: F7832284: after.png REPOSITORY R120 Plasma Workspace REVISION DETAI

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz created this revision. ahartmetz added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahartmetz requested review of this revision. REVISION SUMMARY Whatever behavior change was apparently expected in Qt 5.14 didn't happen. I compiled again

D16550: [ksmserver] Fix session restore check

ahartmetz accepted this revision. ahartmetz added a comment. This revision is now accepted and ready to land. This fixes session restore for me. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16550 To: davidedmundson, ahartmetz Cc: ahartmet

D13435: Remove verbose debugging statement

ahartmetz accepted this revision. ahartmetz added a comment. There are many more plain qDebug()s in this module, but this one seems to produce the most noise... REPOSITORY R101 KHotKeys BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13435 To: fvogt, #plasma, davidedm

Re: Review Request 128956: Make KF5Baloo optional

hey still really want to, they can probably use the cascading feature of KConfig and supply a global config file that disables the Baloo runner by default. - Andreas Hartmetz On Sept. 20, 2016, 12:06 p.m., Andreas Sturmlechner wrote: > > --

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

e clear > words, my english is till here, > Kwin is stared before apps: > 1. setGeometry(), move() always works > Kwin not stated before apps: > 1. setGeometry(), move() if new values are same as internal widget => > placement > 2. setGeometry(), move() differs internal

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

e clear > words, my english is till here, > Kwin is stared before apps: > 1. setGeometry(), move() always works > Kwin not stated before apps: > 1. setGeometry(), move() if new values are same as internal widget => > placement > 2. setGeometry(), move() differs internal

Re: Review Request 127631: [ksmserver] We must be sure that kwin process is ended

> On April 11, 2016, 5:45 a.m., Martin Gräßlin wrote: > > > otherwise kwindowsystem::self() is nullptr > > > > how can KWindowSystem::self() be null? And why should that have anything to > > do with KWin? KWindowSystem does not depend on a window manager running. > > Thomas Lübking wrote: >

Re: Review Request 127475: Make one more DBus call async

call is safe, it must be assumed to cause deadlocks. Careless blocking calls are causing us so many problems. - Andreas Hartmetz On March 23, 2016, 3:06 p.m., David Edmundson wrote: > > --- > This is an automatically generated e

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

, I just made a mistake while editing the patches to push. I'd have at least given credit otherwise... - Andreas Hartmetz On Feb. 22, 2016, 11:55 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

> On Feb. 20, 2016, 4:51 p.m., Andreas Hartmetz wrote: > > Interesting! > > I have a few local patches like this that I haven't pushed, because > > applications that don't need to be restored by the session manager don't > > care whether they are kille

Re: Review Request 127125: [plasmashell] Disable Qt's fallback session management

waiting to push them in case they turn out to be useful :) Of course, in the cancelled logout scenario, one does care about applications getting killed too early and this fixes it. This one is yours, I'll push the other ones. - Andreas Hartmetz On Feb. 20, 2016, 2:51 p.m.,

[Differential] [Commented On] D884: Async variant to check whether power management is inhibited

ahartmetz added a comment. Excellent! That synchronous call might have caused deadlocks before. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D884 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah,

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

ahartmetz added a comment. A good rule is that if you want to protect against a security issue, you must first explain why the user is not already screwed. If a malicious app is running and can disable the screen locker (or not), the security state transition is from "the user is completely

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

marked as submitted. Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin. Changes --- Submitted with commit 85cc90b65ed8a9aa110018b01813fe1fd6772d48 by Andreas Hartmetz to branch master. Repository: kpackage Description --- That was a problem in a scenario such as

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

"add applets" and tray config dialog, no duplicates anymore. Also no duplicates anymore in KWin effects KCM. Thanks, Andreas Hartmetz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

g by > > the id (the plugin name). > > Andreas Hartmetz wrote: > Depends on the scope in which an ID is guaranteed to be unique. If it's > guaranteed to be globally unique and independent of category, sure, I'm all > for not making it more complicated than

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

be: > > alreadyListed() or something along those lines. > > Andreas Hartmetz wrote: > It also adds it to the list, though. The point is that it isn't const, and it also has a return value that matters. The name -sort of- conveys both. - Andreas

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 --- On Jan. 7, 2016, 3:21 p.m., Andreas Hartmetz wrote: > >

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

category, sure, I'm all for not making it more complicated than necessary. - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90755 ---

Heads-up: Session management issues

Hello, I've started a thread "Causes of session management problems in Plasma 5" on kde-core-devel about the session management problems affecting Plasma 5. ksmserver is part of plasma-workspace but the other involved parts aren't part of Plasma. Cheers, Andreas ___

Re: Review Request 123770: Play the login sound in its own thread

server/startup.cpp:99 #38 0x7f125a231643 in QThreadPrivate::start (arg=0x9910b0) at /opt/src/ksrc5/qt/stable/qtbase/src/corelib/thread/qthread_unix.cpp:337 #39 0x7f12589c66aa in start_thread (arg=0x7f1243fff700) at pthread_create.c:333 #40 0x7f1259ecbeed in clone () at ../sysdep

Re: Review Request: Some system tray fixes

eeded anymore? do a separate commit for that. > > Andreas Hartmetz wrote: > I'm not really sure, so I'll drop that part for now. This hack here is, > according to its commit message, supposed to fix some glitch after wake up > from suspend. I don't have a

Re: Review Request: Some system tray fixes

don't have a computer with working suspend (to disk) currently so I can't test. - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/#review4399 --- On 2010-03-07 01:16

Re: Review Request: Some system tray fixes

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/ --- (Updated 2010-03-07 00:01:49.016030) Review request for Plasma. Changes --

Re: Review Request: Some system tray fixes

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/ --- (Updated 2010-03-07 01:16:48.875540) Review request for Plasma. Changes --

Review Request: Some system tray fixes

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/ --- Review request for Plasma. Summary --- The system tray behaves very erratic